1247030DEV70-ffaafc4f35-37
Let's make it smarter. Instead of returning the full path let's substract the prefix from it if it's equal to the current directory in Dir.pwd.
lib/zold/wallets.rbYegor Bugayenkoyegor256@gmail.com1256430DEV64-220d800a35-38
Let's get rid of this and find a way to pass that $log global variable to all tests. Now it's defined inside test__helper.rb, but there should be a better solution. I posted a question about it: https://stackoverflow.com/questions/50418822
.rubocop.ymlYegor Bugayenkoyegor256@gmail.com21421230DEV212-37109e2371-73
The test is skipped because it crashes sporadically. I don't know why. Let's investigate, find the cause and fix it properly: http://www.rultor.com/t/14887-396655530
test/node/test_front.rbYegor Bugayenkoyegor256@gmail.com24123930DEV239-8451ca1787-90
This tests is skipped since it crashes sporadically. Let's investigate and make it stable. I don't really know what's going on, but suspect some collision between threads: http://www.rultor.com/t/14940-397702802
test/node/test_front.rbYegor Bugayenkoyegor256@gmail.com26426230DEV262-ee9602d645-48
This test is skipped because it doesn't work. I can't understand why. It seems that File.open() creates an empty file first which is then being read by File.read() in another thread. Let's find out and make AtomicFile truly thread-safe.
test/test_atomic_file.rbYegor Bugayenkoyegor256@gmail.com32227930DEV279-4664e37c3-5
Write unit tests for the alias command. It should test all the subcommands (set, remove and show) and any options.
test/commands/test_alias.rbrultorme@rultor.com37732230DEV322-7828612a8-9
Implement the set command and unskip this test. The syntax is already documented in the alias command in the help.
test/commands/test_alias.rbrultorme@rultor.com37832230DEV322-58c2b41220-21
Implement the remove command and unskip this test. The syntax is already documented in the alias command in the help.
test/commands/test_alias.rbrultorme@rultor.com37932230DEV322-c77a5ea135-36
Implement the show command and unskip this test. The syntax is already documented in the alias command in the help.
test/commands/test_alias.rbrultorme@rultor.com32327930DEV279-d44ca5ec31-33
Implement command handling. As in other commands, there should be case/when command/end loop and commands should be implemented as methods.
lib/zold/commands/alias.rbrultorme@rultor.com32628530DEV285-7d7687a112-14
Replace this stub with functionality. We need to run the script (`yield`) if the version of the script is between the saved version and the current one.
lib/zold/version_file.rbJames C Russelljames@101ideas.cz32728530DEV285-214c18b012-15
Write the upgrade manager tests that ensure: - Nothing breaks without the version file. - The upgrade scripts run when there is a version file and there are pending upgrade scripts. - Make sure *only* the correct upgrade scripts run.
lib/zold/upgrades.rbJames C Russelljames@101ideas.cz36532730DEV327-60adc21c31-32
Uncomment, when you're ready to work on upgrade manager's test case of absent version file. Start with running the test first.
test/test_upgrades.rbrultorme@rultor.com36632730DEV327-2e6b086944-46
Uncomment, when you're ready to work on upgrade manager's test case of running only pending upgrade scripts (i.e. the scripts with versions greater than those in the version file).
test/test_upgrades.rbrultorme@rultor.com32829230DEV292-732aceea95-103
Group options by subcommands Having all the options in one place _rather than grouping them by subcommands_ makes the help totally misleading and hard to read. Not all the options are valid for every command - that's the key here. The option below (`--max-nodes`) is an example. **Next actions:** - Implement the suggestion above. - Remove note from the --max-nodes option saying that it applies to the select subcommand only.
lib/zold/commands/remote.rbJames C Russelljames@101ideas.cz32929230DEV292-3bcf6540254-255
Implement the logic of selecting the nodes as per #292. The strongest n nodes should be selected, where n = opts['max-nodes'].
lib/zold/commands/remote.rbJames C Russelljames@101ideas.cz38832930DEV329-08487f44120-122
Verify that the nodes that are being selected are really the strongest ones. The strongest nodes are the ones with the highest score.
test/commands/test_remote.rbJames C Russelljames@101ideas.cz33328030DEV280-c01529866-7
Add to the queue. Once in there, try to pull it as soon as possible as is described in #280.
lib/zold/hungry_wallets.rbrultorme@rultor.com3427940DEV79-aed0d144110-112
Extract message cretion into a separate method for easier testing. Add tests for when in debt and not. Extract to a module, possibly Notify.
lib/zold/commands/pay.rbrultorme@rultor.com37035730DEV357-e0152e7393-94
Test that the headers are being set correctly. Currently there are no tests at all that would verify the headers.
lib/zold/node/front.rbJames C Russelljames@101ideas.cz38538430DEV384-9943eeb2141-143
This is a workaround, move this code into Upgrades, somehow. We should find a way to run these arbitrary scripts and pass arguments to them. Each of them may need its own set of arguments.
bin/zoldYegor Bugayenkoyegor256@gmail.com38930630DEV306-7716d23242-44
This test is failing from time to time We should find a way to check that tests involved in thread concurrency are always working
test/commands/test_node.rbrultorme@rultor.com3939830DEV98-ed83632053-58
The following two statements are seen as issues by rubocop raising a Lint/AmbiguousBlockAssociation offense. It is somthing that could be solved by changing the TargetRubyVersion in .rubocop.yml that is already taken care of in another issue. I am leaving a todo to check that rubocop doesn't complain anymore, otherwise find another solution
lib/zold/http.rbEmiliano Della Casaemiliano.dellacasa@gmail.com3949830DEV98-a72851ba23-26
Right now only Score and Http classes have been refactored for using dry-types, even tough the issue has been boosted refactoring the whole project is very cumbersome. Please refer to Score and Http class on how to perform all the changes for the project to adopt dry-types
lib/zold/type.rbEmiliano Della Casaemiliano.dellacasa@gmail.com42139430DEV394-fda9e6d823-27
Right now only Score, Http, Zold::Remotes and Zold::Remote classes have been refactored for using dry-types, even tough the issue has been boosted refactoring the whole project is very cumbersome. Please refer to Score and Http class on how to perform all the changes for the project to adopt dry-types
lib/zold/type.rbrultorme@rultor.com51150730DEV507-040930f554-56
I don't understand why this test doesn't work. It's not mission critical, since we don't have spaces in our paths, mostly. But still, would be great to fix it.
test/test_dir_items.rbYegor Bugayenkoyegor256@gmail.com51451330DEV513-3d9ea123430-432
This method is temporarily disabled since it takes a lot of time (when the amount of wallets is big, like 40K). However, we must find a way to count them somehow faster.
lib/zold/node/front.rbYegor Bugayenkoyegor256@gmail.com52952730DEV527-2b511bc262-67
This test takes too long. The speed should be less than a few milliseconds, however, if you run it a few times, you will see that it is over 100ms sometimes. This is way too slow. I can't understand what's going on. It seems that IO.read() is taking too long sometimes. Try to measure its time of execution in Farm.load() and you will see that it's usually a few microseconds, but sometimes over 200ms.
test/node/test_farm.rbYegor Bugayenkoyegor256@gmail.com56044430DEV444-c6c7b248114-118
It's obvious that the test works (I can see that in the console, but for some weird reason it doesn't work in Minitest. Try to run it: ruby test/test_http.rb -n test_sends_correct_http_headers If fails because of PUT HTTP request timeout. Let's find the problem, fix it, and un-skip the test.
test/test_http.rbYegor Bugayenkoyegor256@gmail.com