12 4 30 DEV 4-968ad704 70-73 Return the new instance of the Wallet, that will be created in the path with all wallets. Should be taken care of after Wallet interface will have implementations. Cover with tests and remove irrelevant test case. src/main/java/io/zold/api/WalletsIn.java Tolegen Izbassar t.izbassar@gmail.com 65 12 30 DEV 12-1be65647 93-95 Create the new wallet in the path with all wallets. It should contain the correct content according to the white paper. Also add a the test to validate everything is ok. src/main/java/io/zold/api/WalletsIn.java rultor me@rultor.com 85 65 30 DEV 65-14add99d 140-143 Create the new wallet in the path with all wallets. It should contain the correct content according to the white paper (network, protocol version, id and public RSA key). After this remove exception expect for tests on WalletsInTest. src/main/java/io/zold/api/WalletsIn.java Paulo Lobo pauloeduardolobo@gmail.com 86 65 30 DEV 65-64ffac10 96-102 Complete Wallet implementations with id, public RSA key and network id. Wallets.create(Long, String, String) must create a Wallet with these strings set and a constructor must be added to all Walletl realizations (Wallet(final long id, final String pubkey, final String network, final Transaction... transactions). After completing these implementations fix tests that uses Wallets.create() and all Wallet realizations. src/main/java/io/zold/api/Wallet.java Paulo Lobo pauloeduardolobo@gmail.com 66 12 30 DEV 12-99ac50e5 84-89 Ensure creating a new wallet in a path where a wallet with the same id throws an exception and does not overwrite the existing one. This could be done using by using a Random object with a similar seed in WalletsIn and creating a wallet twice for example. When it is done enable the test. src/test/java/io/zold/api/WalletsInTest.java rultor me@rultor.com 13 4 30 DEV 4-aab61a84 79-82 Read instance of the Wallet from file and put it to the result. Should be taken care of after Wallet interface will have necessary implementations. Cover with tests and remove irrelevant test case. src/main/java/io/zold/api/WalletsIn.java Tolegen Izbassar t.izbassar@gmail.com 15 6 30 DEV 6-f97f5c14 123-125 Implement pay method. This should add a transaction to the wallet containing the correct details. Also add a unit test to replace WalletTest.payIsNotYetImplemented(). src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 21 15 30 DEV 15-b88242e3 45-47 Check validity of the incoming string representation of transaction. It should comply the pattern described in the white paper. Cover with unit tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 77 21 30 DEV 21-829d3247 81-84 This test had to be marked as ignored after #30 because CpTransaction does not create the transaction string correctly yet. When CpTransaction is correctly implemented uncomment this method and make sure that it's working correctly src/test/java/io/zold/api/WalletTest.java Paulo Lobo pauloeduardolobo@gmail.com 22 15 30 DEV 15-4f67a35d 53-55 Implement id() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 23 15 30 DEV 15-1e017e66 62-64 Implement time() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 24 15 30 DEV 15-a01f2b41 70-72 Implement amount() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 25 15 30 DEV 15-f9a60893 78-80 Implement prefix() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 26 15 30 DEV 15-957c2199 86-88 Implement bnf() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 27 15 30 DEV 15-ad2b4fa5 94-96 Implement details() by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 28 15 30 DEV 15-0d2d728d 104-106 Implement signature by parsing the string representation of transaction according to the pattern, described in the white paper. Replace relevant test case with actual tests. src/main/java/io/zold/api/RtTransaction.java Tolegen Izbassar t.izbassar@gmail.com 29 15 30 DEV 15-0b8da355 123-126 Implement pay method. This should add a transaction to the wallet containing the correct details with the help of RtTransaction class. Also add a unit test to replace WalletTest.payIsNotYetImplemented(). src/main/java/io/zold/api/Wallet.java Tolegen Izbassar t.izbassar@gmail.com 54 29 30 DEV 29-4f17ced3 30-32 Implement the computation of the transaction string based on the white paper. The unit test should also be updated to ensure it works as expected. src/main/java/io/zold/api/CpTransaction.java Victor Noël victornoel@users.noreply.github.com 73 54 30 DEV 54-c02fec87 30-33 Implement the computation of the transaction string based on the white paper. The unit tests should also be updated to ensure it works as expected and test for returnSignatureForNegativeTransaction must be implemented. src/main/java/io/zold/api/CpTransaction.java rultor me@rultor.com 74 54 30 DEV 54-605ff193 200-202 Implement key method. This should return the public RSA key of the wallet owner in Base64. Also add a unit test to replace WalletTest.keyIsNotYetImplemented(). src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 16 6 30 DEV 6-af7c6ffd 131-134 Implement merge method. This should merge this wallet with a copy of the same wallet. It should throw an error if a wallet is provided. Also add a unit test to replace WalletTest.mergeIsNotYetImplemented(). src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 75 16 30 DEV 16-e32ec38b 47-50 Merge method should update transactions in wallet's file and return concrete implementation not a fake one. Beware that tests should be refactored to take care of file cleanup after each case that merges wallets. src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 76 16 30 DEV 16-27c16652 205-213 Following transactions should be ignored according to the whitepaper: a) If the transaction is negative and its signature is not valid, it is ignored; b) If the transaction makes the balance of the wallet negative, it is ignored; c) If the transaction is positive and it’s absent in the paying wallet (which exists at the node), it’s ignored; If the paying wallet doesn’t exist at the node, the transaction is ignored; src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 17 6 30 DEV 6-2cc9aa8f 142-144 Implement ledger method. This should return all the transactions in this copy of the wallet. Also add a unit test to replace WalletTest.ledgerIsNotYetImplemented(). src/main/java/io/zold/api/Wallet.java rultor me@rultor.com 34 33 30 DEV 33-65714492 43-46 CheckedScalar from 'cactoos' does not wrap runtime exceptions for some reason. Once it's fixed (see yegor256/cactoos#933) un-ignore WalletTest.throwIoExceptionIfReadingIdFails and make sure it works. src/test/java/io/zold/api/WalletTest.java George Aristy george.aristy@gmail.com 38 5 30 DEV 5-38f68f69 38-41 Implement Remote interface. Remote Interface must be implemented because Network depends on Remote behavior. Network.pull needs to search all remotes for some wallet id and merge all found wallets; Network.push must push a wallet to a remote based in remote. src/test/java/io/zold/api/NetworkTest.java Paulo Lobo pauloeduardolobo@gmail.com 39 5 30 DEV 5-fd3c6d54 32-35 We must figure out how to 'load' some network. Loading the network will be loading a local JSON file that contains data on all remote nodes that we know about; we must have a pre configured set of remote nodes built in too. See whitepaper for details. src/main/java/io/zold/api/RtNetwork.java Paulo Lobo pauloeduardolobo@gmail.com 40 5 30 DEV 5-c56bb757 52-55 Implement scoring algorithm when paying taxes. Scoring algorithm must select the node with the highest score and with score >= 16. There are some tests for the scoring algorithm in NetworkTest: remove ignore tag from them after algorithm implementation. src/main/java/io/zold/api/RtNetwork.java Paulo Lobo pauloeduardolobo@gmail.com 61 40 30 DEV 40-432fb579 34-40 Implement tax payment to remote nodes. Payment should happen only if the wallet is in debt of more than 1 Zold. Debt is difference between current taxes that should have been paid by wallet (see whitepaper for formula) and how much it already paid in the past. A first algorithm could pay the max to each node until there is nothing else to pay. The test must also be updated. src/main/java/io/zold/api/Taxes.java Victor Noël victor.noel@crazydwarves.org 81 61 30 DEV 61-94b7f6ca 145-148 Too many parameters on Fake constructor. Transaction.Fake have too many parameters; think and implement a way of reducing this number. After this implementation correct all other Fake usages to receive the new paramater values. src/main/java/io/zold/api/Transaction.java rultor me@rultor.com 82 61 30 DEV 61-7c0a7e0c 34-41 Implement tax payment to remote nodes. Payment should happen only if the wallet is in debt of more than 1 Zold. Debt is difference between current taxes that should have been paid by wallet (see whitepaper for formula) and how much it already paid in the past. A first algorithm could pay the max to each node until there is nothing else to pay. After completion the test methods TaxesTest.pay and TaxesTest.didntPayIfLessThanOneZLDDebt new tests covering other possible situations must be added. src/main/java/io/zold/api/Taxes.java rultor me@rultor.com 83 61 30 DEV 61-03d7ee35 95-99 Create and implement an Transaction matcher, where we can assure if some transaction have some values for its fields. After its implementation, fix this test so it can assure that the wallet has at least one transaction with TAXES prefix src/test/java/io/zold/api/TaxesTest.java rultor me@rultor.com 84 61 30 DEV 61-fb82e65a 114-119 Implement test assuring that the taxes had been paid correctly to the right nodes, according to whitepaper (p.13)each node. This payments must be checked by looking in the transactions of the wallet with "TAXES" prefix and must obey the rule set in #40 ("A first algorithm could pay the max to each node until there is nothing else to pay."). src/test/java/io/zold/api/TaxesTest.java rultor me@rultor.com 116 61 30 DEV 61-03259421 129-132 Too many parameters on Fake constructor. Transaction.Fake have too many parameters; think and implement a way of reducing this number. After this implementation correct all other Fake usages to receive the new parameter values. src/main/java/io/zold/api/Transaction.java @yegor256 yegor256@gmail.com 117 61 30 DEV 61-4494b2e5 67-69 Once Taxes.exec is implemented, replace this assertThrows with the original assertion that ensures the wallet ledger contains a transaction with the "TAXES" prefix. src/test/java/io/zold/api/TaxesTest.java Yegor Bugayenko yegor256@gmail.com 41 5 30 DEV 5-dec07794 63-67 Implement pull method. Pulling a wallet from the network should return all the wallets with that id in the network merged together. After the implementation NetworkTest.pullIsNotYetImplemented() have to be uncommented and test if pull method is behaving correctly. src/main/java/io/zold/api/RtNetwork.java Paulo Lobo pauloeduardolobo@gmail.com 56 41 30 DEV 41-44da2a34 35-41 The constructor of Copies should be implemented to retrieve the Wallet with the provided id in the provided remotes and group them by equivalent wallet (i.e., equivalent content) along with their remotes as explained in the whitepaper. A unit test should be added to validate this behaviour. The unit test NetworkTest.pullIsNotYetImplemented() should also be removed and replaced with a real test. src/main/java/io/zold/api/Copies.java Victor Noël victor.noel@crazydwarves.org 79 56 30 DEV 56-e2c92447 85-87 Compare the entire content of two wallets. In addition to id, compare RSA key and all transactions one by one. Entire content of each transaction should be compared. src/main/java/io/zold/api/Copies.java Vatavuk vatavuk1@hotmail.com 80 56 30 DEV 56-02b4f5e6 37-41 Add more test scenarios to Copies. Scenarios: remotes return empty list remotes return single element remotes return wallets with different content src/test/java/io/zold/api/CopiesTest.java Vatavuk vatavuk1@hotmail.com