4130IMP1-c3b485bc24-26
We don't have any Slack-talking crew. Let's implement a simple one, which would listen to the new channels and create new projects when someone is asking for it.
src/main/java/com/zerocracy/farm/package-info.javaYegor Bugayenkoyegor256@gmail.com5330IMP3-2274f2a342-46
Current implementation has a big flaw -- it reads the last message in an issue, not the one posted by the user. Thus, if there were a few messages after the original one, we will lose them all together with the original one and will process just the latest one in the thread.
src/main/java/com/zerocracy/crews/gh/GithubCrew.javaYegor Bugayenkoyegor256@gmail.com8630IMP6-00c8b61e34-37
We don't want to upload objects to S3 every time. We have to check first, whether any changes were actually made. Only if they were made, we will upload. Otherwise, just delete the file and that's it.
src/main/java/com/zerocracy/farm/S3Item.javaYegor Bugayenkoyegor256@gmail.com10930IMP9-d729c78975-77
Even if the document already exists, we must check that it has the right URI of the XSD schema. The most important thing is its version. If the URI is wrong, we must update it.
src/main/java/com/zerocracy/Xocument.javaYegor Bugayenkoyegor256@gmail.com181715IMP17-9258a67429-31
This object doesn't implement method toString(), but it should, in order to allow other decorators to re-use it and print project name correctly.
src/main/java/com/zerocracy/farm/S3Project.javaYegor Bugayenkoyegor256@gmail.com444330IMP43-30d30d8730-33
At the moment this pool of items will never be cleaned. They will get into the pool but will never be removed. There has to be some mechanism to implement that cache cleaning. Otherwise, we'll hit out-of-memory, sooner or later.
src/main/java/com/zerocracy/farm/sync/SyncProject.javaYegor Bugayenkoyegor256@gmail.com484730IMP47-634f267d82-86
We have to predict that exceptions, in order to optimize performance. No need to try to process each and every stakeholder for every claim. We must learn which of them throw on which types of claims and avoid sending them more of the same type.
src/main/java/com/zerocracy/farm/reactive/Brigade.javayegor256yegor256@gmail.com534330IMP43-8cbb05fb31-34
At the moment this pool of items will never be cleaned. They will asValue into the pool but will never be removed. There has to be some mechanism to implement that cache cleaning. Otherwise, we'll hit out-of-memory, sooner or later.
src/main/java/com/zerocracy/farm/sync/SyncProject.javayegor256yegor256@gmail.com896230IMP62-6eaaf14030-35
We have to implement simple slack session object to use inside 'notify_in_slack' stakeholder-script and fake object for tests. This session object may wrap `SlackSession` from `com.ullink.slack.simpleslackapi`. After that we should get rid of `Mockito` in this test.
src/test/resources/com/zerocracy/bundles/notify_in_slack_without_user/_before.groovyg4s8g4s8.public@gmail.com11398930DEV89-f08c508631-33
Add a new class FkSkSession that implements interface SkSession, and then use this new class in tests instead of using Mockito. This task can be implemented only when SkSession replaces SlackSession.
src/test/resources/com/zerocracy/bundles/notify_in_slack_without_user/_before.groovyrultorme@rultor.com1544113930DEV1139-7ab7e83e31-33
Finish implementation of FkSkSession, FkTeam and FkPersona, fake classes implementing SkSession, SlackTeam and SlackPersona. Then use these classes to replace Mockito in tests
src/test/resources/com/zerocracy/bundles/notify_in_slack_without_user/_before.groovyPaulo Lobopauloeduardolobo@gmail.com2282154430DEV1544-03b86ed331-36
Finish implementation of FkSkSession, FkTeam and FkPersona, fake classes implementing SkSession, SlackTeam and SlackPersona. Then use these classes to replace Mockito in tests. In particular, try to remove from SkSession any reference to the underlying com.ullink.slack library in the same way SkUser and SkChannel abstracts over SlackUser and SlackChannel.
src/main/java/com/zerocracy/radars/slack/FkSkSession.javaVictor Noëlvictor.noel@crazydwarves.org2283154430DEV1544-efc40b2237-41
Remove the need for the ConfusingTernary suppress warning caused by the if/else in channel and user. A good solution would be not to return null and handle non-existence of a channel or a user in a different more OO way. This would also impact RealSkSession and its users.
src/main/java/com/zerocracy/radars/slack/FkSkSession.javaVictor Noëlvictor.noel@crazydwarves.org2284154430DEV1544-05cf05b123-27
Change this bundle to test notify_in_slack but with an existing user. FkSkSession should store the messages sent to users and in this implementation of _after, we should verify the message is present. When it is done, don't forget to change the name of the bundle too.
src/test/resources/com/zerocracy/bundles/upBkMF_notify_in_slack_without_user/_after.groovyVictor Noëlvictor.noel@crazydwarves.org11408930DEV89-93f0abbe29-31
Use this interface and its implementation RealSkSession everywhere instead of SlackSession that is used currently. When it's done some tests can be refactored to get rid of Mockito library.
src/main/java/com/zerocracy/radars/slack/SkSession.javarultorme@rultor.com938330IMP83-dbce820923-27
We should add new "bans" to this XML document every time we add a new job to the WBS. Lets create a new stakeholder pm.staff.bans.ban_github_reporter. It has to catch "Job was added to WBS" type, check whether the job starts with gh: and then take the author of the ticket from GitHub.
src/test/resources/com/zerocracy/bundles/not_assign_task_to_reporter/_after.groovyg4s8g4s8.public@gmail.com1819330IMP93-9038cbbe23-27
Task reporter is already added to bans.xml. However, this test still fails for some reason. It could be because the election mechanism is broken (https://github.com/zerocracy/farm/issues/150), or that the test setup or data is not complete. Let's find out what's wrong and revise the test appropriately, perhaps even rewriting it.
src/test/resources/com/zerocracy/bundles/not_assign_task_to_reporter/_after.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1227530IMP75-f02bb74634-37
Need to parse telegram message and post as claim to a project. It should be similar to Slack implementations. Bot must understand only profile commands, q-profile.xml from slack can be copied.
src/main/java/com/zerocracy/radars/telegram/TelegramRadar.javag4s8g4s8.public@gmail.com1237530IMP75-ba330a2538-41
Add notify_in_telegram stakeholder script. This script should take Telegram session from binding properties and send a message to sessions's chat. It may be direct chat or Telegram channel.
src/main/java/com/zerocracy/radars/telegram/TelegramRadar.javag4s8g4s8.public@gmail.com1246330IMP63-beda870f26-31
We should multiply the payment with the given boost factor if a boost factor has been set for the task. The boost factor is defined in an XML document and the schema is in `pm/cost/boosts.xsd`. Default job size is 15 minutes. In case boost is not specified, the default factor should be 2, which means default payment is 30. Let's also use the same boost factor in awarding points in add_award_points.groovy.
src/main/resources/com/zerocracy/stk/pm/cost/make_payment.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1319630IMP96-82b5d3bf66-73
This test as well as TkAgendaTest.redirectsWhenAccessingNonexistentUsersAgenda should return a redirect status code. RqSecureLogin actually throws RsFailure, which is a HTTPException subtype that embeds 301 status. However, invoking the scenario through an actual request in TkApp causes it to be embedded in UncheckedIOException, causing the Takes framework to return HTTP 500 error status instead. Let's find out what's going on and fix it. After fix is applied we should re-enable these tests.
src/test/java/com/zerocracy/tk/profile/TkAgendaTest.javaCarlos Mirandacarlosmiranda@users.noreply.github.com13811030IMP110-87d46df229-32
Add a stakeholder to change person's vacation status and two commands in `q-profile`: "vacation on" and "vacation off". Stakeholder should change `vacation` flag in people.xml.
src/main/java/com/zerocracy/pm/staff/voters/Vacation.javaKirillg4s8.public@gmail.com1516915IMP69-d2b8b32f24-28
This assertion is disabled because the mock Github pull request created in _before.groovy is not recognized as a valid pull request. See https://github.com/jcabi/jcabi-github/issues/1323. When the issue is fixed, jcabi-github version should be updated and the assertion should be enabled.
src/test/resources/com/zerocracy/bundles/adds_new_pull_request_to_wbs/_after.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1526915IMP69-df6def7751-54
We're now using this class here and adds_new_pull_request_to_wbs/_before.groovy. In the future we might have even more uses after we've expanded the bundles tests. Probably better to factor this out into its own class file in src/test/java.
src/test/resources/com/zerocracy/bundles/adds_new_pull_request_to_wbs/_before.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1647215IMP72-38387e3c24-29
The assertion at the end is disabled because the mock Github pull request created in _before.groovy is not recognized as a valid pull request. So it is not recognized as a PR and the test fails. See https://github.com/jcabi/jcabi-github/issues/1323. When the issue is fixed, jcabi-github version should be updated and the assertion should be enabled.
src/test/resources/com/zerocracy/bundles/awards_points_to_arc_for_pull_request/_after.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com17314530IMP145-58d6666a26-29
Needs project cross-item synchronization. Now WBS can be changed during elections cleanup that resulting in keeping unused elections until next WBS update. To avoid this behavior we need some kind of transactional items change.
src/main/resources/com/zerocracy/stk/pm/scope/wbs/cleanup_elections.groovyrultorme@rultor.com17916530IMP165-d25ac01623-29
Implement archive mechanism. There is empty stakeholder `archive_job` that handles 'Job removed from WBS' claims. It should get some job info (such as created time, performer, boost, close reason) * and submit it into `archive.xml`. Also it's needed to complete this bundle-test with some archive assertions.
src/test/resources/com/zerocracy/bundles/archive_job/_after.groovyrultorme@rultor.com18516630IMP166-540fefdb28-30
let's implement this stakeholder. It will update precedences.xml. The update should occur whenever a GitHub ticket gets assigned to a milestone.
src/main/resources/com/zerocracy/stk/pm/staff/milestones/update_precedences.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com114318530DEV185-4c68317627-30
let's implement this stakeholder. It will update precedences.xml. It should use the Precedences class, similar to how the Milestones class is used in update_milestones.groovy. The update should occur whenever a GitHub ticket gets assigned to a milestone.
src/main/groovy/com/zerocracy/stk/pm/staff/milestones/update_precedences.groovyamihaiemilamihaiemil@gmail.com18616630IMP166-073320e428-31
let's implement this stakeholder. It will update milestones.xml, taking information from GitHub milestones. It has to be triggered by GitHub webhook: when milestones are updated. For each milestone, it has to add gh: prefix to the name found on GitHub.
src/main/resources/com/zerocracy/stk/pm/staff/milestones/update_milestones.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com60918630IMP186-75ab7a6230-33
Let's implement this `Rebound`. It should post a claim with type 'Add milestone' and params 'milestone' and 'date' on github web-hook with new milestone. Milestone param is a label of milestone, date is a milestone date.
src/main/java/com/zerocracy/radars/github/RbMilestone.javag4s8g4s8.public@gmail.com18716615IMP166-fa2613a219-21
The latest Github milestones information is contained in milestones.xml document. We should display those updated milestones right here in project.xsl.
src/main/xsl/project.xslCarlos Mirandacarlosmiranda@users.noreply.github.com21215630IMP156-a417a2c536-39
We need to check issue closer's role. If his role is 'PO' or 'ARC' we should skip warning message about bad practice and just say that issue has been closed by ARC (or PO).
src/main/java/com/zerocracy/radars/github/RbVerifyCloser.javarultorme@rultor.com22317230IMP172-5f493d1329-32
This class has been migrated to the zerocracy/jstk project. It is now in com.zerocracy.jstk.fake.FkProjectFarm. When the change has been released let's update the jstk library, remove ProjectFarm class, and substitute FkProjectFarm in its place wherever we are using it.
src/test/java/com/zerocracy/farm/ProjectFarm.javaCarlos Mirandacarlosmiranda@users.noreply.github.com24514830IMP148-ab92e4ca63-66
Let's make it possible for a user to say `@0crat waiting`. When this is done we should register an impediment for the job of type "unknown" in impediments.xml. See http://datum.zerocracy.com/pages/policy.html#7.
src/main/resources/com/zerocracy/radars/q-tracker.xmlrultorme@rultor.com25015830IMP158-f2c9ed8b30-32
Add new stakeholder that should add a record to speed.xml on each 'Order was finished' claim. Also we need a voter which will pay attention to that numbers and vote for that person who is the fastest.
src/main/java/com/zerocracy/pmo/Speed.javag4s8g4s8.public@gmail.com34725030IMP250-6fc9b9f330-32
Add new voter for `speed.xml` This voter should pay attention to user's speed from `speed.xml` and vote for that person who is the fastest.
src/main/java/com/zerocracy/pmo/Speed.javag4s8g4s8.public@gmail.com26425830IMP258-3baf550632-34
This assertion `elections.elected(job)` always failing on Rultor but passing locally and on Shippable. It related to #258 bug. This `assert` should be uncommented after #258 fix.
src/test/resources/com/zerocracy/bundles/not_assign_task_to_reporter/_after.groovyg4s8g4s8.public@gmail.com26522830IMP228-a2ff440f23-25
We should be able to test PMO items, e.g. 'agenda/<login>.xml'. Now it's impossible because `BundlesTest` uses FkProject for all resources. Also 'farm' can't be accessed via `binding.variables` in test groovy script.
src/test/resources/com/zerocracy/bundles/workload/_after.groovyg4s8g4s8.public@gmail.com26613730IMP137-3450910328-32
Add new stakeholder, which will go through all orders and check their age. If they are old enough to create a new reminder (5 days, 8 days) - we should create it and send a notification to the user that the task will be taken away from him in 10 days (this is our policy).
src/test/java/com/zerocracy/pm/time/RemindersTest.javag4s8g4s8.public@gmail.com33326630IMP266-c54a4e6232-34
Notify users about job in github with reminder's label. It can be new stakeholder which will react to 'Ping' claim.
src/main/resources/com/zerocracy/stk/pm/time/reminders/remind.groovyg4s8g4s8.public@gmail.com26720930IMP209-04646802131-133
Add set title command here (q-profile.xml) which should be handled by new `set_title` stakeholder. This stakeholder should change project title in `catalog.xml` /catalog/project/title.
src/main/resources/com/zerocracy/radars/q-profile.xmlg4s8g4s8.public@gmail.com27327230IMP272-5f75250e40-42
Error handling in `StkSafe::process` method is similar to `ReSafe` in telegram, slack and github error handling. We need to refactor it. Let's use one class for it, now it's placed in `TxtUnrecoverableError`.
src/main/java/com/zerocracy/farm/StkSafe.javag4s8g4s8.public@gmail.com28123530IMP235-ca1d9c8f23-26
This test started to fail after `remove_assignee` script fix. In this test stakeholder can't find assignee in MkIssue which throws an exception: XPath '/github/repos/repo[@coords='test/test']/issues/issue[number='2']' not found
src/test/resources/com/zerocracy/bundles/resigns_tasks_upon_quit/_after.groovyg4s8g4s8.public@gmail.com28415530IMP155-f2c0cacb41-45
This test and `FtParamTest` fail because they require proper 'mongod' installation. Locally test fails with error: "Cannot run program "mongod": error=2, No such file or directory", on Shippable it's 'MongoTimeoutException'.
src/test/java/com/zerocracy/tk/project/TkFootprintTest.javag4s8g4s8.public@gmail.com30211730IMP117-a7f9455552-54
Remove this debug message when slack messages duplicates will be solved now this string needs to clarify Slack stakeholder work
src/main/resources/com/zerocracy/stk/pm/comm/notify_in_slack.groovyg4s8g4s8.public@gmail.com36836230IMP362-2359568752-55
This verification is disabled because GitHub goes over quota very soon, since some issues have too many events. Let's find a way to make less requests to GitHub. The same problem exists in finish_stale_github_order.groovy
src/main/resources/com/zerocracy/stk/pm/scope/wbs/remove_stale_github_ticket_from_wbs.groovyYegor Bugayenkoyegor256@gmail.com37136030IMP360-726376b139-42
Download and analyze heap dump from http://www.0crat.com/heapdump after next out of memory error, then fix memory leaks and remove this debug class.
src/main/java/com/zerocracy/tk/TkDump.javag4s8g4s8.public@gmail.com4087330IMP73-6d39317c83-86
Add command to rate the quality, the format is 'quality is good|bad|acceptable', this command should trigger 'Finish order' with 'quality' param (see #73 comments for details) and pay 15 min to QA user.
src/main/resources/com/zerocracy/radars/q-tracker.xmlg4s8g4s8.public@gmail.com42440930IMP409-3fa451d0105-108
Txn.Item is not implemented. This class should keep local changes for single item and push them to origin item on commit. Also it should revert all local changes when transaction closed without commit() call.
src/main/java/com/zerocracy/Txn.javag4s8g4s8.public@gmail.com42536030IMP360-7aef014d39-42
Download and analyze heap dump from https://www.0crat.com/heapdump after next out of memory error, then fix memory leaks and remove this debug class.
src/main/java/com/zerocracy/tk/TkDump.javaYegor Bugayenkoyegor256@gmail.com72542530DEV425-40a20d3d38-40
Download and analyze heap dump from https://www.0crat.com/heapdump after next out of memory error, then fix detected memory leaks. Also waiting for #400 to be solved.
src/main/java/com/zerocracy/tk/TkDump.javaamihaiemilamihaiemil@gmail.com120272530DEV725-3ad115cb43-46
Fix memory leak in async-flush. AsyncFlush consumes about half of application memory (before OutOfMemoryError). It may keep references to threads via SmartLock references in `locks` field.
src/main/java/com/zerocracy/farm/reactive/AsyncFlush.javag4s8g4s8.public@gmail.com120372530DEV725-e530d94646-48
Fix memory leak in Terminator. It may keep references to threads via thread local variable in `killer` method. I think it can be replaced with WeakReference to thread.
src/main/java/com/zerocracy/farm/sync/Terminator.javag4s8g4s8.public@gmail.com47629730IMP297-8a8d277c30-33
App shutdown is not implemented. This take will be called by Rultor during deploy. We should stop all background threads, services, wait until they stopped and return 200-OK status to Rultor.
src/main/java/com/zerocracy/tk/TkShutdown.javag4s8g4s8.public@gmail.com96347630DEV476-cbedeee7124-127
Method freeze should wait for all processed claims, and stop giving new claims with IOException, it should block all SyncProjects so they stops to return SyncItems and wait for all current opened SyncItems to close.
src/test/java/com/zerocracy/farm/sync/SyncFarmTest.javag4s8g4s8.public@gmail.com47729730IMP297-c88f310734-36
Shutdown endpoint can be accessed without authentication. We should verify that /shutdown request was sent by Rultor during deploy. It can be implemented with auth header.
src/main/java/com/zerocracy/tk/TkShutdown.javag4s8g4s8.public@gmail.com47840330IMP403-fdebb43c42-44
Right now we are adding the label 'in' to the issue to a Github job that is in WBS. We should also remove it when the issue is removed from WBS (out of scope).
src/main/resources/com/zerocracy/stk/pm/scope/wbs/add_label_to_github_ticket.groovyCarlos Mirandacarlos.m.a.miranda@accenture.com48038030IMP380-d5fa189f42-44
Single claim xsl is missing. We need to display one claim xml as a single page to show it in election link.
src/main/java/com/zerocracy/tk/project/TkClaim.javag4s8g4s8.public@gmail.com48138030IMP380-7a7b952945-48
Add link to election claim instead of election full election text in chats. See https://github.com/zerocracy/farm/issues/380#issue-287764148 for details. It should be in format /footprint/(project)/(claim-id)
src/main/java/com/zerocracy/tk/project/TkClaim.javag4s8g4s8.public@gmail.com49439030IMP390-ecc6350135-37
We should remove people from people.xml when their score goes below 200. Let's implement that. We should also notify the person in case that happens.
src/main/resources/com/zerocracy/stk/pm/staff/awards/reject_people_below_score.groovyCarlos Mirandacarlos.m.a.miranda@accenture.com49540430IMP404-c83766b864-68
Use of the Twitter API in this project is neither reusable nor testable. Let's introduce an interface that will serve as our frontend for the Twitter API. We should have a real implementation and also a fake one for testing. This interface should be used where the twitter API is currently used, and we should add tests for the usage of Twitter.
src/main/resources/com/zerocracy/stk/pm/publish_project.groovyCarlos Mirandacarlos.m.a.miranda@accenture.com54538430IMP384-734984f725-32
Let's implement this stakeholder. This script should send a notification to all users, who is not on vacation. Let's mention in the notification, that if they don't want to receive them anymore, they just have to turn the vacation mode ON. Also 'publish_project' bundle test should be fixed. And 'Notify test' claim in this script should be replaced with actual implementation.
src/main/resources/com/zerocracy/stk/pm/comm/notify_all.groovyg4s8g4s8.public@gmail.com55236630IMP366-6dccce2843-47
Let's keep person reputation, agenda and project count inside `people.xml` and update them when reputation, agenda or projects changed as described in https://github.com/zerocracy/farm/issues/366#issuecomment-359568311 It should be done after #386 bug to avoid conflicts.
src/main/java/com/zerocracy/pmo/People.javarultorme@rultor.com84055230DEV552-b158b0f739-41
Add tests for details(), links(), wallet() and rate() in People.java because these methods are not fully covered. Then remove People.java from jacoco excludes in pom.xml
src/test/java/com/zerocracy/pmo/PeopleTest.javag4s8g4s8.public@gmail.com105984030DEV840-1e70f3dd44-46
Add tests for links(), wallet() and rate() in People.java because these methods are not fully covered. Then remove People.java from jacoco excludes in pom.xml
src/test/java/com/zerocracy/pmo/PeopleTest.javarultorme@rultor.com84155230DEV552-9d3ef34944-47
Let's keep agenda inside `people.xml` and update it when agenda changed as described in https://github.com/zerocracy/farm/issues/366#issuecomment-359568311 Also put it as 'agenda' element in TkGang xml.
src/main/java/com/zerocracy/pmo/People.javag4s8g4s8.public@gmail.com55651130IMP511-1a49e160129-132
S3Item does not handle InterruptedException properly. It should not allow reading from io.channel stream if thread was interrupted because it automatically check thread status before reading and can throw `ClosedChannelException`.
src/test/java/com/zerocracy/farm/S3ItemTest.javag4s8g4s8.public@gmail.com55949230IMP492-2cc3618926-30
Let's implement this stakeholder. It will take a random user from the list, which has the oldest updated attribute, go to its GitHub account, fetch all repositories he owns and contributes to and fetch the most popular languages from them. GitHub provides that information.
src/main/resources/com/zerocracy/stk/pmo/people/update_skills.groovyg4s8g4s8.public@gmail.com141155930DEV559-80a85ff327-30
Create a method People.oldestSkillsUpdate to retrieve the login of the user that needs theirs skills updated and fetch all repositories he owns and contributes to and fetch the most popular languages from them. GitHub provides that information.
src/main/groovy/com/zerocracy/stk/pmo/people/update_skills.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com141255930DEV559-34ba884a45-46
Let's display the data from people/skills on the profile page of a given user as well as on the team page.
src/main/java/com/zerocracy/tk/TkTeam.javaKrzysztof KrasonKrzysztof.Krason@gmail.com59953930IMP539-4e7a400028-33
The ticket should be removed from WBS and performer should receive payment and awards only if ticket was closed by the reporter, ARC or PO. In other cases we should say "sorry, we won't pay". So let's provide who close an issue in claim params in `RbOnClose` and check it in 'Close job' and 'Remove job from WBS' scripts, then commented tests will be worked. Also policy have to be updated.
src/test/resources/com/zerocracy/bundles/close_the_job/_after.groovyg4s8g4s8.public@gmail.com60252030IMP520-a0cac38b38-40
TkJoin does not handle POST requests. It can be sent from join page on submit. Let's process this request and send gathered information to all users with reputation 1024+
src/test/java/com/zerocracy/tk/TkJoinTest.javag4s8g4s8.public@gmail.com61347430IMP474-ba887765609-611
branch coverage, complexity coverage and class coverage limits are disabled, because current coverage is too low. Let's add tests and increase class and branch coverage.
pom.xmlg4s8g4s8.public@gmail.com108361330DEV613-9bd5aca0621-623
Continue increasing coverages to reach branch coverage of 65% and class missed count of max 15. Remember to increase those coverages below in jacoco configuration.
pom.xmlKrzysztof KrasonKrzysztof.Krason@gmail.com1351108330DEV1083-da87ec45487-489
Continue to increase the coverages to reach branch coverage of 65% and class missed count of max 15. Remember to increase those coverages below in jacoco configuration.
pom.xmlrultorme@rultor.com65244730DEV447-38b7b52b27-29
register_impediment stakeholder should pay attention to impediment count requested by user and not allow to register new impediments if threshold has been reached. See #447 comments for details.
src/test/resources/com/zerocracy/bundles/impediments/_after.groovyKirillg4s8.public@gmail.com65664630DEV646-eda38fad29-32
We should place the demand for review into the XML document 'pm/qa/reviews.xml' and then place the mark there, when the review is completed. When the order gets removed from orders.xml we automatically destroy the review (should happen in Datum by auto update).
src/main/resources/com/zerocracy/stk/pm/qa/complete_qa_review.groovyg4s8g4s8.public@gmail.com66845030DEV450-6f8e690424-28
Let's implement this stakeholder: it should deduct 256 points from claim author for breakup. At moment it's not possible because 'Make payment' script and Awards requires job parameter, but in 'breakup' there is no any job. Also test in 'invite_a_friend/_after.groovy' should be uncommented.
src/main/resources/com/zerocracy/stk/pmo/profile/penalize_for_breakup.groovyrultorme@rultor.com70325830DEV258-bca58f1a24-28
Options are not implemented. We should be able to access `options/{username}.xml` file (where {username} is a person name from `people.xml`) to read and modify user options. Also some mechanism should be invented to allow user to change this options.
src/test/java/com/zerocracy/pmo/OptionsTest.javag4s8g4s8.public@gmail.com103570330DEV703-5f3e27dc33-36
Options are not used. Election should check maxJobsInAgenda option, notify stakeholders should check notify options: notifyPublish, notifyRfps, notifyStudents. Also user should be able to download, edit and upload options.xml file on profile page.
src/main/java/com/zerocracy/pmo/Options.javaYegor Bugayenkoyegor256@gmail.com1185103530DEV1035-248d802b33-36
Notify stakeholders should check notify options from the Options object specific to given user whether to notify him about certain events. Options that should be used: notifyPublish, notifyRfps, notifyStudents.
src/main/java/com/zerocracy/pmo/Options.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1186103530DEV1035-a9c9989f37-39
Options should be changeable by the user from their profile page. Allow users to download, edit and upload options.xml file on profile page.
src/main/java/com/zerocracy/pmo/Options.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1472118630DEV1186-c29461b229-34
Add ability to change options notifyStudents, notifyRfps and notifyPublish. This stakeholder (and maybe Options class itself) most probably will need to be refactored to allow easier addition of any future options. Introduce also handling of `/option` - should display all available options with their current values, and `/option name` - should display current value of a given option.
src/main/groovy/com/zerocracy/stk/pmo/profile/change_option.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1187103530DEV1035-3b7a2d5a23-25
Options are not used. Election should check maxJobsInAgenda option and not elect users that already have already max number of jobs. After this is implemented uncomment this test.
src/test/resources/com/zerocracy/bundles/elections_dont_exceed_max_jobs_option/_after.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com70944730DEV447-7f13e82b27-29
register_impediment stakeholder should charge attention to impediment count requested by user and not allow to register new impediments if threshold has been reached. See #447 comments for details.
src/test/resources/com/zerocracy/bundles/impediments/_after.groovyYegor Bugayenkoyegor256@gmail.com71053930DEV539-28713f5928-33
The ticket should be removed from WBS and performer should receive payment and awards only if ticket was closed by the reporter, ARC or PO. In other cases we should say "sorry, we won't charge". So let's provide who close an issue in claim params in `RbOnClose` and check it in 'Close job' and 'Remove job from WBS' scripts, then commented tests will be worked. Also policy have to be updated.
src/test/resources/com/zerocracy/bundles/close_the_job/_after.groovyYegor Bugayenkoyegor256@gmail.com72849630DEV496-4b81e8fe8-12
Let's implement this stakeholder. It has to fetch all users from people.xml, pick random 5, go through their agendas and check that each job they have there really exist in the correspondent projects. If they don't exist, it should remove them from the agenda. Also uncomment 'delete_stale_jobs' test assertion.
src/main/resources/com/zerocracy/stk/pmo/agenda/delete_stale_jobs.groovyrultorme@rultor.com76053630DEV536-488b0c6c41-43
Every time we close a ticket in GitHub, which was not a job, or when we close a pull request, which was not merged, we should add it to blanks.xml
src/main/resources/com/zerocracy/stk/pm/in/orders/close_job.groovyg4s8g4s8.public@gmail.com76148930DEV489-3f92a3b139-41
Write more test cases for a claim's children. Currently only the no-children case is validated, tests for one and for more children are required.
src/test/java/com/zerocracy/tk/project/TkClaimTest.javaamihaiemilamihaiemil@gmail.com76248930DEV489-f307c75254-57
Change claim.xsl in such a way that it displays the children of this claim as well. They are returned in the children element and represent all the claims that have the cause equal to this claim's id.
src/main/java/com/zerocracy/tk/project/TkClaim.javaamihaiemilamihaiemil@gmail.com76540030DEV400-9e93881643-45
Should use HeapDump to get contents from S3, rather than from the server file, as it might be deleted and won't be available anymore.
src/main/java/com/zerocracy/tk/TkDump.javaIzbassar Tolegent.izbassar@gmail.com76640030DEV400-fba0df9b32-35
Use this class, to periodically update contents from ./heapdump.hprof file to S3. Should be implemented after #680 would be resolved as part of the routine work, that needs to be done in background.
src/main/java/com/zerocracy/entry/HeapDump.javaIzbassar Tolegent.izbassar@gmail.com123276630DEV766-8d00e56f30-32
Add a unit test for this stakeholder using fake S3 storage. Maybe you will need to modify the stakeholder itself so that is allows using fake S3 storage.
src/main/groovy/com/zerocracy/stk/internal/update_heapdump.groovyrultorme@rultor.com76740030DEV400-cf11083e80-84
Should return the latest version of heap dump, available in S3 or temporary storage (if it is up to date). Cover implementation with unit and integration tests.
src/main/java/com/zerocracy/entry/HeapDump.javaIzbassar Tolegent.izbassar@gmail.com76840030DEV400-1ca94fd494-98
Should save heap dump to S3 bucket if file with dump exists, but only do that, if there is new version of file available. Ignore, if we already have latest version in S3. Should be covered with unit and integration tests.
src/main/java/com/zerocracy/entry/HeapDump.javaIzbassar Tolegent.izbassar@gmail.com77051030DEV510-7cdf5e0a23-27
Let's implement a test for small-size pull requests. At moment it's not possible because it requires to construct specific json for PR with fields 'additions' and 'deletions' via MkStorage. Also `add_new_pull_request_to_wbs` should be fixed. See https://developer.github.com/v3/pulls/#get-a-single-pull-request
src/test/resources/com/zerocracy/bundles/small_pr_skip_wbs/_before.groovyg4s8g4s8.public@gmail.com78353530DEV535-b70e915c34-38
Every time we close a job completed by a developer, we should count the amount of messages that person posted in the GitHub issue or a pull request. Let's count not only issue messages, but also commit messages. Then, post it to verbosity.xml
src/main/resources/com/zerocracy/stk/pm/in/orders/close_job.groovyg4s8g4s8.public@gmail.com109678330DEV783-b88b1a6d35-37
Commit messages are not counted. We have to find commits belongs to issue and pushed by task performer and consider it as a verbosity of a user.
src/main/groovy/com/zerocracy/stk/pm/in/orders/update_verbosity.groovyg4s8g4s8.public@gmail.com83354630DEV546-c1316cdf66-68
Let's add project adviser in bootstrap, it should be passed as a bootstrap command parameter (change in q-project.xml) then bootstrap.groovy script should update catalog.xml with this parameter.
src/main/resources/com/zerocracy/stk/pm/bootstrap.groovyrultorme@rultor.com83555530DEV555-426f09d250-52
Let's implement 'Delete user' stakeholder which should find user by id from 'login' param and delete it. Also 'remove_stale_users._after' test should be fixed.
src/main/resources/com/zerocracy/stk/pmo/people/remove_stale_users.groovyg4s8g4s8.public@gmail.com89683530DEV835-3f8bfc9938-41
At moment user.exists() throws NullPointerException for tests, see https://github.com/jcabi/jcabi-github/issues/1370 After jcabi bug fix this condition should be removed and test assertion in `remove_stale_users/_after.groovy` should be uncommented.
src/main/resources/com/zerocracy/stk/pmo/people/remove_stale_users.groovyg4s8g4s8.public@gmail.com84342230DEV422-1711e98637-42
Title element, of an order in agenda, has been declared in agenda.xsd. Let's add method title(...), which will set the title of on order and add a new stakeholder, set_agenda_title_from_github.groovy, which will get title of a job from GitHub and set it to Agenda. THe reason for the new stakeholder is that not all orders will come from Github, some may also come from Jira, Trello etc, in the future.
src/main/java/com/zerocracy/pmo/Agenda.javaamihaiemilamihaiemil@gmail.com110584330DEV843-976686f824-29
Title element, of an order in agenda, has been declared in agenda.xsd. Let's add a new stakeholder, set_agenda_title_from_github.groovy, which will get title of a job from GitHub and set it to Agenda. THe reason for the new stakeholder is that not all orders will come from Github, some may also come from Jira, Trello etc, in the future.
src/main/groovy/com/zerocracy/stk/package-info.javaRoman Proshinroman@proshin.org1152110530DEV1105-a65697ae24-29
Title element, of an order in agenda, has been declared in agenda.xsd. The stakeholder set_agenda_title_from_github.groovy must be implemented correctly: it just runs an script that returns the same value. It must get the title value from github issue and set agenda title with this value. The tests were already implemented in #1105 resolution.
src/main/groovy/com/zerocracy/stk/package-info.javaPaulo Lobopauloeduardolobo@gmail.com90369630DEV696-6509159438-40
Add test for pay_all_depts stakeholder script. It is not possible because payments are not testable. It should be fixed in #565 ticket.
src/main/resources/com/zerocracy/stk/pmo/debts/pay_all_debts.groovyg4s8g4s8.public@gmail.com90880030DEV800-10ded7b040-51
Requests to /join should add an entry to 'resumes.xml' then an 'examiner' should be assigned. When the examiner "invites" a user, we check whether there was a resume for that user. If yes, we pay examiner +32 points. Examiner can reject a resume by saying 'deny {username}' (where username is a login in 'resumes.xml') to Zerocrat. In that case we also pay +32 to the examiner. Each user should see the status of his/her resume at /join. If the resume is there, he/she should see the resume, not the form. If he/she already has a mentor, there should be a redirect, saying that "User @yegor256 is already your mentor, no need to join again". See https://github.com/zerocracy/farm/issues/800#issuecomment-375551970 comment for details.
src/main/java/com/zerocracy/tk/TkJoin.javag4s8g4s8.public@gmail.com114690830DEV908-27b4bc6932-37
Let's create new stakeholder to assign resume to examiner and notify. When the examiner "invites" a user, we check whether there was a resume for that user. If yes, we pay examiner +32 points. Examiner can reject a resume by saying 'deny {username}' (where username is a login in 'resumes.xml') to Zerocrat. In that case we also pay +32 to the examiner.
src/main/java/com/zerocracy/pmo/Resumes.javag4s8g4s8.public@gmail.com1352114630DEV1146-0cb0fd8838-44
New user should be invited only by examiner. We should check that user has a resume in resumes.xml and author of invite is his examiner also new users can be invited by PMO members (has any role in PMO project) without resumes check. On invite we should notify user and examiner and add +32 reputation points to examiner. Also examiner should be able to reject resume by saying `deny @username`.
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyg4s8g4s8.public@gmail.com1486135230DEV1352-131ebec639-44
New users can also be invited by PMO members (has any role in PMO project) or QAs in Zerocracy (C3NDPUA8L) project without resumes check. On invite we should notify user and examiner and add +32 reputation points to examiner. Also examiner should be able to reject resume by saying `deny @username`.
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1552148630DEV1486-f5becce539-41
On invite we should notify user and examiner and add +32 reputation points to examiner. Also examiner should be able to reject resume by saying `deny @username`.
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyg4s8g4s8.public@gmail.com1649155230DEV1552-d7bf68d439-41
Allow examiner to reject resume by saying `deny @username`. In that case examiner should still get +32 points of reputation (and be notified about that).
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1666155230DEV1552-5d564f6639-44
Allow examiner to reject resume by saying `deny @username`. In that case examiner should still get +32 points of reputation (and be notified about that). Implement deny @username stakeholder and create claim Deny resume which must accept parameters set in deny_resume_application\claims.xml. Then uncomment deny_resume_application\_after.groovy tests.
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyrultorme@rultor.com1353114630DEV1146-1c2b1c2045-47
Test for this stakeholder is missed. We should verify that new resume can be assigned only to high-reputation user (>= 1024) and can't be assigned to users on vacation.
src/main/groovy/com/zerocracy/stk/pmo/resumes/assign_examiner.groovyg4s8g4s8.public@gmail.com114790830DEV908-f22ecc2e45-50
Each user should see the status of his/her resume at /join. If the resume is there, he/she should see the resume, not the form. If he/she already has a mentor, there should be a redirect, saying that "User @yegor256 is already your mentor, no need to join again". See https://github.com/zerocracy/farm/issues/800#issuecomment-375551970 comment for details.
src/main/java/com/zerocracy/tk/TkJoin.javag4s8g4s8.public@gmail.com1179114730DEV1147-60d5b5b445-52
Each user should see the status of his/her resume at /join. If the resume is there, he/she should see the resume, not the form. If he/she already has a mentor, there should be a redirect, saying that "User @yegor256 is already your mentor, no need to join again". See https://github.com/zerocracy/farm/issues/800#issuecomment-375551970 comment for details. These two conditions are already tested in TkJoinTest, in showResumeIfAlreadyApplied and showAlreadyHasMentor, and the ignore tag on the tests should be removed upon puzzle completion.
src/main/java/com/zerocracy/tk/TkJoin.javarultorme@rultor.com1506117930DEV1179-61ff2e4f43-48
Each user should see the status of his/her resume at /join. If the resume is there, he/she should see the resume, not the form. See https://github.com/zerocracy/farm/issues/800#issuecomment-375551970 comment for details. This condition is already tested in TkJoinTest, in showResumeIfAlreadyApplied. If implemented, update the test if necessary and the ignore tag should be removed upon puzzle completion.
src/main/java/com/zerocracy/tk/TkJoin.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1568150630DEV1506-ecd7faa730-36
Each user should see the status of his/her resume at /join. If the resume is there, he/she should see the resume, not the form. For this, a resume page must be implemented in zerocracy-datum (pmo/resume .xsl), which will show the resume extracted from Resumes.This condition is already tested in TkJoinTest, in showResumeIfAlreadyApplied. When implemented, update the test and the ignore tag should be removed upon puzzle completion.
src/main/java/com/zerocracy/tk/TkJoin.javaPaulo Lobopauloeduardolobo@gmail.com1805156830DEV1568-f8e630b638-41
TkJoinTest is not checking if join page is being rendered correctly; it just checks if something is rendered. Improve this test making sure that a user that not joined yet is requisting /join and that join page is bein correctly fetched.
src/test/java/com/zerocracy/tk/TkJoinTest.javapaulodamasopauloeduardolobo@gmail.com1569150630DEV1506-9a48ed6331-35
Implement resumes.resume(login), which will return the resume sent for some user. It will have to return a Resume (the interface needs to be created, too) object mapping the resume information so it can be used in resume page. Don't forget to create a test for it in ResumesTest.
src/main/java/com/zerocracy/pmo/Resumes.javaPaulo Lobopauloeduardolobo@gmail.com1645156930DEV1569-990fecb831-36
Implement resumes.resume(login), which will return the resume sent for some user. It will have to return a Resume implementation which reads the resume from resumes.xml. It must read /resumes/resume attributes and return them in its methods. Then remove expected from ResumesTest.findResume so it can be tested to be used in resume page.
src/main/java/com/zerocracy/pmo/Resumes.javaPaulo Lobopauloeduardolobo@gmail.com1774164530DEV1645-dc067a6a41-43
Handle resume not found in resumes.resume(login). It will have to throw a meaningful message using a SoftException. A test should be written to cover this situation.
src/test/java/com/zerocracy/pmo/ResumesTest.javaVictor Noëlvictor.noel@crazydwarves.org90968030DEV680-5b4d78681-6
Change jobStore to JDBC to store job info persistently. Now all quartz jobs will be restarted on application restart, database store will solve it. Before changing job store to JDBC a database should be connected, I suppose via Heroku plugin. This link will be helpful also: http://www.quartz-scheduler.org/documentation/quartz-2.x/configuration/ConfigJDBCJobStoreClustering.html
src/main/resources/quartz.propertiesg4s8g4s8.public@gmail.com95665330DEV653-b9d34fcf40-43
We should allow user to send `/join` requests only once a week, it can be checked and updated via People.applied methods. The 7 days value can be accessed via Par after https://github.com/zerocracy/zerocracy.github.io/issues/9 fix.
src/main/java/com/zerocracy/tk/TkJoin.javag4s8g4s8.public@gmail.com97092530DEV925-41a8087133-35
Vacancies are not rendered on `/vacancies` page. This page should list all current vacancies in all projects. Let's display vacancy author, date and text.
src/main/java/com/zerocracy/pmo/Vacancies.javarultorme@rultor.com97192530DEV925-74129afd36-38
Old vacancies are not removed automatically. Let's add new stakeholder which will remove vacancies from `vacancies.xml` which are older than 32 days.
src/main/java/com/zerocracy/pmo/Vacancies.javarultorme@rultor.com100671530DEV715-1243e0dc24-27
Change 'com.zerocracy.pmo' classes constructor to accept `Pmo` instead of `Project`, also all tests and groovy scripts should be fixed after refactoring. It is: Agenda, Catalog, People, Projects, Rfps, Speed.
src/main/java/com/zerocracy/pmo/package-info.javaYegor Bugayenkoyegor256@gmail.com103688930DEV889-ebed2d8723-27
Implement stakeholder 'check_automatic_vacation.groovy'. We should implement auto-vacation mechanism. See https://github.com/zerocracy/farm/issues/889 and http://www.zerocracy.com/policy.html#52 for details. When done uncomment the assertion below to enable this test.
src/test/resources/com/zerocracy/bundles/turn_on_vacation_for_too_many_negative_awards/_after.groovyYegor Bugayenkoyegor256@gmail.com106068730DEV687-bf5e026538-40
There are no tests for the refresh method (and as a result start method also) of SlackRadar class. Please add tests verifying behavior of those methods.
src/test/java/com/zerocracy/radars/slack/SlackRadarTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com106180830DEV808-5c63d8cf41-44
VsWorkload test is missed, workload votes are not tested neither with first constructor (farm, others) nor with second (farm, project, others). First should be tested for all agenda items, second only for project items.
src/main/java/com/zerocracy/pm/staff/votes/VsWorkload.javag4s8g4s8.public@gmail.com106240230DEV402-12bf002441-42
Let's write a test for RsPage that will check a general case that any page sent to Firefox will be rendered as html and not xml.
src/test/java/com/zerocracy/tk/profile/TkAgendaTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com106340230DEV402-85a1a26e43-44
Write a test confirming that awards page when opened in a Firefox browser will always render html and not xml.
src/test/java/com/zerocracy/tk/profile/TkAgendaTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com106440230DEV402-71bf3c7f45-46
Write a test confirming that profile page when opened in a Firefox browser will always render html and not xml.
src/test/java/com/zerocracy/tk/profile/TkAgendaTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com106656530DEV565-02a276a936-46
Implement method pay() that will write details about payment to the xml file in this format: `<payments> ` <payment> ` <target>trg</target> ` <amount>$0.55</amount> ` <details>dtls</details> ` <result>E0885448-5DEE-11E8-9C2D-FA7AE01BBEBC</result> ` </payment> `</payments> Unignore relevant test case from FkBankTest.
src/main/java/com/zerocracy/pmo/banks/FkBank.javaTolegen Izbassart.izbassar@gmail.com106756530DEV565-1108b58247-55
Implement method fee() that will write details about fee to the xml file in this format: `<fees> ` <fee> ` <amount>$0.50</amount> ` <result>$0.80</result> ` </fee> `</fees> Unignore relevant test case from FkBankTest.
src/main/java/com/zerocracy/pmo/banks/FkBank.javaTolegen Izbassart.izbassar@gmail.com106856630DEV566-492b566856-59
Implement equals so that it conforms the relevant test case from FkBankTest. Implement relevant to equals hashcode method. Implement toString() method, that will print the content of the underlying xml file. Cover with required test cases.
src/main/java/com/zerocracy/pmo/banks/FkBank.javaTolegen Izbassart.izbassar@gmail.com106956530DEV565-edf3387860-62
Add FkBank to the Payroll under the file payment method. Ensure, that the opened files are closed properly and cover Payroll with tests.
src/main/java/com/zerocracy/pmo/banks/FkBank.javaTolegen Izbassart.izbassar@gmail.com1428106930DEV1069-c7edbb2e57-60
Add FkBank to the Payroll under the file payment method. Ensure, that the opened files are closed properly and implement walletIsEmpty, unsupportedPaymentMethod and makePayment tests in PayrollTest.
src/main/java/com/zerocracy/pmo/banks/FkBank.javarultorme@rultor.com107093930DEV939-5d35582c33-38
Implement TkViber. We should be able to receive Viber webhook requests and react to them accordingly. In the case of "message" events, we should route them to ReProfile. For the rest we should at least be able to return a 200 OK response to Viber. When fully implemented this should be added to Main.java so that it can be called. See https://developers.viber.com/docs/api/rest-bot-api/
src/main/java/com/zerocracy/radars/viber/TkViber.javaCarlos Mirandacarlos.m.a.miranda@accenture.com107193930DEV939-6d7b535825-29
Implement Viber bot. We should be able to send messages via the Viber REST API. There are other operations but I think that is the only operation we need (I might be wrong). See: https://developers.viber.com/docs/api/rest-bot-api/#authentication-token https://developers.viber.com/docs/api/rest-bot-api/#send-message
src/main/java/com/zerocracy/radars/viber/VbBot.javaCarlos Mirandacarlos.m.a.miranda@accenture.com1449107130DEV1071-28281b2a32-37
Let's allow notification via Viber. If we receive a Notify claim with a 'viber' prefixed token, we copy the claim to a new claim, "Notify in Viber". Then, create a stakeholder that will handle the claim and send the actual message to the user. Also create a mock/fake VbBot implementation that we can use for stakeholder testing (may require extracting an interface for VbBot).
src/main/groovy/com/zerocracy/stk/pm/comm/notify.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com107293930DEV939-6bf607a528-30
Implement VbEvent.Simple and VbEvent.Message. These classes should be able to parse the underlying JSON and return the correct data via the defined interface methods.
src/main/java/com/zerocracy/radars/viber/VbEvent.javaCarlos Mirandacarlos.m.a.miranda@accenture.com1079107430DEV1074-b36594a127-29
Zold payments are not implemented, we have to modify wallet by including new transaction for user and push it to some node via java-api: https://github.com/zold-io/java-api
src/main/java/com/zerocracy/pmo/banks/Zold.javarultorme@rultor.com108874730DEV747-d2018a51652-654
Groovy scripts are excluded from coverage report because they are not fully tested. Let's add tests for them and remove this `<exclude>` line.
pom.xmlg4s8g4s8.public@gmail.com1391108830DEV1088-c6f329b3492-496
Groovy scripts are now not excluded, as a result complexity coverage ration dropped from 0.57, and instruction coverage dropped from 0.60. Add tests to stakeholder scripts to the previous coverage of 0.57 for complexity and 0.60 for instruction coverage.
pom.xmlKrzysztof KrasonKrzysztof.Krason@gmail.com108974730DEV747-f592778823-25
This test started to fail after moving groovy stakeholder scripts to groovy directory. Assertion `elections.elected` is false now, so it's needed to investigate why this test is failing and fix it.
src/test/resources/com/zerocracy/bundles/not_assign_task_to_reporter/_after.groovyg4s8g4s8.public@gmail.com1504108930DEV1089-d64db1c123-29
This test should be fixed already. However, it is not stable and fails intermittently. Let's stabilize the test and uncomment the code below. Elections elections = new Elections(project).bootstrap() String job = 'gh:test/farm#1' assert elections.elected(job) assert elections.winner(job) == 'g4s8'
src/test/resources/com/zerocracy/bundles/not_assign_task_to_reporter/_after.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1123112130DEV1121-f96bc81e46-48
Speed and Agenda is skipped now because it causes slow page loading. We have to fix #1121 bug and show it on page as before.
src/main/java/com/zerocracy/tk/TkTeam.javag4s8g4s8.public@gmail.com114154030DEV540-880d3ffd32-39
Finish implementing and testing this class, decide on the XML format and declare it in /datum repository. When done, use this metric inside resin_on_delay.groovy. After this, finish implementing the voter VsNegligence: similar to VsSpeed and VsWorkload, it should vote for the user with the highest negligence (most number of delays). When done, the voter should be declared in elect_performer.groovy with weight -1 (since the highest negligence will have the highest vote).
src/main/java/com/zerocracy/pmo/Negligence.javaamihaiemilamihaiemil@gmail.com1450114130DEV1141-7253381b33-38
Use this metric inside resing_on_delay.groovy. After this, finish implementing the voter VsNegligence: similar to VsSpeed and VsWorkload, it should vote for the user with the highest negligence (most number of delays). When done, the voter should be declared in elect_performer.groovy with weight -1 (since the highest negligence will have the highest vote).
src/main/java/com/zerocracy/pmo/Negligence.javarultorme@rultor.com1142108030DEV1080-e7775be0107-109
Refactor this method and similar functionality in TkAwardsTest into a reusable class in which we could control what kind of view we want to generate.
src/test/java/com/zerocracy/tk/profile/TkProfileTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1399114230DEV1142-5773798e30-32
This class should be tested that it actually forwards the call to the TkApp with the url provided by the user, and that the resulting page is an xml or html, depending on the method.
src/test/java/com/zerocracy/tk/View.javaKrzysztof KrasonKrzysztof.Krason@gmail.com114598930DEV989-2e7ad17632-36
MkGithub can't create private repository, any repository from MkGithub is public, see _before in this test. I suppose it's bug in jcabi-github, see https://github.com/jcabi/jcabi-github/issues/1421 When the bug is fixed, update jcabi-github and uncomment code below.
src/test/resources/com/zerocracy/bundles/assign_role/_after.groovyg4s8g4s8.public@gmail.com1163101530DEV1015-7cbe8f9326-28
Fix the problem when PR job is assigned manually it has role of DEV and 30 points award. After fixing it uncomment following two lines and the test should pass.
src/test/resources/com/zerocracy/bundles/assigns_performer_pr/_after.groovyrultorme@rultor.com1167105030DEV1050-8012ef0f73-77
This test is not stable (depending on environment it fails in about 5% cases) refactor it to make it stable. Remember to run large number of builds to make sure it doesn't fail (at least 100 builds are needed, maybe more). The trouble is most probably in ExtMongo for the fake Mongo instance.
src/test/java/com/zerocracy/pm/FootprintTest.javarultorme@rultor.com1189114430DEV1144-dd8c18c543-46
Create an implementation of GitLab API that will mirror the one we use for Github (Github class and friends). We only need those API endpoints that we use in farm project so don't try to implement the full API.
src/main/java/com/zerocracy/radars/gitlab/TkGitlab.javarultorme@rultor.com1190114430DEV1144-5990610c47-52
Create a generic interface for hosted version control systems that we could use in stakeholders (and other classes) where we don't care about specific vendor (Github or Gitlab). Remember that besides the generic interface stakeholders have to have a way to find out if they are working with GitLab or GitHub. Most probably React and Rebound interfaces should be reworked to support such general vendor.
src/main/java/com/zerocracy/radars/gitlab/TkGitlab.javarultorme@rultor.com1191114430DEV1144-d78254a353-55
Mimic the functionality of TkGithub in this class. For Gitlab we should support all the webhook notifications that we currently do for Github.
src/main/java/com/zerocracy/radars/gitlab/TkGitlab.javarultorme@rultor.com1196116830DEV1168-91afb75634-36
TkBadge is temporary disabled because of high load. There are a lot of requests to project badges, each request trigger SyncFarm lock acquire, which is broken right now.
src/main/java/com/zerocracy/tk/project/TkBadge.javag4s8g4s8.public@gmail.com1201116830DEV1168-428c4b6138-40
Revert all unnecessary changes which appeared during #1168 bug fixing. It is: lock timeouts was changed, badges takes was deleted, log levels was changed.
src/test/java/com/zerocracy/tk/PingTest.javag4s8g4s8.public@gmail.com1215120830DEV1208-ab49977348-50
During #1208 fixing PMO claims was saved locally and removed from production. We need to analyze it, find critical claims and submit them to current `claims.xml` in PMO.
src/main/java/com/zerocracy/pm/Claims.javag4s8g4s8.public@gmail.com1245121530DEV1215-4176ce2c38-47
We should not try to add claims with 'Error' type and stacktrace if error was thrown from Claims.add because of claims overflow. It may produce very huge stacktraces (about 2000 lines for stacktrace): claims.xml is full, we try to add new claim, Claims throws an exception about overflow, this exception is handled in StkSafe catch (Throwable), submitted again (goto step 2), this exception may goes in a loop about few hundred times, until some claims will be removed from claims.xml, and then this error with thousand lines of stacktrace lines will be added to `claims.xml`.
src/main/java/com/zerocracy/farm/StkSafe.javag4s8g4s8.public@gmail.com1246121530DEV1215-032c8ff347-51
Invent mechanism to prevent huge claims.xml files. We can check claims.xml size before working with it and pause a project if this size is too big. We can skip downloading from S3, just need to check attributes, and if claims.xml is bigger than 10MB stop working with this project and send notification to PMO.
src/main/java/com/zerocracy/pm/Claims.javag4s8g4s8.public@gmail.com1225105530DEV1055-055a4c3b23-26
Implement logic for removal of all orders and clear WBS when the link to the Github repo is removed by the user. After it is implemented uncomment terminates_orders_wbs_on_link_removal test.
src/main/groovy/com/zerocracy/stk/pm/in/links/terminate_orders_wbs_on_link_removal.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1226104830DEV1048-04512f7325-31
Implement logic for adding webhook in add_github_webhook stakeholder (see #1048 for details). After it is implemented uncomment adds_github_webhook test and make sure it passes. In production we need to use url: http://www.rehttp.net/p/https://www.0crat.com/ghook, and in testing we use current url of our instance + "/ghook". Add another test that will check that in case we don't have enough permissions we will inform the user about it.
src/main/groovy/com/zerocracy/stk/pm/hooks/add_github_webhook/add_github_webhook.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1550122630DEV1226-cf6a00fb29-36
add_github_webhook.groovy bundletest can't be properly implemented because we are not able to retrieve a valid github hook instance: repo.hooks().get(0) returns a MkHook instance and MkHook does not have the #json() method implemented. Wait for the resolution of this case (https://github.com/jcabi/jcabi-github/issues/1425) or find another solution and then uncomment the remaining tests and add another test that will check that in case we don't have enough permissions we will inform the user about it.
src/test/resources/com/zerocracy/bundles/adds_github_webhook/_after.groovyPaulo Lobopauloeduardolobo@gmail.com1231104130DEV1041-c307d5cc997-1002
These tests are failing on Windows system, some of them because of locale and decimal point, see https://github.com/zerocracy/farm/pull/1178#discussion_r196476659 for more details. We need to fix them and remove surefire exclusions from this profile and jacoco exlusions also.
pom.xmlg4s8g4s8.public@gmail.com1542123130DEV1231-e8f4cee31026-1032
Fixing language issues of #1231 did not resolved problems with S3ItemTest. Discover why S3ItemTest is not working in windows builds and fix it. Remove surefire and jacoco exclusions after fixing this problem and update jacoco coverage values. See #1041 https://github.com/zerocracy/farm/pull/1178#discussion_r196476659 for more details about windows build failure.
pom.xmlPaulo Lobopauloeduardolobo@gmail.com1240120030DEV1200-fd0f226645-47
Add a test that validates that pings are sent to projects in batches depending on the ping interval. All projects need to be pinged eventually.
src/test/java/com/zerocracy/entry/PingTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com125791730DEV917-ba7a1a0436-39
Notify all project about expired vacancy. Notification text should include that vacancy was removed because it was expired. Vacancies.removeOlderThan in such case should return project ids of removed vacancies.
src/main/groovy/com/zerocracy/stk/pmo/vacancies/remove_old_vacancies.groovyg4s8g4s8.public@gmail.com1543125730DEV1257-c5a3831932-34
After all the puzzles are solved from #89 (a way to test slack communication) add an assert that will validate that slack messages notifying project about expired vacancies has been posted.
src/test/resources/com/zerocracy/bundles/remove_old_vacancies/_after.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1267112130DEV1121-eb4ead73738-742
We should periodically compute average speed for each person and update it. This stat will be displayed in Team page. Probably the most logical time to do this is after "Order was finished" claim. We can add this logic to compute_speed.groovy stakeholder. We should also add tests for it.
src/main/java/com/zerocracy/pmo/People.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1278105430DEV1054-f370f52f76-77
The code inside the init if should be extracted into another class (a decorator?), as it doesn't belong here at all.
src/test/java/com/zerocracy/tk/RqWithUser.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1279105430DEV1054-30c8b97d69-71
A check whether user is a PO in any of the projects happens in this method and in RqLogin#value. Extract this check to a common place and reuse it in both places.
src/main/java/com/zerocracy/tk/RqUser.javaKrzysztof KrasonKrzysztof.Krason@gmail.com128499330DEV993-2ea9b05d81-83
Fix NullPointerException due concurrency issues. Txn.acq() is throwing an NullPointerException when trying to read this.items. Ignore annotation must be removed after puzzle solution.
src/test/java/com/zerocracy/TxnTest.javarultorme@rultor.com130498030DEV980-46a7406843-45
We need to drop Etherium support from Zerocracy: Remove ETH support mentioned in Policy (§20) and Remove ETH wallets support informing that ETH cannot be used when user tries to use it.
src/main/java/com/zerocracy/pmo/banks/Crypto.javaPaulo Lobopauloeduardolobo@gmail.com130595230DEV952-47c309d245-48
Continue replacing old Date classes with Instant. Remember also to remove instances of `DateAsText` (Instant.toString should be used). There is a lot of classes to change so try to find a good small cluster of related classes that can be updated.
src/test/java/com/zerocracy/pmo/PeopleTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1761130530DEV1305-25fd047a38-42
Continue replacing old Date classes with Instant. Remember also to remove instances of `DateAsText` (Instant.toString should be used). Be careful to ensure Groovy classes are properly updated since typing is sometimes dodgy in there. There is a lot of classes to change so try to find a good small cluster of related classes that can be updated.
src/main/java/com/zerocracy/pmo/Catalog.javaVictor Noëlvictor.noel@crazydwarves.org1311129130DEV1291-e0f9fdc929-32
Add tests for payments via concrete banks, I suppose `Payroll` may check 'testing' property in farm and return fake `Bank` implementations for each supported payment method. First of all we need to test Zold payments.
src/main/groovy/com/zerocracy/stk/pm/cost/funding/send_zold.groovyg4s8g4s8.public@gmail.com1317130730DEV1307-a059640952-55
Changes for #1245 fix were reverted in a2f5821c23469a680485ae8bb6ac875316eb3b24 because they produces #1307 bug: some claims may be missed and never added to claims.xml, so 0crat lose Github or chat actions.
src/main/java/com/zerocracy/pm/Claims.javag4s8g4s8.public@gmail.com1325111930DEV1119-cdea2c7744-46
Reason is not attached to transaction as 'details' because of this bug: https://github.com/zold-io/wts.zold.io/issues/36 let's use reason claim parameter as reason when it will be fixed.
src/main/groovy/com/zerocracy/stk/pm/cost/funding/send_zold.groovyg4s8g4s8.public@gmail.com1364130230DEV1302-97bdfff023-26
This test always fail because for unknown reason roles.xml in PMO is full copy of roles.xml in this fake project. Files in PMO and in bundle test project should be different and not correlate somehow.
src/test/resources/com/zerocracy/bundles/resign_on_delay/_after.groovyg4s8g4s8.public@gmail.com1462136430DEV1364-17eeb363104-108
This class is way to complex for a unit test. Most of the code here should be extracted into another class. And this new class should be covered with unit tests. And BundlesTess should be a simple class that just calls a method or two from the other class. Most of the checkstyle excludes should be removed after this refactoring.
src/test/java/com/zerocracy/BundlesTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1366126930DEV1269-a1c2eb5430-34
Each time a release is published, we should pay the architect a release bonus. Let's create a stakeholder that will react to the "Release was published" claim that will do this. See the following: https://github.com/zerocracy/farm/issues/1269#issuecomment-402054891 http://www.zerocracy.com/policy.html#53
src/main/java/com/zerocracy/radars/github/RbRelease.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1380101630DEV1016-094de40035-38
Add a new stackeholder, remove_impediment.groovy, that will remove the impediment once a user says "@0crat continue" on an Issue that is on hold. The "continue" command is already registered in q-tracker.xml, the code is "Remove impediment".
src/main/java/com/zerocracy/pm/in/Impediments.javarultorme@rultor.com1461138030DEV1380-39754ff830-34
The impediment should also be removed from the Agenda. We should implement a mechanism similar to how register_impediment.groovy and add_impediment_to_agenda.groovy are working. This stakeholder should send a 'Impediment was removed' claim, caught and handled by remove_impediment_from_agenda.groovy.
src/main/groovy/com/zerocracy/stk/pm/in/impediments/remove_impediment.groovyamihaiemilamihaiemil@gmail.com138186030DEV860-c0f3bfe538-40
Modify the stakeholder where the payments are made and use method Speed.bonus(...) to pay the user a bonus in minutes if they completed the job in less than 48 hours.
src/main/java/com/zerocracy/pmo/Speed.javaamihaiemilamihaiemil@gmail.com1483138130DEV1381-932a555e28-31
Create a test for checking that the speed bonus for REV tasks is calculated correctly, and validate that for both DEV and REV tasks when quality is good, the bonus for speed and quality accumulates correctly.
src/test/resources/com/zerocracy/bundles/add_speed_bonus/_after.groovyrultorme@rultor.com1484138130DEV1381-6fac770c58-62
This message has to be moved to the final message in make_payment.groovy stakeholder. Leaving it here adds a pointless message in issue tracker, we could reduce it into a single message that contains all the reasons for bonuses (QA and speed). For that you'll most probably need to create a new parameter that can be retrieved during the payment.
src/main/groovy/com/zerocracy/stk/pm/in/orders/finish_order.groovyrultorme@rultor.com1385103730DEV1037-a0e8482578-80
Xocument is not thread safe. Because of this, multiple threads modifying the same file can result in race conditions. Let's fix the concurrency issue, then enable this unit test.
src/test/java/com/zerocracy/XocumentTest.javaCarlos Mirandacarlosmiranda@users.noreply.github.com138892630DEV926-8659444053-56
we should synchronize elected, but not assigned jobs between different projects, because one project may elect a user as a performer for few jobs and another project may elect same user before jobs from first project will be assigned to the performer.
src/main/groovy/com/zerocracy/stk/pm/staff/elections/elect_performer.groovyrultorme@rultor.com138992630DEV926-0d29fc0096-100
Refactor this method - extract to some class, because it's used in two different places: here and in VsNoRoom, this class should encapsulate farm or pmo and accept login as argument and should get this information from policy, not hard code it.
src/main/java/com/zerocracy/pm/staff/votes/VsOverElected.javarultorme@rultor.com1435143330DEV1433-9a8228e933-36
VsOverElected may cause dead-locks in some cases. Looks like lock for election.xml file can be acquired but never released for unknown reason (not sure about it). After fix also uncomment line in elect_performer script with this Votes.
src/main/java/com/zerocracy/pm/staff/votes/VsOverElected.javag4s8g4s8.public@gmail.com1448141430DEV1414-beb41dc935-41
Cleanup of stale jobs is disabled for QA roles. This is because QA jobs are not in Orders, but in Reviews. This causes a bug where QA agenda is removed even though the jobs have not completed review yet. For QA roles, get the list of jobs from Reviews.findByInspector(). Let's also add a Bundles test case where delete_stale_jobs should clean up jobs that are not in Reviews and retains those that are still awaiting verdict.
src/main/groovy/com/zerocracy/stk/pmo/agenda/delete_stale_jobs.groovyCarlos Mirandacarlosmiranda@users.noreply.github.com1458119330DEV1193-ee91f3f919-22
When https://github.com/zerocracy/datum/issues/375 is done we should refactor this template to display debts table with Job/Project | Added | Amount. Where job should be a job number with a link to the issue/PR, and amount should include both cash value and minutes (as close as possible to agenda table).
src/main/resources/xsl/profile.xslrultorme@rultor.com1460139530DEV1395-2f0f55eb39-41
This assertion fails because Wbs.role(job, role) is not working in `add_job_to_wbs` groovy script for this test case. We need to understand why it fails and fix it.
src/test/resources/com/zerocracy/bundles/close_job_with_quality_review/_after.groovyrultorme@rultor.com146377330DEV773-d4aeb93a50-53
Use Amazon SQS instead of xml files for claims. Let's convert `Claims` to interface and add two implementations: one for SQS and another for xml file (we need to use xml claims in bundle tests).
src/main/java/com/zerocracy/pm/Claims.javag4s8g4s8.public@gmail.com146477330DEV773-9193767329-34
Use long-polling for claims instead of reactions. We are going to split application into web part and worker parts, so we have to submit new claims in both parts, but receive them only in worker parts via claims polling. Worker app will not be physically connected to web part, so web part will not be able to notify worker app about new claims as now via `Flush`es.
src/main/java/com/zerocracy/farm/reactive/Flush.javag4s8g4s8.public@gmail.com1533146430DEV1464-5424b9c629-34
Get rid of flushes and refactor the code to use similar logic for unit-tests and web app. Now web-app logic located in ClaimsRoutine class + com.zerocracy.claims.proc classes, ClaimsRoutine was designed to use claims long-polling with Amazon SQS, but unit tests uses claims.xml files and Flush implementations with RvFarm class.
src/main/java/com/zerocracy/farm/reactive/Flush.javag4s8g4s8.public@gmail.com146577330DEV773-13f5d30a29-32
Use external synchronization of items instead of java locks. There will be multiple instances of worker apps which can access same resources from different machines. We need to invent something to be able to synchronize access to files for all worker instances.
src/main/java/com/zerocracy/farm/sync/SyncItem.javag4s8g4s8.public@gmail.com1644146530DEV1465-4595fca126-29
Implement external locking mechanism based in MongoDB. The lock must be set to some resource in a table where resource path and name must be set, along with time of lock. Then remove expects from MongoDBLockTest.
src/main/java/com/zerocracy/farm/sync/MongoDbLock.javaPaulo Lobopauloeduardolobo@gmail.com1680164430DEV1644-df92de1b29-36
Implement external locking mechanism based in MongoDB. Implement tests for methods in MongoDbLock (stacktrace(), lock(), lockInterruptibly(), tryLock(), tryLock(final long time, final TimeUnit unit), unlock() and newCondition()). These methods must behave as specified in in java 8 java.util.concurrent.locks.Lock interface, except stacktrace() which must behave like SmartLock.stacktrace(). Then implement these methods so they'll pass all the tests below.
src/test/java/com/zerocracy/farm/sync/MongoDbLockTest.javarultorme@rultor.com1681164430DEV1644-7ed092c384-88
Implement external locking mechanism based in MongoDB. According to javas Lock interface, when there is already a lock on given resource, it should suspend the thread until it is possible to do a lock. This class is not implementing this behavior on lock() method. Implement this so this lock should block until the resource is unlocked.
src/main/java/com/zerocracy/farm/sync/MongoDbLock.javarultorme@rultor.com146673330DEV733-0f01ea8f76-82
Prevent StkSafe from swallowing exceptions generated in tests. It was discovered in #733 that StkSafe is treating all exceptions requests in the same way: thay're wrapped in an notify claim and processed. This causes tests to never fail when throwing exceptions: the exception which should break the test is treated like a notification and does not breaks it. We should create a way to avoid this exception swallowing.
src/main/java/com/zerocracy/farm/StkSafe.javaPaulo Lobopauloeduardolobo@gmail.com1480143630DEV1436-66b5a84627-29
Add SQS claims implementation and integration test to verify that it's working, then use it for production code in `ClaimsOf` and use `ClaimsXml` for tests.
src/main/java/com/zerocracy/pm/Claims.javag4s8g4s8.public@gmail.com1532148030DEV1480-7db2565f39-41
Prevent claims duplication, let's add claim's hash based on it's content to claims attributes, save it in footprint and check before processing new claim.
src/main/java/com/zerocracy/pm/ClaimsSqs.javag4s8g4s8.public@gmail.com1492121430DEV1214-eb4dd68758-62
0crat is assigning closed jobs. It happens when the issue was closed in github but the Close Job flow fails for some reason and the job does not leave WBS. Assure that we are iterating only in open issues when electing performer and uncomment _after.groovy tests in dont_assign_job_closed bundle.
src/main/groovy/com/zerocracy/stk/pm/staff/elections/elect_performer.groovyrultorme@rultor.com1508121830DEV1218-6ccd8af140-44
refresh_awards.groovy is submitting claims for all users in Zerocracy even if reputation didn't change. Fix refresh_awards.groovy so it only submit claims when there is a reputation change for user and uncomment tests in dont_refresh_awards_when_no_change/_after.groovy
src/main/groovy/com/zerocracy/stk/pmo/awards/refresh_awards.groovyPaulo Lobopauloeduardolobo@gmail.com1513109930DEV1099-6ff2eb5a22-24
After upgrading datum, version to 0.62.3 this test stopped working (the only changes were adding of `added` field to verbosity, speed and blanks). Find out why and fix it.
src/test/resources/com/zerocracy/bundles/refresh_person_job_count_on_agenda_update/_after.groovyKrzysztof KrasonKrzysztof.Krason@gmail.com1519123330DEV1233-8e34519656-60
Verbosity.add is throwing an exception when trying to add verbosity to a job more than once. We should check verbosity before adding a new element and override the previous value to prevent this exception being thrown. After the fix, test the code removing ignore tag from VerbositTest.overrideVerbosity.
src/main/java/com/zerocracy/pmo/Verbosity.javarultorme@rultor.com154157530DEV575-5d95eb0b33-35
This rank just check that issue is milestoned, but it should check it's due-date param, it can be obtained from milestones.xml by repo coordinates and milestone title.
src/main/java/com/zerocracy/pm/staff/ranks/RnkGithubMilestone.javag4s8g4s8.public@gmail.com1547139030DEV1390-12031a9153-57
Adjust call below to Quota.over with proper message and create test case for the scenario it returns true. The PR https://github.com/zerocracy/farm/pull/1501 introduced this change on Quota.over and has example of its adjustment and test for the case of over use in AcceptInvitations.
src/main/groovy/com/zerocracy/stk/pm/comm/notify_in_github.groovyrultorme@rultor.com1548139030DEV1390-d5feac23150-154
Adjust call to Quota.over with proper message and create test case for the scenario it returns true. PR https://github.com/zerocracy/farm/pull/1501 introduced this change on Quota.over and has example of its adjustment and test for AcceptInvitations.
src/main/java/com/zerocracy/radars/github/TkGithub.javarultorme@rultor.com1564155330DEV1553-3bca3cf463-77
This 'stylesheet' is not merely a document transform, but in fact the central mechanism for determining the result of the election. Not only is this approach confusing and convoluted, it's also very inefficient, since we have to do a XSL transform each and every time we want to determine the result of an election. Let's remove this XSL transform, and replace it with a programmatic version. What I am thinking is to create an inner type, Elections.Result, representing a single election. It should contain the following information: 1) "elected", true if at least one person has a total non-zero vote 2) "winner", username of person with the highest non-zero vote. 3) "reason", the reason why the winner won. We should replace all usages of XSL Stylesheet with Elections.Result. Let's prioritize implementing "elected", since the repeated usage of this in assign_performer.groovy and elect_performer.groovy is not scalable for increasingly big projects.
src/main/java/com/zerocracy/pm/staff/Elections.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1583156430DEV1564-96d4a10936-38
Change this stakeholder to handle 'Performer was elected' claims instead of 'Ping' and assign elected performer from 'login' param to job from 'job' claim param.
src/main/groovy/com/zerocracy/stk/pm/in/orders/assign_performer.groovyg4s8g4s8.public@gmail.com1584153930DEV1539-240ed02847-49
Create a FakeMessage and use it each test where a Message is used. An example is in staysAtOneIfBlocked, remove Mockito mock and use the newly created fake message.
src/test/java/com/zerocracy/claims/proc/CountingProcTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1586150030DEV1500-e289d746581-586
Code warnings in groovy scripts doesn't affect build process. Let's try to fail build if any warning in groovy code was found. It may be an option in gmaven plugin like 'treat warnings as errors' or some codenarc option. We need to prevent such mistakes as in #1500 bug.
pom.xmlg4s8g4s8.public@gmail.com1589156730DEV1567-45090e1f134-139
This method is too complicated at the moment. Let's separate the functionality of extending validity of messages into another class somehow. Note, one complication: we need to keep track of which messages have already been sent by AsyncProc for processing (since they are deleted from the queue very soon after). After refactoring let's remove any unnecessary suppressions here.
src/main/java/com/zerocracy/claims/proc/AsyncProc.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1595117230DEV1172-7bc2550f26-33
Add performance metrics: add measurement of time taken to execute Measured stakeholder. Time taken must be saved to mongodb instance on database "metrics", collection "time_taken". Fields to be saved: "stakeholder" with stakeholder class qualified name, "claim_type" with claim type, "date_time" with datetime of execution, "time_taken" with time taken to stakeholder process claim. After this decorate StkRuntime so it could really collect the metrics and fix test in MeasuredText .collectTimeTakenToExecute if needed.
src/main/java/com/zerocracy/Measured.javarultorme@rultor.com1596117230DEV1172-adac844934-37
Add performance metrics: add measurement of other performance metrics (track S3 artifacts download, xml document modifications, footprint access) and save the to mongodb under database "metrics".
src/main/java/com/zerocracy/Measured.javarultorme@rultor.com1606153430DEV1534-c808318e29-30
For 'Ping' claims, we should add expiry attribute to SQS messages. The expiry period should be 5 minutes after the claim is created.
src/main/java/com/zerocracy/claims/proc/ExpiryProc.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1608107730DEV1077-1ed65c7222-26
Job is not removed from agenda on repo rename. Some jobs are not being removed from agenda. In one of the cases, when a repo is renamed the jobs are not removed from the agenda. After fixing this problem uncomment the test below to assure that the job is being correctly removed
src/test/resources/com/zerocracy/bundles/remove_from_agenda_on_repo_rename/_after.groovyPaulo Lobopauloeduardolobo@gmail.com161051230DEV512-6c0350fb82-85
0crat is displaying an error page when trying to use PsByFlag=PsGithub parameter. This test is triggering this behavior. Find what is causing it and fix it so this exception screen is not displayed anymore and un-ingnore the test below.
src/test/java/com/zerocracy/tk/TkAppTest.javaPaulo Lobopauloeduardolobo@gmail.com1620109830DEV1098-b2de21b625-29
Wire pulse information from /pulse into Pulse as Ticks. See implementation in rultor project on how to initalize Pulse objetcs in program start and how to make it Tick every minute to collect execution data. Then add SVG created in TkTicks to start page (or wherever the pulse bar have to be shown).
src/main/java/com/zerocracy/pulse/Pulse.javarultorme@rultor.com1621154530DEV1545-87cf0a1627-29
Implement BatchClaims for sending claims in batch. Assure that maximum batch size is 256KB for each batch and after implementation remove expected exception from tests in BatchClaimsTest.
src/main/java/com/zerocracy/claims/BatchClaims.javaPaulo Lobopauloeduardolobo@gmail.com1622154530DEV1545-78dce50633-35
We should use Fake classes instead of Mocks. So, implement another way of testing BatchClaims behavior in this test without relying on mockito and mocking.
src/test/java/com/zerocracy/claims/BatchClaimsTest.javaPaulo Lobopauloeduardolobo@gmail.com1640115930DEV1159-ca75469b42-44
Modify add method to accept user that created the given Wbs item and use it in stakeholders (and tests). All Wbs items should have an author (see zerocracy/datum#383).
src/main/java/com/zerocracy/pm/scope/Wbs.javarultorme@rultor.com2279164030DEV1640-5874bcfa30-34
Implement wbs.add(job, author) and wbs.author(job) methods to change wbs.add() method behavior (every wbs item should have an author). The method wbs.add(job) must be deleted when wbs.add(job, author) is implemented. After this, remove addsAndRemovesJobs() test and replace it by addsAndRemovesJobWithAuthor() removing its ignore annotation.
src/test/java/com/zerocracy/pm/scope/WbsTest.javapaulodamasopauloeduardolobo@gmail.com1641115930DEV1159-ce5d7ee634-37
Change implementation of this Take to print the Wbs data created by user from request and format it using an xsl file. To do that you will need to extend `Wbs` with a method that retrieves only those elements that were created by user (see zerocracy/datum#383).
src/main/java/com/zerocracy/tk/profile/TkUserWbs.javarultorme@rultor.com1643110230DEV1102-4d6d1bcf22-24
0crat should not add job to WBS and create order if issue is already closed. Correct add_job_to_wbs.groovy so closed jobs aren't added to WBS. Then uncomment this test.
src/test/resources/com/zerocracy/bundles/dont_add_closed_job_to_wbs/_after.groovyPaulo Lobopauloeduardolobo@gmail.com164792130DEV921-1530b8b322-25
0crat ignores debt on new payment. Change make_payment.groovy so we check if user already has some debts on new payment. If he/she already has, fail the payment and add it to debts. After this, uncomment this test to assure that payment has been added to debts.
src/test/resources/com/zerocracy/bundles/add_payment_to_debts_if_has_debt/_after.groovyPaulo Lobopauloeduardolobo@gmail.com1648134630DEV1346-59918b0444-50
Incorrect zold extra payments. Zold payments are not including shares part of the payment, just cash part. Correct this and change send_zold so it emits a notification of payment even when testing ('Notify test' claim) so we can assure that the correct value was calculated. Then, uncomment \send_correct_zold_value\_after.groovy which checks footprint for these notifications in this bundle test. See #1346 for the correct formula for calculating zold value.
src/main/groovy/com/zerocracy/stk/pm/cost/funding/send_zold.groovyPaulo Lobopauloeduardolobo@gmail.com1657133330DEV1333-6882f9fb51-53
Board page is slow, load all project properties present in board page in catalog.xml similar it is made in team page. After this, uncomment test catalogHasBoardPageInfo
src/test/java/com/zerocracy/pmo/CatalogTest.javarultorme@rultor.com1952165730DEV1657-8629e70845-49
Implement stakeholders to update catalog project properties such as architect, members, jobs, orders, cash, languages. Languages should be loaded from github repository. This stakeholder should be started once a day. All update should be performed in a transaction.
src/main/java/com/zerocracy/tk/TkBoard.java@g4s8g4s8.public@gmail.com1954195230DEV1952-ecca0a0359-61
Right now we are displaying all languages for all repositories. We should only display the top 4 languages (ranked by bytes of code, as returned by Github) across all project repos.
src/main/groovy/com/zerocracy/stk/pmo/catalog/update_catalog_props.groovyKirillg4s8.public@gmail.com1953165730DEV1657-7708bb2538-41
Board implementation was changed, let's updated this tests according new implementation based on `0.64` datum update which changed catalog.xml format with new catalog properties.
src/test/java/com/zerocracy/tk/TkBoardTest.javaKirillg4s8.public@gmail.com1658153630DEV1536-7b5e844422-25
Project is not paying adviser when being funded. Correct fund_by_stripe.groovy and donate.groovy to send a payment of 4% of the amount of funding to the project advisor on every funding operation. Then uncomment these tests to make sure that these payments are happening.'
src/test/resources/com/zerocracy/bundles/pays_adviser_on_funding/_after.groovyPaulo Lobopauloeduardolobo@gmail.com1790165830DEV1658-f3d9a10541-43
We should allow negative balance only to PMO project. If any other project tries to submit a transaction which changes the balance to negative value we should fail this transaction.
src/main/java/com/zerocracy/pm/cost/Ledger.javaKirillg4s8.public@gmail.com1791165830DEV1658-5dca057288-90
Add adviser info to policy and provide amount of adviser payments there, then replace current constants which are used to calculate the payment with `Par` objects.
src/main/groovy/com/zerocracy/stk/pm/cost/funding/fund_by_stripe.groovyKirillg4s8.public@gmail.com1792165830DEV1658-62012fd922-24
It's not possible to test ledger related code because it uses PgLedger Postgres implementation, let's extract interface of PgLedger and create fake ledger object to use it for testing. Then uncomment this test.
src/test/resources/com/zerocracy/bundles/pays_adviser_on_funding/_after.groovyKirillg4s8.public@gmail.com1669157030DEV1570-01eb7ff831-36
cleanup_comments often fails. This happens because we are trying to remove from github some comment that had already been deleted before using github interface. We must test if the comment exists in github before trying to delete it. After the correction, uncomment tests in /cleanup_comments/_after.groovy. Don't forget to remove the lines that skip this stakeholder in test mode too so we can test its behavior.
src/main/groovy/com/zerocracy/stk/internal/cleanup_comments.groovyPaulo Lobopauloeduardolobo@gmail.com1670166330DEV1663-4d268a0e24-26
Elections.remove is not working for this test, it's called in `remove_stale_elections` but doesn't affect target file in this test. Let's fix it and uncomment this test.
src/test/resources/com/zerocracy/bundles/remove_invalid_elections/_after.groovyg4s8g4s8.public@gmail.com168793030DEV930-ecca0a03188-190
Right now we are displaying all languages for all repositories. We should only display the top 4 languages (ranked by bytes of code, as returned by Github) across all project repos.
src/main/java/com/zerocracy/tk/TkBoard.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1692133230DEV1332-94d9282c66-71
After zerocracy/datum#386 is done remove below filtering based on Awards below and get the data directly from people.xml file. Also people.xml needs to be updated with "active=true" when given person receives any award, and when there is no reward for the last 90 days, we should automatically updated people.xml with "active=false".
src/main/java/com/zerocracy/tk/TkTeam.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1705134730DEV1347-5a27c21a7-11
Call this script from maven build (maybe on `process-test-resources` if possible), the execution of this script should be enabled with maven profile, e.g.: `mvn process-test-resources -Pupgrade-bundles`. Note: this script depends on compiled farm classes, such as Xocument, Farm, so it's required to reference farm classes somehow before run.
upgrade_bundles.groovyrultorme@rultor.com1762170530DEV1705-5eef677d152-156
Xocument writes upgraded xml files with formatting incompatible with xcop validation. When upgrade-bundles profile is activated it results in xcop errors in the upgraded files. After this has been resolved enable upgrade-bundles profile in rultor and travis builds.
src/main/java/com/zerocracy/Xocument.javaKrzysztof KrasonKrzysztof.Krason@gmail.com1706134730DEV1347-214c7ed461-66
Xocument is the most slow part of the system, especially in bundle tests: bootstrap of a new file can take few hundreds ms to complete (in BundleTests too many new files to bootstrap). Also there are too many `modify` calls, which can take few seconds in sum for one bundle test. Let's investigate how to speed up this class and discuss the solution.
src/main/java/com/zerocracy/Xocument.javarultorme@rultor.com1871170630DEV1706-b3b081d261-63
Find all usages of this method and replace them with acq(file, mode) methods with correct access mode, when all done, remove this default method.
src/main/java/com/zerocracy/Project.javaKirillg4s8.public@gmail.com1872170630DEV1706-2d29728430-31
Implement ReadWriteLock in PgLock and use it here also add many tests to verify that postgres locks are working correctly.
src/main/java/com/zerocracy/farm/sync/PgLocks.javaKirillg4s8.public@gmail.com1763139630DEV1396-ad84ffab26-28
This stakeholder was disabled, because `Elections` class was removed. Let's find another way to check the lack of staff to notify a project about it.
src/main/groovy/com/zerocracy/stk/pm/staff/hint_when_lack_of_staff.groovyg4s8g4s8.public@gmail.comunknown166230DEV1662-c5598e8535-41
Ledger is really slow when it grows big. Performance degrades linearly (O(n)) with the size of the ledger due to the need to perform ID lookups. The slowdown is roughly 50ms per 1000 entries. See https://github.com/zerocracy/farm/issues/1662#issuecomment-416454156 for details. Let's move away from using XML and record entries using Postgres. For more info see https://github.com/zerocracy/farm/issues/1662#issuecomment-422759929
src/main/java/com/zerocracy/pm/cost/Ledger.javaCarlos Mirandacarlosmiranda@users.noreply.github.com1764166230DEV1662-8f6d00af46-48
Run this test with embedded postgres installation on Travis and Rultor. Embedded database should be started before tests and updated with liquibase changelog from maven.
src/test/java/com/zerocracy/pm/cost/PgLedgerITCase.javarultorme@rultor.com1765116230DEV1162-5bbf3bac40-42
In continuation of #1162, add a test to ensure that a payment results on points being awarded. Once this is done, add a todo to continue the work on the the "Make Payment" started with #1162.
src/main/groovy/com/zerocracy/stk/pm/cost/make_payment.groovyrultorme@rultor.com1766173130DEV1731-c06199b757-59
ClaimsRoutine is too complex and not testable, let's refactor it to few simpler classes and unit test them if possible.
src/main/java/com/zerocracy/claims/ClaimsRoutine.javag4s8g4s8.public@gmail.com1767171130DEV1711-5de0b04148-50
Provide a single Mongo database instance (process) for all tests. The ExtMongo launches a new Mongo database process every time it is requested for the testing purposes.
src/main/java/com/zerocracy/entry/ExtMongo.javarultorme@rultor.com1768171130DEV1711-0d4ee78451-55
Provide a documentation on how to configure an external (local or remote) Mongo database authorization. It is not clear how to do this properly. If a Mongo database security.authorization option is turned on, it is impossible to pass the authentication by running associated unit tests.
src/main/java/com/zerocracy/entry/ExtMongo.javarultorme@rultor.com1769171130DEV1711-a20e4cad56-58
Fix up failing cases when an external Mongo database is specified for tests. Under these conditions the Mongo database data is not get cleared every time a new database related test is started.
src/main/java/com/zerocracy/entry/ExtMongo.javarultorme@rultor.com1780177930DEV1779-30eba46a94-97
We are ignoring ping claims duplicates due to Sentry over loading, ping duplicates are not critical, but we need to uncomment this check (!claim.type().equals("Ping")) after duplicate issue fix in #1770.
src/main/java/com/zerocracy/claims/Footprint.javaKirillg4s8.public@gmail.com1796116230DEV1162-41dbc93d43-44
In continuation of #1162, add a test to ensure that a payment results on points being awarded. Also add tests for transfer_shares and pay_cash stakeholders.
src/main/groovy/com/zerocracy/stk/pm/cost/make_payment.groovyKirillg4s8.public@gmail.com1819181530DEV1815-c9e7ebc3136-139
We're loading all transactions here, it would be better to implement lazy loading for transaction pages and return iterable which will trigger next page loading when previous pages are read.
src/main/java/com/zerocracy/pmo/banks/coinbase/Coinbase.javaKirillg4s8.public@gmail.com1893189230DEV1892-81b0117026-28
This test is failing on rultor but is working fine on local and on travis CI. It seems there is some issue with parallel test execution (may be I'm wrong about it, just a guess).
src/test/resources/com/zerocracy/bundles/pr_assigns_performer/_after.groovy@g4s8g4s8.public@gmail.com1905177530DEV1775-79469cb730-32
Reimplement this class - it should return not constant set of users, but all users who has any role in PMO project and users who has QA role in Zerocracy project.
src/main/java/com/zerocracy/pm/staff/GlobalInviters.java@g4s8g4s8.public@gmail.com1908190430DEV1904-85820cd733-35
0crat often can't update agenda of performer on 'Start QA review' because failed to find the job in agenda. 0crat is responding with message "can't inspect" right in the ticket.
src/main/groovy/com/zerocracy/stk/pm/qa/start_qa_review.groovyKirillg4s8.public@gmail.com1922175330DEV1753-e367fe7374-78
It's a temporary workaround to use `login` as a name, because jcabi-github can't check that real name is present because of bug https://github.com/jcabi/jcabi-github/issues/1495 After fix `hasName` in jcabi-github uncomment the code above and remove name variable initialization.
src/main/groovy/com/zerocracy/stk/pmo/profile/invite_friend.groovyKirillg4s8.public@gmail.com1968196630DEV1966-8492b125375-379
Refactor wallet usage, wallet command was removed from chat bots, so we're sending all payments only via Zold WTS by Github username. So let's update datum and remove elements from 'people' scheme and remove it from farm then. Same for bank() method.
src/main/java/com/zerocracy/pmo/People.javaKirillg4s8.public@gmail.com1989189730DEV1897-424356db47-50
MkPull.merge is not implemented in jcabi github library let's submit a bug to jcabi, wait for fix and remove this check for testing mode. MkPull.merge should change 'merged' boolean flag in pull JSON, see github docs. Also jcabi can implement Pull.Smart.merged() method to check that PR was merged.
src/main/groovy/com/zerocracy/stk/pm/cost/pay_architect_for_pull_request.groovyKirillg4s8.public@gmail.com1996150730DEV1507-c0ca225223-25
When implementing 1507 this test was broken because mock code was removed from `remove_stale_users` script. Let's implement this test in other way and not use mocking in stakeholder scripts.
src/test/resources/com/zerocracy/bundles/upbcWp_remove_stale_users/_after.groovyKirillg4s8.public@gmail.com2049203030DEV2030-8edd287a48-54
Reimplement this stakeholder in such way: it should react to 'Reputation was updated' for the user, and if it was less than 1024 but becomes greater than 1024 then kick out user from sandbox projects. If user decided to join sandbox project when he/she has more than 1024 reputation, then we should not kick out such user. Use 33.sandbox-rep-threshold instead of 1024 like in this stk.
src/main/groovy/com/zerocracy/stk/pm/staff/roles/kickout_from_sandbox.groovyKirillg4s8.public@gmail.com2084145330DEV1453-269b8f9449-52
Add new command to handle `sandbox on|off` command in q-project.xml and stakeholder to change sandbox in catalog.xml via Catalog.sandbox(...) methods. This stakeholder should allow to change sandbox flag only to users with role in PMO.
src/main/java/com/zerocracy/pmo/Catalog.javaKirillg4s8.public@gmail.com2102134930DEV1349-1d1c372632-35
Remove application when user get the role in project (invited by ARC or PO), keep in mind, that user can be invited even he/she is not in the `applications.xml` list. Also, let's remove old application (older than one month), we can check it periodically every week.
src/main/java/com/zerocracy/pm/staff/Applications.javaKirillg4s8.public@gmail.com2165215030DEV2150-34dfa09b32-37
- Lets introduce new `Farm`, `Project` and `Item` implementation which should check that `project.acq()` and `item.close()` are called on proper project thread (see this class for thread name pattern), then replace `SyncProject` with new implementation. It will trigger some design issues (like some stakeholders may access resources of different projects), so it should be solved before.
src/main/java/com/zerocracy/claims/proc/ExecFor.javaKirillg4s8.public@gmail.com2170216530DEV2165-34dfa09b36-42
- Lets introduce new `Farm`, `Project` and `Item` implementation which should check that `project.acq()` and `item.close()` are called on proper project thread (see this class for thread name pattern), then replace `SyncProject` with new implementation. It will trigger some design issues (like some stakeholders may access resources of different projects), so it should be solved before.
src/main/java/com/zerocracy/claims/proc/AsyncSink.javaKirillg4s8.public@gmail.com2171216530DEV2165-6203cc2e189-192
Some threads are getting terminated by someone from outside. More often PQ-PMO thread is interrupted. Most probably `Terminator` is the problem here. Let's fix this issue and remove this dirty hack from this object.
src/main/java/com/zerocracy/claims/proc/ProjectQueue.javaKirillg4s8.public@gmail.com2178217730DEV2177-1b35d37732-36
Continue replacing `project.acq(file)` with explicit `project.acq(file, mode)`. When done, remove `default acq(file)` method from interface. Also, find a way to avoid unnecessary bootstrap on each access, since it's expensive read-write locking operation.
src/main/java/com/zerocracy/Project.java@g4s8g4s8.public@gmail.com2195219430DEV2194-2e5e4df363-67
Election is disabled for huge WBS (> 50 items). Analyze the bottleneck of election performance, most probably it can be solved by caching some external resources, such as Github labels etc. Then optimize election process and enable it back.
src/main/groovy/com/zerocracy/stk/pm/staff/elections/elect_performer.groovyYegor Bugayenkoyegor256@gmail.com2203220230DEV2202-a6c7d53a102-106
Fix JobAudit. It may complain about not existing issues. Most probably it counts only PR comments to find authors, but CR comments can be different entities in Github. After fix skip payment if any complaints exist.
src/main/groovy/com/zerocracy/stk/pm/in/orders/finish_order.groovyKirillg4s8.public@gmail.com2204205130DEV2051-5324c0a452-56
Adding milestones which doesn't match the pattern '[a-z]{2}:[A-Z0-9a-z.\-#/]+' fail with exception on XML validation Validation happens inside com.jcabi.xml.StrictXML constructor, outside of this project's codebase. Un-ignore this test and remove comment after impediments are resolved.
src/test/java/com/zerocracy/pm/time/MilestonesTest.javaloro2oroszlany.lorant@gmail.com2285223730DEV2237-7683322433-38
Don't kickout graduates from sandbox projects Instead of removing the script, we must add a way to enable and disable a feature. Add Assume.feature method that will check for the feature name in a list of enabled features. Then change claims.xml type to `Ping hourly' to add dont_kickout_graduates_from_sandbox to tests execution.
src/main/groovy/com/zerocracy/stk/pm/staff/roles/kickout_from_sandbox.groovypaulodamasopauloeduardolobo@gmail.com