unknown444-700e5a1e444rultor-drain/src/test/java/com/rultor/drain/StandedTest.java59-6030DEVunknownunknown@0pdd.com
Refactor tests to support new Request/Response clases from rexsl-test 0.8.
unknown162-79dc5021162rultor-drain/src/main/java/com/rultor/drain/Standed.java85-8630DEVunknownunknown@0pdd.com
As soon as rexsl #716 is resolved remove SQSEntry interface and use Request directly.
unknown285-bf044707285rultor-drain/src/main/java/com/rultor/drain/Standed.java148-15030DEVunknownunknown@0pdd.com
Due to a problem with concurrency we're using this same thread executor. When the problem is fixed we should use Executors.newFixedThreadPool(Standed.THREADS, new VerboseThreads())
unknown201-bee63d33201rultor-widget/src/main/java/com/rultor/widget/BuildHealth.java69-7230DEVunknownunknown@0pdd.com
If we increase the amount of elements to be processes, an OutOfMemory exception will be thrown. I don't understand why and how memory leakage is happening... http://stackoverflow.com/questions/18684598
unknown34-f8b8e11934rultor-base/src/main/java/com/rultor/shell/Terminal.java75-7730DEVunknownunknown@0pdd.com
This implementation is extremely bad and doesn't comply with any standards. Let's find out what is the right way to escape strings for BASH and implement it here
unknown307-21366cc2307rultor-base/src/main/java/com/rultor/ext/jira/RxJiraIssue.java146-14630DEVunknownunknown@0pdd.com
Paging is not implemented
unknown238-d7aca987238rultor-web/src/test/java/com/rultor/web/AuthKeysTest.java82-8230DEVunknownunknown@0pdd.com
AuthKeys should validate empty string.
unknown439-04d567a5439rultor-web/src/test/java/com/rultor/web/ButtonRsTest.java249-25430DEVunknownunknown@0pdd.com
Batik image generation depends on JDK used and in some cases leads to different images for the same data (e.g. different anti-aliasing in images) as a result the images can't be compared byte by byte. This problem can be recreated by running image generation with OpenJDK and Oracle JDK. Possible solution would be to use vector images or a different library to generate images.
unknown215-ce623916215rultor-users/src/test/java/com/rultor/users/pgsql/ArchiverITCase.java63-6430DEVunknownunknown@0pdd.com
Refactor test so it can run VACUUM correctly, right now it throws "VACUUM cannot run inside a transaction block".
unknown275-0d238316275rultor-conveyer/src/main/resources/start.sh78-8330DEVunknownunknown@0pdd.com
This design is wrong, for one important reason - it doesn't take into account a version of software being deployed. Version is hardcoded in ec2-pom.xml as 1.0-SNAPSHOT. This should be changed. An alternative approach is to specify version as user data parameter, and use Maven only to download one required executable JAR file. Then, just run it with provided user data arguments.
unknown536-6896859a536src/main/java/com/rultor/dynamo/DyTalks.java285-28630unknownunknown@0pdd.com
Remove this method and PMD.TooManyMethods when jcabi-aspects#91 is resolved.
IMPunknown593-2aed2390593src/test/java/com/rultor/agents/req/DockerRunTest.java115-11630unknownunknown@0pdd.com
Add handling of hash inside single and double quotes - it should not be treated as a comment there.
IMP633594-7fd8c4ec594src/test/java/com/rultor/agents/req/StartsRequestTest.java60-6130unknownunknown@0pdd.com
Add a test for case where dockerfile is specified instead of image in configuration (docker: directory some/directory).
IMPunknown633-705a6074633src/main/resources/com/rultor/agents/req/_head.sh81-8330unknownunknown@0pdd.com
For some reason the pipes inside use_image are giving non-zero exit code although the result filename is correct. Find out why it is happening and remove unsetting of pipefail below
IMPunknown565-b6318cf3565src/test/java/com/rultor/agents/req/StartsRequestTest.java60-6030unknownunknown@0pdd.com
Add a test for stop command.
IMPunknown674-74d6c10e674src/test/java/com/rultor/agents/github/IndexesRequestsTest.java46-4830unknownunknown@0pdd.com
Implement behavior tested in storeIndexIfNone, retrievesIndexFromLog, retrievesIndexFromSibling and remove Ignore annotation. Add this SuperAgent to com.rultor.agents.Agents.starter method.
IMP1156570-b7bcc1c2570src/main/java/com/rultor/profiles/GithubProfile.java247-25030unknownunknown@0pdd.com
Implement validation using Kwalify library in separate class called ValidYaml, move this method to that class and move tests from GitHubProfileValidationTest to ValidYamlTest. Remember about removing PMD suppress below.
IMPunknown561-e08f2fc3561src/test/java/com/rultor/profiles/GithubProfileValidationTest.java48-4930unknownunknown@0pdd.com
Implement validation tests based on 2014-07-13-basics.md file.
IMPunknown498-a06fa417498src/test/java/com/rultor/agents/github/StarsTest.java47-4830
When MkStars (issues jcabi/jcabi-github#965 and jcabi/jcabi-github#965) is implemented remove Ignore annotations.
IMPkrzykKrzysztof.Krason@sabre.comunknown629-e67af157629src/main/java/com/rultor/agents/ec2/Amazon.java42-4730
Add implementation for com.rultor.agents.ec2.Amazon. It must create com.amazonaws.services.ec2.AmazonEC2 client with config params "credentials", "zone", "type", "key". Use client.runInstances(com.amazonaws.services.ec2.model.RunInstancesRequest) to run on-demand instance. Method runOnDemand must finally wait for started instance and check if start was successful.
IMPalevohinalevohin@mail.ruunknown629-7845a57e629src/main/java/com/rultor/agents/ec2/StartsEC2.java48-5030
Implement com.rultor.agents.ec2.StopsEC2 agent. It must stopped EC2 on-demand instance if it was started at StartsEC2 agent. StopsEC2 must use instance id from /talk/ec2/[@id] to stop it.
IMPYuriy.Alevohinyuriy.alevohin@zed.comunknown629-1e130e87629src/main/java/com/rultor/agents/ec2/StartsEC2.java51-5430
RegistersShell must register SSH params "host", "port", "login", "key" for ec2 on-demand instance, if this one was successfully started. Successfully start means that these parameters exist in /talk/ec2
IMPalevohinalevohin@mail.ruunknown629-50db40cf629src/main/java/com/rultor/agents/ec2/StartsEC2.java55-5730
Add new instance creation classes for StartsEC2 and StopsEC2 to com.rultor.agents.Agents. StartsEC2 must be invoked before RegistersShell agent. StopsEC2 must be invoked after RemovesShell agent.
IMPalevohinalevohin@mail.ruunknown629-b8fe2cc2629src/main/java/com/rultor/agents/ec2/StartsEC2.java58-5930
Write documentation for configuring ec2 via .rultor.yml at 2014-07-13-reference.md
IMPalevohinalevohin@mail.ru1157748-9cbe7474748src/main/java/com/rultor/agents/Mails.java47-5330
Implement Mails agent. Similar to what we do in CommentsTag we should do here - send an email to all listed addresses. The body of the email should contain similar text to what we create for the tag comment. Postman's parameters are stored in Manifest.MF. We need 4 parameters: Rultor-SMTPHost, Rultor-SMTPPort, Rultor-SMTPUsername, Rultor-SMTPPassword. New instance of Mails must be created at Agents, after CommentsTag.
IMPalevohinalevohin@mail.ru1158748-bb1cb5c5748src/main/java/com/rultor/agents/Mails.java54-5630
Describe in file 2014-07-13-reference.md config parameters for email after release and how it works shortly. Config format described in issue #748.
IMPalevohinalevohin@mail.ru1159748-a3bd319f748src/test/java/com/rultor/agents/MailsTest.java95-9630
Implement method sendsToRecipients. It must check that mail is sent to all recipients. Recipients are defined in Profile.
IMPalevohinalevohin@mail.ru1160662-8cc0c29a662src/main/java/com/rultor/agents/github/ReleaseBinaries.java47-4930
Implement attaching artifacts to release, remove PMD suppression below and enable attachesBinariesToRelease test. Similar functionality exists in CommentsTag so you can look there for clues.
IMPkrzykKrzysztof.Krason@sabre.comunknown567-359f8c66567src/main/java/com/rultor/agents/daemons/EndsDaemon.java63-6430
Refactor this class to use less objects and remove checkstyle exception above.
DEVYegor Bugayenkoyegor@tpc2.com10531018-15a5404e1018src/test/java/com/rultor/agents/daemons/StartsDaemonITCase.java121-12530
Implement a deprecation message at the start and end of the process if the project is using the default image 'yegor256/rultor'. Fix the issue using the xpath available in com.rultor.agents.daemons.StartsDaemon and com.rultor.agents.daemons.EndsDaemon.
IMPSebin GeorgeSebin.George@datacash.com11611053-dc86a5cc1053src/main/java/com/rultor/agents/daemons/EndsDaemon.java64-6630
Reduce the data abstraction coupling of EndsDaemon in order to get rid of the checkstyle suppression of ClassDataAbstractionCouplingCheck
IMPNicolas Filottonicolas.filotto@gmail.comunknown1018-b83a728c1018src/test/java/com/rultor/agents/daemons/StartsDaemonITCase.java126-12830
This test should not check for start and end deprecation messages if when the repo is the actual Rultor repo: https://github.com/yegor256/rultor
IMPSebin GeorgeSebin.George@datacash.com1162918-89660440918src/test/java/com/rultor/agents/github/ClosePullRequestTest.java59-6330
This class should only close pull requests for successful merges, that have not resulted in GitHub itself closing the PR, do nothing for any other kind of request. Once this is implemented here, implement this class acting on all pull requests by adding it to the active Agents.
IMPViktor Kuchynkuchin.victor@gmail.com11631041-7f83dd261041src/main/java/com/rultor/agents/docker/DockerHealthCheck.java47-5030
Add DockerHealthCheck to the running SuperAgents. In doing so make sure that Rultor crashes throwing a meaningful exception as soon as DockerHealthCheck#execute throws and exception. #1041 has the details on the motivation behind this agent.
IMPArmin Braunarmin.b@icanlocalize.com11641039-d8a49c641039src/main/java/com/rultor/profiles/Profiles.java108-11530
Add integration test to be sure that validation exception will eventually be posted as an Answer in GitHub. After you create integration test, add `validated` method call in `fetch` method: `...this.validated(master, this.merged(...`. Modify `merged` method implementation: merged profile is a `.rultor.yml` form result of real `git merge` of master branch and fork branch. We need real `git merge` result here. See some details here: https://github.com/yegor256/rultor/pull/1064/files#r56796959
IMPMaksimenko Vladimirxupypr@xupypr.comunknown1055-4f9e2bff1055pom.xml777-78430
build docker image and run sshd container (see src/docker-it/run_docker_sshd.sh), run integration tests (port information located at target/sshd.port, host is predefined) and than tear down container (see src/docker-it/clear_docker_sshd.sh). Need to be configured to run in Travis. Adjust com.rultor.agents.daemons.StartsDaemonITCase#talk to use ssh into the dockerized SSH daemon when the profile docker-tests is active. Add a quick explaination of this test feature to the readme containing what it does and how to run the tests with this profile active.
IMPArmin Braunarmin.b@icanlocalize.com1165629-3b4a7478629src/main/java/com/rultor/agents/ecs/Amazon.java42-4530
Add implementation for com.rultor.agents.ecs.Amazon. It must create com.amazonaws.services.ecs.AmazonECSClient with config params "credentials", "zone", "type", "key". Method runOnDemand must finally wait for started container and check if start was successful.
IMPMaksimenko Vladimirxupypr@xupypr.com1166629-97e18362629src/main/java/com/rultor/agents/ecs/StartsECS.java51-5330
Implement com.rultor.agents.ecs.StopsECS agent. It must stop ECS on-demand container if it was started at StartsECS agent. StopsECS must use container ARN from /talk/ec2/[@id] to stop it.
IMPMaksimenko Vladimirxupypr@xupypr.comunknown629-bf520350629src/main/java/com/rultor/agents/ecs/StartsECS.java54-5730
RegistersShell must register SSH params "host", "port", "login", "key" for ecs on-demand container, if this one was successfully started. Successfully start means that these parameters exist in /talk/ec2
IMPalevohinalevohin@mail.ru1167629-efc8aa9c629src/main/java/com/rultor/agents/ecs/StartsECS.java58-6030
Add new container creation classes for StartsECS and StopsECS to com.rultor.agents.Agents. StartsECS must be invoked before RegistersShell agent. StopsECS must be invoked after RemovesShell agent.
IMPMaksimenko Vladimirxupypr@xupypr.com1168629-bb1a14ed629src/main/java/com/rultor/agents/ecs/StartsECS.java61-6430
Implement the ability to use Rultor with any AWS account, by providing the credentials to it via the encrypted assets and a respective configuration setting in the .rultor.yml. Document the implementation properly in the Rultor documentation.
IMPMaksimenko Vladimirxupypr@xupypr.com11691125-c2e86b181125src/main/java/com/rultor/Routine.java59-6830
Routine should be delegate execution to separate threads. Currently com.rultor.Routine#process() is sequentially processing all Talks and breaking out of this sequential processing to log occurring exceptions. This leads to issues in one build breaking all builds globally. This should be reworked to run the chain of Agents for each talk in a separate thread, not interfering with the main Routine in error cases. Once this is done the swallowing of generic exceptions, added to circumvent this issue, in com.rultor.agents.github.Reports#process(com.jcabi.xml.XML) should be removed.
IMPArmin Braunme@obrown.io12326290IMP629-ebd8dabe81-82
Add Container params to Directive, for example publicIpAddress Let's fix this when possible. The ticket will be in GitHub.
src/main/java/com/rultor/agents/ecs/StartsECS.javaYegor Bugayenkoyegor256@gmail.com1303124630DEV1246-03defb2b53-56
PR by ARC merge shouldn't require confirmation by ARC. Implement the asked in #1246. The tests have already benn implemented in QnByArchitectTest.acceptsIfMergeArchitectPull. After resolving this issue, uncomment the test.
src/main/java/com/rultor/agents/github/qtn/QnByArchitect.javaPaulo Lobopauloeduardolobo@gmail.com1837163390DEV1633-f29541d1127-134
Replace typedResponse static method with RsFork. The current solution with typedResponse method is crutch, actually. The previous solution with {@link org.takes.facets.fork.RsFork} was broken after the Maven 3.9.0 release. The proper solution would be to fix the original problem in <a href="https://github.com/yegor256/takes">takes</a> framework and then to return the correct solution with {@link org.takes.facets.fork.RsFork} back.
src/main/java/com/rultor/web/RsPage.java@yegor256yegor256@gmail.com184310DEV1-e3409bbe188-191
Improve assertion for correct start release request Test should have an assertion, so it is the fastest way to add it. Comments are prohibited in methods by current stylechecker.
src/test/java/com/rultor/agents/req/StartsRequestTest.javaNatalia PozhidaevaNatalia_Pozhidaeva@epam.com184410DEV1-0304c8cf232-235
Improve assertion for correct start merge request Test should have an assertion, so it is the fastest way to add it. Comments are prohibited in methods by current stylechecker.
src/test/java/com/rultor/agents/req/StartsRequestTest.javaNatalia PozhidaevaNatalia_Pozhidaeva@epam.com186614590DEV1459-0d69ec2c196-198
Enable this test after com.jcabi.github.mock.MkPull changed to allow to work with the files in Pull according to https://github.com/jcabi/jcabi-github/issues/1720
src/test/java/com/rultor/agents/github/qtn/QnMergeTest.javarultorme@rultor.com1896107460DEV1074-474b2aa959-64
Current implementation can answer only for issue and PR comments, mostly because of Issue structure from jcabi-github (id is integer). For now mentions NOT from issue or PR will be ignored. Can be extended if more generic entity will be created to cover commits and may be other types.
src/main/java/com/rultor/agents/github/StartsTalks.java@rultorme@rultor.com1918120760DEV1207-256f2781105-108
There is no limit of tail message (only shifting to 100_000 symbols), but TkDaemon has a limit of 100_000 symbols in buffer It is better to have a restriction for the tail length, not about start position.
src/main/java/com/rultor/agents/daemons/EndsDaemon.java@rultorme@rultor.com2155124630DEV1246-1f929d5228-31
PR by ARC merge shouldn't require confirmation by ARC. Implement the asked in #1246. The tests have already been implemented in QnByArchitectTest.acceptsIfMergeArchitectPull. After resolving this issue, uncomment the test.
src/main/java/com/rultor/agents/github/qtn/QnByArchitect.java@yegor256yegor256@gmail.com223957030DEV570-0dda1891316-319
Implement validation using Kwalify library in separate class called ValidYaml, move this method to that class and move tests from GithubProfileValidationTest to ValidYamlTest. Remember about removing PMD suppress below.
src/main/java/com/rultor/profiles/GithubProfile.java@yegor256yegor256@gmail.com