11143370DEV337-8e901889169-169
Implement exclude and excludes for ant QuliceTask
qulice-ant/src/main/java/com/qulice/ant/AntEnvironment.java@Graurancongr@yandex.ru11153370DEV337-3d7cb36139-39
Implement unit tests at AntEnvironmentTest
qulice-ant/src/test/java/com/qulice/ant/AntEnvironmentTest.java@Graurancongr@yandex.ru111654430DEV544-c37b2cc338-40
Tests below pass only when run sequentially, when they are run in parallel some of them start to fail. Please fix the tests below and remove override of maven-surefire-plugin configuration in qulice-pmd pom.xml
qulice-pmd/src/test/java/com/qulice/pmd/PmdEmptyTest.java@Graurancongr@yandex.ru11172500DEV250-1b26b28c42-52
Maven-duplicate-finder-plugin should support exclusions. Let's add exclusions of following formats (examples): - duplicate:about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 - duplicate:org.codehaus.groovy.ast.expr.RegexExpression - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 |xml-apis:xml-apis:1.0.0|about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 |xml-apis:xml-apis:1.0.0|org.w3c.dom.UserDataHandler See https://github.com/tpc2/qulice/issues/152#issuecomment-39028953 and https://github.com/teamed/qulice/issues/250 for details
qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java@Graurancongr@yandex.ru11182500DEV250-bd6aad8857-59
Fix a problem with maven configuration of duplicate finder plugin in commented out code below, and enable duplicate-finder-ignore-deps IT in pom.xml.
qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java@Graurancongr@yandex.ru11191230DEV123-1f09aa3b41-42
Make this better in multiple lines but different.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.javagraurancongr@yandex.ru11201230DEV123-b644cf2264-65
Make this better in multiple lines.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.javagraurancongr@yandex.ru1121123120DEV123-cfed8d027-7
This is also valid.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.javagraurancongr@yandex.ru11221230DEV123-5357374c24-25
Here we should capture also another line.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.javagraurancongr@yandex.ru112373830DEV738-5bee823d39-41
Static inner classes should be qualified with outer class Implement QualifyInnerClassCheck so it follows what defined in QualifyInnerClassCheck test and add this check to checks.xml and CheckTest.
qulice-checkstyle/src/main/java/com/qulice/checkstyle/QualifyInnerClassCheck.javagraurancongr@yandex.ru11242600DEV260-dc51e6f448-49
Add handling of multiple anonymous classes inside methods by looking at the recursive tree.
qulice-checkstyle/src/main/java/com/qulice/checkstyle/MethodBodyCommentsCheck.javagraurancongr@yandex.ru112541230DEV412-bd044e7657-59
Split this class into smaller ones and remove PMD exclude `TooManyMethods`. Good candidates for moving out of this class are all that use `validateCheckstyle` method.
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.javagraurancongr@yandex.ru112644730DEV447-94597ea9304-306
Right now ConstantUsageCheck takes into account usage of constants inside method annotations, add handling of constants used in field and class annotations.
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.javagraurancongr@yandex.ru11276130DEV61-61fa67ee446-448
This test and passesWindowsEndsOfLineWithoutException should be refactored to gather log4j logs and validate that they work correctly. (see changes done in #61)
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.javagraurancongr@yandex.ru112841130DEV411-71c8871e459-463
Sample code provided in #411 should be considered as invalid. Find a way how to do that by either custom check, or updating Checkstyle whenever IndentationCheck there will be more reliable. As for Checkstyle 6.15 there's no ready solution for that. Right now Qulice allows both correct and incorrect code from #411.
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.javagraurancongr@yandex.ru118011480DEV1148-d892359844-44
Avoid branchContains usages in checks and delete this class
qulice-checkstyle/src/main/java/com/qulice/checkstyle/BranchContains.java@blablatdinova.ilaletdinov@yandex.ru118111480DEV1148-0feabb8c46-46
Avoid equalsTree usages in checks and delete this class
qulice-checkstyle/src/main/java/com/qulice/checkstyle/EqualsTree.java@blablatdinova.ilaletdinov@yandex.ru119211290DEV1129-2c8d24c888-89
If was added to avoid failing build, but there should be better place for this check.
qulice-pmd/src/main/java/com/qulice/pmd/PmdListener.java@yegor256yegor256@gmail.com119311290DEV1129-a60b2495130-131
Replace not+empty() with more precise containsInAnyOrder @throws Exception If something wrong happens inside.
qulice-pmd/src/test/java/com/qulice/pmd/PmdValidatorTest.javaYegor Bugayenkoyegor256@gmail.com