1159860DEV98-ccf056c0251-262
I assumed that the test `test_different_properties_when_concurrent_inserts` would be passed. I see like this: ``` [2024-08-22 21:14:53.962] ERROR -- Expected: 1 Actual: 0: nil [2024-08-22 21:14:53.962] ERROR -- Expected: 1 Actual: 0: nil test_different_properties_when_concurrent_inserts ERROR (0.01s) Minitest::UnexpectedError: RuntimeError: Only 0 out of 5 threads completed successfully /home/suban/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/threads-0.4.0/lib/threads.rb:73:in `assert' test/test_factbase.rb:265:in `test_different_properties_when_concurrent_inserts' ```
test/test_factbase.rb@yegor256yegor256@gmail.com1169860DEV98-6370f6bf278-285
I assumed that the test `test_concurrent_transactions_inserts` would be passed. I see like this: ``` Expected: 100 Actual: 99 D:/a/factbase/factbase/test/test_factbase.rb:281:in `test_concurrent_transactions_inserts' ``` See details here https://github.com/yegor256/factbase/actions/runs/10492255419/job/29068637032
test/test_factbase.rb@yegor256yegor256@gmail.com1179860DEV98-8aa17f83327-338
I assumed that the test `test_concurrent_queries` would be passed. I see like this: ``` [2024-08-22 17:40:19.224] ERROR -- Expected: [0, 1] Actual: [0, 0]: nil [2024-08-22 17:40:19.224] ERROR -- Expected: [0, 1] Actual: [0, 0]: nil test_concurrent_queries ERROR (0.00s) Minitest::UnexpectedError: RuntimeError: Only 0 out of 2 threads completed successfully /home/suban/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/threads-0.4.0/lib/threads.rb:73:in `assert' test/test_factbase.rb:329:in `test_concurrent_queries' ```
test/test_factbase.rb@yegor256yegor256@gmail.com33030230DEV302-0da7696f8-10
Remove this module and move its methods to Factbase::TermBase. Currently, we use it because we are required to inject all thesse methods into Factbase::Term. When all the terms will inherit from Factbase::TermBase, we can remove this module.
lib/factbase/terms/shared.rb@volodya-lombrozovolodya.lombrozo@gmail.com44233090DEV330-d3182961349-362
Fix the flaky test 'test_txn_performance_degradation'. The 'test_txn_performance_degradation' sometimes fails, sometimes passes. The reason is not clear yet. I got the following error message: ``` In indexed+cached+rules+plain, the trend is up: 2.483, 2.567, 2.872, 2.785, 2.798, 2.895, 3.114, 3.152, 3.087, 3.094. Expected 5 to be < 5. test/factbase/test_query.rb:366:in 'block in TestQuery#test_txn_performance_degradation' test/factbase/test_query.rb:496:in 'Hash#each' test/factbase/test_query.rb:496:in 'TestQuery#with_factbases' test/factbase/test_query.rb:352:in 'TestQuery#test_txn_performance_degradation' ``` It needs investigation.
test/factbase/test_query.rb@yegor256yegor256@gmail.com35730230DEV302-2566871e68-71
Remove the _arithmetic method. Currently, we use it because we are required to inject all thesse methods into Factbase::Term. But we have Factbase::Arithmetic class for arithmetic operations. When all the 'math' terms will use from Factbase::Arithmetic, we can remove this method.
lib/factbase/terms/math.rb@yegor256yegor256@gmail.com36524930DEV249-13330610145-148
Enable unique prediction tests. Right now these tests are disabled because unique prediction is not implemented yet. When it's done we should enable the tests and make sure they work as expected. Don't forget to remove the puzzle.
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com36724930DEV249-dbaa326422-24
Improve prediction for 'unique' term. Current prediction is quite naive and returns many false positives because it just filters facts which have exactly the same set of keys regardless the values. We should introduce more smart prediction.
lib/factbase/indexed/indexed_term.rb@yegor256yegor256@gmail.com37036330DEV363-56f9dfcf37-39
Move the test to a separated class. Since we've moved prediction of 'one' term to separated class IndexedOne, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@rultorgpg@rultor.com37436330DEV363-3e1331b827-29
Move the test to a separated class. Since we've moved prediction of 'exists' term to separated class IndexedExists, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com37836330DEV363-766882fb16-19
Introduce new test for indexed 'absent' term. We've moved the logic for prediction 'absent' term from IndexedTerm class to a separated IndexedAbsent class. But for some reason there's no test for the term in this TestIndexedTerm. Let's introduce it and move to a separated test class like it's done with TestIndexedOne.
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com38236330DEV363-5ba60f44129-131
Move the test to a separated class. Since we've moved prediction of 'unqieu' term to separated class IndexedUnique, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com38336330DEV363-ce25b77821-23
Move the test to a separated class. Since we've moved prediction of 'eq' term to separated class IndexedEq, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com39436330DEV363-32a641fe100-102
Move the test to a separated class. Since we've moved prediction of 'lt' term to separated class IndexedLt, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com39736330DEV363-0ff6815581-83
Move the test to a separated class. Since we've moved prediction of 'gt' term to separated class IndexedGt, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com39936330DEV363-c5700afa31-33
Move the test to a separated class. Since we've moved prediction of 'and' term to separated class IndexedAnd, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com40636330DEV363-5b3c468e58-60
Move the test to a separated class. Since we've moved prediction of 'or' term to separated class IndexedOr, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com40736330DEV363-45cff65921-23
Move the test to a separated class. Since we've moved prediction of 'not' term to separated class IndexedNot, let's move this test to a separated test class too in order to be consistent with rule 'one class - one test class'
test/factbase/indexed/test_indexed_term.rb@yegor256yegor256@gmail.com44542430DEV424-00be419f10-13
Add dedicated unit tests for LazyTapedArray class. Currently this class is tested indirectly through LazyTaped tests. We should add explicit tests for all public methods including each, [], to_a, any?, <<, and uniq! to ensure proper copy-on-write behavior.
lib/factbase/lazy_taped_array.rb@yegor256yegor256@gmail.com44642430DEV424-092ae89511-14
Add dedicated unit tests for LazyTapedHash class. Currently this class is tested indirectly through LazyTaped tests. We should add explicit tests for all public methods including keys, map, bracket access, bracket assignment, and the copy-on-write behavior.
lib/factbase/lazy_taped_hash.rb@yegor256yegor256@gmail.com67164430DEV644-ba59c59f10-16
Add a test that validates YARD docstring examples match the actual API signatures. The docstring in this class was recently fixed because the block signature was documented as |f, fbt| but the actual implementation passes |property, value|. A general test that parses docstrings and checks their examples against the real method signatures would prevent this class of bugs from recurring across the codebase.
lib/factbase/inv.rb@VasilevNStas33578155+VasilevNStas@users.noreply.github.com1123101760DEV1017-2ccd0ddf38-45
Yield the facts one by one, the way the plain query does. The facts are collected before any of them is yielded, so a caller that breaks out of the loop still pays for every remaining fact, and a term that raises on a later fact raises even though the caller never asked to see it. Streaming here breaks test_materializes_before_iterating, which relies on the snapshot to keep a nested sub-query stable while the block inserts facts, so a way to keep that guarantee without collecting first has to be found before this can change.
lib/factbase/indexed/indexed_query.rb@yegor256yegor256@gmail.com1410121360DEV1213-0636d68747-50
Notice a fact replaced in the scoped array without a change of its size. Every index, the range ones included, only compares the size of the array with the count it has seen, so it rebuilds when the array shrinks but keeps answering with the old fact when one element is swapped for another and the size stays the same.
lib/factbase/indexed/indexed_eq.rbmorphqddeuropeDreadlyDevil@gmail.com