10 3 30 IMP 3-04ce612e 44-46 Let's implement this entry point, where we will render all puzzles we have for a particular project. Let's not forget about security too. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 11 3 30 IMP 3-09c2d743 35-38 It's not really effective to always save the XML document back to storage, even when it was not really modified. Would be much better to check whether any modifications have been made and skip that SAVE() operation. objects/puzzles.rb Yegor Bugayenko yegor256@gmail.com 12 3 20 IMP 3-5ec03020 48-51 For some reason, at the moment of this PUSH event arrival the repository is not ready yet and we don't have the current version of it. Let's introduce some delay or some other method, so that we can wait until the repo is in proper state. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 13 2 30 IMP 2-f47a3215 52-56 At the moment we're not thread-safe. If two PUSH events arrive at the same time we will/may have troubles with concurrent modification of S3 objects and Git repository. Let's introduce some queing system, which will put all requests into a pipeline and proceed them one by one. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 15 13 30 IMP 13-4c2685d4 34-37 We may lose the moment of update and forget to create an issue or close it. For many reasons that may happen. No matter why, we have to do the second check once in a while and update GitHub issues. Maybe every hour or so. objects/job.rb Yegor Bugayenko yegor256@gmail.com 16 15 30 IMP 15-1dc72086 41-43 This feature is not implemented now and it makes it very difficult to track the status of puzzles in a repo. Let's add this simple converter from XML to HTML (through XSLT). 0pdd.rb Yegor Bugayenko yegor256@gmail.com 17 15 30 IMP 15-a1d6817e 32-34 We don't have an SVG badge for GitHub, which will show how many puzzles we have at the moment in the repo. Let's create it, in SVG format (and maybe in PNG too). 0pdd.rb Yegor Bugayenko yegor256@gmail.com 14 3 20 IMP 3-9fa46796 36-39 This mechanism of body abbreviation is rather primitive and doesn't produce readable texts very often. Instead of cutting the text at the hard limit (40 chars) we have to cut it at the end of the word, staying closer to the limit. objects/github_tickets.rb Yegor Bugayenko yegor256@gmail.com 22 3 15 IMP 3-41f7e700 33-35 Page not found is not implemented. When I open a URL that doesn't exist I see a default sinatra "not found" page, which is annoying. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 34 1 30 IMP 1-e4c85f20 33-35 This puzzle is just a test. It has to prove that the system works. Right after that I will remove it and it has to be removed from Github. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 35 31 15 IMP 31-641f9fa5 33-35 This puzzle is just a test. It has to prove that the system works just well. Right after that I will remove it and it has to be removed from Github. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 36 31 15 IMP 31-3016794f 23-26 This is just a test puzzle. This is just a test puzzle. This is just a test puzzle. This is just a test puzzle. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 37 31 15 IMP 31-30e0dcda 23-26 This is just a test puzzle 2. This is just a test puzzle 2. This is just a test puzzle 2. This is just a test puzzle 2. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 38 31 15 IMP 31-bd057c47 23-26 This is just a test puzzle 3. This is just a test puzzle 3. This is just a test puzzle 3. This is just a test puzzle 3. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 39 1 30 IMP 1-1c2ee73f 23-25 We lose errors when they happen with the source code. They just drop into the log and that's it. Instead, we must email them to the repository owner or a predefined email from .0pdd.yml 0pdd.rb Yegor Bugayenko yegor256@gmail.com 47 41 30 IMP 41-ab139346 58-60 Let's add GZIP compression to this output, since most XML files are rather big and it would be beneficial to see them compressed in the browser. 0pdd.rb Yegor Bugayenko yegor256@gmail.com 48 41 30 IMP 41-15a94873 87-89 Let's post notification messages to tickets where other puzzles were waiting for the resolution of this one. Let's update them with a summary information of what is left. objects/puzzles.rb Yegor Bugayenko yegor256@gmail.com 55 26 30 IMP 26-9cfe9c79 25-27 Let's implement a unit test for this class, using some SMTP stubbing engine, to catch the emails it is sending. We must be sure that the functionality works. objects/emailed_tickets.rb Yegor Bugayenko yegor256@gmail.com 56 26 30 IMP 26-91cf6434 25-27 Let's implement a unit test for this class, using some SMTP stubbing engine, to catch the emails it is sending. We must be sure that the functionality works. It's very important. objects/emailed_tickets.rb Yegor Bugayenko yegor256@gmail.com 58 26 30 IMP 26-2470bd41 25-27 Let's implement an integration test for this class, using some SMTP stubbing engine, to catch the emails it is sending. We must be sure that the functionality works. objects/emailed_tickets.rb Yegor Bugayenko yegor256@gmail.com 64 40 30 IMP 40-679dfbe3 27-29 Would be great to make sure the exceptions that we swallow here are also emailed to the admin, in order not to be lost. Let's do it as soon as possible. objects/safe_tickets.rb Yegor Bugayenko yegor256@gmail.com 65 64 30 IMP 64-9110b6ed 52-54 Let's implement the emailing of the exception. Somehow we need to encapsulate the email client and format the exception backtrace to make it look nice. objects/safe_tickets.rb Yegor Bugayenko yegor256@gmail.com 77 76 30 IMP 76-925a3c27 91-93 Would be better to store these two guys somewhere in configuration and re-use on every click. At the moment we are making too many unnecessary calls to the operating system. 0pdd.rb 0pdd git@0pdd.com 83 80 30 IMP 80-31addd77 142-144 Let's create an integration test for this feature, with DynamoDB Local. It's important to make sure that log works. Also, class Log should be used in the test. 0pdd.rb yegor256 yegor256@gmail.com 84 80 30 IMP 80-59dbe53a 142-145 Let's create an integration test for this feature, with DynamoDB Local. It's important to make sure that log works. Also, class Log should be used in the test. Let's use Maven plugin, like it's done in yegor256/sixnines GitHub project. 0pdd.rb yegor256 yegor256@gmail.com 111 110 30 IMP 110-9c9d8a7c 57-59 Let's add DynamoDB Local for the testing cycle and make sure we work correctly with Dynamo persistence layer. Somehow we must also fix the Rakefile. 0pdd.rb yegor256 yegor256@gmail.com 112 110 30 IMP 110-1d6b79a2 199-201 Let's not show the MORE link in the log list if the list doesn't have any more elements. At the moment we keep showing that MORE link if any elements are there. 0pdd.rb yegor256 yegor256@gmail.com 113 110 30 IMP 110-b6547ac0 28-30 Let's make puzzles.xsd publicly avaiable in the web and let's add it to the XML files we save, so that users can see the XSD schema together with the XML content. Rakefile yegor256 yegor256@gmail.com 198 194 30 DEV 194-4ac81527 248-250 Need to figure out the correct way to accept the Organization Invitation. It's not quite clear. Octokit Doc Link: https://bit.ly/2qFkfpU 0pdd.rb yegor256 yegor256@gmail.com 199 195 60 DEV 195-ac2e468f 116-117 Replace body with Template markdown using engine such as Liquid. https://github.com/Shopify/liquid objects/github_tickets.rb rultor me@rultor.com 349 41 30 DEV 41-65582b0c 432-432 Make this vcs independent. Move this logic to github vsc object. 0pdd.rb Ayomide Bakare bakkareayomideo@gmail.com 351 312 30 DEV 312-e81466ef 56-58 Currently, if 0pdd fails to close an issue it causes all other downstream execution to be skipped therefore leaving the job in a non deterministic state. Catch and track the error here to prevent this from happening. Also applies to `add_comment(...)` objects/vcs/github.rb Ayomide Bakare bakkareayomideo@gmail.com 353 312 30 DEV 312-3e51e119 383-384 Handle the use case where projects from different vcs have the same <user/repo_name>. This will cause a conflict. 0pdd.rb Ayomide Bakare bakkareayomideo@gmail.com 354 312 30 DEV 312-68d60ea6 33-34 Be sure to handle the use case where projects from different vcs have the same <user/repo_name>. This will cause a conflict. objects/log.rb Ayomide Bakare bakkareayomideo@gmail.com 360 378 30 DEV 378-7f330a4d 35-35 rewrite @is_valid = {} as it suppose to be after the jira server part integration objects/vcs/jira.rb Arina Cheverda amoriodi@yandex-team.ru 386 234 15 DEV 234-12f515de 8-11 Add tests for more complicated dynamics, like [here](https://github.com/php-coder/mystamps/issues/695#issuecomment-405372820). Ideally, this tests other cases that can lead to the observed behaviour, but not covered by the test suite. test/test_diff_complicated.rb @yegor256 yegor256@gmail.com 562 532 60 DEV 532-a6c77906 30-32 Add unit-tests. We should add unit-tests for this class that checks puzzle ranking. For now its untested, don't forget to remove this puzzle. model/linear.rb rultor me@rultor.com 563 532 60 DEV 532-c8e80cf1 55-60 Implement a ranked puzzles. Let's implement a class that will use `LinearModel` to rank puzzles. This class is need in order to do an integration between original 0pdd and model modules. Probably it can be a decorator for `Puzzles` that ranks XML puzzles, and then submits them into `Puzzles`. Don't forget to remove this puzzle. model/linear.rb rultor me@rultor.com 564 532 60 DEV 532-cf0ceb1a 28-32 Implement a decorator for optional model configuration load. Let's implement a class that decorates `Puzzles` and based on presence of `model: true` attribute in YAML config, decides whether the puzzles should be ranked or not. Don't forget to remove this puzzle. objects/puzzles.rb rultor me@rultor.com 591 572 60 DEV 572-65f83727 152-153 rewind is removed from rack 3.0, so it is moved to rewindableInput for now, but it is better to check another solutions 0pdd.rb @rultor me@rultor.com