171635DEV716-7b35e97f19-23
Enable hone.yml and jmh.yml (hone-dependent workflow) after hone will be fixed. At present, the hone is unable to generate the correct optimized byte code for Groovy, see this issue: https://github.com/objectionary/hone-maven-plugin/issues/297. Also, the plugin run is time-consuming, we should enable it only after the plugin will have stable execution time, in order to not disturb the development in this repository.
.github/workflows/hone.ymlYegor Bugayenkoyegor256@gmail.com254060DEV540-1cf7838e10-14
Add a new style package - `write-good` - to both this list and the package list. Then fix all the issues it reports(there will be a lot). It’s better to run Vale locally to find issues, since the GitHub Action outputs the list in a less readable format when there are many errors. format due to the large number of errors.
.vale.iniYegor Bugayenkoyegor256@gmail.com339330DEV393-4973abd922-26
DEV Introduce LfDfSticky integration tests. LfDfSticky is used in PkMono and PkWpa, which in turn are used in Program and Programs. Run Program::defects and Programs::defects separately and check that caching works correct. Important to note that specific Lint implementation is highly coupled with PkMono class, which in turn is used in Program's most used constructor, so probably Program(s) refactoring is required.
src/main/java/org/eolang/wpa/LtDfSticky.javaYegor Bugayenkoyegor256@gmail.com425960DEV259-23892a1e29-33
Optimize performance of inconsistent arguments finding. Instead of re-collecting objects in nested loops, we should merge all objects from all programs into single XMIR under '<o/>' element. After objects are merged, we can iterate over all the objects there only once, and find inconsistencies.
src/main/java/org/eolang/wpa/LtInconsistentArgs.javaYegor Bugayenkoyegor256@gmail.com562460DEV624-70aa78e15-10
Enable `catches-inconsistency-in-nested-anonymous-formations` test story. For now, its disabled because `LtInconsistentArgs` fails to convert parent tree with anonymous objects to searchable XPath for the XMIR. We should change our logic in both `LtInconsistentArgs#voidFqn()` and `VoidXpath`. Don't forget to enable `catches-inconsistency-resolving-anonymous-path.yaml`, `catches-inconsistency-when-parent-object-lacks-name.yaml`, and test stories as well.
src/test/resources/org/eolang/lints/packs/wpa/inconsistent-args/catches-inconsistency-in-nested-anonymous-formations.yamlYegor Bugayenkoyegor256@gmail.com462760DEV27-db1e6d8f26-28
Re-enable the incorrect-alias lint in integration tests once its performance is fixed. Remove it from the .without() calls in this test class. The lint is currently too slow because it is called once per source file.
src/test/java/org/eolang/wpa/WpaIntegrationTest.java@volodya-lombrozovolodya.lombrozo@gmail.com472760DEV27-a4f5539129-31
Re-enable the object-is-not-unique lint in integration tests once its performance is fixed. Remove it from the .without() calls in this test class. The lint is currently too slow because it is called once per source file.
src/test/java/org/eolang/wpa/WpaIntegrationTest.java@volodya-lombrozovolodya.lombrozo@gmail.com482760DEV27-f63cfce032-34
Re-enable the atom-is-not-unique lint in integration tests once its performance is fixed. Remove it from the .without() calls in this test class. The lint is currently too slow because it is called once per source file.
src/test/java/org/eolang/wpa/WpaIntegrationTest.java@volodya-lombrozovolodya.lombrozo@gmail.com492760DEV27-27ef2c5035-37
Re-enable the inconsistent-args lint in integration tests once its performance is fixed. Remove it from the .without() calls and re-enable the detectsInconsistentArgsAcrossFolders test. The lint has O(n^2) performance issue.
src/test/java/org/eolang/wpa/WpaIntegrationTest.java@volodya-lombrozovolodya.lombrozo@gmail.com502760DEV27-7432a51b38-40
Re-enable the incorrect-number-of-attributes lint in integration tests once its performance is fixed. Remove it from the .without() calls in this test class. The lint recomputes object definitions once per source file.
src/test/java/org/eolang/wpa/WpaIntegrationTest.java@volodya-lombrozovolodya.lombrozo@gmail.com666290DEV62-27c27c0b22-28
Reconsider the architectural placement of LtUnlintNonExistingDefectWpa. This lint is a second-order lint (lint of lints): it validates +unlint annotations by running other active lints and inspecting their results. This makes it fundamentally different from peer lints in WpaLints and forces PkWpa to treat it as a special case. Consider whether it belongs in the Lint hierarchy at all, or should be extracted into a separate post-processing abstraction that operates on already-computed defect results rather than embedding itself among peer lints.
src/main/java/org/eolang/wpa/PkWpa.java@volodya-lombrozovolodya.lombrozo@gmail.com