unknown 2-5feea170 2 pom.xml 84-90 30 DEV unknown unknown@0pdd.com Get rid of reb4j dependency and build that regular expression on compile phase, somehow. Maybe we can use some sort of Groovy plugin, which will create the expression and store it in a plain text file, which will be used later in runtime. It's important to leave expression building mechanims maintainable. If we just hard-code the expression, we'll loose an ability to maintain/change it later. unknown 2-4b48606c 2 pom.xml 98-100 30 DEV unknown unknown@0pdd.com Get rid of commons-lang3 dependency, or move it to "test" scope. It's not efficient for such a small and lightweight library to have a big dependency of this kind. unknown 2-b54ace9f 2 pom.xml 107-109 30 DEV unknown unknown@0pdd.com Get rid of commons-io dependency, or move it to "test" scope. It's not efficient for such a small and lightweight library to have a big dependency of this kind. unknown 32-8743edc8 32 src/test/java/com/jcabi/xml/StrictXMLTest.java 171-176 30 unknown unknown@0pdd.com This test does nothing useful for the moment, to be a real test it needs to mock com.jcabi.xml.StrictXML.newValidator() and new mocked validator should throw few SocketException's while executing javax.xml.validation.Validator.validate(Source) in order to simulate the situation with network problems. For more details, see com.jcabi.xml.StrictXML.validate(XML) as well. IMP unknown 70-64aec8f3 70 pom.xml 217-221 30 This reporting doesn't work, becuase of a conflict with Patterns.java file, which is generated on fly and doesn't really have a source. See the log here, for example: http://www.rultor.com/t/5393-146659058 Let's fix it somehow and enable this profile again. DEV Yegor Bugayenko yegor@tpc2.com unknown 96-5e311117 96 src/test/java/com/jcabi/xml/StrictXMLTest.java 60-63 30 Fix the tests passesValidXmlUsingXsiSchemaLocation() and rejectsInvalidXmlUsingXsiSchemaLocation() which started failing with exception from SaxParser (http://maven.apache.org/maven-v4_0_0.xsd; White spaces are required between publicId and systemId). IMP Mihai Andronache amihaiemil@gmail.com 213 221 30 DEV 221-807476ba 59-64 Implement XPath 2.0 evaluations. We have to implement XPath 2.0 evaluations in order to support more complex XPath queries. For example, the following query is not supported: - "//o[@base and @ver]/concat(@base,'|',@ver)" When we implement XPath 2.0 evaluations, we should remove the @Disabled annotation from findsXpathWithFunctionThatReturnsSeveralItems test. src/test/java/com/jcabi/xml/XMLDocumentTest.java @volodya-lombrozo volodya.lombrozo@gmail.com 248 1 90 DEV 1-ee5e6b2b 168-172 Enable Groovy Integration Test The Groovy integration test is disabled because it fails. The problem is that the XMLDocument#equals method is indentation-aware, but it shouldn't be. We need to fix it and enable the test. pom.xml @rultor me@rultor.com 249 1 90 DEV 1-c7571585 390-393 Implement comparison of XML documents with different indentations. The current implementation of XMLDocument does not ignore different indentations when comparing two XML documents. We need to implement a comparison that ignores different indentations. Don't forget to remove the @Disabled annotation from this test. src/test/java/com/jcabi/xml/XMLDocumentTest.java @rultor me@rultor.com 303 301 35 DEV 301-8e1d58a4 52-55 Remove suppression of "PMD.JUnitAssertionsShouldIncludeMessage" warning. For now its suppressed, but it would be great to add assertion message in each test, and enable the check. Don't forget to enable it in {@link XSLDocumentTest}, {@link XPathContextTest} as well. src/test/java/com/jcabi/xml/XMLDocumentTest.java @h1alexbel h1alexbelx@gmail.com