unknown 143-44bd09d0 143 src/main/java/com/jcabi/log/DecorsManager.java 47-48 30 unknown unknown@0pdd.com The class has to be @Immutable, but with ConcurrentMap it's impossible to do. Let's refactor. IMP unknown 143-c036470e 143 src/main/java/com/jcabi/log/PreFormatter.java 46-48 30 unknown unknown@0pdd.com The class has to be annotated with @ToString, but we can't do it at the moment: https://code.google.com/p/projectlombok/issues/detail?id=457 IMP 31 26-b04be6bf 26 src/test/java/com/jcabi/log/ObjectDecorTest.java 66-68 30 unknown unknown@0pdd.com The ObjectDecor class is not implemented yet, that's why the test is not enabled at the moment. You should uncomment the lines below and make sure the test passes. IMP unknown 31-6c930351 31 src/test/java/com/jcabi/log/ObjectDecorTest.java 66-71 30 unknown unknown@0pdd.com Let's handle arrays. For now, ObjectDecor only does a deepToString of array contents. Let's make it so that each of its members will also show its internal contents. Ensure that this is handled in a "deep" fashion; that is, if its members are also arrays, then print the contents of the members of that array member (and so on). When done, uncomment the last test case below. IMP unknown 26-9f34c6f6 26 src/test/java/com/jcabi/log/SecretDecorTest.java 67-69 30 unknown unknown@0pdd.com The SecretDecor class is not implemented yet, that's why the test is not enabled at the moment. You should uncomment the lines below and make sure the test passes. IMP unknown 26-9c2568b0 26 src/test/java/com/jcabi/log/SizeDecorTest.java 66-68 30 unknown unknown@0pdd.com The SizeDecor class is not implemented yet, that's why the test is not enabled at the moment. You should uncomment the lines below and make sure the test passes. IMP 98 18-de8643f2 18 src/test/java/com/jcabi/log/VerboseProcessTest.java 52-55 30 unknown unknown@0pdd.com Locale/encoding problem in two test methods here. I'm not sure how to fix them, but they should be fixed. They fail on some machines, while run perfectly on others. They also fail when being executed from IntelliJ. IMP unknown 38-9367cb1e 38 src/main/java/com/jcabi/log/VerboseProcess.java 179-183 30 unknown unknown@0pdd.com When VerboseProcess is closed, we should also shut down the monitor threads and prevent them trying to obtain the output from the process. It should be done before destroy() is called. See the following for more details: https://github.com/jcabi/jcabi-log/issues/38 http://www.java2s.com/Code/Java/Threads/Thesafewaytostopathread.htm IMP 63 54-5ce25827 54 src/test/java/com/jcabi/log/MulticolorLayoutTest.java 44-56 30 Create an integration test for testing if MulticolorLayout will disable text coloring when an application is run with `-Dcom.jcabi.log.coloring=false`. ... Intergration testing is required because this can't be done in a unit test: ... - We can't just pass a parameter to `MulticolorLayout` that determines if the layout should color its output, because Log4J requires EnhancedPatternLayout to have a 0-arguments constructor. - We can't disable coloring with something like `MulticolorLayout#setColoring(boolean)`, too, (that would be unit-testable) because Log4J won't know how to call that. - `System.getProperty(String)` is not mockable for obvious reasons. IMP Suseika wlasowegor@gmail.com unknown 63-fcb6d07a 63 src/test/java/com/jcabi/log/MulticolorLayoutTest.java 44-51 30 Fix bug in method format(LoggingEvent). The tests disablesOverridenConstantColor() and disablesConstantColor() from /src/it/it-decoloring/.../MulticolorLayoutITCase are currently failing and are ignored. Problem is that the text isn't decolored correctly when the color is specified in the conversion pattern. E.g. "[%color-blue{%p}] %color-blue{%m}" . IMP Mihai Andronache amihaiemil@gmail.com unknown 59-498fab78 59 src/main/java/com/jcabi/log/MulticolorLayout.java 84-85 30 This class is still handling multiple responsibilities like formatting, parsing and coloring and should be refactored. IMP Igor Piddubnyi igor.piddubnyi@solvians.com 101 100 30 IMP 100-e041f047 43-45 Some tests here are ignored since they conflict in multi-threading run. I don't know exactly how to fix them, but we need to fix and remove the "Ignore" annotations. src/test/java/com/jcabi/log/SupplierLoggerTest.java Yegor Bugayenko yegor256@gmail.com