34730DEV7-c333ea8315-17
Let's introduce real fake objects which could be helpful for testing in the future. For example, a class which would contain a loop inside for easier Iterator checks.
tests/src/SavingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru443420DEV34-3e386aad30-31
Long test methods should be rewritten in one line, redundant variables should be removed.
tests/src/TransparentIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru514420DEV44-d8e690f310-12
Classes Let and The do not have proper type hints in constructor and methods. Workarounds with `@var` tags must be removed after that.
fakes/The.phpMax Goryunovmaximthehedgehog@yandex.ru645130DEV51-659aec3520-25
It seems that The and Let new typehints have a negative effect on PHPStan in a way that when type coming to The or Let is not typehinted as plain `mixed` or `Closure` PHPStan starts complaining about types for `TransparentIterator` for example. It should probably be solved by prefixing tags for PHPStan with `phpstan`. It also causes IDE to complain about incorrect types(X or T or Y instead of some expected type).
tests/src/SavingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru524425DEV44-cdf3921710-11
Classes Let and The contain some repeated cdde which could be extracted into a separate class.
fakes/Let.phpMax Goryunovmaximthehedgehog@yandex.ru685220DEV52-3176158a12-13
Create test file for this class and maybe change tests for `Let` and `The`.
fakes/SurveyEnvelope.phpMaxGoryunov40582951+MaxGoryunov@users.noreply.github.com695215DEV52-c17a26513-3
add codecov strict analysis for 100% coverage.
codecov.ymlMaxGoryunov40582951+MaxGoryunov@users.noreply.github.com35710DEV7-4477297e10-11
Add fakes directory back to infection.json.dist after fakes folder will be created
src/Indifferent.phpMax Goryunovmaximthehedgehog@yandex.ru36710DEV7-3e566c001-2
add fakes folder back for PHPStan checks when it will be created.
phpstan.neonMax Goryunovmaximthehedgehog@yandex.ru40830DEV8-efc308e619-20
It is needed to test that `SavingIterator` works correctly with an empty Iterator.
tests/src/SavingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru484040DEV40-d3a6e32610-12
There is some code duplication for adding current iterator value to $saved array. It would be better to extract the code into a separate class.
src/SavingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru554530DEV45-d697e05827-28
The minimum required MSI percentage should be 80%, but actual is 70%.
.github/workflows/php.ymlMax Goryunovmaximthehedgehog@yandex.ru564515DEV45-a0c402e010-12
Class MaxGoryunov\SavingIterator\Src\TimesCalled implements generic interface MaxGoryunov\SavingIterator\Src\Scalar but does not specify its types: T
src/TimesCalled.phpMax Goryunovmaximthehedgehog@yandex.ru826640DEV66-f5ef058e53-54
Add a fake class for putting the values into Adding Iterator from source.
tests/src/ArrayAddingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru836630DEV66-c5b6b0859-9
Add implementation for this interface.
src/AddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1188315DEV83-3bfdfca854-54
Replace algorithm with a fake class.
tests/src/OpenAddingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru1198320DEV83-53972e1c40-41
Cover that Iterator works with an immutable iterator.
src/OpenAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1208320DEV83-b8f6701a44-44
Assert that iterator does not add values if they are already stored.
src/OpenAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1218320DEV83-9115b04d89-89
Assert that iterator rewinds original iterator.
src/OpenAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1228320DEV83-8a90ae8d38-40
Current approach mutates existing object. If it is not reassigned but instead passed to some method variable which holds a reference to this object with be in an invalid state.
src/ArrayAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru846620DEV66-0f62b41f38-39
Add a decorator for AddingIterator which does not allow to add values if source is not valid.
src/ArrayAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru856625DEV66-991314f250-51
Codebeat complains about similar code in two methods. It should be refactored.
src/SavingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru948540DEV85-d49ed4bf52-53
There is a private function in this class. It should be removed without creating the code duplication problem again.
src/SavingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1279430DEV94-e20f17d230-31
Add a way to provide context which does not do anything.
tests/src/ContextVeilTest.phpMax Goryunovmaximthehedgehog@yandex.ru14712760DEV127-705509277-7
Change ContextVeil to accept a Reaction.
src/Reaction.phpMax Goryunovmaximthehedgehog@yandex.ru1289430DEV94-be7f430258-59
Add a way to provide one several contexts for different methods.
tests/src/ContextVeilTest.phpMax Goryunovmaximthehedgehog@yandex.ru1009520DEV95-4bec69c89-9
Tests do not cover cases when context is called on subject.
fakes/The.phpMax Goryunovmaximthehedgehog@yandex.ru1019515DEV95-cfe7147928-29
Increase the required min MSI and min covered MSI to at least 90 percent.
.github/workflows/php.ymlMax Goryunovmaximthehedgehog@yandex.ru1029515DEV95-3433bd4686-86
Reset behaviour for array is not covered.
src/ArrayAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru1039515DEV95-21b8f58474-75
Reset functionality for encapsulated iterator is not covered.
src/TransparentIterator.phpMax Goryunovmaximthehedgehog@yandex.ru10910340DEV103-8defb5a068-70
Add a fake class or try to write a matcher for testing iterator rewinds. It often seems to be the method about which Infection complains.
tests/src/TransparentIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru12910930DEV109-071d960d9-10
Add Rewinding repetition or repetition which converts iterator to array for rewind tests and use it in iterator tests.
fakes/RepetitionEnvelope.phpMax Goryunovmaximthehedgehog@yandex.ru14812930DEV129-e00ee433176-177
Remove usage of The, Let and redundant variables where RpIteratorToArray was introduced.
tests/src/SavingIteratorTest.phpMax Goryunovmaximthehedgehog@yandex.ru1239230DEV92-0dcb141b9-10
Remove extension of SurveyEnvelope because it is not needed anymore.
fakes/The.phpMax Goryunovmaximthehedgehog@yandex.ru1249230DEV92-491600809-10
Remove extension of SurveyEnvelope from this class because it is not needed.
fakes/Let.phpMax Goryunovmaximthehedgehog@yandex.ru14612490DEV124-62b2aa839-10
Move common functionality from Let and The to the parent class.
fakes/Let.phpMax Goryunovmaximthehedgehog@yandex.ru17917745DEV177-9672656d40-43
Check for valid source is repeated in several classes: here, in SavingIterator and in IteratorTransfer. It would be better to move this common checking functionality to a separate small class and use it instead.
src/ValidAddingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru18017715DEV177-6ad5429b40-42
SavingIterator has most of its behavior in the encapsulated ContextVeil. It would be better remove all other methods and instead inherit from TransparentIterator.
src/SavingIterator.phpMax Goryunovmaximthehedgehog@yandex.ru20219660DEV196-8eb9bde232-35
There are phpstan issues with ClosureReaction here and in ContextVeilTest. Now they are fixed by ignore-line stubs but need to be fixed according to phpstan ruleset.
src/SavingIterator.php@MaxGoryunov40582951+MaxGoryunov@users.noreply.github.com20319515DEV195-9abebe3210-12
README has to mention that now it is not required to create ArrayAddingIterator and pass it into the constructor because now it is a default option.
src/SavingIterator.php@MaxGoryunov40582951+MaxGoryunov@users.noreply.github.com20419415DEV194-308aaf5636-38
README has to show that it is now possible to directly pass Generator Closures into constructor without having to manually call them.
src/SavingIterator.php@MaxGoryunov40582951+MaxGoryunov@users.noreply.github.com