11234-91a7c8a034s3auth-hosts/src/main/java/com/s3auth/hosts/SyslogHosts.java46-5830DEVunknownunknown@0pdd.com
SyslogHosts should add syslog capabilities to the operations of its underlying Hosts instance. The way that I imagine that this will be done is that {@link SyslogHosts#find(String)}) should create instances of Host, in turn {@link Host#fetch(java.net.URI, Range)} will create instances of {@link Resource} that sends messages to the syslog host when {@link Resource#writeTo(java.io.OutputStream)} is invoked. I'm making a few assumptions about what remains to be done here, namely: 1) The Host and Resource decorator objects will probably be inner classes within Hosts or find, or even anonymous inner classes - whatever seems best, and 2) the underlying Hosts' close() and domains() operations will be unchanged, and thus I made simple implementations that directly delegate to the underlying instance. Go ahead and change any of the above if the initial design considerations are incorrect.
unknown112-4379cc4c112s3auth-rest/src/main/webapp/xsl/index.xsl117-12030DEVunknownunknown@0pdd.com
SyslogHosts has been implemented, but the syslog field is still not visible to the user. Let's make it visible. Let's also update Domain.Validator to ensure that the user input is correct.
35133-9ff485f733s3auth-relay/src/test/java/com/s3auth/relay/MainTest.java51-5230DEVunknownunknown@0pdd.com
Test doesn't work since AWS Dynamo config is not available in runtime. We should find a way to mock it properly.
unknown48-1047c13d48s3auth-hosts/src/test/java/com/s3auth/hosts/DefaultDynamoTest.java59-6130DEVunknownunknown@0pdd.com
This test doesn't work because @Cacheable doesn't allow cache flushing. Should be implemented in JCABI: https://github.com/yegor256/jcabi/issues/163
901-f2c33b381s3auth-hosts/src/main/java/com/s3auth/hosts/DefaultDynamo.java64-6430DEVunknownunknown@0pdd.com
Would be nice to migrate to jcabi-dynamo
35290-43f9c54990s3auth-hosts/src/test/java/com/s3auth/hosts/DefaultDynamoTest.java61-6430
This test creates a mock region with a H2Data backend which has table columns with characters unsupported by the h2 database. Issue #7 in jcabi-dynamo should fix this. Don't forget to remove the @Ignore annotation from this test.
IMPpinaffelipe.pina@gmail.comunknown61-70b549cd61s3auth-relay/src/main/java/com/s3auth/relay/HttpThread.java190-19430DEVunknownunknown@0pdd.com
We should be able to fetch the list of versions of a given resource. The request should contain the query "all-versions". That is, for example, requesting "http://maven.s3auth.com/index.html?all-versions" should return the list of all versions of the requested object.
unknown133-d8e15b67133s3auth-hosts/src/test/java/com/s3auth/hosts/DirectoryListingTest.java97-10030DEVunknownunknown@0pdd.com
Better to use XPath for this. However, I wasn't able to get it to work because of XHTML namespace issues. Let's fix it. Let's also address the same issue with hasCommonPrefix below and {@link DefaultHostTest#showsDirectoryListing()}.
unknown101-1cb64a78101s3auth-relay/src/main/java/com/s3auth/relay/HttpThread.java118-12130DEVunknownunknown@0pdd.com
Let's handle GZIP HTTP compression. We should parse the request's Accept-Encoding and Content-Type headers, and use GZIP compression if appropriate. If we are returning compressed input, we should wrap the resource in a GzipResource instance.
185173-8d71c922173s3auth-hosts/src/main/java/com/s3auth/hosts/DefaultResource.java57-6430DEVunknownunknown@0pdd.com
Due to the large cost of having very many small CloudWatch requests, we changed the implementation of DefaultResource so that it now retains information to a local H2 database instead of directly making CloudWatch API requests. However, we still don't have a way to post it to CloudWatch. Let's create a way to do this, such as a cron job that runs every hour. It should post aggregated traffic metrics to Amazon CloudWatch per domain, and also perform cleanup of old data after it manages to post the information.
unknown185-1d178b38185s3auth-hosts/pom.xml102-10830unknownunknown@0pdd.com
jcabi-manifests version here should be managed by the parent. Version 1.0.2 fixes some multithreading bugs that causes the build to fail. The reason why we're specifying it here is because the parent is still referencing the buggy version. Let's remove the version here when the parent has been updated. Let's also update the pom.xml files in s3auth-relay and s3auth-rest folders.
IMPunknown173-e3a77fb4173s3auth-hosts/src/main/java/com/s3auth/hosts/DefaultHost.java352-35530DEVunknownunknown@0pdd.com
We should be caching the results of this method for a short period somehow, or at least prevent unnecessary repeated requests to Amazon CloudWatch API. This is so that we can improve performance and reduce access costs.
1918-5eb4ae338s3auth-relay/src/test/java/com/s3auth/relay/HttpFacadeTest.java515-51830unknownunknown@0pdd.com
For some reason this test is not passing in Travis and Rultor, even with the jcabi-ssl-maven-plugin. It does work on my local machine. It fails with javax.net.ssl.SSLHandshakeException with message: Received fatal alert: handshake_failure. Let's investigate and fix.
IMP353191-7e266bd1191s3auth-relay/src/test/java/com/s3auth/relay/HttpFacadeTest.java523-52630
The test fails to retrieve the expected content over SSL. The response body is empty while it should be "secured". Test fails on line 570. Let's fix it and unignore the test.
IMPArtem Nakonechnywentwog@gmail.comunknown198-0764d06e198s3auth-relay/src/main/java/com/s3auth/relay/HttpException.java86-8730unknownunknown@0pdd.com
1) Don't lose cause stacktrace 2) cause.getMessage can be null, so it can produce ConstraintViolationException instead of HttpException
IMP354200-e1abb509200s3auth-rest/src/test/casperjs/RendersHomePage.js33-3330unknownunknown@0pdd.com
Migrate old tests from rexsl/scripts to casperjs
IMP355213-2f9b789a213s3auth-relay/src/main/java/com/s3auth/relay/FtpFacade.java65-6630
Implement TLS secure port listening in a manner analogous to HttpFacade.
IMPpinaffelipe.pina@gmail.com356213-d22cf12f213s3auth-relay/src/main/java/com/s3auth/relay/FtpResponse.java55-5730
Implement methods 'withCode', 'withText', 'send' as above. Also, implement 'asString' and unignore test 'constructsCorrectly' in FtpResponseTest.
IMPpinaffelipe.pina@gmail.com357213-5796b8fa213s3auth-relay/src/main/java/com/s3auth/relay/FtpThread.java52-5330
Implement authentication based on the USER and PASS commands.
IMPpinaffelipe.pina@gmail.com358213-6939d515213s3auth-relay/src/main/java/com/s3auth/relay/FtpThread.java54-5730
Implement relay functionality to fetch resource upon receival of the RETR command with valid authorization. Return an error in case of other commands (unsupported for now). Remove unnecessary asserts ffor fields 'sockets' and 'hosts' in method 'dispatch'.
IMPpinaffelipe.pina@gmail.com359213-721856fe213s3auth-relay/src/main/java/com/s3auth/relay/HttpFacade.java66-6960
Create new a class Facade with all protocol-neutral code (such as socket handling, socket queue, etc). Then convert {@link com .s3auth.relay.HttpFacade} and {@link com.s3auth.relay.FtpFacade} so they use the new Facade class in order to avoid code duplication.
IMPpinaffelipe.pina@gmail.com360213-af390358213s3auth-relay/src/main/java/com/s3auth/relay/Main.java67-6830
Create a FtpFacade in order to provide a FTP gateway. Also unignore test 'connectDisconnect' in FtpFacadeTest.
IMPpinaffelipe.pina@gmail.com37131730DEV317-34dbec3632-34
Need to fix other build errors in order to upgrade to jcabi-parent v0.49.3. There is an error due to the use of deprecated APIs, errors due to classpath issues during test runtime, and others.
pom.xmlGeorge Aristygeorge.aristy@gmail.com56521330DEV213-ec25c60e25-28
Implement relay functionality to fetch resource upon receival of the RETR command with valid authorization. Return an error in case of other commands (unsupported for now). Remove unnecessary asserts for fields 'sockets' and 'hosts' in method 'dispatch'.
s3auth-relay/src/main/java/com/s3auth/relay/FtpThread.java@yegor256yegor256@gmail.com