unknown1-b51515581netbout-web/src/main/java/com/netbout/dynamo/DyInbox.java134-14030
DynamoDBLocal doesn't work with all attributes in global index. If we remove this check for a local version, most tests fail. I'm not sure how to fix that. I suspect, it's a bug in DynamoDBLocal, but I don't even know how to report it to them :( Anyway, let's try to investigate and either fix property or introduce a better workaround. Pay attention that this code works correctly in production.
IMPYegor Bugayenkoyegor@tpc2.comunknown610-76d661ee610netbout-web/src/test/java/com/netbout/rest/bout/TkStartTest.java54-5730
Test case for negative scenario of TkStart should be added, e.g. when a friend is not found, the error should be reported correctly and bout creation should be discarded.
IMPIvan Inozemtsevivan.inozemtsev@gmail.comunknown609-bc8eaf9f609netbout-web/src/test/java/com/netbout/rest/TkAppTest.java99-10230
We need to be able to send anonymous requests from tests to verify correct TkApp behavior for anonymous users. But now all requests from tests are authorized because of PsFake(TkAppAuth.TESTING) in TkAppAuth.
IMPIvan Inozemtsevivan.inozemtsev@gmail.com682547-299902f6547netbout-web/src/main/java/com/netbout/email/EmMessages.java96-9730
Send email if friend subscribed to bout. Friend should be filtered before send email by subscription
DEVerim erturkerimerturk@gmail.comunknown682-753e25af682netbout-client/src/main/java/com/netbout/client/RtBout.java155-15730
Implement getting subscription by alias. Should return subscription status for current boat, passing friend alias value using REST call.
DEVEugene Kondrasheveugene.kondrashev@gmail.comunknown682-2583dc75682netbout-client/src/main/java/com/netbout/client/RtBout.java155-15730
Implement getting subscription by alias. Should return subscription status for current boat, passing friend alias value using REST service call.
DEVEugene Kondrasheveugene.kondrashev@gmail.com692600-f8c0ce2e600netbout-web/src/main/java/com/netbout/email/EmCatch.java188-19430
Create bout message using using msg values. Msg recipient value will hold boutId info. Msg from value will hold bout message creator info. Msg content will hold bout message content info. This method should get bout info from email and save it as bout message. And then change method signature like void run(Bout bout, String email, String body);
DEVerim erturkerimerturk@gmail.comunknown692-1caba32d692netbout-web/src/main/java/com/netbout/email/EmMessages.java137-14130
Header `Reply-To` should be added to an outgoing email. Format is crypt-string@reply.netbout.com where crypt-string is user-urn|bout-number Use EmCatch.encrypt() to encrypt the string see #692 and EmActionTest for additional info
DEVDmitry Zaytsevdmitry.zaytsev@gmail.comunknown603-0cf011c2603netbout-web/src/main/java/com/netbout/dynamo/DyInbox.java62-6530
Refactor DyInbox class to avoid suppressing of PMD.TooManyMethods and PMD.ExcessiveImports warnings. for example there are some private static methods there, those could be easily extracted.
IMPIvan Inozemtsevivan.inozemtsev@gmail.comunknown603-5d374ee5603netbout-web/src/main/java/com/netbout/dynamo/DyMessages.java68-7130
Refactor DyMessages class to avoid suppressing of PMD.TooManyMethods and PMD.ExcessiveImports warnings. for example there are some private static methods there, those could be easily extracted.
IMPIvan Inozemtsevivan.inozemtsev@gmail.com704603-303ccd32603netbout-web/src/main/java/com/netbout/rest/TkInbox.java50-5230
Index page should also display search box so that user can search for bouts containing text. See Inbox#search method for details.
IMPIvan Inozemtsevivan.inozemtsev@gmail.comunknown704-c6ad2d19704netbout-web/src/test/java/com/netbout/rest/TkInboxTest.java46-4830
Test case for search bouts of TkInbox should be added, e.g. response should have filtered bouts by search term
IMPerimerturkerimerturk@gmail.comunknown603-275d519b603netbout-web/src/main/java/com/netbout/rest/bout/TkIndex.java53-5530
Bout page should also display search box so that user can search for text in messages. See Messages#search method for details.
IMPIvan Inozemtsevivan.inozemtsev@gmail.comunknown685-6534dff2685netbout-web/src/main/java/com/netbout/rest/TkAppAuth.java92-10130
Need to implement PsBasic.Entry. PsFake usage should be changed to PsBasic( Manifests.read("Netbout-Basic-Realm"), new PsBasic.Default( Manifests.read("Netbout-Basic-User"), Manifests.read("Netbout-Basic-Pwd"))) But PsBasic.Default like class is currently missing. See takes #349. It is also needed to be able to switch on/off BasicAuth e.g. by via change the manifest entry "Netbout-Basic":true/false.
DEVEugene Kondrasheveugene.kondrashev@gmail.comunknown606-457eb15d606netbout-web/src/main/xsl/bout.xsl45-4530
The line below should be changed to avoid linking
IMPMatteo Barbieribarbieri.matteo@gmail.comunknown643-0c6bbfa8643netbout-web/src/main/js/bout.js141-14430
System should highlights a message when accessing it through message's permalink. This must be implemented on a different method and must be called over here and on the `else` statement of the same `if else` block.
DEVEndrigo Antoninieantonini@eidoscode.com751602-3825bd3b602netbout-web/src/main/java/com/netbout/rest/bout/TkInvite.java119-12430
Invited user should receive an email message with a text like this 'You are invited into the Netbout click on the link to register' and the link should be `http://www.netbout.com/b/
?invite= ` where `invite-key` is the encrypted urn. We can use `CcAES` from Takes project.
DEVEndrigo Antoninieantonini@eidoscode.comunknown751-6f10d03b751netbout-web/src/main/java/com/netbout/rest/login/TkRegister.java67-7130
During the user registraton if the invite-key` param presented in the original ticket (destination url) it should decrypt that value and use it to search for alias. using that alias, you must update urn and alias to use the alias that was choosen by the user.
DMesut Özenmesut.ozen@n11.comunknown602-8a4d4ea4602netbout-web/src/main/java/com/netbout/rest/login/TkRegister.java62-6630
During the user registration if the `invite-key` param presented in the original ticket (destination url) it should decrypt that value and use it to search for alias. Using that alias, you must update urn and alias to use the alias that was choosen by the user.
DEVEndrigo Antoninieantonini@eidoscode.comunknown703-ca5668ad703netbout-web/pom.xml58-5830
Current version of Takes doesn't support
IMPEndrigo Antoninieantonini@eidoscode.comunknown806-1e507f57806netbout-client/src/main/java/com/netbout/mock/MkAttachments.java86-8830
This method needs to be implemented because it is used in tests that read bout properties. Currently, this implementation always returns 0.
DEVbdraganbozanovicdr@gmail.comunknown806-43ee63d7806netbout-client/src/main/java/com/netbout/mock/MkBout.java104-10630
This method needs to be implemented because it is used in tests that read bout properties. Currently, this implementation always returns the current date.
DEVbdraganbozanovicdr@gmail.comunknown738-4d284963738netbout-web/src/main/java/com/netbout/email/EmAlias.java130-13430
We need to improve the format and content of the verification email. Currently, it only asks the user to verify the new email by using the provided verification link. We may add some header, footer, note like "Ignore this email if you did not change your email address", etc.
IMPbdraganbozanovicdr@gmail.com842738-d76bd177738netbout-web/src/main/java/com/netbout/rest/account/TkSaveEmail.java53-5530
If the email attribute value contains !, we should display an exclamation icon with hint that the email is not verified yet near the alias name.
IMPbdraganbozanovicdr@gmail.comunknown842-9eb73ef4842netbout-web/src/main/java/com/netbout/rest/XeAlias.java95-9730
Write test for the logic of generating Xembly for {@link Alias} class. It should focus on checking whether tags "email" and "newEmail" are properly populated based on input.
Dmkordaskordas.michal@gmail.com867847-f2a7caae847netbout-web/src/main/java/com/netbout/rest/Markdown.java38-4030
MarkdownTxtmark not implemented but has to be. This class should be implementation of Markdown using TxtMark. See https://github.com/rjeschke/txtmark. Don't forget about unit tests.
DEVDmitry Zaytsevdmzaytsev@users.noreply.github.com873867-4e7e6e8f867netbout-web/src/test/java/com/netbout/rest/MarkdownTxtmarkTest.java42-4630
MarkdownTxtmark not implemented but has to be. See #847 for details. This class should be implementation of Markdown using TxtMark. See https://github.com/rjeschke/txtmark. After that don't forget remove Ignore annotation from unit tests.
DEVDmitry Zaytsevdmitry.zaytsev@gmail.comunknown873-bdf7b68b873netbout-web/src/main/java/com/netbout/rest/MarkdownTxtmark.java62-6430
We need more tests for the case, when text contains several links. Both plain links and markdown preformatted links need to be checked.
DEVDmitry Zaytsevdmitry.zaytsev@gmail.com888873-3b1d8aa3873netbout-web/src/test/java/com/netbout/rest/MarkdownTxtmarkTest.java200-20430
MarkdownTxtmark doesn't break a line on a new line symbol. It should put br code or make a new paragraph on each new line in the input data. I didn't find that option in TxtMark's settings, but perhaps I missed something. If the option won't be found we can replace single eol symbol to double eol as workaround.
DEVDmitry Zaytsevdmzaytsev@users.noreply.github.comunknown888-3f71fb04888netbout-web/src/main/java/com/netbout/rest/Markdown.java59-6130
We should switch to another Markdown processor MarkdownTxtMark and remove the old implementation MarkdownPegdown and its unit tests from the code.
IMPDmitry Zaytsevdmzaytsev@users.noreply.github.com1150750-23d45618750netbout-web/src/main/java/com/netbout/rest/TkStart.java57-5930
Solve the puzzle for build mysteriously failing for this task citing a NullPointerException (See qulice issue #608 raised for the same) and then remove TkStart.java from qulice exceptions.
IMPPrahlad Yeriprahladyeri@yahoo.com954750-65232fbb750netbout-web/src/main/java/com/netbout/rest/TkStart.java60-6130
Add unit tests to test scenarios for requests with/without a token.
IMPPrahlad Yeriprahladyeri@yahoo.comunknown954-b453159b954netbout-web/src/test/java/com/netbout/rest/bout/TkStartTest.java63-6530
TkStart should not create new bout when same token is specified. When this is fixed, remove @Ignore from handlesTokens test
IMPclarence hoclarenceho@gmail.comunknown947-64235763947netbout-web/src/main/java/com/netbout/rest/account/TkSaveEmail.java53-5530
TkSaveEmail shouldn't validate a email when running locally. One idea how to know Netbout running locally or not is checking Version attribute from MANIFEST for substring LOCAL
IMPDmitry Zaytsevdmzaytsev@users.noreply.github.comunknown911-a1464331911netbout-client/pom.xml184-18930
Fix findbugs errors in client Some issues may not require fixing an should be excluded. Filters in qulice 0.12 are broken, right excludes should be more granular. I think it should be resolved when #961 completed due to broken Findbugs filters in current version of Qulice
IMPexper0aeg.exper0@gmail.comunknown911-20c870d4911netbout-spi/pom.xml94-10030
Fix findbugs errors in SPI classes Friends and Attachemtns Some issues may not require fixing and should be excluded. filters in qulice 0.12 are broken, right excludes should be more granular. I think it should be resolved when #961 completed due to broken Findbugs filters in current version of Qulice
IMPexper0aeg.exper0@gmail.comunknown911-1ad8e6c0911netbout-web/pom.xml730-73530
Fix findbugs errors in web Some issues may not require fixing an should be excluded. Filters in qulice 0.12 are broken, right excludes should be more granular. I think it should be resolved when #961 completed due to broken Findbugs filters in current version of Qulice
IMPexper0aeg.exper0@gmail.comunknown914-ecab4401914netbout-web/pom.xml330-33930
investigate error messages of the following command and change package.json accordingly. The error messages are: [ERROR] npm WARN package.json netbout-web@ No description [ERROR] npm WARN package.json netbout-web@ No repository field. [ERROR] npm WARN package.json netbout-web@ No README data [ERROR] npm WARN package.json netbout-web@ license should be a valid SPDX license expression -->
IMPLeoleo@yogaimurlaub.de1012961-58fc8a23961netbout-web/pom.xml747-75230
These excludes were added during upgrade to qulice 0.15.2. New version of qulice adds new violations that need to be fixed. There are also excludes added to netbout-client/pom.xml (lines 192 - 207) related to this puzzle. They also need to be fixed in order to solve this puzzle.
IMPDan Baleanudan.baleanu@gmail.com11511012-2dfa2c651012netbout-client/src/test/java/com/netbout/client/NbRule.java42-4530
No public static methods are allowed. This class should be refactored to not contain any of them. The method get() should either be an instance method with refrence to this (to avoid checkstyle NonStaticMethodCheck) or a static but not public.
IMPDan Baleanudan.baleanu@gmail.comunknown1012-7ae4ec061012netbout-web/pom.xml754-75730
These excludes were added because of the upgrade to qulice 0.16.2. The new version of qulice adds some javadocs rules and also regexp rules for imported some wrong classes which should be replaced with others.
IMPDan Baleanudan.baleanu@gmail.comunknown1012-68768ab81012netbout-web/src/main/java/com/netbout/misc/Ports.java42-4430
This class should not be left as utility one. All methods became static because of checkstyle NonStaticMethodCheck introduced after qulice upgrade to 0.15.2 and the contructor became private.
IMPDan Baleanudan.baleanu@gmail.comunknown1013-d9e5eb871013netbout-client/pom.xml193-19730
Fix findbugs errors in mock. There are issues with classes that use jcabi-aspects annotations and they are causing the false violation positives. This will be resolved when issue teamed/qulice#706 is closed.
IMPkujtimiihoxhakujtimii.h@gmail.com11521025-adc690761025netbout-web/pom.xml544-54730
This integration test doesn't work on Mac OSX at all. I tried to run it a few times and every time all tests fail with some sort "timeout" problem. I'm not sure what it is. Let's try to fix and enable it again.
IMPYegor Bugayenkoyegor@tpc2.com1090839-90f22678839netbout-web/src/main/java/com/netbout/dynamo/DyAttachment.java166-17230
An attribute for the creation time must be added to the attachment item in the remote db. Until then, this method crashes. Once it is done, this must be developed: - Remove @Ignore from DyAttachmentITCase.obtainsCreationDate(). - Add directive for date in XeAttachment.make(). - Properly implement RtAttachment.date() to retrieve date from request. - Remove @Ignore from RtAttachmentsITCase.obtainsCreationDate().
IMPCarlos Ginésefrel@MacBook-Pro-de-Efrel.local11531090-b1fba4c11090netbout-client/src/main/java/com/netbout/client/RtAttachment.java53-5530
There is code duplication in public methods in this class: ctype(), etag(), unseen(), date(), author(), read() and write(). Please refactor to avoid it.
IMPCarlos Ginésefrel@MacBook-Pro-de-Efrel.local11541090-d49470f51090netbout-web/src/main/java/com/netbout/dynamo/DyAttachments.java52-5430
No public static literals are recommended according to our methodology. This class should be refactored to not contain any of them. See: http://www.yegor256.com/2015/07/06/public-static-literals.html
IMPCarlos Ginésefrel@MacBook-Pro-de-Efrel.local11551094-571b0dd71094netbout-web/src/main/java/com/netbout/dynamo/DyMessages.java197-20230
HttpException seems not really appropriate here in database layer. I think we have to throw something like BoutNotFoundException and process its somewhere in web layer. Pay attention that we should also change a test DyMessagesITCase.exceptionIfBoutNotFound() which tests a presence of HttpException.
IMP2686747m.vakhnik.dev@gmail.com11561103-520ca7fd1103netbout-web/src/main/java/com/netbout/dynamo/DyAttachment.java168-17130
please create a proper integration test for both cases when attribute DyAttachments.ATTR_DATE exists before getting, when attribute DyAttachments.ATTR_DATE not exists.
DEVDmitry Zaytsevdmzaytsev@users.noreply.github.com