3130DEV1-94e5101439-44
The implementation of method stream() is less than effective, because it reads the entire content of the response, turning it into text and then splitting. What if the content is binary and can't be converted to string? What if the content is super big and must be presented as an stream, not a piece of text. Let's fix it.
src/main/java/org/cactoos/http/HtBody.javaYegor Bugayenkoyegor256@gmail.com37330DEV3-25734ac490-95
this internal class should be transformed to a full fledged public class with a clear interface, either in the cactoos or the cactoos-http project and the implementation is not efficient in memory usage because of the boxing of bytes into an object. This should be replaced by a real circular byte buffer implementation with primitive bytes.
src/main/java/org/cactoos/http/io/SkipInput.javaVictor Noëlvictor.noel@crazydwarves.org4130DEV1-97d18cdb39-43
The implementation of method stream() is rather ineffective and defective. What if the content of the HTTP response is too big? Or is binary and can't be represented as a string? Instead of turning it into a string we must deal with a stream of bytes.
src/main/java/org/cactoos/http/HtHead.javaYegor Bugayenkoyegor256@gmail.com5130DEV1-6a67a5c837-40
The implementation here is not effective. It converts the entire head part of the request to a string and then only takes the first line out of it. We should deal with a stream instead and just read its first line.
src/test/java/org/cactoos/http/HtStatus.javaYegor Bugayenkoyegor256@gmail.com38130DEV1-06a076ae44-48
This test does not cover all possible cases. https://codecov.io/gh/yegor256/cactoos-http/pull/24/diff?src=pr&el=tree #diff-c3JjL21haW4vamF2YS9vcmcvY2FjdG9vcy9odHRwL0h0U3RhdHVzLmphdmE= Finish covering all branches missed for this implementation. A refactor may be due as well.
src/test/java/org/cactoos/http/HtHeadTest.javarultorme@rultor.com45830DEV8-0309755b42-45
The implementation of method stream() can handle only one Set-Cookie in a response. Fix HtHeaders so that a single key may be mapped to one or more values (it is legal to receive more than one Set-Cookie in a response).
src/main/java/org/cactoos/http/HtCookies.javarultorme@rultor.com46830DEV8-4e75a12646-48
The implementation of method stream() will break on "flag-type" directives (`Secure`, `HttpOnly`). Fix HtHeaders so that these directives are handled correctly.
src/main/java/org/cactoos/http/HtCookies.javarultorme@rultor.com594930DEV49-d03f4828165-166
we should re-enable findbugs and fix all problems it detects. This mainly concerns for now reliance on default encoding in HtStatus.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org612330DEV23-e7afac4232-45
min As discovered in #53, the upgrade is not a job of the wire because it need reading the contents of the response (in this case, status code). So, this feature would be under the responsibility of a response-like object. It must be implemented someway like this: new HtUpgradedResponse( new IterableOf<>( new MapEntry<Func<String, Boolean>, Func<URI, Wire>>( upgrade -> upgrade.contains("TLS"), HtSecureWire::new ) ) ) The test HtUpgradeWireTest#testHtUpgrade must be removed after the implementation of this class.
src/main/java/org/cactoos/http/HtUpgradeWire.javarultorme@rultor.com636230DEV62-ec9a5ea746-49
HtWire should not close the socket opened to the remote service (this includes not closing associated input and output streams). It should instead return an `Input` with the socket's inputstream "unread". Refactor accordingly.
src/main/java/org/cactoos/http/HtWire.javaGeorge Aristygeorge.aristy@gmail.com786330DEV63-d518e687103-106
HtWire should not close the socket opened to the remote service (this includes not closing associated input and output streams). It should instead return an `Input` with the socket's inputstream "unread". Refactor accordingly and unignore this test.
src/test/java/org/cactoos/http/HtWireTest.javaVictor Noëlvictor.noel@crazydwarves.org877830DEV78-e9bc29cd79-81
With #78 solved, HtWire stopped closing the connection when send() is called and the following test stopped working for no clear reason. Investigate the cause of this, fix it and unignore this.
src/test/java/org/cactoos/http/HtTimedWireTest.java@rultorme@rultor.com988730DEV87-b84e58fc45-52
Rework the implementation of this class not to rely on the `backlog` behaviour of `ServerSocket` because the assumption made on it can be wrong on some contexts as explained in the `ServerSocket` javadoc and as experienced in https://github.com/yegor256/cactoos-http/pull/93 when the tests are executed by rultor. See this same PR for more details. Unignore the tests in `BlockingSocketServerTest` and `HtTimedWireTest` after.
src/test/java/org/cactoos/http/io/BlockingSocketServer.java@rultorme@rultor.com998730DEV87-6a44baaf98-100
Update cactoos to at least 0.42 and then use the new Binary class to replace the if construction below and have a full OO code here.
src/test/java/org/cactoos/http/io/BlockingSocketServer.java@rultorme@rultor.com646230DEV62-0259301239-42
We need decorators for HtResponse that will automatically close the inputstream (therefore also closing the network socket) based on criteria like the Content-Length header, the Transfer-Encoding header (when service returns the payload in chunks), etc.
src/main/java/org/cactoos/http/HtResponse.javaGeorge Aristygeorge.aristy@gmail.com806430DEV64-afac576d40-45
Introduce abstractions to read from an Input without closing the stream as most of the cactoos abstraction do. As a starter use them in HtAutoClosedResponseTest, HtWireTest and AutoClosedInputStreamTest instead of the ugly while loops or meaningless reads. Use them also to actually test the content of the inputs.
src/test/java/org/cactoos/http/HtAutoClosedResponseTest.javaVictor Noelvictor.noel@crazydwarves.org816430DEV64-63b625df37-40
We need decorators for HtResponse that will automatically transform the inputstream based on criteria like the Content-Length header, the Transfer-Encoding header (when service returns the payload in chunks), etc.
src/main/java/org/cactoos/http/HtResponse.javaVictor Noelvictor.noel@crazydwarves.org742030DEV20-eb4af05958-66
Replace the HtWire by HtKeepAliveWire which should support the <em>Keep-Alive</em> header. It should has at least 1 `ctor` with 3 parameters: - `wire` which represents the HTTP connection; - `timeout` in milliseconds; - `rmax` the max quantity of within the timeout. In case the quantity of requests is greater than rmax but takes less time than `timeout`, the connection should be reset by the server. Remove the suppresing of PMD errors due to unused private fields.
src/main/java/org/cactoos/http/HtKeepAliveResponse.java@rultorme@rultor.com776030DEV60-6fe1be4f79-81
Figure out a more elegant way to compare the ring buffer imitation to another buffer, and avoid the for loop hell that is in the following method.
src/main/java/org/cactoos/http/io/BoundedByteBuffer.javagolyalphagolyalpha@gmail.com