533930IMP39-e7c34bd556-58
Needs cached `LengthOfIterable` version to improve `IterableAsList` performance. Now each call to `size()` goes through all iterable to calculate the size.
src/main/java/org/cactoos/list/IterableAsList.javag4s8g4s8.public@gmail.com50550430IMP504-de6e0b2146-48
This test fails for some reason and I can't understand what's wrong. Seems to be some issue with the Zone we are not detecting in the text.
src/test/java/org/cactoos/time/ZonedDateTimeOfTest.javaYegor Bugayenkoyegor256@gmail.com58548230IMP482-5994e3af33-35
add multi-threaded tests which test that the lock syncs the access to the next method against next and hasNext calls and calls to the hasNext method against next calls.
src/test/java/org/cactoos/iterator/SyncIteratorTest.javaSven Diedrichsensdiedrichsen@yahoo.de63654730DEV547-eacac16989-91
Fix calculation of length for zero buffer I suppose to have an exception in that case For now it runs forever
src/test/java/org/cactoos/io/LengthOfTest.javaYegor Bugayenkoyegor256@gmail.com72063130DEV631-6c33e53a48-50
This class needs more test cases. Currently, only a set of ctors is covered by tests: ctors which use Bytes and byte array as an input. All other ctors should be covered too.
src/main/java/org/cactoos/io/TeeInput.javaRoman Proshinroman@proshin.org79472030DEV720-dcdb33c986-88
When https://github.com/teamed/qulice/issues/877 is fixed upgrade qulice dependency to the one that contains the fix and fix any issues in the project that result from this upgrade.
pom.xmlrultorme@rultor.com72163130DEV631-845093d441-43
Create a new Matcher that will compare results of TeeInput as well as copied content to the original message. Apply this new matcher for this test and for {@link TeeInputFromByteArrayTest}.
src/test/java/org/cactoos/io/TeeInputFromBytesTest.javaRoman Proshinroman@proshin.org79973630DEV736-a59d45fd42-48
Create CheckedBiFunc, CheckedBiProc, CheckedFunc, CheckedProc based on this class (see CheckedBytes for example). Pay attention to a problem with testing these classes: CodeCov doesn't calculate test coverage for these classes properly dur to a problem with throwing exceptions (see https://github.com/jacoco/jacoco/issues/370). So, I would suggest to investigate into this problem at first, find solution for that and then start with implementation of the classes.
src/main/java/org/cactoos/scalar/CheckedScalar.javaRoman Proshinroman@proshin.org80274830DEV748-cb897b6835-40
Introduce IteratorOfFloats, IteratorOfInts, IteratorOfLongs and IteratorOfShorts which will take array of their related primitive types (float, int, long, short) and produce iterator of reference type (Float, Integer, Long, Short). Refactor appropriate IterableOf* classes by using those newly created iterators to avoid unnecessary copying elements to a new array.
src/main/java/org/cactoos/iterable/IterableOfFloats.javaVedranvedran@Vedrans-iMac.local83880230DEV802-6284bb5535-39
Introduce IteratorOfLongs and IteratorOfShorts which will take array of their related primitive types (long, short) and produce iterator of reference type (Long, Short). Refactor appropriate IterableOf* classes by using those newly created iterators to avoid unnecessary copying elements to a new array.
src/main/java/org/cactoos/iterable/IterableOfLongs.javaKrzysztof KrasonKrzysztof.Krason@gmail.com80374830DEV748-7e33dd8135-40
Introduce IteratorOfBooleans, IteratorOfChars, IteratorOfBytes and IteratorOfDoubles which will take array of their related primitive types (boolean, char, byte, double) and produce iterator of reference type (Boolean, Character, Byte, Double). Refactor appropriate IterableOf* classes by using those newly created iterators to avoid unnecessary copying elements to a new array.
src/main/java/org/cactoos/iterable/IterableOfBooleans.javaVedranvedran@Vedrans-iMac.local83980330DEV803-f276f37b35-39
Introduce IteratorOfBytes and IteratorOfDoubles which will take array of their related primitive types (byte, double) and produce iterator of reference type (Byte, Double). Refactor appropriate IterableOf* classes by using those newly created iterators to avoid unnecessary copying elements to a new array.
src/main/java/org/cactoos/iterable/IterableOfBytes.javaKrzysztof KrasonKrzysztof.Krason@gmail.com82175930DEV759-294de7ab38-42
Refactor FuncWithFallback applying a new ScalarWithFallback: change implementation of this class so that it uses ScalarWithFallback as base implementation. Refactored class should allow the user to specify multiple fallbacks for different types of exceptions (similar to ScalarWithFallback).
src/main/java/org/cactoos/func/FuncWithFallback.javaRoman Proshinroman@proshin.org84978830DEV788-d4bcd09238-40
Refactor all classes in text package to extend from TextEnvelope, allowing direct comparison with string objects using hashCode and equals methods.
src/main/java/org/cactoos/text/TextEnvelope.javaPaulo Lobopauloeduardolobo@gmail.com87884930DEV849-f712c12a38-40
Continue refactoring all classes implementing Text to extend TextEnvelope - in most cases asString should be removed and implementation from TextEnvelope should be used.
src/main/java/org/cactoos/text/JoinedText.javarultorme@rultor.com89787830DEV878-f712c12a38-40
Continue refactoring all classes implementing Text to extend TextEnvelope - in most cases asString should be removed and implementation from TextEnvelope should be used.
src/main/java/org/cactoos/text/JoinedText.javarultorme@rultor.com92989730DEV897-9c9a395234-36
Continue refactoring all classes implementing Text to extend TextEnvelope - asString() should be removed and implementation from TextEnvelope should be used.
src/main/java/org/cactoos/text/Base64Text.javarultorme@rultor.com106389730DEV897-f060f15b34-36
All classes implementing Text need to be refactored to extend TextEnvelope - asString() should be removed and implementation from TextEnvelope should be used.
src/main/java/org/cactoos/text/Abbreviated.javaigorceigor94@gmail.com1116106330DEV1063-eb6fd66d39-42
All classes implementing Text need to be refactored to extend TextEnvelope - asString() should be removed and implementation from TextEnvelope should be used. This to-do should be moved to another class which need to be refactored.
src/main/java/org/cactoos/text/FormattedText.java@rultorme@rultor.com1135111630DEV1116-eb6fd66d40-43
All classes implementing Text need to be refactored to extend TextEnvelope - asString() should be removed and implementation from TextEnvelope should be used. This to-do should be moved to another class which need to be refactored.
src/main/java/org/cactoos/text/Randomized.javaVictor Noëlvictor.noel@crazydwarves.org1261111630DEV1116-ec0ce41a53-57
Remove this deprecated class after the issue https://github.com/llorllale/cactoos-matchers/issues/148 has been resolved. The Cactoos-Matchers project(https://github.com/llorllale/cactoos-matchers) utilizes this class and by removing the class right now causes issues with class not found in the Cactoos-Matchers project.
src/main/java/org/cactoos/collection/CollectionOf.javarultorme@rultor.com85781430DEV814-43ada03237-40
Implement immutable ListIterator that should be returned from ListEnvelope when calling `listIterator` method. After it is implemented remove `@Ignore` from the tests below - all of them should pass after the change.
src/test/java/org/cactoos/list/ListEnvelopeTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com86155130DEV551-685b57ce38-41
Remove ctor FuncOf(Proc) by replacing with FuncOf(Proc, Y) FuncOf(Proc) force using of null value which is against design principles. It's affect a lot of classes other classes. Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/FuncOf.javarultorme@rultor.com88386130DEV861-c93d9bb137-39
Avoid usage of null value in IoCheckedProc.exec(X) which is against design principles. Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/IoCheckedProc.javaIsammoc OFFIsammoc@users.noreply.github.com88486130DEV861-7a51e9e548-52
Avoid usage of null value in ctor(Proc, ExecutorService), ctor(Proc, ThreadFactory) and ctor(Proc) which is against design principles. Perhaps with a creation of AsyncProc or removal of this functionality? Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/AsyncFunc.javaIsammoc OFFIsammoc@users.noreply.github.com88586130DEV861-c5656f1b35-37
Avoid usage of null value in UncheckedProc.exec(X) which is against design principles. Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/UncheckedProc.javaIsammoc OFFIsammoc@users.noreply.github.com88686130DEV861-3f3a5fe137-41
Avoid usage of null value in ctor(Proc), ctor(Proc, int), ctor(Proc, Func(Integer, Boolean)) which is against design principles. Perhaps in creating RetryProc? Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/RetryFunc.javaIsammoc OFFIsammoc@users.noreply.github.com106288630DEV886-065814f238-42
Avoid usage of null value in exec(first, second), which is against our design principles. This look like a duplication of functionality from IoCheckedBiFunc. Perhaphs, we do not need this class? Please take a look on #918 for more details.
src/main/java/org/cactoos/func/IoCheckedBiProc.javaGeorge Aristygeorge.aristy@gmail.com88786130DEV861-703fedf338-41
Avoid usage of null value in ctor(Proc, long) which is against design principles. Perhaps in creating TimedProc? Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/TimedFunc.javaIsammoc OFFIsammoc@users.noreply.github.com88886130DEV861-8d8bda5536-39
Avoid usage of null value in ctor(Proc, int) which is against design principles. Perhaps in creating RepeatedProc? Please take a look on #551 and #843 for more details.
src/main/java/org/cactoos/func/RepeatedFunc.javaIsammoc OFFIsammoc@users.noreply.github.com104088830DEV888-b319d71346-48
Avoid usage of null value in ctor(Func) which is against our design principles. Most likely, dropping this ctor will be enough.
src/main/java/org/cactoos/func/CallableOf.javaigorceigor94@gmail.com86281330DEV813-8130ed5b35-37
IterableEnvelope appears to be read only but it returns mutable Iterator through which user can remove elements. Implement immutable Iterator for IterableEnvelope `iterator()` method.
src/test/java/org/cactoos/collection/CollectionEnvelopeTest.javaKrzysztof KrasonKrzysztof.Krason@gmail.com88184430DEV844-c2e67e6a39-42
Implement methods equals and hashCode for this class. Implementation should rely on the items of the nested collection, but not on default JVM impl. Class {@link org.cactoos.map.MapEnvelope} can be used as an example.
src/main/java/org/cactoos/collection/CollectionEnvelope.javaRoman Proshinroman@proshin.org90488130DEV881-d152950a42-48
CollectionEnvelope equals method does not compare objects that implements Collection class. It only compares classes derived from CollectionEnvelope. There are three approaches to solve this issue: 1. add an instanceof (against our principles) 2. build a new type that checks if a class implements/extends an interface 3. modify InheritanceLevel to take into account (1)
src/main/java/org/cactoos/collection/CollectionEnvelope.javarultorme@rultor.com89882930DEV829-59f865f849-51
Remove the use of the static method `Collections.synchronizedList`. Replace by an object-oriented approach. Create a class similar to `SyncCollection` but mutable.
src/test/java/org/cactoos/scalar/AndInThreadsTest.javaPaulo Benetypbenety@gmail.com121789830DEV898-0bea8a5143-45
Get rid of the Immutable in StringList nested class That's because this test should check the original behavior of ListEnvelope Now this test checks behavior of the Immutable decorator
src/test/java/org/cactoos/list/ListEnvelopeTest.java@fanifieievfevzi.anifyeyev@gmail.com121889815DEV898-4936d4fd43-45
Replace Collections.emptyList() with the {@link ListOf} That is because it is necessary to get rid of the static methods as much as possible
src/test/java/org/cactoos/collection/JoinedTest.java@fanifieievfevzi.anifyeyev@gmail.com121989830DEV898-fb66ac0b38-40
Introduce an Immutable wrapper for {@link ListIterator} and use it in listIterator() methods instead of {@link ListIteratorOf}. One another option is renaming of {@link ListIteratorOf}.
src/main/java/org/cactoos/list/Immutable.java@fanifieievfevzi.anifyeyev@gmail.com1230121930DEV1219-fd8dadee39-41
{@link ListIteratorOf} does not have to be immutable. Make it possible to use mutable operations like remove/set/add in this {@link ListIteratorOf} and change the class javadoc as well.
src/main/java/org/cactoos/list/ListIteratorOf.java@fanifieievfevzi.anifyeyev@gmail.com1233123030DEV1230-147999cb29-34
The following list implmenetation classes {@link org.cactoos.list.Joined}, {@link org.cactoos.list.Mapped}, {@link org.cactoos.list.NoNulls}, {@link org.cactoos.list.Shuffled}, {@link org.cactoos.list.Solid}, {@link org.cactoos.list.Solid}, {@link org.cactoos.list.Sorted}, {@link org.cactoos.list.Sticky}, {@link org.cactoos.list.Synced} should support mutability.
src/main/java/org/cactoos/list/package-info.java@fanifieievfevzi.anifyeyev@gmail.com1291123030DEV1230-21258e4c29-33
The following list implmenetation classes {@link org.cactoos.list.Joined}, {@link org.cactoos.list.Mapped}, {@link org.cactoos.list.NoNulls}, {@link org.cactoos.list.Shuffled}, {@link org.cactoos.list.Sorted}, {@link org.cactoos.list.Synced} should support mutability.
src/main/java/org/cactoos/list/package-info.java@rultorme@rultor.com122089830DEV898-457dcf3741-43
Replace all the Collections.unmodifiableList with the {@link org.cactoos.list.Immutable} from the cactoos codebase. That should be done because Elegant Object principles are against static methods.
src/main/java/org/cactoos/list/Immutable.java@fanifieievfevzi.anifyeyev@gmail.com122189830DEV898-b15777f737-39
Replace all the Collections.unmodifiableCollection with the {@link org.cactoos.collection.Immutable} from the cactoos codebase. That should be done because Elegant Object principles are against static methods.
src/main/java/org/cactoos/collection/Immutable.javaFevzi Anifieievfevzi.anifyeyev@gmail.com173089830DEV898-3f27c8c536-38
Replace all the Collections.unmodifiableCollection with the {@link Immutable} from the cactoos codebase. That should be done because Elegant Object principles are against static methods.
src/main/java/org/cactoos/collection/Immutable.javaYegor Bugayenkoyegor256@gmail.com90258830DEV588-33083ad636-40
The test buildsCollectionFromIterator was changed to use BehavesAsCollection instead of Matchers.hasItem and it seems that actually, a CollectionOf built from an Iterator does not behave as a collection. This should be fixed and the @Ignore tag on the buildsCollectionFromIterator method removed.
src/test/java/org/cactoos/collection/CollectionOfTest.javarultorme@rultor.com90358830DEV588-3a40a452151-155
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. At the end the configuration property below should be removed so that calls to forbidden APIs fail the build.
pom.xmlrultorme@rultor.com95190330DEV903-fd48e847154-160
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org108295130DEV951-fd48e847163-169
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org1119108230DEV1082-fd48e847165-171
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xmlrultorme@rultor.com1166111930DEV1119-fd48e847188-194
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xml@rultorme@rultor.com1222116630DEV1166-50dc879695-98
According to this Yegor's post https://www.yegor256.com/2016/05/03/test-methods-must-share-nothing.html test methods must share nothing. Refactor this class by inlining the the code below and remove the method below.
src/test/java/org/cactoos/iterator/IteratorOfTest.java@fanifieievfevzi.anifyeyev@gmail.com1223116630DEV1166-fd48e847193-199
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xmlFevzi Anifieievfevzi.anifyeyev@gmail.com1434122330DEV1223-fd48e847205-211
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xmlandreossandreoss@sdf.org1583143430DEV1434-fd48e847258-264
In the continuation of #588, all the calls to Matchers should be replaced with their OO counterparts. This todo should be updated with a new one until everything is done. The newly covered classes should be added to the include configuration property below. At the end, the configuration property below should be completely removed so that calls to forbidden APIs always fail the build for every classes.
pom.xml@LightPro-Incbaudolivier.oura@gmail.com95594230DEV942-9caf182176-79
Refactor TextEnvelope.equals(). Current implementation of TextEnvelope.equals() uses some things that we must avoid, like more than one return on method, instance of usage and typecasting. Refactor this method so we can get rid of these smelly things.
src/main/java/org/cactoos/text/TextEnvelope.javaPaulo Lobopauloeduardolobo@gmail.com95891330DEV913-d63f0d4a38-40
There is a new class naming convention in effect: avoid compound names for decorators. Continue renaming classes according to this table: https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/package-info.javaGeorge Aristygeorge.aristy@gmail.com96495830DEV958-5fdfc15a38-40
Continue applying the new class naming convention in effect: avoid compound names for decorators. Continue renaming classes according to this table: https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/package-info.javarultorme@rultor.com98096430DEV964-1a0e107838-41
Continue applying the new class naming convention in effect: avoid compound names for decorators. Continue renaming classes according to this table: https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247. Remaining packages are scalar, set, text, and time.
src/main/java/org/cactoos/package-info.javaGeorge Aristygeorge.aristy@gmail.com100398030DEV980-c864268029-32
Continue applying the new class naming convention in effect: avoid compound names for decorators. Continue renaming classes implementing the {@link java.util.Set}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/set/package-info.java@rultorme@rultor.com100498030DEV980-4cee610034-36
Define new name for Base64Text and TextBase64 in order to avoid compound names. These classes are using for decode/encode text using the radix-64 representation.
src/main/java/org/cactoos/text/Base64Text.java@rultorme@rultor.com100598030DEV980-cde865ee29-32
Continue applying the new class naming convention in effect: avoid compound names for decorators. Continue renaming classes implementing the {@link org.cactoos.Text}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/text/package-info.java@rultorme@rultor.com1064100530DEV1005-58ab3a1d29-33
Remove Sticky decorators from tests when: new cactoos-matchers will be released and updated as dependency. Right now, Assertion<>().affirm() is calling test twice. That is the reason why many tests in this package needs to be decorated with Sticky.
src/test/java/org/cactoos/io/package-info.javaigorceigor94@gmail.com1065100530DEV1005-7baae0dd29-32
Continue applying the new class naming convention: avoid compound names for decorators. Continue renaming classes implementing the {@link org.cactoos.Text}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/text/package-info.javaigorceigor94@gmail.com1074106530DEV1065-0d09f05629-32
Continue applying the new class naming convention: avoid compound names for decorators. Continue renaming of classes implementing the {@link org.cactoos.Text}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/text/package-info.java@rultorme@rultor.com100698030DEV980-a6f67b2129-32
Classes from package {@link org.cactoos.time} which are ending with `AsText` are extending TextEnvelope. It means that they are instances of {@link org.cactoos.Text}. They should be merged with {@link org.cactoos.text.TextOf} as ctor(s).
src/main/java/org/cactoos/time/package-info.javarultorme@rultor.com1046100630DEV1006-0071ae3029-33
Classes from package {@link org.cactoos.time} which are ending with `AsText` are extending TextEnvelope. It means that they are instances of {@link org.cactoos.Text}. They should be merged with {@link org.cactoos.text.TextOf} as ctor(s). Tests should be moved to TextOfTest.
src/main/java/org/cactoos/time/package-info.java@rultorme@rultor.com100798030DEV980-ea22ff4929-32
Continue applying the new class naming convention in effect: avoid compound names for decorators. Continue renaming classes implementing the {@link org.cactoos.Scalar}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/scalar/package-info.javarultorme@rultor.com1025100730DEV1007-e4b3819929-32
Continue applying the new class naming convention: avoid compound names for decorators. Continue renaming classes implementing the {@link org.cactoos.Scalar}. More details you can find here https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
src/main/java/org/cactoos/scalar/package-info.javaigorceigor94@gmail.com97296230DEV962-d3b6c3c851-55
o.c.experimental Design the implementation of ThreadsOf. The initial scope is including: 1) receive the ExecutorService; 2) receive the tasks to complete; 3) execute the tasks concurrently and return the values.
src/test/java/org/cactoos/experimental/ThreadsTest.javaYurii Dubinkayurii.dubinka@gmail.com100097230DEV972-6ba919a943-45
j.u.c.ExecutorService#invokeAll(java.util.Collection) should be invoked with timeout. User should have the opportunity to pass the timeout argument. We need a new decorator which supports the timeout.
src/main/java/org/cactoos/experimental/Threads.java@dgroupyurii.dubinka@gmail.com1277100030DEV1000-1e922fa0262-267
Create RepeatedProc decorator in order to get rid of this `dummy` object. After it's done: 1. Leave a puzzle for creation RepeatedCallable decorator 2. Leave a puzzle for splitting the entire `org.cactoos.func` package into `org.cactoos.func`, `org.cactoos.proc` and `org.cactoos.callable`, with each one holding their related decorators, classes and interfaces.
src/test/java/org/cactoos/experimental/TimedTest.javaiakuniniakunin@users.noreply.github.com1406127730DEV1277-9cbed56434-37
Split the entire `org.cactoos.func` package into `org.cactoos.func`, `org.cactoos.proc` and `org.cactoos.callable`, with each one holding their related decorators, classes and interfaces.
src/main/java/org/cactoos/RepeatedProc.javaandreossandreoss@sdf.org1407127730DEV1277-1f8d2dd2265-266
Create RepeatedCallable decorator to get rid of `dummy` object parameter required in #exec(X) method. Then inline the body of this method.
src/test/java/org/cactoos/experimental/TimedTest.javaandreossandreoss@sdf.org101585230DEV852-703228b265-67
Move NoNulls implementations of Func, BiFunc, Proc, and BiProc to their own classes in order to provide the NoNulls classes API consistency.
src/main/java/org/cactoos/Func.java@rultorme@rultor.com101685230DEV852-196f2f0462-64
Move NoNulls implementations of Input, Output, and Bytes to their own classes in order to provide the NoNulls classes API consistency.
src/main/java/org/cactoos/Input.javarultorme@rultor.com101785230DEV852-72b3f84c39-41
Rename XxxNoNulls implementations of Collection and Iterator to NoNulls to avoid the compound names. They should be present in their own classes in order to provide the NoNulls classes API consistency.
src/main/java/org/cactoos/collection/CollectionNoNulls.javarultorme@rultor.com103797130DEV971-205df10084-87
Implement equals() and hashCode() on IterableEnvelope. Then, refactor this test so that only `new IsEqual<>(new Joined<>(first, second, third))` is required as a matcher.
src/test/java/org/cactoos/iterable/IterableOfTest.javarultorme@rultor.com1039102330DEV1023-be859eed37-39
Replace all occurrences of @Rule ExpectedException tests that use it should be refactored to use Throws class introduced in cactoos-matchers 0.13.
src/test/java/org/cactoos/TextTest.java@rultorme@rultor.com1106103915DEV1039-dc7f8b1179-82
Currently it's impossible to match error messages by a pattern or partially. Replace {@link Rule} with {@link Throws} after <a href="https://github.com/llorllale/cactoos-matchers/issues/108">llorllale/cactoos-matchers#108</a> is fixed
src/test/java/org/cactoos/iterator/NoNullsTest.javaAndrey Atapina.atapin@gmail.com1086108130DEV1081-f3313fb136-38
Remove once the dependency cactoos-matchers has been updated to latest version of cactoos and use {@link Unchecked} instead of {@link UncheckedScalar}.
src/main/java/org/cactoos/scalar/UncheckedScalar.javaVictor Noëlvictor.noel@crazydwarves.org1144108630DEV1086-77b0581242-44
Replace the usage of the class TeeInputHasResult in all cactoos tests with the class InputHasContent from cactoos-matcher and then delete it.
src/test/java/org/cactoos/io/TeeInputHasResult.javaVictor Noëlvictor.noel@crazydwarves.org108890930DEV909-fb64001d37-39
add a test to where an interrupt exception is thrown so that the catch and error assignment is verified. The exception should be thrown when Thread.sleep is called in Retry.java:129
src/test/java/org/cactoos/func/RetryTest.javalongstonegit@longstone.ch109593030DEV930-fce9bc8640-42
To be consistent with other objects working on iterables such as HeadOf, TailOf, etc, the constructor of ItemAt should always take the iterable/iterator as a last parameter.
src/main/java/org/cactoos/scalar/ItemAt.javaVictor Noelvictor.noel@brennus-analytics.com110491130DEV911-b9a58d58175-178
Remove iterator constructor from org.cactoos.scalar.ItemAt. We need to avoid the usage of Iterators and replace all of their occurrences in ctors with Iterables.
src/main/java/org/cactoos/scalar/ItemAt.java@rultorme@rultor.com110999630DEV996-e264dc0b42-44
Make the toString() method final and simplify the implementation of Mapped that redefine sit so that it can rely on the implementation of toString already present here.
src/main/java/org/cactoos/collection/CollectionEnvelope.javaVictor Noëlvictor.noel@crazydwarves.org1115111230DEV1112-aa9105a745-46
Continue speeding up the `mvn test` goal until it executes in less than 10 seconds, or as fast as reasonably possible.
src/test/java/org/cactoos/experimental/ThreadsTest.java@llorllalegeorge.aristy@gmail.com1141111530DEV1115-b0c9432741-48
Continue speeding up the `mvn test` goal until it executes in less than 10 seconds, or as fast as reasonably possible. A good solution would be reducing the number of tries to at most 10 in the two tests below with the for loop. After some manual testing to evaluate actual overlaps of threads (see code details in https://www.yegor256.com/2018/03/27/how-to-test-thread-safety.html), it seems most of the tries results in 0 overlapping thread. This is why so much tries are needed in the for loop for the tests to be sound.
src/test/java/org/cactoos/iterator/SyncedTest.javaVictor Noëlvictor.noel@crazydwarves.org1117103330DEV1033-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/main/java/org/cactoos/io/package-info.javaVytaszurauskas.vytautas@gmail.com1152111730DEV1117-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/main/java/org/cactoos/io/package-info.java@rultorme@rultor.com1182115230DEV1152-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1228118230DEV1182-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1235122830DEV1228-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javaiakuniniakunin@users.noreply.github.com1331123530DEV1235-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javaVytautas Žurauskaszurauskas.vytautas@gmail.com1340133130DEV1331-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1343134030DEV1340-b5541bca29-32
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/io/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1362134330DEV1343-b5541bca28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javaiiylllmortaloves@gmail.com1367136230DEV1362-b5541bca28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javaAndrew Korzhovkorzh17121996@gmail.com1375136730DEV1367-b5541bca28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1389137530DEV1375-b5541bca28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1391138930DEV1389-b5541bca28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1396139130DEV1391-715b3f6c28-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers in this package as well as in other packages. Once there is no more usage of MatcherAssert.assertThat, add the signature of MatcherAssert.assertThat to forbidden-apis.txt
src/test/java/org/cactoos/scalar/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1420139630DEV1396-59819ae328-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Keep PR short and limit the changes to single package. Update this puzzle for the next package. After all packages are done, add MatcherAssert to forbidden-apis.txt
src/test/java/org/cactoos/package-info.java@rultorme@rultor.com1425142030DEV1420-59819ae328-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Keep PR short and limit the changes to single package. Update this puzzle for the next package. After all packages are done, add MatcherAssert to forbidden-apis.txt
src/test/java/org/cactoos/package-info.javaConstantin Costescuconstantineugen.costescu@gmail.com1559142530DEV1425-59819ae328-31
Continue replacing usage of MatcherAssert.assertThat with Assertion from cactoos-matchers. Keep PR short and limit the changes to single package. Update this puzzle for the next package. After all packages are done, add MatcherAssert to forbidden-apis.txt
src/test/java/org/cactoos/package-info.java@baudoliver7baudolivier.oura@gmail.com1376136730DEV1367-e974cc7932-34
Replace all the IsEqual with ScalarHashValue in Scalar tests. Can be used as an example BoolOfTest, FirstOfTest, ConstantTest and EqualsTest.
src/test/java/org/cactoos/scalar/package-info.javamarceloamadeumarceloandradeamadeu@gmail.com1341133130DEV1331-806191f638-41
This test is incorrect. It is not being tested whether the path actually contains the content, only that TeeInput, as an Input, has the content. Correct this problem in all TeeInput tests. Solution: test the content of the file, not the content of teeinput.
src/test/java/org/cactoos/io/TeeInputFromBytesTest.javamarceloamadeumarceloandradeamadeu@gmail.com1360134130DEV1341-f972cb6f39-42
Correct any TeeInput tests that are not testing if the path actually contains the content, just that TeeInput, as an Input,has the content. Solution: test the content of the file, not the content of teeinput (e.g. #1331).
src/test/java/org/cactoos/io/TeeInputFromBytesTest.javamarceloamadeumarceloandradeamadeu@gmail.com1372136030DEV1360-f972cb6f39-42
Correct any TeeInput tests that are not testing if the path actually contains the content, just that TeeInput, as an Input,has the content. Solution: test the content of the file, not the content of teeinput (e.g. #1331).
src/test/java/org/cactoos/io/TeeInputFromCharSequenceTest.javaAndrew Korzhovkorzh17121996@gmail.com1381137230DEV1372-f972cb6f41-44
Correct any TeeInput tests that are not testing if the path actually contains the content, just that TeeInput, as an Input,has the content. Solution: test the content of the file, not the content of teeinput (e.g. #1331).
src/test/java/org/cactoos/io/TeeInputFromPathTest.javaAndrew Korzhovkorzh17121996@gmail.com1392138130DEV1381-4d58016d39-42
Correct any TeeInput tests that are not testing if the path actually contains the content, just that TeeInput, as an Input,has the content. Solution: test the content of the file, not the content of teeinput (e.g. #1331 and #1372).
src/test/java/org/cactoos/io/TeeInputFromReaderTest.javamarceloamadeumarceloandradeamadeu@gmail.com1395139230DEV1392-4d58016d39-42
Correct any TeeInput tests that are not testing if the path actually contains the content, just that TeeInput, as an Input,has the content. Solution: test the content of the file, not the content of teeinput (e.g. #1331 and #1372).
src/test/java/org/cactoos/io/TeeInputFromInputTest.javaVictor Noëlvictor.noel@crazydwarves.org118394730DEV947-0e04e40a93-95
Move this constructor in its own class with its own tests and meaningful name (maybe Paged?). Then remove the ClassDataAbstractionCouplingCheck suppression for IterableOf.
src/main/java/org/cactoos/iterable/IterableOf.javaVictor Noëlvictor.noel@crazydwarves.org1464118330DEV1183-64533d2144-46
Continue refactoring and add `iterator.Paged` by extracting inner anon class from this class. The checkstyle suppression should be removed after that.
src/main/java/org/cactoos/iterable/Paged.javaandreossandreoss@sdf.org1537146430DEV1464-68f0eee642-45
We want to use {@code Iterator<X>} directly in the class without introducing I, maybe using {@code Iterator<? extends X>} for example because, we don't have to constrain the {@link Func} to give exactly the same Iterator type as long as it is an iterator that provides X. {@link org.cactoos.iterable.Paged} should be changed too.
src/main/java/org/cactoos/iterator/Paged.java@baudoliver7baudolivier.oura@gmail.com1538146430DEV1464-a8b18c1138-40
Replace the constructor so that instead it takes a {@link Iterable} as first and a {@code Func<Iterable, Iterable>} as next in order to homogenise it with the other {@link Iterable} implementations.
src/main/java/org/cactoos/iterable/Paged.java@baudoliver7baudolivier.oura@gmail.com118494730DEV947-361be9e443-47
CollectionEnvelope should extends IterableEnvelope and only delegates all the methods of Collection to the wrapped Collection. See IterableEnvelope for an example. If needed CollectionOf should have some methods that were previously here and implement Collection instead of extending CollectionEnvelope. Again see IterableOf for an example.
src/main/java/org/cactoos/collection/CollectionEnvelope.javaVictor Noëlvictor.noel@crazydwarves.org1242118430DEV1184-56133cf329-43
The behaviours of the classes of this package are akward because CollectionOf is based on a Scalar while some of the tests of the other classes are expecting mutable collections, except for Sticky itself. This resulted in the use of Sticky in most of the classes of this package during the resolution of #1184 to preserve the actual behaviour. Some tests of Sticky were also ignored because of this. It is as if CollectionOf was once made to be immutable but now there is Immutable for that: ask ARC what direction to take and apply it to make this whole package consistent. Keep in mind that Collection is particular in the way that it is an Iterable and that there are no direct implementation of Collection in Java, but only sub-interfaces (Set, List, etc) with their own implementation. Also don't forget to unignore or modify the tests of Sticky and improve the other tests to be clear about the expected behaviour.
src/main/java/org/cactoos/collection/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1292124230DEV1242-a8a7ac9729-31
The SetOf class should be implemented as an in-memory set, for example based on HashSet. See ListOf for an example and #1242 for the rationale behind this design.
src/main/java/org/cactoos/set/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1325129230DEV1292-c2a188c038-40
This class should also implements SortedSet from the java collection framework by delegating to the wrapped set. Some tests must be added for it.
src/main/java/org/cactoos/set/Sorted.javaVictor Noëlvictor.noel@crazydwarves.org1293124230DEV1242-bb66641c37-41
Remove this class and replace it everywhere it was needed by the appropriate usage of Mapped from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Mapped.javaVictor Noëlvictor.noel@crazydwarves.org1320129330DEV1293-bc5d06e829-34
Introduce a class ScalarOf that takes various objects such as a Supplier, Callable, etc and implement Scalar. Use it to replace in particular the casting to Scalar done in ThreadsTest#failsDueToException, TimedTest#failsDueToException and all the other places where it is needed. Add tests for each of the constructors.
src/main/java/org/cactoos/scalar/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1349132030DEV1320-62e15acb33-36
Continue implement class ScalarOf that takes various objects such as a Supplier, Callable, etc and implement Scalar. Use it to replace in all places where it is needed. Add tests for each of the constructors.
src/main/java/org/cactoos/scalar/ScalarOf.javamarceloamadeumarceloandradeamadeu@gmail.com1294124230DEV1242-3e1cce6435-39
Remove this class and replace it everywhere it was needed by the appropriate usage of HeadOf from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/HeadOf.javaVictor Noëlvictor.noel@crazydwarves.org1295124230DEV1242-40f4f78238-41
Remove this class and replace it everywhere it was needed by the appropriate usage of ListOf, SetOf or any other collection concrete implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Sticky.javaVictor Noëlvictor.noel@crazydwarves.org1296124230DEV1242-fc7e865347-50
Remove this class and replace it everywhere it was needed by the appropriate usage of Synced from list, set, iterable, iterator or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Synced.javaVictor Noëlvictor.noel@crazydwarves.org1297124230DEV1242-f1a7bfc635-39
Remove this class and replace it everywhere it was needed by the appropriate usage of Sliced from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Sliced.javaVictor Noëlvictor.noel@crazydwarves.org1298124230DEV1242-8f74e00b39-43
Remove this class and replace it everywhere it was needed by the appropriate usage of Shuffled from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Shuffled.javaVictor Noëlvictor.noel@crazydwarves.org1299124230DEV1242-d08d303736-40
Remove this class and replace it everywhere it was needed by the appropriate usage of Filtered from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Filtered.javaVictor Noëlvictor.noel@crazydwarves.org1300124230DEV1242-011c38db39-43
Remove this class and replace it everywhere it was needed by the appropriate usage of Reversed from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Reversed.javaVictor Noëlvictor.noel@crazydwarves.org1337130030DEV1300-8636f38d41-43
For now this class is only tested through tests coming from iterables's Reversed: introduces tests for this class to enforce its contract and validate it works as expected.
src/main/java/org/cactoos/iterator/Reversed.javaVictor Noëlvictor.noel@crazydwarves.org1301124230DEV1242-652af3fd35-39
Remove this class and replace it everywhere it was needed by the appropriate usage of Joined from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Joined.javaVictor Noëlvictor.noel@crazydwarves.org1302124230DEV1242-f28dfbc041-45
Remove this class and replace it everywhere it was needed by the appropriate usage of Synced (since Solid is based on Synced and Sticky, which was removed) from list, set, iterable, iterator or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Solid.javaVictor Noëlvictor.noel@crazydwarves.org1303124230DEV1242-15741ade35-39
Remove this class and replace it everywhere it was needed by the appropriate usage of Skipped from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Skipped.javaVictor Noëlvictor.noel@crazydwarves.org1326130330DEV1303-75b3068336-39
Remove the PMD.AvoidDuplicateLiterals suppress warning below and change the tests literals so that they are different. Do not use constants. The rationale si to make the tests more strong by not tying them to the same literals.
src/test/java/org/cactoos/iterable/SkippedTest.javaVictor Noëlvictor.noel@crazydwarves.org1304124230DEV1242-1b85f1d735-38
Remove this class and replace it everywhere it was needed by the appropriate usage of TailOf from list, set, iterable, iterator or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/TailOf.javaVictor Noëlvictor.noel@crazydwarves.org1305124230DEV1242-99c90a2740-44
Remove this class and replace it everywhere it was needed by the appropriate usage of Sorted from iterable (composed with ListOf or SetOf in case a copy is needed) or any other relevant concrete collection implementation. See #1242 for the rationale about this.
src/main/java/org/cactoos/collection/Sorted.javaVictor Noëlvictor.noel@crazydwarves.org118594730DEV947-4efcb5fb41-45
ListEnvelope should only delegates all the methods of List to the wrapped List. See IterableEnvelope for an example. If needed ListOf should have some methods that were previously here and implement List instead of extending ListEnvelope. Again see IterableOf for an example.
src/main/java/org/cactoos/list/ListEnvelope.javaVictor Noëlvictor.noel@crazydwarves.org1191118830DEV1188-96768eb237-39
Change the implementation of this class with the help of <tt>org.cactoos.iterator.Sliced</tt> decorator, to slice the original iterator into sliced portions.
src/main/java/org/cactoos/iterator/Partitioned.java@rultorme@rultor.com1192118830DEV1188-555ede3236-38
Change the implementation of this class with the help of <tt>org.cactoos.iterator.Sliced</tt> decorator, as it contains specific constructor to build skipped iterator.
src/main/java/org/cactoos/iterator/Skipped.java@rultorme@rultor.com1193118830DEV1188-ace6cee040-42
This class to be refactored by extending IteratorEnvelope, which will provide extra functionality to subclasses and is planned to be added to Cactoos shortly.
src/main/java/org/cactoos/iterator/Sliced.java@rultorme@rultor.com1194118830DEV1188-895eb6a436-38
Change the implementation of this class with the help of <tt>org.cactoos.iterator.Sliced</tt> decorator, as it contains specific constructor to build heading iterator.
src/main/java/org/cactoos/iterator/HeadOf.java@rultorme@rultor.com1205115130DEV1151-07534af5166-168
After updated qulice-maven-plugin there're a lot of files which don't pass in the qulice checks. So, let's fix them and remove the their exclusion bellow.
pom.xmlFabricio Cabralfabriciofx@gmail.com1236122430DEV1224-6c7b441d40-44
Original collection should be copied inside this immutable decorator. That should be done because otherwise true immutability cannot be achieved. see: https://github.com/yegor256/cactoos/issues/1224 and https://docs.oracle.com/javase/tutorial/essential/concurrency/immutable.html
src/main/java/org/cactoos/collection/Immutable.javaiakuniniakunin@users.noreply.github.com126294730DEV947-c9c7890537-40
Reimplement the implementation using {@link org.cactoos.iterable.Reversed} decorator. Do not use concrete classes as {@link LinkedList} here, as it is already used in {@link org.cactoos.iterable.Reversed} decorator.
src/main/java/org/cactoos/iterator/TailOf.java@rultorme@rultor.com1416141130DEV1411-445dea43117-120
Migrate existing tests to JUnit 5. It mainly means changing the imports and move from Ignore to Disabled annotation as well as replace rules with corresponding annotations. Once this is done remove the dependencies below.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org1453141630DEV1416-3379c7cc114-116
Migrate the rest of tests to JUnit 5 Junit 4 Rule should be replaced with a Jupiter counterpart. `@Text(expected=..)` with `Throws`. After that remove this dependencies.
pom.xmlandreossandreoss@sdf.org1586145330DEV1453-3061acf9120-122
Continue migration of tests to JUnit 5. Junit 4 Rule should be replaced with a Jupiter counterpart. `@Text(expected=..)` with `Throws`. After that remove this dependencies.
pom.xml@LightPro-Incbaudolivier.oura@gmail.com1714158660DEV1586-1c152e7471-72
Tests failed on Windows due to not closed streams. It will be good to have feature to simplify autoclosing streams.
src/test/java/org/cactoos/io/AppendToTest.javaNatalia PozhidaevaNatalia_Pozhidaeva@epam.com1459124730DEV1247-25d91c9c36-37
Add also some null checks both to the `set` and the `add` methods, then also add some tests to validate this behaviour.
src/main/java/org/cactoos/list/ListIteratorNoNulls.javaVictor Noëlvictor.noel@crazydwarves.org1460128730DEV1287-014a515583-87
Introduce `text.Flatten` that takes a `Scalar` of `Text` and call `value()` then `asString()` on it. Add some tests for it (including for `equals`). Then replace the code below by a composition of `text.Flatten` and `scalar.Ternary`. Then do the same for `PrefixOf` and `SuffixOf` using `text.Sub`.
src/main/java/org/cactoos/text/Abbreviated.javaVictor Noëlvictor.noel@crazydwarves.org1461128730DEV1287-48d7a96263-67
Introduce `Text` implementations `TextOfScalar`, `TextOfBytes` and `TextOfDateTime` (i.e., for all of the constructor below that delegates to a `Scalar`) and have `TextOf` extends `TextEnvelope` to delegate to those new classes. If possible remove the checkstyle exclusions below.
src/main/java/org/cactoos/text/TextOf.javaVictor Noëlvictor.noel@crazydwarves.org1560146130DEV1461-42d3dd73320-325
We want constructors with {@code Iterable<?>} and {@code Iterator<Character>} to have same behaviour (simply concatenate list of strings). To do that, we should change {@code Iterable<?>} to {@code Iterable<Character>} and delegate the {@link Iterator} one to the {@link Iterable} one. After that, we need to modify other parts of cactoos that relied on this in order to preserve their behaviour by using {@link Joined} and {@link Concatenated}.
src/main/java/org/cactoos/text/TextOf.java@baudoliver7baudolivier.oura@gmail.com1462128730DEV1287-1c7c828958-62
Introduce `text.Mapped` that takes a `Text` and a `Func` from `String` to `String`. Add some tests (included for `equals`). Once it is done, replace the code below by the use of `text.Mapped`. Do the same for all the one-liner mapping of the `text` package (e.g., `Upper`, `Trimmed`).
src/main/java/org/cactoos/text/Lowered.javaVictor Noëlvictor.noel@crazydwarves.org1526144530DEV1445-4c31227638-41
For consistency sake with Func, let's - introduce envelopes for Proc, BiProc, BiFunc, Runnable and Callable - have FuncOf, ProcOf, etc extend their envelope to simplify their code - apply on other classes that could benefit from it
src/main/java/org/cactoos/package-info.javaVictor Noëlvictor.noel@crazydwarves.org1527144530DEV1445-a0a4952144-46
Replace all the usage of Repeated in tests that are used to execute the same test multiple times with the use of the RepeatedTest annotation from Junit 5.
src/test/java/org/cactoos/experimental/TimedTest.javaVictor Noëlvictor.noel@crazydwarves.org1532144530DEV1445-c6a75ced42-45
Introduce BiProcOf on the model of ProcOf, FuncOf, etc with constructors taking Func, BiFunc, Proc and BiProc as primary. Add tests similar to those of ProcOfTest, FuncOfTest, etc to fully cover the implementation. Use it where needed, for example in AndWithIndexTest.
src/main/java/org/cactoos/BiProc.javaVictor Noëlvictor.noel@crazydwarves.org1561125430DEV1254-cd24df1237-39
Make {@link Joined} implements directly {@link List} and delegate each operation to {@link JoinedListIterator} as if lists joined were one list.
src/main/java/org/cactoos/list/Joined.java@baudoliver7baudolivier.oura@gmail.com1562125430DEV1254-68bc66d239-42
We should implement mutable operations (#add, #set and #remove) according to their javadoc. Also, the behaviour of adding/setting/removing an element when the cursor is in between two listerators should be well documented in this class (because there are multiple options in that case).
src/main/java/org/cactoos/list/JoinedListIterator.java@baudoliver7baudolivier.oura@gmail.com1563153330DEV1533-6b8653a329-31
Exploit generic variance for package org.cactoos.set to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/set/package-info.java@baudoliver7baudolivier.oura@gmail.com1564153330DEV1533-0433abcf29-31
Exploit generic variance for package org.cactoos.io to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/io/package-info.java@baudoliver7baudolivier.oura@gmail.com1565153330DEV1533-a2c3471829-31
Exploit generic variance for package org.cactoos.iterator to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/iterator/package-info.java@baudoliver7baudolivier.oura@gmail.com1566153330DEV1533-48e5c99429-31
Exploit generic variance for package org.cactoos.list to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/list/package-info.java@baudoliver7baudolivier.oura@gmail.com1567153330DEV1533-ac41b39c29-31
Exploit generic variance for package org.cactoos.proc to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/proc/package-info.java@baudoliver7baudolivier.oura@gmail.com1614156730DEV1567-ac41b39c29-31
Exploit generic variance for package org.cactoos.proc to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/proc/package-info.java@scfjdmitry.barskov64@gmail.com1568153330DEV1533-8f05169029-31
Exploit generic variance for package org.cactoos.iterable to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/iterable/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1569153330DEV1533-c35e378629-31
Exploit generic variance for package org.cactoos.scalar to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/scalar/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1630156930DEV1569-7739be3c29-31
Create tests for the semantics of relaxed wildcards in changed classes of {@link org.cactoos.scalar} package in #1569, which is a child of #1533.
src/main/java/org/cactoos/scalar/package-info.javarocketgamingdas@gmail.com1570153330DEV1533-bf6d58aa29-31
Exploit generic variance for package org.cactoos.time to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/time/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1571153330DEV1533-fb13df6529-31
Exploit generic variance for package org.cactoos.map to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/map/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1572153330DEV1533-37aa2e9029-31
Exploit generic variance for package org.cactoos.func to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/func/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1613157230DEV1572-37aa2e9029-31
Exploit generic variance for package org.cactoos.func to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/func/package-info.javaDmitry Barskovdmitry.barskov64@gmail.com1573153330DEV1533-1282c35c36-37
Exploit generic variance for package org.cactoos.experimental to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/experimental/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1574153330DEV1533-1bce8d4729-31
Exploit generic variance for package org.cactoos.text to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/text/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1575153330DEV1533-d1b8297329-31
Continue to exploit generic variance for package org.cactoos.collection to ensure typing works as best as possible as it is explained in #1533 issue.
src/main/java/org/cactoos/collection/package-info.javaOlivier B. OURAbaudolivier.oura@gmail.com1577144930DEV1449-0c19404b29-33
We must find all the classes that closes stream of {@link org.cactoos.Input} or {@link org.cactoos.Output} that have been passed to them and document them about this behaviour and refer them to the existence of {@link org.cactoos.io.CloseShieldInput} and {@link org.cactoos.io.CloseShieldOutput} and how to use them.
src/main/java/org/cactoos/io/package-info.java@baudoliver7baudolivier.oura@gmail.com1617133530DEV1335-2793a93737-41
Following the rewrite of the Number implementations in cactoos, the three methods below prefixed by overflow where adapted because they started to give different results. The task is to investigate thoroughly what is a "correct" behaviour concerning overflow in the case of SumOf and adapt the tests and the code to make this obvious and clear.
src/test/java/org/cactoos/number/SumOfTest.javaVictor Noëlvictor.noel@crazydwarves.org1623161530DEV1615-3f3b75c737-40
Extract fallback logic for Bytes to a separate class in accordance to other XXXWithFallback classes. Leave only basic exception handling in this class.
src/main/java/org/cactoos/bytes/UncheckedBytes.javaandreossandreoss@sdf.org