unknown8-67eb39548pom.xml280-28330DEVunknownunknown@0pdd.com
This test is not working. I don't know what exactly is going on. Seems like ASM is not working in maven-dependency-analyzer. I copied implementation from maven-dependency-plugin, almost literally.
unknown83-6c3a2ab983src/main/java/com/qulice/maven/DefaultValidatorsProvider.java47-4730DEVunknownunknown@0pdd.com
When it works, add {@code DependenciesValidator()} to this list
unknown83-d32bcbba83src/main/java/com/qulice/maven/DefaultValidatorsProvider.java62-6230DEVunknownunknown@0pdd.com
When it works, add {@code FindBugsValidator()} to this list
17613-53c7238813qulice-xml/src/test/java/com/qulice/xml/XmlValidatorTest.java48-4930DEVunknownunknown@0pdd.com
The test doesn't work because functionality is not implemented yet.
unknown176-99bef10b176qulice-xml/src/main/java/com/qulice/xml/XmlValidator.java83-8430DEVunknownunknown@0pdd.com
Perform refactoring: remove this method, use Environment.files() instead.
unknown55-7f8cd1da55qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/PuzzleFormatCheck/Invalid.java14-1530DEVunknownunknown@0pdd.com
First line is correct, but second line is impropertly indented
unknown555-31c30df2555qulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/PuzzleFormatCheck/Valid.java7-730DEVunknownunknown@0pdd.com
Some text with proper indentation of the second and all consecutive lines.
unknownJIRA-7643-d253cd9dJIRAqulice-checkstyle/src/test/resources/com/qulice/checkstyle/ChecksTest/PuzzleFormatCheck/Valid.java10-1090DEVunknownunknown@0pdd.com
Longer format of puzzle marker
unknown44-99bef10b44qulice-checkstyle/src/main/java/com/qulice/checkstyle/CheckstyleValidator.java206-20760DEVunknownunknown@0pdd.com
Perform refactoring: remove this method, use Environment.files() instead.
unknown44-c0ef14bd44qulice-pmd/src/main/java/com/qulice/pmd/Files.java56-5830DEVunknownunknown@0pdd.com
Perform refactoring: remove this method, use Environment.files() instead, in order to simplify files manipulations.
unknown1-3eabd9441qulice-checkstyle/src/main/java/com/qulice/checkstyle/ConstantUsageCheck.java42-4630DEVunknownunknown@0pdd.com
ConstantUsageCheck doesn't work. This check is still in development and is not used in a released version. Let's try to fix it and enable its validation inside ChecksTest. Also, don't forget to enable it inside checks.xml and make sure all maven-invoker-plugin tests pass
unknown1-14ec496b1qulice-checkstyle/src/main/java/com/qulice/checkstyle/NonStaticMethodCheck.java46-5030DEVunknownunknown@0pdd.com
NonStaticMethodCheck doesn't work. This check is still in development and is not used in a released version. Let's try to fix it and enable its validation inside ChecksTest. Also, don't forget to enable it inside checks.xml and make sure all maven-invoker-plugin tests pass
unknown143-2a590ee4143qulice-checkstyle/src/main/java/com/qulice/checkstyle/PuzzleDuplicateCheck.java46-4630DEVunknownunknown@0pdd.com
Add handling of non-java files (e.g. xml, groovy).
unknown153-1c44959f153qulice-spi/src/main/java/com/qulice/spi/Environment.java86-9030DEVunknownunknown@0pdd.com
Using File as classpath element is dangerous, as it won't work under Windows without conversion - classpaths always use slashes, while File objects under Windows will always use backslashes. This method should return a collection of elements that are not affected by OS.
unknown67-ea924b7967qulice-maven-plugin/src/main/java/com/qulice/maven/PomXpathValidator.java51-5260DEVunknownunknown@0pdd.com
Implement integration tests for PomXpathValidator. Validator should obtain xpath queries from plugin configuration
unknown148-3add3478148qulice-codenarc/src/main/java/com/qulice/codenarc/CodeNarcValidator.java46-5030DEVunknownunknown@0pdd.com
Create integration tests to check exclusion. Lets implement integration tests to check that exclusion patterns propagated to CodeNarc Validator. For syntax example see http://www.qulice.com/qulice-maven-plugin/example-exclude.html
unknown152-5f54d891152qulice-maven-plugin/src/main/java/com/qulice/maven/DefaultMavenEnvironment.java56-5830DEVunknownunknown@0pdd.com
Refactor excludes method. Refactor excludes method to return Collection of excludes. Move joining excludes directly to CodeNarcValidator
250152-ea9dc1d7152qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java40-4030DEVunknownunknown@0pdd.com
Maven-duplicate-finder-plugin should support exclusions. Let's add exclusions of following formats (examples): - duplicate:about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 - duplicate:org.codehaus.groovy.ast.expr.RegexExpression See https://github.com/tpc2/qulice/issues/152#issuecomment-39028953 for details
unknown250-bd6aad88250qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java58-6030DEVunknownunknown@0pdd.com
Fix a problem with maven configuration of duplicate finder plugin in commented out code below, and enable duplicate-finder-ignore-deps IT in pom.xml.
unknown250-70b42373250qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java45-5330unknownunknown@0pdd.com
Maven-duplicate-finder-plugin should support exclusions. Let's add exclusions of following formats (examples): - duplicate:about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 - duplicate:org.codehaus.groovy.ast.expr.RegexExpression - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5|xml-apis:xml-apis:1.0.0|about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5|xml-apis:xml-apis:1.0.0|org.w3c.dom.UserDataHandler See https://github.com/tpc2/qulice/issues/152#issuecomment-39028953 and https://github.com/teamed/qulice/issues/250 for details
IMPunknown250-1b26b28c250qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java44-5430
Maven-duplicate-finder-plugin should support exclusions. Let's add exclusions of following formats (examples): - duplicate:about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 - duplicate:org.codehaus.groovy.ast.expr.RegexExpression - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 |xml-apis:xml-apis:1.0.0|about.html - duplicate:org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M5 |xml-apis:xml-apis:1.0.0|org.w3c.dom.UserDataHandler See https://github.com/tpc2/qulice/issues/152#issuecomment-39028953 and https://github.com/teamed/qulice/issues/250 for details
IMPkrzykKrzysztof.Krason@sabre.comunknown152-25766266152qulice-maven-plugin/src/main/java/com/qulice/maven/DuplicateFinderValidator.java47-4930DEVunknownunknown@0pdd.com
Maven-duplicate-finder-plugin integration tests. Let's add integration tests to check that all types of excludes work properly for maven-duplicate-finder-plugin
251151-1b555c82151qulice-maven-plugin/src/main/java/com/qulice/maven/JslintValidator.java40-4230DEVunknownunknown@0pdd.com
Integration tests for jslint-maven-plugin. Let's implement integration tests for jslint-maven-plugin to be sure it is called.
unknown251-723b0584251qulice-maven-plugin/pom.xml300-30330DEVunknownunknown@0pdd.com
Rename volations.JS to violations.js after a new version of parent is published (that uses qulice which has jslint configured to use src/main for the js file locations) and uncomment following line.
2521-75aae8251qulice-xml/src/test/java/com/qulice/xml/XmlValidatorTest.java48-5130DEVunknownunknown@0pdd.com
Let's implement a proper validation of XML document formatting (!). Not just XML validity, but formatting of the document, including indentation, spaces, quotation marks used, etc.
unknown252-5858aa84252qulice-xml/src/main/java/com/qulice/xml/XmlValidator.java54-5630unknownunknown@0pdd.com
Use better approach to display differences between correctly and incorrectly formatted files, maybe use google-diff-match-patch.
IMPunknown252-a79829e3252qulice-xml/src/main/java/com/qulice/xml/XmlValidator.java70-7130unknownunknown@0pdd.com
Fix all test cases to pass with formating check enabled and change default value to true.
IMPunknown1-3859ec8f1qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml366-36830DEVunknownunknown@0pdd.com
This check leads to NullPointerException when run on a bit source code base. Just try to turn it on and run through Qulice code base. It throws NPE almost at every file.
unknown1-3961fc831qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml372-37730DEVunknownunknown@0pdd.com
The check complains about all methods in all unit tests, because they are not using "this", but are in reality static methods. Even though this complain is totally valid, we can't do anything about this, since JUnit is designed that way. Let's introduce a parameter in this check, which will allow to excluse classes by pattern
unknown1-d234717c1qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml366-36930DEVunknownunknown@0pdd.com
NPE when parsing interfaces with embedded classes. This check fails with an NPE, when parsing an interface with a final class inside it. Let's try to reproduce and fix. Once fixed, remove this puzzle and enable the check again.
unknown1-6974f5e91qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml225-22930DEVunknownunknown@0pdd.com
RedundantThrows check complains about custom exceptions, even in the same package. An exception is defined in the same package, and a method throws it. This checkstyle check complains. Let's fix this problem and enable the check.
352149-fa59b6ee149qulice-findbugs/src/main/java/com/qulice/findbugs/FindBugsValidator.java66-7130unknownunknown@0pdd.com
Create integration tests to check that FindBugsValidator can exclude classes from check. see http://findbugs.sourceforge.net/manual/filter.html for details of findbug filter patterns. Don't forget to update example-exclude.apt.vm with example for findbugs exclusion.
IMPunknown352-f6cf61e2352qulice-maven-plugin/src/it/findbugs-exclude/pom.xml51-5330
Need to add multiline check after issue #350 resolved. Now only one class can be excluded Don't forget update example-exclude.apt.vm
IMPalevohinalevohin@mail.ruunknown149-29796bc9149qulice-findbugs/src/test/java/com/qulice/findbugs/FindBugsValidatorTest.java91-9430unknownunknown@0pdd.com
Add support for multiline excludes. Use xembly Directives to generate xml on the fly. Beware, excludes may contain coma separated list of exclude patterns. When done, remove Ignore annotation on this test.
IMPunknown262-9a421520262qulice-maven-plugin/src/it/checkstyle-exceptions/verify.groovy37-4130unknownunknown@0pdd.com
Checkstyle doesn't have current module in classpath (either because RedundantThrows/AbstractTypeAwareCheck have wrong implementation of resolveClass() or qulice provides wrong classpath to the module. When this is fixed uncomment following three checks and remove "suppressLoadErrors" from RedundantThrows configuration in checks.xml.
IMPunknown123-3eeb54ce123qulice-maven-plugin/src/it/checkstyle-violations/src/main/resources/some.xml3-430unknownunknown@0pdd.com
Make this a better text.
IMPunknown60-2649436b60qulice-maven-plugin/src/it/findbugs-violations/verify.groovy36-3930unknownunknown@0pdd.com
This validation doesn't work at the moment because of incorrect classpath generation in DefaultMavenEnvironment. There is some problem which leads to incomplete classpath being passed to com.qulice.findbugs.Wrap class.
IMPunknown246-77de21a5246qulice-xml/src/test/java/com/qulice/xml/XmlValidatorTest.java91-9530unknownunknown@0pdd.com
XmlValidator should be able to log IO problems (for example, inability to connect to a server) and ignore them (see ticket #243).\ However, {@link com.jcabi.xml.StrictXML} class outright throws an IllegalArgumentException in such cases. Let's find a way to detect whether a failure was caused by such IO errorsand fix this test.
IMPunknown260-dc51e6f4260qulice-checkstyle/src/main/java/com/qulice/checkstyle/MethodBodyCommentsCheck.java50-5130unknownunknown@0pdd.com
Add handling of multiple anonymous classes inside methods by looking at the recursive tree.
IMPunknown260-1576b183260qulice-checkstyle/src/main/java/com/qulice/checkstyle/MethodBodyCommentsCheck.java52-5330unknownunknown@0pdd.com
Add handling of anonymous classes outside of variable definitions, e.g. in for, try/catch, expression, etc.
IMPunknown281-2350cdf0281qulice-maven-plugin/pom.xml296-30230unknownunknown@0pdd.com
Dependency-violations is broken. As it uses maven-dependency-analyzer 1.4. The latter depends on ASM3. We can't add ASM3 in classpath as findbugs and PMD depends on ASM5. Find a way to upgrade maven-dependency-analyzer to use ASM5. After fix uncomment next line
dependency-violations/pom.xml
IMPunknown308-45ddd042308pom.xml134-13630unknownunknown@0pdd.com
Remove this declaration when parent pom would depends on qulice-maven-plugin:0.12 -->
IMP370333-37771839333qulice-findbugs/pom.xml207-20830unknownunknown@0pdd.com
When new jcabi is released based on qulice > 0.11, remove the line below.
IMPunknown370-69914ea1370qulice-maven-plugin/pom.xml379-38030
Fix all FindBugs problems reported in qulice-maven-plugin and remove the FindBugs exclude below.
IMPkrzykKrzysztof.Krason@gmail.comunknown339-6f043704339qulice-gradle-plugin/src/main/java/com/qulice/gradle/QulicePlugin.java47-4730
Design validator classes for Gradle.
IMPDmitri Pisarenkodp@altruix.counknown280-4ce4d8c5280qulice-xml/pom.xml66-7230
This version of jcabi-xml retries if the connection to the host of the schema document is reset. However I don't know how to trigger the "connection reset" condition for testing. We should find a way to test whether it does retry if this happens. See issues https://github.com/jcabi/jcabi-xml/issues/32 and https://github.com/teamed/qulice/issues/280 for background details.
IMPCarlos Mirandacarlosmiranda@users.noreply.github.comunknown337-8e901889337qulice-ant/src/main/java/com/qulice/ant/AntEnvironment.java168-16830
Implement exclude and excludes for ant QuliceTask
IMPalevohinalevohin@mail.ruunknown337-3d7cb361337qulice-ant/src/test/java/com/qulice/ant/AntEnvironmentTest.java40-4030
Implement unit tests at AntEnvironmentTest
IMPalevohinalevohin@mail.ruunknown337-8e901889337qulice-ant/src/main/java/com/qulice/ant/AntEnvironment.java168-16830
Implement exclude and excludes for ant QuliceTask
IMPYegor Bugayenkoyegor@tpc2.comunknown469-1b2c894b469qulice-xml/src/main/java/com/qulice/xml/XmlValidator.java173-17930
Remove the method below and find a way to format tags correctly in XML. Attributes should be indented by 4 spaces, just like XML tags, but in IT xml-violations there is a tag that our Prettifier want to be indented by 3 spaces which is wrong. Another problem is that in the parent tag, attributes are indented to match the first attribute, this is also wrong - all attributes on new line should be indented by 4 spaces.
IMPkrzykKrzysztof.Krason@gmail.comunknown447-94597ea9447qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java214-21630
Right now ConstantUsageCheck takes into account usage of constants inside method annotations, add handling of constants used in field and class annotations.
IMPkrzykKrzysztof.Krason@gmail.comunknown412-bd044e76412qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java51-5330
Split this class into smaller ones and remove PMD exclude `TooManyMethods`. Good candidates for moving out of this class are all that use `validateCheckstyle` method.
IMPkrzykKrzysztof.Krason@gmail.comunknown544-c37b2cc3544qulice-pmd/src/test/java/com/qulice/pmd/PMDEmptyTest.java48-5030
Tests below pass only when run sequentially, when they are run in parallel some of them start to fail. Please fix the tests below and remove override of maven-surefire-plugin configuration in qulice-pmd pom.xml
IMPPrahlad Yeriprahladyeri@yahoo.comunknown569-cd6c2a10569qulice-pmd/src/test/java/com/qulice/pmd/PMDDisabledRulesTest.java44-4715
When new version of Qulice is released (with disabled rules: UseConcurrentHashMap, DoNotUseThreads and AvoidUsingVolatile) remove suppression of given rules and remove unneeded usages of ConcurrentMap and ConcurrentHashMap.
IMPkrzykKrzysztof.Krason@gmail.comunknown339-f214ff2b339qulice-gradle-plugin/src/main/java/com/qulice/gradle/QulicePlugin.java47-4830
Design validator classes for Gradle. And remove the NonStaticMethod exclude below.
IMPkrzykKrzysztof.Krason@gmail.comunknown411-71c8871e411qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java383-38730
Sample code provided in #411 should be considered as invalid. Find a way how to do that by either custom check, or updating Checkstyle whenever IndentationCheck there will be more reliable. As for Checkstyle 6.15 there's no ready solution for that. Right now Qulice allows both correct and incorrect code from #411.
IMPMichal Kordaskordas.michal@gmail.comunknown676-be080182676qulice-maven-plugin/src/test/java/com/qulice/maven/DefaultMavenEnvironmentTest.java136-14330
Ideally integration test is required to reproduce NPE in issue #676. To reproduce problem firstly revert changes marked with #676, then add to pom.xml of IT project at least one exclude rule in configuration.excludes block and dependency (in my case worked org.hibernate:hibernate-annotations:3.5.6-Final). Suggestion is that dependency must be compile-time scope as far as JUnit didn't work as test-scope dependency.
IMPViktor Kuchynkuchin.victor@gmail.comunknown61-61fa67ee61qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java442-44430
This test and passesWindowsEndsOfLineWithoutException should be refactored to gather log4j logs and validate that they work correctly. (see changes done in #61)
IMPkrzykKrzysztof.Krason@gmail.comunknown61-1d39a5c761qulice-maven-plugin/src/main/java/com/qulice/maven/DefaultValidatorsProvider.java78-8030
Make PMDValidator inherit from ResourceValidator and use it similarly to CheckstyleValidator. Move it to externalResource method and make sure all the tests pass.
IMPkrzykKrzysztof.Krason@gmail.comunknown61-832eca6261qulice-maven-plugin/src/main/java/com/qulice/maven/DefaultValidatorsProvider.java81-8330
Make FindBugsValidator inherit from ResourceValidator and use it similarly to CheckstyleValidator. Remember to move it to externalResource method and make sure all the tests pass.
IMPkrzykKrzysztof.Krason@gmail.com84961-1e86e58761qulice-maven-plugin/src/main/java/com/qulice/maven/DefaultValidatorsProvider.java84-8630
Make XmlValidator and CodeNarcValidator inherit from ResourceValidator and use it similarly to CheckstyleValidator. Remember to move it to externalResource method and make sure all the tests pass.
IMPkrzykKrzysztof.Krason@gmail.comunknown61-654de8aa61qulice-spi/src/main/java/com/qulice/spi/Violation.java57-6030
Let's split the message part into lines, message and check name. After it is done fix CheckstyleValidatorTest.ViolationsMatcher to handle all those parameters and fix all failing tests.
IMPkrzykKrzysztof.Krason@gmail.comunknown715-04710633715qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java722-72330
add test for next situation `return new ArrayList
();`
IMPViktor Kuchynkuchin.victor@gmail.com850715-2a207c32715qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java700-70130
add test for next situation {@code return new ArrayList
();}
IMPViktor Kuchynkuchin.victor@gmail.com851706-72bdab5d706qulice-findbugs/src/main/java/com/qulice/findbugs/Wrap.java78-8430
After fix issue mentioned in comment https://github.com/teamed/qulice/issues/706#issuecomment-225943946 rollback the changes done in #706 then remove @Ignore above FindBugsValidatorTest.reportsIncorrectlyAddedThrows test and fix test findbugs-bed-bogus-exception-declaration. For the moment third item is done from comment https://github.com/teamed/qulice/issues/706#issuecomment-184611854
IMPDSkalenkod.skalenko@gmail.com8161230IMP123-1f09aa3b43-44
Make this better in multiple lines but different.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.javaYegor Bugayenkoyegor256@gmail.com8171230IMP123-b644cf2266-67
Make this better in multiple lines.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.javaYegor Bugayenkoyegor256@gmail.com818123120IMP123-cfed8d027-7
This is also valid.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.javaYegor Bugayenkoyegor256@gmail.com8191230IMP123-5357374c24-25
Here we should capture also another line.
qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.javaYegor Bugayenkoyegor256@gmail.com94912330DEV123-42c66e69103-103
Dummy todo to test if it works -->
qulice-checkstyle/pom.xmlkrzykKrzysztof.Krason@gmail.com95080130DEV801-1b19be4155-60
This rule currently doesn't complain if the string is prefixed with this when length is called (e.g. somestring.length() works but this.somestring.length() does not). The same happens in with a method call (this.method().length() does not work). Check if possible and if it is, extend this rule to also catch this case. More about how to write PMD rules here: http://pmd.sourceforge.net/pmd-4.3/howtowritearule.html.
qulice-pmd/src/main/java/com/qulice/pmd/rules/UseStringIsEmptyRule.javarultorme@rultor.com99995030DEV950-157b811653-58
Correct this class so it complains if the string is prefixed with this when length is called (e.g. somestring.length() works but this.somestring.length() does not). The same happens in with a method call (this.method().length() does not work). More about how to write PMD rules here: http://pmd.sourceforge.net/pmd-4.3/howtowritearule.html. Then ignore the tests on UseStringIsEmptyRuleTest.
qulice-pmd/src/main/java/com/qulice/pmd/rules/UseStringIsEmptyRule.javapaulodamasopauloeduardolobo@gmail.com100095030DEV950-05d88f7941-43
UseStringIsEmptyRuleTest is not comparing all possible targets. Implement the tests for the remaining targets (see complete list in UseStringIsEmptyRule#getComparisonTargets).
qulice-pmd/src/test/java/com/qulice/pmd/UseStringIsEmptyRuleTest.javapaulodamasopauloeduardolobo@gmail.com1016100030DEV1000-db538e2440-48
UseStringIsEmptyRuleTest is not comparing all possible targets. Implement the tests for the remaining targets (see complete list in UseStringIsEmptyRule#getComparisonTargets). Conditions that must be tested are checking string length when the String is the result of a method (this.method().length()) and when the String is a class field (this.somestring.length()). Use the same name and file pattern used in the test methods, appending 'This' or 'Method' suffix to indicate which access type the test relates to (field or method), renaming the tests if needed.
qulice-pmd/src/test/java/com/qulice/pmd/UseStringIsEmptyRuleTest.javaPaulo Lobopauloeduardolobo@gmail.com95988430DEV884-ab2ca2fa39-42
Continue migration from FindBugs to SpotBugs. Implement SpotBugsValidator for this and then uncomment SpotBugsValidatorTest class so the minimal tests on this class can be run. Then, after all is set, remove FindBugs references from pom and from qulice executions.
qulice-spotbugs/src/test/java/com.qulice.spotbugs/SpotBugsValidatorTest.javaPaulo Lobopauloeduardolobo@gmail.com100184730DEV847-6f98df3539-42
Enforce right parameter order in javadoc. Checkstyle must check if parameter order in javadoc is the same as is in the method signature. Implement this check and add its tests to checks.xml under custom checks.
qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocParameterOrderCheck.javaPaulo Lobopauloeduardolobo@gmail.com100474330DEV743-bb004e2166-69
Nested classes should have since tag. Implement check to validate if nested classes javadoc have a valid since tag. After the implementation add JavadocTagsCheck to checks.xml and ChecksTest (removed because now the test fails).
qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocTagsCheck.javaPaulo Lobopauloeduardolobo@gmail.com100589730DEV897-e70cf262682-685
Allow lambdas and generics to be places at end of line. RegexpSingleline is too strict and not allow generics and lambdas being placed at end of lines. Correct this behavior and uncomment test below.
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.javaPaulo Lobopauloeduardolobo@gmail.com100691730DEV917-27a2aa2844-50
Make ProtectedMethodInFinalClassCheck stricter. ProtectedMethodInFinalClassCheck must check if the protected method in final class isn't overriding some default method from abstract parent class and fail if so. The Invalid class for tests is already implemented. After the change in ProtectedMethodInFinalClassCheck complete the tests adding the following line to violations.txt: 23:Protected method is overriding default scoped method
qulice-checkstyle/src/main/java/com/qulice/checkstyle/ProtectedMethodInFinalClassCheck.javaPaulo Lobopauloeduardolobo@gmail.com100792030DEV920-5b2cf26e38-42
Qulice should prohibit any non-final class. Tests for this check have already been implemented in ProhibitNonFinalClassesCheck folder. After the implementation of this class add config.xml to folder pointing to ProhibitNonFinalClassesCheck class, add check into ChecksTest and add it to custom checks in checks.xml
qulice-checkstyle/src/main/java/com/qulice/checkstyle/ProhibitNonFinalClassesCheck.javaPaulo Lobopauloeduardolobo@gmail.com100873830DEV738-5bee823d39-41
Static inner classes should be qualified with outer class Implement QualifyInnerClassCheck so it follows what defined in QualifyInnerClassCheck test and add this check to checks.xml and CheckTest.
qulice-checkstyle/src/main/java/com/qulice/checkstyle/QualifyInnerClassCheck.javaPaulo Lobopauloeduardolobo@gmail.com10099665DEV966-537ebfc378-79
Add Cactoos dependency to qulice-pmd and replace IOUtils usage with Cactoos alternatives `TextOf` and `ResourceOf`
qulice-pmd/src/test/java/com/qulice/pmd/PmdAssert.javaNico Korthoutnicokorthout@gmail.com101993930DEV939-39a57206138-140
Upgrade to Junit5. Continue to upgrade to Junit5 updating qulice-maven-plugin sub-module and removing remaining junit4 tags.
pom.xml@rultorme@rultor.com1030101930DEV1019-4869c92c46-49
Upgrade to Junit5. Finish JUnit upgrade to JUnit5 by upgrading it in qulice-maven-plugin submodules. Qulice-maven-plugin presents some build error that does not trigger any bulid failure, so maybe they must be corrected first.
qulice-maven-plugin/pom.xmlPaulo Lobopauloeduardolobo@gmail.com