17 10 15 DEV 10-367b8283 41-45 Extract to hamcrest matcher, check value cucumber annotations, inspect all annotations. Add configure for checking timeout. Maybe more than one annotation. Bad idea use many methods in test. seeds-db/src/test/java/com/github/smallcreep/cucumber/seeds/db/steps/StpDefConnectionTest.java Ilia Rogozhin ilia.rogozhin@adsterra.com 18 10 15 DEV 10-e62debd8 32-34 Move this interface to the Core module. Ann create basic implementation for this interface. Because many modules maybe used it. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Suit.java Ilia Rogozhin ilia.rogozhin@adsterra.com 24 18 30 DEV 18-8db2f47e 36-40 Redesign class. Suit must be a Singleton class. This class must two static {@link AtomicReference} fields: Context suit and Scenario. Scenario should be return context of current. Because we don't want use dependency injection. For correct using Before and After we can use order feature seeds-core/src/main/java/com/github/smallcreep/cucumber/seeds/suit/StSimple.java Ilia Rogozhin ilia.rogozhin@adsterra.com 19 10 35 DEV 10-8101f1eb 32-34 Need add new module with name Core. And move this interface to this module. Ann create basic implementation for this interface. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Scenario.java Ilia Rogozhin ilia.rogozhin@adsterra.com 20 10 30 DEV 10-4feee286 33-36 Move this class to the Core module. Because many modules maybe used it. Method {@link Context#suit()} should return the same suit every time. After add implementation of {@link Suit} need replace it. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java Ilia Rogozhin ilia.rogozhin@adsterra.com 21 10 45 DEV 10-30907043 65-68 Need remove using public static method. But I don't know how fixed it. This mistake in cucumber. If not resolved this problem need remove this comment and add doc why we use it. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/Context.java Ilia Rogozhin ilia.rogozhin@adsterra.com 30 28 15 DEV 28-92e27b36 33-36 Need implement this class. This class must search properties in all context. And have storage for new values. Need use many context from constructor. seeds-core/src/main/java/com/github/smallcreep/cucumber/seeds/context/CxJoined.java Ilia Rogozhin ilia.rogozhin@adsterra.com 33 10 25 DEV 10-8e4704c8 30-33 Need add basic implementation for this interface. For basic implementation method #connect should send simple select, for example `SELECT 1;`, to real database, and check that connect is available. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/DataBase.java Ilia Rogozhin ilia.rogozhin@adsterra.com 41 33 30 DEV 33-51e244f3 41-46 Move this test to integration tests. Need startup any Database (ex. Postgres) before run integration test. We can start DB in docker, for running docker images we can use fabric8io/docker-maven-plugin. For more info about this plugin go to the link http://dmp.fabric8.io/ seeds-db/src/test/java/com/github/smallcreep/cucumber/seeds/db/DbDefaultTest.java Ilia Rogozhin ilia.rogozhin@adsterra.com 34 10 20 DEV 10-795d4cf6 59-61 Need add hooks for update suit context. Suit context should contains Properties Context (CxProperties). This need to transfer data between scenarios. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/StpDefConnection.java Ilia Rogozhin ilia.rogozhin@adsterra.com 35 10 25 DEV 10-f940a7a1 30-34 Need add basic implementation for this interface. For basic implementation method #database(String) should return default database. And doesn't create new database, if this database already created. And return already created database. For sharing database between scenarios we can use Suit#context(). seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/steps/DataBases.java Ilia Rogozhin ilia.rogozhin@adsterra.com 48 35 30 DEV 35-c3c2f21a 47-49 Add constructors that get Suit context, and Props implementation for get default values if values for current data base dose not set. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/DbsDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 50 48 15 DEV 48-b558b139 35-41 Implement this #property(String) method. This method was return default value if has not specific value. Returned values mapping: "jdbs.driver" = "cucumber.seeds.db.%db_name%.jdbc.driver" "jdbs.url" = "cucumber.seeds.db.%db_name%.jdbc.url" "user" = "cucumber.seeds.db.%db_name%.user" "password" = "cucumber.seeds.db.%db_name%.password" seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/props/PrDbContext.java Ilia Rogozhin ilia.rogozhin@adsterra.com 62 60 20 DEV 60-f9b83fa7 43-46 Redesign class constructor. For example add to DataBase#table(String, String), This method must return table by schema and name. And rows must get into constructor only Table and Rows. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/rows/RwDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 63 60 30 DEV 60-7cbcbbd6 59-62 Implement this method. This method must add rows to table. Need that method generate data by #Random#Integer or other placeholders. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/rows/RwDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 85 63 30 TEST 63-19a2d4ae 60-63 Add integration test to this method. For example this test must insert to exist database table. To create table can use liquibase, see for example usage https://www.yegor256.com/2014/07/20/liquibase-in-maven.html seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/rows/RwDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 86 63 30 DEV 63-01c92703 64-76 Add change values from placeholders. We need use placeholders for example #Random#Integer. This placeholder should replace before insert. Placeholders to implementation: #Random#Integer - random integer; #Random#String - random string; #Timestamp#Now - current timestamp by default in format YYYY/MM/DD hh:mm:ss #Random#String#End(endString) - random string with string in the end, can send another placeholder as parameter; #Random#String(length) - random string length from parameter; #Encryption#Md5() - encrypt string to md5 hash, can send another placeholder as parameter; seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/rows/RwDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 64 60 15 DEV 60-57442154 77-81 Implement this method. Need that method return already connected database by name. See method DbsDefault#database(String). And throw exception if hasn't connected database. After connect to new database this method return this database. seeds-db/src/main/java/com/github/smallcreep/cucumber/seeds/db/DbsDefault.java Ilia Rogozhin ilia.rogozhin@adsterra.com 89 87 15 DEV 87-e3f4ac65 44-47 Implement this class. This class should replace all placeholders. This class doesn't change key, but change values from origin map. Values should replaced by regexp. seeds-generator/src/main/java/com/github/smallcreep/cucumber/seeds/generator/surrogate/SurrogateSimple.java Ilia ilia.rogozhin@gmail.com