10 3 30 DEV 3-66625a17 12-14 Continue implementing Self's API (Java Interfaces). We should continue with an Iterable of Project (interface Projects) and also introduce the Contributor. A Project has one or many Contributors. self-api/src/main/java/com/selfxdsd/api/Project.java @amihaiemil amihaiemil@gmail.com 12 10 30 DEV 10-7b5d7cf5 34-36 Continue implementing Self's API (Java Interfaces). We should introduce the Contributor. A Project can have one or more contributors. Each contributor has an hourly rate. self-api/src/main/java/com/selfxdsd/api/Project.java @amihaiemil amihaiemil@gmail.com 45 12 30 DEV 12-9eb2412e 41-43 Method contracts(). Continue implementing the Storage (and the mock InMemory) for the Contributor/Project many-to-many relation, via the Contract association. self-api/src/main/java/com/selfxdsd/api/storage/StoredProject.java @amihaiemil amihaiemil@gmail.com 50 45 30 DEV 45-26649917 44-47 Implement method int::Project.projectId(). Changes will also be needed inside StoredProjectManager.assign(...) -- the Project should be instantiated and returned from the Storage, since that's the place where the id is generated. self-api/src/main/java/com/selfxdsd/api/storage/StoredProject.java @amihaiemil amihaiemil@gmail.com 13 10 30 DEV 10-6d2570b5 29-31 Start implementing these interfaces. We should start with an implementation for this interface, as well as Repos, Repo, User etc. self-api/src/main/java/com/selfxdsd/api/Self.java @amihaiemil amihaiemil@gmail.com 15 13 30 DEV 13-b311c7f8 38-40 Implement User.repos(). It should return a Repos instance which should represent the user's repository from the provider's platform (Github, Bitbucket etc). self-core-impl/src/main/java/com/selfxdsd/core/GithubSelf.java @amihaiemil amihaiemil@gmail.com 20 15 30 DEV 15-5c5b51d8 37-40 Implement User.repos(). It should return a Repos instance which should represent the user's repository from the provider's platform (Github, Bitbucket etc). GithubRepo is already implemented, we can start with Github Repos. self-core-impl/src/main/java/com/selfxdsd/core/GithubSelf.java @amihaiemil amihaiemil@gmail.com 26 20 30 DEV 20-8927304b 35-37 Implemented method repo(). Write unit tests, as well as integration tests for it. This method assumes that the repo in question is a user-owned and public. self-core-impl/src/main/java/com/selfxdsd/core/Github.java @amihaiemil amihaiemil@gmail.com 28 26 30 DEV 26-e68b9b1a 36-38 Bring in Gizzly mock HTTP Server (see jcabi-http), so we can mock the Github server and write unit tests for the methods that perform HTTP Requests. self-core-impl/src/main/java/com/selfxdsd/core/Github.java @amihaiemil amihaiemil@gmail.com 21 15 30 DEV 15-b8fdffc7 36-38 Implement and test activation of this Github repository. Activating a repository means creating and persisting a Project that will be managed by the platform later. self-core-impl/src/main/java/com/selfxdsd/core/GithubRepo.java @amihaiemil amihaiemil@gmail.com 16 13 30 DEV 13-32838750 33-36 Write unit tests for all the InMemory mock infrastructure. These are tools used in Self's unit tests which should also be tested themselves. Self's unit tests should fail only if there's a problem with Self. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemory.java @amihaiemil amihaiemil@gmail.com 39 16 30 DEV 16-dcb763b9 18-20 Continue writing unit tests for the InMemory storage infrastructure. In the end all classes and methods should be covered with unit tests so we can rely 100% on them. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryTestCase.java @amihaiemil amihaiemil@gmail.com 82 39 30 DEV 39-dcb763b9 23-25 Continue writing unit tests for the InMemory storage infrastructure. In the end all classes and methods should be covered with unit tests so we can rely 100% on them. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryProjectsTestCase.java HoreaPetrila horea.petrila99@e-uvt.ro 31 29 30 DEV 29-494905a9 34-36 Implement the assign(Repo) method. This repo should store create a Project, link it to this PM and then return it back. Don't forget ot test this method. self-api/src/main/java/com/selfxdsd/api/StoredProjectManager.java @amihaiemil amihaiemil@gmail.com 42 31 30 DEV 31-902d1319 33-35 Implement the deactivate method which should remove the Project form the DB (it means Self will stop managing it). Return the corresponding Repo when done. Don't forget the tests. self-api/src/main/java/com/selfxdsd/api/StoredProject.java @amihaiemil amihaiemil@gmail.com 53 42 30 DEV 42-89e036d3 36-38 Implement this class and write some unit tests for Project.contracts(). Then go further and implement Contributor.contracts() self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContracts.java @amihaiemil amihaiemil@gmail.com 32 29 30 DEV 29-ee978689 36-38 Implement the projects() storage. A Project has an incremented integer id, a foreign key to its PM and some other stuff that are not yet decided. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemory.java @amihaiemil amihaiemil@gmail.com 47 27 30 DEV 27-ef64e245 37-37 Continue adding integration tests for Gitlab provider. self-core-impl/src/main/java/com/selfxdsd/core/Gitlab.java cristianpela cristypela05@gmail.com 65 59 30 DEV 59-f2a3b904 39-42 Implement and test method register(...). It should register the repo with respect to the fact that this is a User's Projects, meaning the given Repo has to belong to this User, the PM has to work for the same provider etc. self-core-impl/src/main/java/com/selfxdsd/core/projects/UserProjects.java @amihaiemil amihaiemil@gmail.com 73 71 30 DEV 71-377a5e3f 37-40 Implement method Contracts.addContract(...). Implement ProjectContracts to replace the anonymous class used here inside ofProject(...). Once we can test this class, write some unit tests for it. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContracts.java @amihaiemil amihaiemil@gmail.com 77 73 30 DEV 73-94622f1f 39-40 Implement method Contracts.addContract(...). Once we can test this class, write some unit tests for it. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContracts.java @amihaiemil amihaiemil@gmail.com 79 74 30 DEV 74-6fc04657 40-42 When Storage API has contributors available, update InMemoryContracts#getContributorById() to use storage. Then update InMemoryContractsTestCase tests to reflect that. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContracts.java cristianpela cristypela05@gmail.com 94 79 30 DEV 79-580e807d 32-34 Implement and test StoredContract, following the pattern of StoredContributor and others. This is a good ticket for first-time contributors. self-api/src/main/java/com/selfxdsd/api/Contract.java @amihaiemil amihaiemil@gmail.com 95 79 30 DEV 79-282aa471 40-42 Write some unit tests for this class, make sure it works fine. This is a good starting point if you want to start contributing to self-core. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContributors.java @amihaiemil amihaiemil@gmail.com 96 79 30 DEV 79-2e30e1fe 41-43 Implement and test Project :: Projects.getById(...). Once that is ready, use it here and remove the private method getProjectById(...). self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryContracts.java @amihaiemil amihaiemil@gmail.com 108 96 30 DEV 96-dea5d869 23-25 Provide implementation of {@link Projects#getProjectById(int)} for each class implementation and create unit tests. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryProjectsTestCase.java Bogdan Adrian bogdanadrian102@gmail.com 83 68 20 DEV 68-34d53a58 38-39 Add ProjectManager with gitlab provider to the pms map. Refactor {@link this#pick(String)} to take into consideration the provider. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryProjectManagers.java Bogdan Adrian bogdanadrian102@gmail.com 86 69 20 DEV 69-62299523 38-41 Add to the ability for {@link ProjectManagers} to add a project manager `addProjectManager(...)` and then test that using {@link InMemoryProjectManagers#getById(int)} and {@link InMemoryProjectManagers#pick(String)} self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryProjectManagers.java cristianpela cristypela05@gmail.com 100 97 30 DEV 97-bcc117e9 32-34 Implement Comments::Issue.comments(). This method should be the entry point to an Issue's comments and have methods for both listing and posting new comments. self-api/src/main/java/com/selfxdsd/api/Issue.java @amihaiemil amihaiemil@gmail.com 244 100 30 DEV 100-a80e16f6 14-15 Implement and test the remaining methods in GithubIssueComments. self-core-impl/src/main/java/com/selfxdsd/core/GithubIssueComments.java cristianpela cristypela05@gmail.com 249 100 30 DEV 100-24fff222 20-22 Provide a pagination solution in iterator() using Github response headers, when {@link Resource} API has access to http response headers (issue #241). self-core-impl/src/main/java/com/selfxdsd/core/GithubIssueComments.java cristianpela cristypela05@gmail.com 101 97 0 DEV 97-8b9168b0 37-40 Implement and unit test method json() here. It should call Github's API to fetch the Issue json and then use it to return a GithubIssue. If the API returns 404 or 204, then the method should return null. self-core-impl/src/main/java/com/selfxdsd/core/issues/GithubIssues.java @amihaiemil amihaiemil@gmail.com 102 97 30 DEV 97-617dbb3c 36-37 Write unit tests for this class and for GithubRepo.issues. self-core-impl/src/main/java/com/selfxdsd/core/issues/GithubIssue.java @amihaiemil amihaiemil@gmail.com 112 110 30 DEV 110-e3027d6c 44-47 Implement and unit testContributorContracts.addContract. A Contract added via this method can only belong to the Contributor who owns these Contracts. Check ProjectContracts.addContract(...) for a similar example. self-core-impl/src/main/java/com/selfxdsd/core/contracts/ContributorContracts.java @amihaiemil amihaiemil@gmail.com 121 97 30 DEV 97-08232f72 34-36 In the "contributors" package of self-core-impl create ProjectContributors and test it. This class will be used to implement Contributors.ofProject(id). self-api/src/main/java/com/selfxdsd/api/Project.java cristianpela cristypela05@gmail.com 123 116 30 DEV 116-8dc0f12b 30-31 Start implementing Tasks.getById and InMemoryTasks. Don't forget the unit tests. self-api/src/main/java/com/selfxdsd/api/Tasks.java @amihaiemil amihaiemil@gmail.com 125 123 30 DEV 123-f40507f6 30-32 Add method register(projectId, Issue), to register a new Issue as a Task in the given Project. Don't forget about unit tests. self-api/src/main/java/com/selfxdsd/api/Tasks.java @amihaiemil amihaiemil@gmail.com 133 125 30 DEV 125-c81f1ae0 30-32 Implement and unit test Project.tasks() and Contributor.tasks(). They each should return their own implementation of interface Tasks. self-api/src/main/java/com/selfxdsd/api/Tasks.java @amihaiemil amihaiemil@gmail.com 136 133 30 DEV 133-7376f99a 30-31 Implement and unit test Contributor.tasks(). It should return its own implementation of Tasks. self-api/src/main/java/com/selfxdsd/api/Tasks.java @amihaiemil amihaiemil@gmail.com 137 133 30 DEV 133-30481f08 42-44 Implement and unit test method ofProject(...) which should return the specified Project tasks using class {@link com.selfxdsd.core.tasks.ProjectTasks}. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryTasks.java @amihaiemil amihaiemil@gmail.com unknown 128 30 DEV 128-bc49fe1d 37-39 Initially, all the Issues will have the DEV or REV role. In a future version, we will set an Issue's role based on labels set by the user. self-core-impl/src/main/java/com/selfxdsd/core/issues/GithubIssue.java @amihaiemil amihaiemil@gmail.com 141 134 30 DEV 134-f73a4154 21-24 In `InMemoryTasks.java` Implement and unit test method ofContributor(...) which should return the specified Contributor tasks using class {@link com.selfxdsd.core.tasks.ContributorTasks}. self-core-impl/src/main/java/com/selfxdsd/core/tasks/ContributorTasks.java cristianpela cristypela05@gmail.com 144 135 30 DEV 135-200b416a 37-39 Finish 'getTasksOfContributor()' test case when API permits that; as in when a Task can be assigned to a Contributor. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryTasksTestCase.java cristianpela cristypela05@gmail.com 146 142 30 DEV 142-5967597e 35-38 At the moment the User's accessToken is never used. This token should be passed on to the Provider implementation, which in turn will use it to make API Requests which require user authentication. self-core-impl/src/main/java/com/selfxdsd/core/StoredUser.java @amihaiemil amihaiemil@gmail.com 164 163 30 DEV 163-912d9b79 11-12 Implement and test InMemoryInvoices. Also implement Storage#invoices(). self-api/src/main/java/com/selfxdsd/api/Invoices.java cristianpela cristypela05@gmail.com 167 165 30 DEV 165-5a08baef 35-37 Implement method issue(). It should read the Issue from the Project's repository. We need a change in interface Issues: method getById should expect String, rather than Integer. self-core-impl/src/main/java/com/selfxdsd/core/tasks/StoredTask.java @amihaiemil amihaiemil@gmail.com 175 165 30 DEV 165-63222a61 19-23 Refactor and test ContractInvoices to be part of self-impl API . Also InvoiceTask should have its own concrete implementation in self-impl. Use that in InMemoryInvoices. Continue testing InMemoryInvoices. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryInvoices.java cristianpela cristypela05@gmail.com 184 181 30 DEV 181-f7ddabbd 19-20 Refactor and test ContractInvoices to be part of self-impl API. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryInvoices.java cristianpela cristypela05@gmail.com 193 190 30 DEV 190-567012ff 20-21 Implement and test unassigned() for ProjectTasks and InMemoryTasks, using UnassignedTasks. self-core-impl/src/main/java/com/selfxdsd/core/tasks/UnassignedTasks.java cristianpela cristypela05@gmail.com 199 192 30 DEV 192-5ba266e8 35-39 Method tasks() here should return the tasks with respect ot the encapsulated Contracts. If the Contracts exist (!= null), then the method should only return the Tasks from these contracts. Otherwise, it should return all the Tasks of the contributor, as it does now. self-core-impl/src/main/java/com/selfxdsd/core/contributors/StoredContributor.java @amihaiemil amihaiemil@gmail.com 203 204 30 DEV 204-4a2ef409 33-35 Finish implementing and testing ContractTasks, that will be used later to implement tasks() in ProjectTasks, ContributorTasks and InMemoryTasks. self-api/src/main/java/com/selfxdsd/api/Contract.java cristianpela cristypela05@gmail.com 207 203 30 DEV 203-be4943c6 19-21 Implement and test ofContract() in ProjectTasks, ContributorTasks and in InMemoryTasks, using ContractTasks. self-core-impl/src/main/java/com/selfxdsd/core/tasks/ContractTasks.java @amihaiemil amihaiemil@gmail.com 223 207 30 DEV 207-01b671c5 19-21 Method Tasks.ofContract() has been implemented everywhere. However, some unit tests are missing. Write unit tests for all the implementations where they are missing. self-core-impl/src/main/java/com/selfxdsd/core/tasks/ContractTasks.java @amihaiemil amihaiemil@gmail.com 262 223 30 DEV 223-49114d3d 43-44 It needs to implement the unit test for the method Tasks.ofContract() of the class ContributorTasks. self-core-impl/src/main/java/com/selfxdsd/core/tasks/ProjectTasks.java @ANadrowski aislan.nadrowski@gmail.com 216 214 30 DEV 214-78b57c14 19-22 Implement and write tests for InvoicedTasks. This interface will represent some finished tasks that have been invoiced (attached to the active invoice of a Contract). Interface Invoice should have the method InvoicedTasks :: tasks(). self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryInvoices.java amihaiemil amihaiemil@gmail.com 220 216 30 DEV 216-e1db1cae 32-34 Implement and write unit tests for methods int :: estimation() and BigDecimal :: hourlyRate() so we can calculate the Task's value when we add it to an Invoice. self-api/src/main/java/com/selfxdsd/api/Task.java @amihaiemil amihaiemil@gmail.com unknown 212 30 DEV 212-4e897150 39-40 Test equals and hashcode methods for each Stored* classes (StoredProjectManager, StoredProject etc.). self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java @amihaiemil amihaiemil@gmail.com 225 190 30 DEV 190-3d425bb7 44-46 Add an implementation of interface Invitation, called GithubInvitation, which will take the invitation's JSON and work with it. self-core-impl/src/main/java/com/selfxdsd/core/GithubRepoInvitations.java @amihaiemil amihaiemil@gmail.com 228 225 30 DEV 225-a1140b0d 39-40 When accepting an invitation, get the response status code and if it's different from 204 NO CONTENT, log a warning or something. self-core-impl/src/main/java/com/selfxdsd/core/GithubInvitation.java @amihaiemil amihaiemil@gmail.com 226 190 30 DEV 190-ecea2376 40-43 Abstract all the HTTP calls behind an implementation of an interface called JsonResources. JsonResources will have a runtime implementation called HttpJsonResources and a mock implementation used for unit testing. self-core-impl/src/main/java/com/selfxdsd/core/Github.java amihaiemil amihaiemil@gmail.com 234 226 30 DEV 226-70fb6f35 40-44 Add other methods such as post, patch etc and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). After that is done, we should add a mock implementation of JsonResources, which we will use in writing unit tests for the providers. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 237 234 30 DEV 234-54720845 40-45 Add other methods such as post, patch etc and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). Make sure to offer alternatives with accessToken as well. After that is done, we should add a mock implementation of JsonResources, which we will use in writing unit tests for the providers. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 246 237 30 DEV 237-bafb0c68 40-45 Add other methods such as delete, patch etc and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). Make sure to offer alternatives with accessToken as well. After that is done, we should add a mock implementation of JsonResources, which we will use in writing unit tests for the providers. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 235 226 30 DEV 226-b27bdc42 45-46 Bring in Grizzly in-memory HTTP Server (see project jcabi-github), so we can write integration tests for class JdkHttp. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 251 248 30 DEV 248-4312ce52 41-43 Pass the JsonResources to the GithubInvitation as well so we can remove the HTTP calls from there as well. Don't forget about testing. self-core-impl/src/main/java/com/selfxdsd/core/GithubRepoInvitations.java @amihaiemil amihaiemil@gmail.com 252 248 30 DEV 248-f065cfa2 40-44 Add other methods such as delete, patch etc and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). After that is done, we should add a mock implementation of JsonResources, which we will use in writing unit tests for the providers. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 254 252 30 DEV 252-820887a6 40-44 Add other methods such as delete and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). After that is done, we should add a mock implementation of JsonResources, which we will use in writing unit tests for the providers. self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 263 252 30 DEV 252-9dba75c4 40-42 Add other methods such as delete and continue abstracting the HTTP calls away from the Provider's implementations (Issues, Comments etc). self-core-impl/src/main/java/com/selfxdsd/core/JsonResources.java amihaiemil amihaiemil@gmail.com 259 122 30 DEV 122-8525164d 8-9 Start implementing Github Organizations of which the authenticated User has admin rights. self-api/src/main/java/com/selfxdsd/api/Organizations.java cristianpela cristypela05@gmail.com 272 270 30 DEV 270-83d7f545 39-41 Continue implementation of the resolve(...) method. It should decide what kind of event has occurred and delegate it further to the ProjectManager who will deal with it. self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 284 272 30 DEV 272-7c5879a1 38-41 Continue implementation of the resolve(...) method. It should decide what kind of event has occurred and delegate it further to the ProjectManager who will deal with it. We still need the Issue Reopened case and Comment Created case. self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 275 122 30 DEV 122-8be42be5 14-15 Continue to implement and test Github Organization Repos for the authenticated User. self-core-impl/src/main/java/com/selfxdsd/core/GithubOrganization.java cristianpela cristypela05@gmail.com unknown 277 30 DEV 277-e4f1192a 30-31 Allow {@link User} interface to have access to {@link Organizations}. self-api/src/main/java/com/selfxdsd/api/User.java cristianpela cristypela05@gmail.com 285 278 30 DEV 278-d86e619b 30-31 Implement and test Organizations for Gitlab provider. self-api/src/main/java/com/selfxdsd/api/User.java cristianpela cristypela05@gmail.com 289 278 30 DEV 278-0caa54b3 38-41 Continue implementation of the resolve(...) method. It should decide what kind of event has occurred and delegate it further to the ProjectManager who will deal with it. We still need the Issue Assigned case and Comment Created case. self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 303 300 30 DEV 300-8b838371 36-37 Gitlab Invitations: implement and test invitations for Gitlab provider. self-core-impl/src/main/java/com/selfxdsd/core/Gitlab.java cristianpela cristypela05@gmail.com unknown 305 30 DEV 305-e93af154 41-43 Labels API: should be able to list and add labels for Provider resources (Repo, Issue). Labels will be used mainly for an Issue to get its estimation. self-core-impl/src/main/java/com/selfxdsd/core/GithubIssue.java cristianpela cristypela05@gmail.com 317 315 30 DEV 315-3e2d84bd 13-15 An Invoice should have the method #register(Task). This method should check if the Invoice is active. If it is, register the Task to the invoice. self-api/src/main/java/com/selfxdsd/api/Invoice.java @amihaiemil amihaiemil@gmail.com 327 324 30 DEV 324-de3d5d88 33-35 Implement a Step which invites the PM to the project's Repo and also a Step which sets up the project Webhook in the Repo. self-api/src/main/java/com/selfxdsd/api/pm/Step.java @amihaiemil amihaiemil@gmail.com 348 327 30 DEV 327-e59edc6b 33-34 Implement a Step which sets up the project Webhook in the Repo. self-api/src/main/java/com/selfxdsd/api/pm/Step.java @amihaiemil amihaiemil@gmail.com 355 348 60 DEV 348-1471771f 36-38 Implement and test Repo.webhooks().add(...) method, which will setup a webhook in the Repo. Afterwards, continue implementing and testing this class. self-core-impl/src/main/java/com/selfxdsd/core/managers/SetupWebhook.java amihaiemil amihaiemil@gmail.com 357 355 30 DEV 355-a0b82922 35-36 Implement and test Webhooks for the Gitlab repository. self-core-impl/src/main/java/com/selfxdsd/core/GitlabRepo.java @amihaiemil amihaiemil@gmail.com 358 355 30 DEV 355-e7106a95 38-40 Implement and write tests for method add(Project). It should set up a webhook. Please see PR #292 for how the webhook should be configured. self-core-impl/src/main/java/com/selfxdsd/core/GithubWebhooks.java amihaiemil amihaiemil@gmail.com 349 327 15 DEV 327-196b193e 38-39 Create classes for permissions constants in both Github and Gitlab. self-core-impl/src/main/java/com/selfxdsd/core/managers/InvitePm.java amihaiemil amihaiemil@gmail.com 350 327 30 DEV 327-e55cf50f 40-43 Add method ProjectManager.userId() which should return the user ID (not username) registered with the Provider. Then, modify the invitation logic to use the user ID in case of GitLab. After this, don't forget to write unit tests for this class. self-core-impl/src/main/java/com/selfxdsd/core/managers/InvitePm.java amihaiemil amihaiemil@gmail.com 330 328 60 DEV 328-f56725d1 38-39 Implement the GitLab Collaborators, especially the invite(...) method. Don't forget about the tests. self-core-impl/src/main/java/com/selfxdsd/core/GitlabRepo.java @amihaiemil amihaiemil@gmail.com 331 328 30 DEV 328-bf9f2d94 35-36 Implement the invite method using JsonResources.put. Don't forget about unit tests. self-core-impl/src/main/java/com/selfxdsd/core/GithubCollaborators.java amihaiemil amihaiemil@gmail.com 343 333 30 DEV 333-0a2c981a 85-91 The method Provider.repo(name) has been changed to Provider.repo(owner, name), where owner is either the User's login or the Organization's name. This change was necessary because it's not correct to assume that the User is always the actual owner -- a repo can also be owned by an Organization. In this task, figure out what value needs to be passed bellow (currently, we always pass empty string). self-core-impl/src/main/java/com/selfxdsd/core/GitlabOrganizationRepos.java @amihaiemil amihaiemil@gmail.com 353 346 30 DEV 346-3112900e 45-46 Write unit tests for paging InMemoryProjects, PmProjects and UserProjects. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryProjects.java cristianpela cristypela05@gmail.com 363 290 15 DEV 290-4f83021f 42-43 Unit tests have been added for class Authenticated. We should also add unit tests for class PmUser. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java Aislan Nadrowski aislan.nadrowski@gmail.com 364 360 30 DEV 360-6b8f3473 9-10 Provide paging implementation for other Self entities: Collaborators, Contracts, Contributors, Tasks, Invoices, InvoicedTasks. self-api/src/main/java/com/selfxdsd/api/storage/Paged.java cristianpela cristypela05@gmail.com 371 366 30 DEV 366-f7a7e029 9-11 Provide paging implementation for other Self entities: Contributors, Contracts, Invoices, InvoicedTasks, Tasks. As guidance use implementation for Projects: Pm/User/InMemoryProjects. self-api/src/main/java/com/selfxdsd/api/storage/Paged.java cristianpela cristypela05@gmail.com 378 376 60 DEV 376-1e018104 42-44 At the moment the wallet() method always returns the Missing wallet. Implement the walletId DB column and attribute of a Project and return a real Wallet if this id exists (!= null). self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 379 376 30 DEV 376-b4f38c4d 45-46 Change this class to encapsulate the whole Project, not just its ID. We need the Project in order to access its Wallet. self-core-impl/src/main/java/com/selfxdsd/core/contributors/ProjectContributors.java @amihaiemil amihaiemil@gmail.com 380 376 30 DEV 376-eb663e41 47-50 Once we have the Project encapsulated here, adapt the election algorithm to make sure that we only elect contributors whom we can afford to pay (the would-be Task value has to be less than the available cash in the Wallet). self-core-impl/src/main/java/com/selfxdsd/core/contributors/ProjectContributors.java @amihaiemil amihaiemil@gmail.com 384 380 30 DEV 380-c7c335ec 32-34 Implement the Invoice :: Wallet.pay(Invoice) method, which will perform the payment and return the Invoice with the trasactionId and payment timestamp set. self-api/src/main/java/com/selfxdsd/api/Wallet.java @amihaiemil amihaiemil@gmail.com 395 393 30 DEV 393-8cb94068 30-31 Method register(...): make sure to also accept the PM's commission (BigDecimal) as parameter. self-api/src/main/java/com/selfxdsd/api/ProjectManagers.java @amihaiemil amihaiemil@gmail.com 396 393 30 DEV 393-882ba2c8 43-44 Take the PM's commission into account when electing a Contributor (to make sure we can afford to pay everything). self-core-impl/src/main/java/com/selfxdsd/core/contributors/ProjectContributors.java @amihaiemil amihaiemil@gmail.com 403 400 30 DEV 400-bb6375ab 14-15 Addapt method register to also accept the PMs commission as BigDecimal. self-core-impl/src/main/java/com/selfxdsd/core/contracts/invoices/StoredInvoice.java amihaiemil amihaiemil@gmail.com 404 402 30 DEV 402-0cf23d35 43-44 When electing a contributor for a task, we must make sure that ProjectContributors's contract Project matches Task's Project. self-core-impl/src/main/java/com/selfxdsd/core/contributors/ProjectContributors.java cristianpela cristypela05@gmail.com 410 408 30 DEV 408-cc11e464 14-15 StoredInvoice should encapsulate its invoiced tasks, rather than reading them from the storage every time. self-core-impl/src/main/java/com/selfxdsd/core/contracts/invoices/StoredInvoice.java amihaiemil amihaiemil@gmail.com 412 410 30 DEV 410-bc32691d 13-16 Remove the first constructor, since it is not needed. When creating an Invoice, we'll make an INSERT via JOOQ, which means this constructor is only needed for the InMemoryInvoices (which is just present for scaffolding reasons and will be removed later). self-core-impl/src/main/java/com/selfxdsd/core/contracts/invoices/StoredInvoice.java amihaiemil amihaiemil@gmail.com 420 418 30 DEV 418-e7efccc1 38-40 Method issue() here should fetch the Issue from the PM's repository, so that the PMs authentication token is encapsulated and we can post comments on the PMs behalf. self-core-impl/src/main/java/com/selfxdsd/core/tasks/StoredTask.java @amihaiemil amihaiemil@gmail.com 423 420 30 DEV 420-955836a7 319-320 Rewrite this test, as well as handlesNewIssueEvent, so they use only mocks and no real objects. self-core-impl/src/test/java/com/selfxdsd/core/managers/StoredProjectManagerTestCase.java amihaiemil amihaiemil@gmail.com 421 418 0 DEV 418-842c5bb8 43-44 Finish the unassignedTasks method once we have a way of assigning a Task to a Contributor. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java amihaiemil amihaiemil@gmail.com 427 421 30 DEV 421-1f3ca14f 30-31 Implement and test Contributor.contract(...), which should return the contract, if found. If not, then return null. self-api/src/main/java/com/selfxdsd/api/Contributor.java @amihaiemil amihaiemil@gmail.com 430 427 30 DEV 427-faf325d8 40-41 Implement method Tasks.assign(Task, Contract), to assign a given Task to a given Contract. self-core-impl/src/main/java/com/selfxdsd/core/tasks/StoredTask.java @amihaiemil amihaiemil@gmail.com 431 427 30 DEV 427-4eee3dd1 42-43 Implement and test method Task::Task.unassign(). This method should remove the assignee and leave the Task unassigned. self-core-impl/src/main/java/com/selfxdsd/core/tasks/StoredTask.java @amihaiemil amihaiemil@gmail.com 428 421 30 DEV 421-6e1bdcba 38-39 Continue implementing method assign(...) here, once we have method Contributor.contract(...). self-core-impl/src/main/java/com/selfxdsd/core/tasks/StoredTask.java @amihaiemil amihaiemil@gmail.com 435 421 30 DEV 421-18e2f379 43-44 When assigning a Task to a Contributor, make sure to also assign the Issue as well. Don't forget about updating the tests. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java amihaiemil amihaiemil@gmail.com 443 439 30 DEV 439-396801f4 40-41 Update InMemoryTasks assign() and unassign() to use Task#issueId() then test them. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryTasksTestCase.java cristianpela cristypela05@gmail.com 446 441 60 DEV 441-5ef8b246 32-35 Add the first implementation of Conversation, which should be named Understand and should use the project's Language to understand the comment and set the event's type accordingly. self-api/src/main/java/com/selfxdsd/api/pm/Conversation.java @amihaiemil amihaiemil@gmail.com 449 446 30 DEV 446-2aa4416d 35-36 Add an implementation of Step which sends a reply to the event comment. self-core-impl/src/main/java/com/selfxdsd/core/managers/Understand.java amihaiemil amihaiemil@gmail.com 450 446 30 DEV 446-d17e5fc9 37-38 Add the next implementation of Conversation, called Hello, which will send a reply if the event type is "hello". self-core-impl/src/main/java/com/selfxdsd/core/managers/Understand.java amihaiemil amihaiemil@gmail.com 451 446 30 DEV 446-a770e22e 39-41 Add the Confused implementation of Conversation, which will send a "didn't understand" reply, if the event type is "confused". self-core-impl/src/main/java/com/selfxdsd/core/managers/Understand.java amihaiemil amihaiemil@gmail.com 457 454 30 DEV 454-764e6990 36-38 We must implement a Step where we should validate that the comment's author is indeed the task's assignee. After that, we also need a Step to actually unassign the Task. self-core-impl/src/main/java/com/selfxdsd/core/managers/Resign.java amihaiemil amihaiemil@gmail.com 459 457 30 DEV 457-7bc91db1 36-38 Implement and test an Intermediary step which unassigns the event's task. Once that is ready, complete the composition in method start(...) here. self-core-impl/src/main/java/com/selfxdsd/core/managers/Resign.java amihaiemil amihaiemil@gmail.com 465 462 30 DEV 462-31b3b28d 9-11 Provide paging implementation for other Self entities: Contracts, Invoices, InvoicedTasks, Tasks. As guidance use implementation for Projects: Pm/User/InMemoryProjects. self-api/src/main/java/com/selfxdsd/api/storage/Paged.java cristianpela cristypela05@gmail.com 472 470 60 DEV 470-0c95486b 38-39 Finish implementing RemoveTask when Tasks api allows to remove a Task. Then write tests for it and Deregister. self-core-impl/src/main/java/com/selfxdsd/core/managers/RemoveTask.java cristianpela cristypela05@gmail.com 478 476 30 DEV 476-448b8be8 30-32 Update filter implementations of Tasks#getById to not use issue() when doing queries (like getById), but use Task#project() and Task#issueId() instead. ProjectTasks is already updated. self-api/src/main/java/com/selfxdsd/api/Tasks.java cristianpela cristypela05@gmail.com 489 478 30 DEV 478-71d5692f 39-41 Implement an intermediary step where the event's Issue is registered as a Task and finish the composition of the register steps here. self-core-impl/src/main/java/com/selfxdsd/core/managers/Register.java amihaiemil amihaiemil@gmail.com 491 489 30 DEV 489-893054ff 38-42 Add a simple constructor which only takes the String reply and sets a Final next step which only logs "Conversation ended". Usually, SendReply is the last step in any Conversation, so this will simplify the code a lot in most places where SendReply is used. self-core-impl/src/main/java/com/selfxdsd/core/managers/SendReply.java amihaiemil amihaiemil@gmail.com 487 470 30 DEV 470-9318b89e 37-39 Implement an intermediary step which checks if the Issue in question is already registered or not. Then, use it together with AuthorHasRoles (any) to build and return the steps. self-core-impl/src/main/java/com/selfxdsd/core/managers/Register.java amihaiemil amihaiemil@gmail.com 496 462 30 DEV 462-18da03fe 40-42 Implement and write tests for a Task's resignations. It will be a class named TaskResignations implementing interface Resignations. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryResignations.java amihaiemil amihaiemil@gmail.com 502 499 30 DEV 499-c992814d 36-41 Add methods cash() which should return all the available cash in the wallet (what available() is doing now). Add also the method debt() which should return all the debt the project still has (the current value of all the contracts). Change method available() to return the difference between the cash and the debt. self-api/src/main/java/com/selfxdsd/api/Wallet.java @amihaiemil amihaiemil@gmail.com 503 499 60 DEV 499-38b411f6 43-45 At the moment the wallet() method always returns the Missing wallet. Implement the reading of the project's active Wallet from the storage. self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 504 499 30 DEV 499-d1da8a5e 40-42 As soon as we have the Stripe wallet implemented, modify the register(...) method here to take it into account, according to the given type (at the moment, it always registers the Missing wallet). self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryWallets.java amihaiemil amihaiemil@gmail.com 511 498 30 DEV 498-73b39da9 33-35 Task api should expose resignations(), for easier access in ProjectContributors#elect(Task) algorithm, in order to filter out previously resigned contributors from Task. self-api/src/main/java/com/selfxdsd/api/Task.java cristianpela cristypela05@gmail.com 527 525 30 DEV 525-0b11017a 32-33 Implement method Issue.close() which should use the "Update Issue" endpoint to close it. self-api/src/main/java/com/selfxdsd/api/Issue.java @amihaiemil amihaiemil@gmail.com unknown 524 30 DEV 524-1af26f28 34-36 Replace old custom exceptions InvoiceAlreadyPaidExeption, RepoAlreadyActiveException, RepoNotFoundException with Self exceptions (Repo and Invoice). self-api/src/main/java/com/selfxdsd/api/exceptions/SelfException.java cristianpela cristypela05@gmail.com 530 526 30 DEV 526-213a6cc8 35-37 Write custom SelfExceptions for Contracts (NotFound, Duplicate, etc...), and replace the existent IllegalStateExceptions with them. self-api/src/main/java/com/selfxdsd/api/Contracts.java cristianpela cristypela05@gmail.com 534 532 30 DEV 532-1a0d1d21 32-33 Write custom SelfExceptions for Contributors and replace the existent IllegalStateExceptions with them. self-api/src/main/java/com/selfxdsd/api/Contributors.java cristianpela cristypela05@gmail.com 535 531 30 DEV 531-d334ba72 40-42 Implement methods register and ofProject(...) of this class, once we have an implementation of PayoutMethod (we will start with the Stripe payment method) and class ContributorPayoutMethods. self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryPayoutMethods.java amihaiemil amihaiemil@gmail.com 538 535 30 DEV 535-d1f88dd7 39-41 Implement methods register of this class, once we have an implementation of PayoutMethod (we will start with the Stripe payment method). self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryPayoutMethods.java amihaiemil amihaiemil@gmail.com 540 538 30 DEV 538-e2c71d0d 30-33 Implement method PayoutMethod::createStripeAccount() which will first check if the contributor doesn't already have a Stripe PayoutMethod, then use Stripe's API cu create an account and finally register the PayoutMethod. self-api/src/main/java/com/selfxdsd/api/Contributor.java @amihaiemil amihaiemil@gmail.com 541 538 30 DEV 538-6c60ba7a 33-36 Implement Stripe API call to check if the contributor has finished the onboarding process for this payout method. Then, implement an API call to see if there are any more actions that the Contributor needs to take in order for the account to be fully active. self-core-impl/src/main/java/com/selfxdsd/core/contributors/StripePayoutMethod.java @amihaiemil amihaiemil@gmail.com 544 519 30 DEV 519-be5395a8 67-71 Replace this method with method Contributor::User.asContributor(). This way, we will have access to all of the user's stuff (contracts, tasks, payout methods etc). If the User is not a Contributor, the method should return null. self-api/src/main/java/com/selfxdsd/api/User.java @amihaiemil amihaiemil@gmail.com 546 536 30 DEV 536-f6f2e44e 32-33 Write custom SelfExceptions for Projects and replace the existent IllegalStateExceptions with them. self-api/src/main/java/com/selfxdsd/api/Projects.java cristianpela cristypela05@gmail.com 550 548 30 DEV 548-3fa180bc 32-35 Implement and test Contributors::Contributors#ofProvider(String). Also iterating over all contributors should be restricted in favor of ofProvider() (throwing SelfException). self-api/src/main/java/com/selfxdsd/api/Contributors.java cristianpela cristypela05@gmail.com 549 550 30 DEV 550-0614a150 33-34 Write custom SelfExceptions for Tasks and replace the existent IllegalStateExceptions with them. self-api/src/main/java/com/selfxdsd/api/Task.java cristianpela cristypela05@gmail.com 555 552 45 DEV 552-d847b7f6 8-10 Finish writing custom Self Exception for Invoices (InvoicesException). Also include the already written InvoiceException into InvoicesExceptions as InvoicesException.Single. self-api/src/main/java/com/selfxdsd/api/Invoices.java cristianpela cristypela05@gmail.com 564 562 30 DEV 562-63248b5a 45-47 When reviewing the assigned tasks (assignedTasks(Event)), if the deadline of the task has expired, we should resign the Contributor and inform them about it via an Issue comment. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java amihaiemil amihaiemil@gmail.com 572 571 30 DEV 571-e9749a10 46-48 When checking if task deadline is missed in assignedTasks(...), we should take into account the hours and minutes as well. Right now we checking it against days left. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java cristianpela cristypela05@gmail.com 576 570 30 DEV 570-dcd501ea 32-35 Add a Conversation implementation where we should ignore the comment if it comes from any other PMs. We should not allow the PMs to talk to each other because they will most likely end up in an infinite loop of "Sorry, I don't understand that". self-api/src/main/java/com/selfxdsd/api/pm/Conversation.java @amihaiemil amihaiemil@gmail.com 594 581 30 DEV 581-6cae0f5d 43-45 Continue implementing the createStripeMethod here. It should create a Customer via Stripe API (using the Project ID), then register and return the new stripe Wallet. self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java @amihaiemil amihaiemil@gmail.com 598 594 60 DEV 594-abba5903 36-40 A project's Wallet should have one or more PaymentMethods, which will represent the cards or other payment methods that the Project's owner has registered for the project. Only one of these methods should be active or primary and it will be the first one we try to use when making payments. self-api/src/main/java/com/selfxdsd/api/Wallet.java @amihaiemil amihaiemil@gmail.com 599 594 30 DEV 594-984a648d 41-46 A Wallet should have the method updateCash(...) which will update the amount of cash that we are allowed to use. In other words, this cash value will act as a limit that the user sets for us -- when this limit reaches zero, we will not make any more payments and they will have to go on the web dashboard to update this value. self-api/src/main/java/com/selfxdsd/api/Wallet.java @amihaiemil amihaiemil@gmail.com 595 581 30 DEV 581-6471a6d6 50-54 When reviewing the unassigned tasks (unassignedTasks(...)), the PM should check if the Issue is already assigned to someone and, if it is, it should assign the Task to that contributor. If the Issue is assigned to someone who is not a registered to someone who is not a Contributor, they should be unassigned and a Contributor should be elected. self-core-impl/src/main/java/com/selfxdsd/core/managers/StoredProjectManager.java amihaiemil amihaiemil@gmail.com 603 585 30 DEV 585-676e2a39 39-41 When unassigning the Task, we should also remove the Issue assignee (if any) and leave a comment to let them know about it. self-core-impl/src/main/java/com/selfxdsd/core/managers/UnassignTask.java amihaiemil amihaiemil@gmail.com 606 604 60 DEV 604-dc7ff9e3 36-38 Implement method pay(...) here as soon as we have a Wallets PaymentMethods available. We should always try to use the active PaymentMethod first. self-core-impl/src/main/java/com/selfxdsd/core/projects/StripeWallet.java @amihaiemil amihaiemil@gmail.com 612 610 30 DEV 610-65b8cb4e 42-43 Implement and test method search(...) here, by using class FoundIssues to represent the found issues. self-core-impl/src/main/java/com/selfxdsd/core/GithubIssues.java @amihaiemil amihaiemil@gmail.com 615 608 60 DEV 608-b4f8136c 30-31 Provide implementation and unit tests for PaymentMethods#ofWallet(...). self-api/src/main/java/com/selfxdsd/api/PaymentMethods.java cristianpela cristypela05@gmail.com 616 609 15 DEV 609-53389968 40-41 Implement equals() and hashCode() for StripeWallet since StoredPaymentMethod is using Wallet for its equals and hashCode methods. self-core-impl/src/main/java/com/selfxdsd/core/projects/StripeWallet.java cristianpela cristypela05@gmail.com 632 629 30 DEV 629-041ddd1b 40-41 After we have the method Repo.star() implemented, finish implementation of method accept here to actually star the repo. self-core-impl/src/main/java/com/selfxdsd/core/GithubInvitation.java @amihaiemil amihaiemil@gmail.com 641 630 30 DEV 630-7e246601 18-22 Write some unit tests for method add() here. They should follow the same pattern as other unit tests and make use of class MockJsonResources. As example of usage, see how tests GithubIssueTestCase.reopensOk() and GithubIssueTestCase.reopensNotFound() are implemented. self-core-impl/src/main/java/com/selfxdsd/core/GithubStars.java amihaiemil amihaiemil@gmail.com