157 150 30 DEV 150-f4a028a1 45-47 We might have to implement mappings and indexing of suggestions. Waiting for a clarification here: https://discuss.elastic.co/t/simple-way-to-implement-autocomplete-functionality/68979 src/main/java/com/amihaiemil/charles/aws/AmazonEsRepository.java amihaiemil amihaiemil@gmail.com 158 150 30 DEV 150-d3633346 63-64 When the autocomplete topic is clear and the handler implemented write unit tests for AmazonEsSuggest. src/main/java/com/amihaiemil/charles/aws/AmazonEsSuggest.java amihaiemil amihaiemil@gmail.com 159 150 30 DEV 150-54535ee7 85-88 This implementation might have to be changed. Currently it's using bare Suggester which does word correction rather than actual autocomplete. Waiting for an answer here: https://discuss.elastic.co/t/simple-way-to-implement-autocomplete-functionality/68979 src/main/java/com/amihaiemil/charles/aws/SuggestQuery.java amihaiemil amihaiemil@gmail.com 160 150 30 DEV 150-47fee5a9 59-60 Once the autocomplete topic is clear and we have the final response layout, implement and unit test this method. src/main/java/com/amihaiemil/charles/aws/SuggestionsResponseHandler.java amihaiemil amihaiemil@gmail.com 166 162 60 DEV 162-48c2e1d6 36-39 Checkstyle validation was added but currently the build fails since not all the rules are respected. The validations should be fixed, but this will probably be an ongoing task since they are too many of them to go in one shot. src/main/java/com/amihaiemil/charles/rest/RestApplication.java amihaiemil amihaiemil@gmail.com 184 181 30 DEV 181-ca416da0 61-63 After Russian language is done and tested, let's start using it. It should be added bellow, right after English and everything should work after that. src/main/java/com/amihaiemil/charles/github/Brain.java Mihai Emil Andronache amihaiemil@gmail.com 185 176 60 DEV 176-a617e601 44-46 Test puzzle to test if 0pdd works for this repository? Last puzzle didn't generate any Github issue, seems to be a bug asdasdew. src/main/java/com/amihaiemil/charles/github/Command.java Mihai Emil Andronache amihaiemil@gmail.com 186 174 30 DEV 174-2ae6a13d 33-35 Implement and unit test Language class Russian, following the model of this class and its unit tests. The class should use the commands_ru and responses_ru properties files. src/main/java/com/amihaiemil/charles/github/English.java Mihai Emil Andronache amihaiemil@gmail.com 201 199 30 DEV 199-aff84e88 33-35 Implement and Unit test 4 system properties SecretKey, Region, EsEndPoint and AccessKeyId. Also add fake implementation for the interfaces to use them in testing. src/main/java/com/amihaiemil/charles/aws/SystemProperty.java sherif sherifwaly95@gmail.com 205 201 15 DEV 201-af20c932 34-35 Add fake implementation for the 4 SystemProperty interfaces to use them in testing. src/main/java/com/amihaiemil/charles/aws/AbstractSystemProperty.java sherif sherifwaly95@gmail.com 222 220 30 IMP 220-20b595ff 35-36 Add further Knowledge implementations, to replace the Brain class entirely. src/main/java/com/amihaiemil/charles/github/Conversation.java Mihai Emil Andronache amihaiemil@gmail.com 237 222 30 IMP 222-903f585c 35-36 Hello was added, to handle hello commands. Continue with further Knowledges for the other commands (index site, index page etc). src/main/java/com/amihaiemil/charles/github/Conversation.java Mihai Andronache amihaiemil@gmail.com 223 220 30 IMP 220-27beec2c 44-45 Add CachedCommand class, which would handle caching of values that are currently handled here. src/main/java/com/amihaiemil/charles/github/Command.java Mihai Emil Andronache amihaiemil@gmail.com 234 219 60 IMP 219-dd617bae 42-45 Write some integration tests for this step, check that the tree of steps executes correctly/in the right order. For this, you need to mock a Github server (use MkGithub) in appropriate ways, to check each flow. src/main/java/com/amihaiemil/charles/github/GeneralPreconditionsCheck.java rultor me@rultor.com 243 241 30 IMP 241-12bd8c89 39-40 Pull out the system proerties, same as was done in the aws layer, to simplify the unit tests. src/main/java/com/amihaiemil/charles/github/Tweet.java amihaiemil amihaiemil@gmail.com 258 255 30 IMP 255-54364d10 36-38 Get rid of this POJO and turn it into a smart class, same as it was done with SearchResult. Update and unignore tests in CharlesResourceTestCase when its done. src/main/java/com/amihaiemil/charles/rest/model/SearchResultsPage.java amihaiemil amihaiemil@gmail.com 260 250 60 IMP 250-3323e69b 57-58 Implement the delete page knowledge. We have the repo method and unit test for it. Continue with the language, knowledge and steps. src/main/java/com/amihaiemil/charles/aws/AmazonEsRepository.java amihaiemil amihaiemil@gmail.com 261 250 30 IMP 250-d7d97575 59-60 Rename this class to Index (since that's what it is), and remove AmazonEsSearch class, moving the search method here src/main/java/com/amihaiemil/charles/aws/AmazonEsRepository.java amihaiemil amihaiemil@gmail.com