166 161 0 DEV 161-af52ca76 25-27 Modify ctor to accept the Login interface. This interface must be propagated to collaborators through their ctors. Wrap the given login in the new CachedLogin implementation. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 196 166 0 DEV 166-496efef5 25-26 Continue making all implementations accept a Login instead of a Session. Wrap the given login in the new CachedLogin implementation. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 168 164 0 DEV 164-782b906d 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. pom.xml George Aristy george.aristy@gmail.com 171 168 0 DEV 168-5f0e7803 203-205 Continued: <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. pom.xml George Aristy george.aristy@gmail.com 173 171 0 DEV 171-ffcedfbe 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 175 173 0 DEV 173-ffcedfbe 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 177 175 0 DEV 175-ffcedfbe 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 179 177 0 DEV 177-ffcedfbe 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 181 179 0 DEV 179-ffcedfbe 203-205 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 183 181 0 DEV 181-ffcedfbe 426-428 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 186 183 0 DEV 183-ffcedfbe 426-428 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 188 186 0 DEV 186-ffcedfbe 426-428 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 190 188 0 DEV 188-ffcedfbe 426-428 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 192 190 0 DEV 190-ffcedfbe 426-428 <sourceDirectory> should be '${basedir}/src' in order to include test sources in the checks, but there are MANY failures triggered there. Will need to fix those step by step. Keep going. pom.xml George Aristy george.aristy@gmail.com 204 202 0 DEV 202-33686010 35-37 Continue using llorllale/cactoos-matchers for tests where ever possible. Also, wherever possible, stop using static methods from Matcher and start using their object counterparts. src/test/java/org/llorllale/youtrack/api/CachedLoginTest.java George Aristy george.aristy@gmail.com 206 204 0 DEV 204-33686010 35-37 Continue using llorllale/cactoos-matchers for tests where ever possible. Also, wherever possible, stop using static methods from Matcher and start using their object counterparts. src/test/java/org/llorllale/youtrack/api/DefaultIssueTimeTrackingTest.java George Aristy george.aristy@gmail.com 219 206 0 DEV 206-33686010 35-37 Continue using llorllale/cactoos-matchers for tests where ever possible. Also, wherever possible, stop using static methods from Matcher and start using their object counterparts. src/test/java/org/llorllale/youtrack/api/DefaultIssueTimeTrackingTest.java George Aristy george.aristy@gmail.com 208 71 0 DEV 71-9315671c 27-29 Add an attribute to Attachment for its contents. This would return an InputStream with the attachment's contents. Add another attribute for the attachment's content-type. src/main/java/org/llorllale/youtrack/api/Attachment.java George Aristy george.aristy@gmail.com 216 208 0 DEV 208-edc51acf 34-37 The HTTP client configured for XmlIssue is the default one that only pools 2 connection that are not being released for reuse. Therefore the code hangs after a few calls to issue.attachments() and everything else accessible from there. This problem is probably present in the rest of the implementations. src/main/java/org/llorllale/youtrack/api/XmlIssue.java George Aristy george.aristy@gmail.com 222 216 0 DEV 216-3cbd571f 25-27 Even though DefaultHttpClient is pooling connections, we must take care to release each connection so that it can be reused. We should ensure that all Http entities are consumed and that all responses are closed, for example. src/main/java/org/llorllale/youtrack/api/DefaultClient.java George Aristy george.aristy@gmail.com 240 222 0 DEV 222-dda41031 26-31 Now that all HTTPClients and HTTPResponses are closeable, we need to start making sure that the underlying connections are being released when we are done with the http responses. For reference, read: - https://stackoverflow.com/a/31659073/1623885 - Sections 1.1.5 and 1.1.6 of https://hc.apache.org/httpcomponents-client-4.5.x/tutorial/html/fundamentals.html src/main/java/org/llorllale/youtrack/api/http/Client.java George Aristy george.aristy@gmail.com 244 240 0 DEV 240-d2ce6279 51-54 Concurrency tests have been implemented. However, the build is failing with errors internal to youtrack, similar to "jetbrains.exodus.ExodusException: Can't read full bytes from log [/opt/youtrack/data/youtrack] with address 1245184". After that is fixed, make sure all connections are released as per #240, and make sure these tests pass. src/test/java/org/llorllale/youtrack/api/ConcurrencyIT.java George Aristy george.aristy@gmail.com 223 216 0 DEV 216-2d921078 46-48 DefaultYoutrack is now taking in an HttpClient as parameter, and this client is being passed to some parts of the API implementations. Finish making all implementations accept this client. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 228 223 0 DEV 223-5ca94c9b 46-48 Continue making all implementations accept an HttpClient in order to enable concurrency. Right now major parts of the API are hanging when multiple threads are accessing them. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 231 228 0 DEV 228-5ca94c9b 46-48 Continue making all implementations accept an HttpClient in order to enable concurrency. Right now major parts of the API are hanging when multiple threads are accessing them. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 233 231 0 DEV 231-5ca94c9b 46-48 Continue making all implementations accept an HttpClient in order to enable concurrency. Right now major parts of the API are hanging when multiple threads are accessing them. src/main/java/org/llorllale/youtrack/api/DefaultYouTrack.java George Aristy george.aristy@gmail.com 217 208 0 DEV 208-1962a091 87-91 The YouTrack API inside the test docker container is returning 'fileUrl/@url' without the mapped port number for the docker container. This is probably because the service inside uses port 80. Figure out a way to make it so that the returned '@url' is a URL that can be readily accessed from outside the container, and then un-ignore this test. src/test/java/org/llorllale/youtrack/api/XmlAttachmentIT.java George Aristy george.aristy@gmail.com 209 71 0 DEV 71-9c1a88dc 25-26 Implement Attachments interface. It is a stream (as anticipated in #200), and will in the future support creation of attachments. src/main/java/org/llorllale/youtrack/api/Attachments.java George Aristy george.aristy@gmail.com