3 1 0 DEV 1-919cdc44 53-56 Enable this configuration after this golangci-lint issue is fixed: https://github.com/golangci/golangci-lint/issues/397. According to the golangci-lint docs, this config is desirable since the CI build should not be required to update go.mod. .golangci.yml @llorllale george.aristy@gmail.com 9 4 0 DEV 4-2f6700f4 10-12 The path should be passed in as a command line flag instead of being hard coded. All other configuration options should be passed in through CLI as well. cmd/go-gitlint/main.go @llorllale george.aristy@gmail.com 23 9 0 DEV 9-05e94b28 26-29 Global variables are a code smell (especially those in filterse.go). They promote coupling across different components inside the same package. Figure out a way to remove these global variables. Whatever command line parser we choose should be able to auto-generate usage. cmd/go-gitlint/main.go @llorllale george.aristy@gmail.com 10 4 0 DEV 4-dc893088 13-17 Figure out how to disable the golint check that forces us to write redundant comments of the form 'comment on exported type Commits should be of the form "Commits ..." (with optional leading article)' and rewrite all comments. internal/commits/commits.go @llorllale george.aristy@gmail.com 11 4 0 DEV 4-faa799fb 28-30 These err checks are extremely annoying. Figure out how to handle them elegantly and reduce the cyclo complexity of this function (currently at 4). internal/commits/commits.go @llorllale george.aristy@gmail.com 12 4 0 DEV 4-03485093 48-50 Figure out how to split the commit's message into a subject and a body. I believe the separator is the first instance of the CRLFCRLF sequence. internal/commits/commits.go @llorllale george.aristy@gmail.com 18 16 0 DEV 16-e0d2cf8f 22-24 The coverage script is ignoring packages that are not tested at all (0% coverage). It should be fixed so that all packages are tested (except for main). check_coverage.sh @llorllale george.aristy@gmail.com 34 31 0 DEV 31-07b6963e 37-40 Function issues.Filters() can be removed by providing default values for each filter that will effectively render them disabled. For example, OfSubjectRegex() can be effectively disabled by using ".*" as regex. internal/issues/filters.go @llorllale george.aristy@gmail.com 55 53 0 DEV 53-2f5f2d13 3-5 upgrade golangci-lint-version to 1.18.x once their docker image is ready - see https://github.com/golangci/golangci-lint/issues/682. For now, linting on local is against 1.18.x vs their service on 1.17.x. .golangci.yml @llorllale george.aristy@gmail.com