20730DEV7-0cc4122b43-47
All the matchers should implement describeMismatchSafely and their tests must verify that the implementation of the descriptions are satisfactory. The matchers should not expose publicly the xxxSafely method and the tests should rely on actual real use with assertThat. See ScalarHasValueTest for an example of a satisfactory result.
src/main/java/org/llorllale/cactoos/matchers/InputHasContent.javaVictor Noëlvictor.noel@crazydwarves.org2302030DEV20-e1bad07843-45
Replace all the tests in this file that are directly calling the match and mismatch methods of Throws with tests that uses Mismatches instead.
src/test/java/org/llorllale/cactoos/matchers/ThrowsTest.javaVictor Noëlvictor.noel@crazydwarves.org363230DEV32-2540e9c864-66
Add the opportunity to print the exp values to the description in order to avoid abstract message like "The function applied to X,Y,Z is failed".
src/main/java/org/llorllale/cactoos/matchers/HasValues.javarultorme@rultor.com443630DEV36-7ebfe74b47-49
HasValuesMatching that accepts matching function. For example, the "non-null", "startWith", "endsWith", "greaterThan" etc. The HasValue matcher should work only with pre-defined set of expected items
src/main/java/org/llorllale/cactoos/matchers/HasValues.javaYurii Dubinkayurii.dubinka@gmail.com373230DEV32-59ea151963-67
Matcher to test {@link org.hamcrest.Matcher} objects. In order to check the matchers we should verify that - error message is correct in case false status - the status of testing is correct itself. The possible name - {@code IsMatcherOf}.
src/test/java/org/llorllale/cactoos/matchers/HasValuesTest.javarultorme@rultor.com521830DEV18-b493cd8971-73
Replace all uses of MatcherAssert.assertThat() with Assertion, and ban all overloads of the former in forbidden-apis.txt. We should also look into banning common matchers like Matchers.is(), etc.
src/main/java/org/llorllale/cactoos/matchers/Assertion.javaGeorge Aristygeorge.aristy@gmail.com805230DEV52-f2eb48e240-42
Ban all overloads of the former in forbidden-apis.txt. We should also look into banning common static matchers like Matchers.is(), etc.
src/test/java/org/llorllale/cactoos/matchers/EndsWithTest.java@dgroupyurii.dubinka@gmail.com998030DEV80-ce342b3c40-42
We should also look into banning common static matchers like Matchers.is(), etc. Those static matchers should be added to the forbidden-apis.txt file.
src/test/java/org/llorllale/cactoos/matchers/EndsWithTest.java@rultorme@rultor.com815230DEV52-ccaad1a238-40
Replace all uses of MatcherAssert.assertThat() with Assertion. Ensure that the tests behavior wasn't changed during this refactoring. Each test should have single Assertion statement.
src/test/java/org/llorllale/cactoos/matchers/TextIsTest.java@dgroupyurii.dubinka@gmail.com848130DEV81-ccaad1a243-45
Replace all uses of MatcherAssert.assertThat() with Assertion. Ensure that the tests behavior wasn't changed during this refactoring. Each test should have single Assertion statement.
src/test/java/org/llorllale/cactoos/matchers/ScalarHasValueTest.javaigorceigor94@gmail.com531830DEV18-a9679abd74-77
Assertion relies on the operation under test to be idempotent in order to match "error matchers" such as `Throws` as expected. This may not be the case for all operations and could be a problem. Investigate if there's a way around/through this.
src/main/java/org/llorllale/cactoos/matchers/Assertion.javaGeorge Aristygeorge.aristy@gmail.com885330DEV53-0c767106111-115
Avoid the overloading ctor to accept subtype. Throws is a Matcher and thus there should be no need to give it a special treatment. The fact that we're currently being forced to do so smells, and might mean we may end up having to rethink these abstractions.
src/main/java/org/llorllale/cactoos/matchers/Assertion.java@dgroupyurii.dubinka@gmail.com1108830DEV88-bbf98b5667-69
Phase out the original Assertion class and replace with Assertion2 instead. When done, delete the original Assertion and rename Assertion2 to 'Assertion'.
src/main/java/org/llorllale/cactoos/matchers/Assertion2.java@llorllalegeorge.aristy@gmail.com11311030DEV110-bae5f26c67-69
Continue phasing out the original Assertion class and replacing with Assertion2 instead. When done, delete the original Assertion and rename Assertion2 to 'Assertion'.
src/main/java/org/llorllale/cactoos/matchers/Assertion2.java@llorllalegeorge.aristy@gmail.com11611330DEV113-840654f667-69
Delete the original Assertion and rename Assertion2 to 'Assertion'. Then refactor all uses of 'Assertion2' to switch back to Assertion again.
src/main/java/org/llorllale/cactoos/matchers/Assertion2.java@llorllalegeorge.aristy@gmail.com541630DEV16-acf734f939-42
Extends the envelope in TextIs, TextHasString, StartsWith, EndsWith. Most of operations with text like startsWith, endsWith, contains, equals, etc has the same algorithm. There is only difference in the function which should be applied to text.
src/main/java/org/llorllale/cactoos/matchers/TextMatcherEnvelope.javaYurii Dubinkayurii.dubinka@gmail.com603530DEV35-b5eec46c72-86
The TextMatcherEnvelope should support the description for actual/expected values separately. For example, for now we are using single `TextMatcherEnvelope#TextMatcherEnvelope(Matcher, String)` description object which describe actual/expected objects and leads to uninformative message in case of failure of MatchesRegexp. For example <pre>{@code java.lang.AssertionError: Expected: Text matches "^.*know\sit\.$" but: Text matches "I'm simple." }</pre> Its better to have this error message <pre>{@code java.lang.AssertionError: Expected: Text matches "^.*know\sit\.$" but: Text is "I'm simple." }</pre>
src/test/java/org/llorllale/cactoos/matchers/MatchesRegexTest.javaYurii Dubinkayurii.dubinka@gmail.com685830DEV58-b44e1a4446-48
Delete TeeInputHasResult from the library. It's too specific. Users should use InputHasContent instead. Should be moved to test packages in cactoos.
src/main/java/org/llorllale/cactoos/matchers/TeeInputHasResult.java@rultorme@rultor.com695830DEV58-21ae45f336-38
NotBlank should be changed to `IsBlank`. Users should be able to negate it by simply decorating it with `IsNot`. Update the README once done.
src/main/java/org/llorllale/cactoos/matchers/NotBlank.java@rultorme@rultor.com937530DEV75-33ff510137-39
Remove checkstyle suppression when qulice will fix this issue See https://github.com/teamed/qulice/issues/985. When new version will be released, update qulice and remove this puzzle.
src/main/java/org/llorllale/cactoos/matchers/InputHasContent.java@rultorme@rultor.com947530DEV75-c754358f43-45
Refactor other matchers to extend MatcherEnvelope. If you do not know how to do it please refer to InputHasContent class as the example.
src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java@rultorme@rultor.com1209430DEV94-c754358f43-45
Refactor other matchers to extend MatcherEnvelope. If you do not know how to do it please refer to InputHasContent class as the example.
src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java@vzurauskaszurauskas.vytautas@gmail.com12912030DEV120-c754358f43-45
Refactor other matchers to extend MatcherEnvelope. If you do not know how to do it please refer to InputHasContent class as the example.
src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.javaVictor Noëlvictor.noel@crazydwarves.org13912930DEV129-c754358f43-45
Refactor other matchers to extend MatcherEnvelope. If you do not know how to do it please refer to InputHasContent class as the example.
src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.javaVictor Noëlvictor.noel@crazydwarves.org1219430DEV94-45419d5247-50
Write unit tests for MatcherEnvelope. Create MatcherEnvelopeTest class and write tests to cover the whole functionality. Since MatcherEnvelope is abstract, create a private nested child class and use it for tests.
src/main/java/org/llorllale/cactoos/matchers/MatcherEnvelope.java@vzurauskaszurauskas.vytautas@gmail.com1146530DEV65-01fd604238-41
Add two more tests for the mismatch message, testing both the case when a key is absent and a value is incorrect, if possible using the Mismatches Matcher introduced by https://github.com/llorllale/cactoos-matchers/issues/106.
src/test/java/org/llorllale/cactoos/matchers/HasEntryTest.java@rultorme@rultor.com13610630DEV106-7cce08fb55-57
Convert all the Matcher tests to use Mismatches instead of checking directly the output of mismatch methods or the exception of Assertion.
src/main/java/org/llorllale/cactoos/matchers/Mismatches.javaVictor Noëlvictor.noel@crazydwarves.org16413630DEV136-fc001f3f31-34
Replace the combination of IsNot and Matches with Mismatches. This combination does not check textual output of Matcher, only boolean value. It's up for discussion if checking the output is too exhaustive or not, leave a comment to this task clarify that.
src/main/java/org/llorllale/cactoos/matchers/package-info.java@rultorme@rultor.com13710630DEV106-33b58c3758-61
Add extra tests for this class to validate all the different constructors (also add a constructor taking message as a String) and ensure they are coherent with how Assertion is working and throwing errors.
src/main/java/org/llorllale/cactoos/matchers/Mismatches.javaVictor Noëlvictor.noel@crazydwarves.org13810630DEV106-02263f65131-133
Add a description in case the mismatch fails. And then introduce some tests to validate that the description is properly constructed.
src/main/java/org/llorllale/cactoos/matchers/Mismatches.javaVictor Noëlvictor.noel@crazydwarves.org14613330DEV133-30a4a37a73-76
Currently MatchesBefore directly throws a TimeoutException but instead it should populate the mismatch message so that it can be properly tested with Mismatches. Unignore and update this test to validate it is correctly implemented
src/test/java/org/llorllale/cactoos/matchers/MatchesBeforeTest.javaVictor Noëlvictor.noel@crazydwarves.org1606730DEV67-1f1425d470-73
Assertion should rely on mismatch description when forming error message (as assertThat does). Currently 'was' is being used by this class as part of description, it causes duplication of the word with Matchers derived from BaseMatcher, such as IsEqual.
src/main/java/org/llorllale/cactoos/matchers/Assertion.java@rultorme@rultor.com16513530DEV135-e0b9c88649-51
Remove all constructors except the last one so that every matcher implemented using MatcherOf take care of properly describe itself and the mismatch.
src/main/java/org/llorllale/cactoos/matchers/MatcherOf.java@rultorme@rultor.com22416530DEV165-d4e7ec1b58-60
We need an InputMatcher similar to {@link TextMatcher} that would be in charge of caching the value of the {@link Input} so that it is ready only once per invocation of the {@link Matcher}.
src/main/java/org/llorllale/cactoos/matchers/HasContent.java@baudoliver7baudolivier.oura@gmail.com22516530DEV165-c099c2ad51-52
Introduce a ComparatorMatcher that encapsulates comparison logic here. It would only take a {@code Comparator<X>} and an expected X for example.
src/main/java/org/llorllale/cactoos/matchers/IsNumber.java@baudoliver7baudolivier.oura@gmail.comunknown141130DEV1411-6ab8391578-81
Migrate existing tests to JUnit 5. It mainly means changing the imports and move from Ignore to Disabled annotation as well as replace rules with corresponding annotations. Once this is done remove the dependency for junit 4 and junit-vintage-engine below.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org17016230DEV162-6ab8391578-81
Migrate existing tests to JUnit 5. It mainly means changing the imports and move from Ignore to Disabled annotation as well as replace rules with corresponding annotations. Once this is done remove the dependency for junit 4 and junit-vintage-engine below.
pom.xmlVictor Noëlvictornoel@users.noreply.github.com1758330DEV83-98884b9040-42
Add windows-2019 to the test matrix after fixing quite a few errors happening on windows. Don't forget to add it to the list of required status checks in the repo's settings. See errors in the build log: https://github.com/llorllale/cactoos-matchers/runs/1082946792.
.github/workflows/build.yml@llorllalegeorge.aristy@gmail.com22015930DEV159-5a01dc84162-169
This plugin execution was disabled (phase was set to `package` before) because it prevents cactoos from actually using cactoos-matchers since the interfaces provided by cactoos (`Text`, `Func`, `Scalar`, etc) and those expected by cactoos-matchers do no match! Let's find a solution to this situation (not shading the interfaces for example?) and re-enable this plugin. The best solution should be discussed with ARC in this todo's ticket.
pom.xmlVictor Noëlvictor.noel@crazydwarves.org