95 35 0 DEV 35-1174530b 43-48 Remove code duplications. The CompositeErNamedClass#complaints and CompositeErNamedClass#checkWithErNamedClassRule are code duplication from CompositeMethodsContainsAssignment. Refactoring is necessary. */ src/main/java/ru/l3r8y/rule/CompositeErNamedClass.java @h1alexbel hialexbel@gmail.com 96 81 0 DEV 81-df86a8f4 92-95 Introduce new class from #checkLongName private method. we should introduce new reusable class from private method #checkLongName. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/rule/CompositeLongClassName.java @h1alexbel hialexbel@gmail.com 97 35 0 DEV 35-ba2ad0f0 35-38 Annotations to skip rule. It is necessary to create an annotation for cases when the suffix '-er' cannot be avoided. */ src/main/java/ru/l3r8y/rule/ErNamedClass.java @h1alexbel hialexbel@gmail.com 98 81 0 DEV 81-f6754283 71-74 Introduce new class from #longerThanOk private method. we should introduce new reusable class from private method #longerThanOk. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/rule/LongClassNameCheck.java @h1alexbel hialexbel@gmail.com 99 1 0 DEV 1-e874a893 25-26 Write implementation to pass #failsWithoutThisKeyword test case Assigment must fails not only with 'this.' construction. src/test/java/ru/l3r8y/rule/MethodContainsAssigmentTest.java @h1alexbel hialexbel@gmail.com 115 38 0 DEV 38-1ad8783b 40-44 This class is too complex. We should decompose it on many small, cohesive objects. What's missing: an object for singe/many suppression check, this object will just aggregate all suppressions. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/parser/SuppressedChecks.java @h1alexbel hialexbel@gmail.com 116 38 0 DEV 38-d8ac8ec9 45-49 This class lacks off unit testing. ClassOrInterfaceDeclaration can't be provided in tests, so we need to do something with it in order to create small unit tests for this and other classes (see puzzle above). Don't forget to remove this puzzle. src/main/java/ru/l3r8y/parser/SuppressedChecks.java @h1alexbel hialexbel@gmail.com 117 38 0 DEV 38-7c44aa58 38-41 Implement Linked decorator for Rule. We should implement decorator for Rule that attaches the link to the message. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/rule/ErSuffixCheck.java @h1alexbel hialexbel@gmail.com 126 85 0 DEV 85-49dfa7ce 82-85 Make new class instead. Let's make a new class that will do the same what we are doing with class names but with methods. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/parser/ClassMethods.java @rultor me@rultor.com 127 85 0 DEV 85-415b3791 86-88 Resolve all available checks into one list. Let's merge all checks we got from ClassNames and here, ClassMethods. Merge them and resolve. src/main/java/ru/l3r8y/parser/ClassMethods.java @rultor me@rultor.com 128 85 90 DEV 85-56f28e18 68-72 Fetch check names from rule/* package (or check/*). Instead of hard-coding, we should fetch the ruleset from related package. Don't forget to remove this puzzle. src/main/java/ru/l3r8y/parser/ClassNames.java @rultor me@rultor.com