unknown1-40eeff881src/test/java/com/jcabi/http/mock/MkContainerTest.java73-7430DEVunknownunknown@0pdd.com
Grizzly container doesn't understand same-name headers, or we don't fetch them correctly from GrizzlyRequest
unknown19-aa7a749719src/main/java/com/jcabi/http/mock/MkContainer.java64-6630DEVunknownunknown@0pdd.com
Let's introduce a utility class MkQueryMatchers which contains convenience methods for matching MkQuery objects. This is primarily intended for use with the conditional MkContainer.next() methods. For example:
unknown19-a877bdce19src/main/java/com/jcabi/http/mock/MkContainer.java87-8930DEVunknownunknown@0pdd.com
Let's add methods take(Matcher ) and takeAll(Matcher
), and a utility class MkAnswerMatchers. Intended usage is as follows:
unknown1-5ecf8bb21src/test/java/com/jcabi/http/response/JsoupResponseTest.java50-5330DEVunknownunknown@0pdd.com
Saxon complains about HTML 1.0, and I'm not sure how this is possible to fix. All we need to check in this test is that the output is a clean HTML document. Aparently JSOUP produces a broken HTML? Let's investigate and fix.
unknown90-35dd830e90src/main/java/com/jcabi/http/wire/LastModifiedCachingWire.java46-4730
If the original request already has an If-Modified-Since header it should be sent directly.
IMPIgor Piddubnyiigor.piddubnyi@solvians.com12090-f5d7f05d90src/main/java/com/jcabi/http/wire/LastModifiedCachingWire.java141-14230
Evict cache entry if If-Modified-Since request responded with HTTP_OK code and no Last-Modified header.
IMPIgor Piddubnyiigor.piddubnyi@solvians.com161120-e6bf947f120src/test/java/com/jcabi/http/wire/LastModifiedCachingWireTest.java62-6915
Clean tests shared fields and redundant variables Move constants in this file to their tests because tests must share nothing. Then also inline any redundant variables. Please also configure pdd and est in.travis.yml as done e.g. in https://github.com/jcabi/jcabi-xml/blob/master/.travis.yml For first points explanation, read: http://www.yegor256.com/2016/05/03/test-methods-must-share-nothing.html http://www.yegor256.com/2015/09/01/redundant-variables-are-evil.html
IMPAlan Evansthealanevans@googlemail.com162120-2756c8f7120src/test/java/com/jcabi/http/wire/LastModifiedCachingWireTest.java211-21930
Confirm cache clearing behaviour in all non-OK responses Non-OK behaviour was not specified in #120, so for example, if the response is 404 as below, does it make any sense to keep the item in cache? Is it likely a server will respond 404, and then later the exact unmodified content is available again. I think they all need to be thought about, another dubious response might be 301 Moved Permanently, or 410 Gone etc. Or, personally I think all non-OK and OK responses should behave the same WRT to clearing the cache as the cache value is so unlikely to be returned in future.
IMPAlan Evansthealanevans@googlemail.com16387-5547b01687src/main/java/com/jcabi/http/request/BaseRequest.java69-7630
Refactor this class to get rid of PMD.GodClass. This can be done if MultiPartFormBody and FormEncodedBody are pulled out. Also, the two share the same implementations for all methods besides formParam, so they can be refactored to extend an AbstractRequestBody. PMD.TooManyMethods might come together with getting rid of the first one, since maybe qulice is counting the methods in the inner classes too - if it doesn't, then it can be left.
IMPamihaiemilamihaiemil@gmail.com16487-bd2cb40187src/main/java/com/jcabi/http/request/BaseRequest.java470-47660
Implement and unit test method formParam(String, Object) Details
here
(second answer).
e.g. While FormEncodedBody.formParam adds the param to a body with enctype application/x-www-form-urlencoded, method MultipartFormBody.formParam should add it to a body with enctype multipart/form-data.
IMPamihaiemilamihaiemil@gmail.com19417130DEV171-f8bc6a22113-117
Transitive dependencies for hamcrest 1.3 and junit 4 comes from this dependency. 1) Upgrade jcabi-matchers to the same version of parent as jcabi-http. 2) Replace hamcrest 1.3 with hamcrest 2.2 (?) from parent 3) Replace junit 5 with junit 5
pom.xmlandreossandreoss@sdf.org19517130DEV171-01da2b80151-157
Migrate all simple tests to Junit 5. For the sake of smaller PRs, migration can be done in steps 1) All tests classes without @Rule, and @Test(expected = ...) 2) All parameterized tests classes 3) The rest, (i.e dependent on @Rule's and so on) After completing one of the steps, create a new puzzle for the next. After all tests are run by Junit 5 remove this dependency.
pom.xmlandreossandreoss@sdf.org19919530DEV195-eea7018e151-155
Migrate the rest of tests to Junit 5. For the sake of smaller PRs, migration can be done in steps 1) Parameterized tests classes 2) Tests dependent on ExpectedException, or @Test(expected= ...) After all tests are run by Junit 5 remove this dependency.
pom.xmlandreossandreoss@sdf.org20619930DEV199-1532b845151-152
Migrate Junit 5 tests dependent on ExpectedException to Junit 5. After all tests are run by Junit 5 remove this dependency.
pom.xmlandreossandreoss@sdf.org21020630DEV206-f355129443-45
Use assertThrows instead of try/catch/match. Some of the tests use try/catch in orted to test caught Exception. Replace them with assertThrows.
src/test/java/com/jcabi/http/response/JsonResponseTest.javaandreossandreoss@sdf.org20220030DEV200-8bafc4f468-70
TrustedWire does not support ApacheRequest. Investigate if it's possible for them to work together, if not see jcabi-http#178 for discussion about alternative solutions.
src/main/java/com/jcabi/http/request/ApacheRequest.javaandreossandreoss@sdf.org20712630DEV126-c5eb9db3173-176
Grizzly Server has native mechanism for port reservation. See https://github.com/eclipse-ee4j/grizzly/issues/1001. Use it and remove this method, field for port probably can be removed as well. This should eventually close jcabi-http#116.
src/main/java/com/jcabi/http/mock/MkGrizzlyContainer.java@rultorme@rultor.com2159730DEV97-5ddd435568-70
Strip user info from URI after Auth header is added. Consider adding warnings about the wire applied for Request with header, and without user info.
src/main/java/com/jcabi/http/wire/BasicAuthWire.javaandreossandreoss@sdf.org22217930DEV179-2a86065085-88
This implementation depends on Guava. Investigate for a possible shared interface between this class and other implementations for caching. If this shared interface is possible replace this task with a task for implementing it.
src/main/java/com/jcabi/http/wire/CachingWire.javaandreossandreoss@sdf.org