15 0 0 DEV 0-7ae6cd57 26-26 extract these `Running` and `Exiting` logs to some scheduled decorator src/main/java/dev/iakunin/codexiabot/codexia/cron/ProjectsHealthCheck.java Maksim Iakunin iakunin@users.noreply.github.com 16 0 0 DEV 0-2d57295c 19-20 rewrite in much common way: `List<GithubRepo> findAllExistsInAllSources(Set<Source> sources)` and remove `findAllInCodexiaAndHackernews()` and `findAllInCodexia()` methods src/main/java/dev/iakunin/codexiabot/github/GithubModule.java Maksim Iakunin iakunin@users.noreply.github.com 19 6 0 DEV 6-02060b89 11-16 split codexiaModule.sendReview() to codexiaModule.createReview() and codexiaModule.sendReview() - codexiaModule.createReview() - just a saving to DB. - codexiaModule.sendReview() - real sending review to Codexia api. - codexiaModule.sendReview() must be used ONLY inside a cron-job. - In other code there should be only a codexiaModule.createReview() calls. - All the codexiaModule.createReview() calls MUST be inside a transaction/ src/main/java/dev/iakunin/codexiabot/codexia/CodexiaModule.java Maksim Iakunin iakunin@users.noreply.github.com 39 19 0 DEV 19-703b27a3 11-11 All the codexiaModule.createReview() calls MUST be inside a transaction src/main/java/dev/iakunin/codexiabot/codexia/CodexiaModule.java Maksim Iakunin iakunin@users.noreply.github.com 40 19 0 DEV 19-ec246873 14-15 sending meta should also be asynchronous (via cron) here should be only a saving Meta (as saving Review) src/main/java/dev/iakunin/codexiabot/codexia/CodexiaModule.java Maksim Iakunin iakunin@users.noreply.github.com 41 19 0 DEV 19-799ed7e1 88-88 rewrite via custom Feign exceptions src/main/java/dev/iakunin/codexiabot/codexia/cron/SendReviews.java Maksim Iakunin iakunin@users.noreply.github.com 20 6 0 DEV 6-ba4d7ce3 73-73 write tests for different timezones src/main/java/dev/iakunin/codexiabot/codexia/sdk/CodexiaClient.java Maksim Iakunin iakunin@users.noreply.github.com 21 6 0 DEV 6-5af20361 75-75 replace `Date` with `ZonedDateTime` src/main/java/dev/iakunin/codexiabot/codexia/sdk/CodexiaClient.java Maksim Iakunin iakunin@users.noreply.github.com 22 6 0 DEV 6-af8b3d4f 36-43 choose better created_at postgres-format (with or without TZ). Also think of ZonedDateTime in createdAt field. ZonedDateTime + timestamptz seems the best way. - Test changing of postgres server timezone. - Test changing of hibernate.time_zone property. - Test changing of JVM timezone. In all of these cases there MUST be valid timestamptz in postgres. In all of these cases there MUST be valid ZonedDateTime in code. src/main/java/dev/iakunin/codexiabot/common/entity/AbstractEntity.java Maksim Iakunin iakunin@users.noreply.github.com 23 6 0 DEV 6-57333c2d 97-97 get rid of FoundOnReddit.TmpDto using `org.javatuples.Pair` src/main/java/dev/iakunin/codexiabot/bot/FoundOnReddit.java Maksim Iakunin iakunin@users.noreply.github.com 24 6 0 DEV 6-cae02d85 113-113 get rid of FoundOnHackernews.TmpDto using `org.javatuples.Pair` src/main/java/dev/iakunin/codexiabot/bot/FoundOnHackernews.java Maksim Iakunin iakunin@users.noreply.github.com 25 6 0 DEV 6-4d9a1ad5 73-73 add test case with transaction rollback src/main/java/dev/iakunin/codexiabot/bot/StarsUp.java Maksim Iakunin iakunin@users.noreply.github.com 26 6 0 DEV 6-facd1e77 52-52 extract to json-file src/test/java/dev/iakunin/codexiabot/codexia/cron/ProjectsHealthCheckIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 27 6 0 DEV 6-3551727a 13-14 this DataTypeFactory should be pull-requested to dbunit for more info see https://github.com/database-rider/database-rider/issues/102#issuecomment-511241871 src/test/java/dev/iakunin/codexiabot/dbunit/CustomPostgresqlDataTypeFactory.java Maksim Iakunin iakunin@users.noreply.github.com 52 50 0 DEV 50-620293b3 69-69 TooManyStars: add test case with transaction rollback src/main/java/dev/iakunin/codexiabot/bot/TooManyStars.java Maksim Iakunin iakunin@users.noreply.github.com 54 10 0 DEV 10-d0e206d9 98-98 Get rid of TooManyStarsResult - Review is enough (see FoundOnHackernews) src/main/java/dev/iakunin/codexiabot/bot/TooManyStars.java Maksim Iakunin iakunin@users.noreply.github.com 55 10 0 DEV 10-5ffba3e0 18-18 Implement MissingFillerIntegrationTest src/test/java/dev/iakunin/codexiabot/codexia/cron/MissingFillerIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 56 10 0 DEV 10-c5423926 18-18 Implement ResendErroneousReviewsIntegrationTest src/test/java/dev/iakunin/codexiabot/codexia/cron/ResendErroneousReviewsIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 57 10 0 DEV 10-137a4b3c 18-18 Implement CodexiaParserIntegrationTest src/test/java/dev/iakunin/codexiabot/codexia/cron/CodexiaParserIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 58 10 0 DEV 10-6d9090eb 11-11 Implement LinesOfCodeIntegrationTest src/test/java/dev/iakunin/codexiabot/github/cron/stat/LinesOfCodeIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 59 10 0 DEV 10-e69f73e3 11-11 Implement GithubIntegrationTest src/test/java/dev/iakunin/codexiabot/github/cron/stat/GithubIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 60 10 0 DEV 10-d5175438 11-11 Implement ParserIntegrationTest src/test/java/dev/iakunin/codexiabot/reddit/cron/ParserIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 61 10 0 DEV 10-f8a4ea3e 11-11 Implement RetryErroneousIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/RetryErroneousIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 62 10 0 DEV 10-a0a04470 11-11 Implement GapsFillerIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/GapsFillerIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 63 10 0 DEV 10-3ebb1a8d 11-11 Implement ItemsHealthCheckIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/ItemsHealthCheckIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 64 10 0 DEV 10-2ff894fd 11-11 Implement IncrementedParserIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/IncrementedParserIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 74 66 0 DEV 66-1eb62372 11-11 Implement AllItemsIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/healthcheck/AllItemsIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 167 74 0 DEV 74-721dfe5c 23-24 AllItems: get rid of this @Transactional spike to do so it's necessary to get rid of Stream<> in repository src/main/java/dev/iakunin/codexiabot/hackernews/cron/healthcheck/AllItems.java iakunin iakunin@users.noreply.github.com 168 74 0 DEV 74-fdc38b44 26-27 GapsFiller: get rid of this @Transactional spike to do so it's necessary to get rid of Stream<> in repository src/main/java/dev/iakunin/codexiabot/hackernews/cron/GapsFiller.java iakunin iakunin@users.noreply.github.com 75 66 0 DEV 66-331f2e6f 11-11 Implement CodexiaItemsIntegrationTest src/test/java/dev/iakunin/codexiabot/hackernews/cron/healthcheck/CodexiaItemsIntegrationTest.java Maksim Iakunin iakunin@users.noreply.github.com 89 85 0 DEV 85-a7ac8fa2 15-15 Remove this cron after https://github.com/yegor256/codexia/issues/98 is done src/main/java/dev/iakunin/codexiabot/codexia/cron/ResendReviewsUntilDuplicated.java Maksim Iakunin iakunin@users.noreply.github.com 130 92 0 DEV 92-3a978031 26-26 make this class generic `<T extends AbstractStat>` src/main/java/dev/iakunin/codexiabot/github/entity/GithubRepoStat.java iakunin iakunin@users.noreply.github.com 131 92 0 DEV 92-312fe964 41-41 replace with FirstOf with 2-arg-ctor when it's merged to cactoos src/main/java/dev/iakunin/codexiabot/bot/toosmall/ExactItem.java iakunin iakunin@users.noreply.github.com 132 92 0 DEV 92-160d1a52 85-85 extract this class to cactoos and replace when it's merged src/main/java/dev/iakunin/codexiabot/bot/toosmall/ExactItem.java iakunin iakunin@users.noreply.github.com 133 92 0 DEV 92-2cd03fd8 13-13 collapse all *CronConfig classes into as inner class of * src/main/java/dev/iakunin/codexiabot/bot/config/TooSmallCronConfig.java iakunin iakunin@users.noreply.github.com 134 92 0 DEV 92-4d3ad9b9 98-98 Small: add test case with transaction rollback src/main/java/dev/iakunin/codexiabot/bot/Small.java iakunin iakunin@users.noreply.github.com 140 136 0 DEV 136-5f5351ff 8-9 replace this class with just ScalarWithFallback when `cactoos` new version is released src/main/java/dev/iakunin/codexiabot/bot/toosmall/FallbackFromNull.java iakunin iakunin@users.noreply.github.com 198 186 0 DEV 186-f76ca369 24-24 CodexiaReviewRepository: Get rid of this query completely src/main/java/dev/iakunin/codexiabot/codexia/repository/CodexiaReviewRepository.java iakunin iakunin@users.noreply.github.com 199 186 0 DEV 186-4b57b47d 31-31 GapsFiller get rid of this heavy SQL src/main/java/dev/iakunin/codexiabot/hackernews/cron/GapsFiller.java iakunin iakunin@users.noreply.github.com 205 150 0 DEV 150-f69aa10e 39-39 writer should be fault tolerant src/main/java/dev/iakunin/codexiabot/codexia/cron/CodexiaParser.java iakunin iakunin@users.noreply.github.com 209 93 0 DEV 93-d07124ac 65-65 LinesOfCodeImpl: rewrite via custom Feign exceptions src/main/java/dev/iakunin/codexiabot/github/service/LinesOfCodeImpl.java iakunin iakunin@users.noreply.github.com