28 9 25 DEV 9-8508d2b5 31-33 Create unit tests for home.rs. We need to create a few unit testes for home endpoints, bootstrapping, and fetching. Don't forget to remove this puzzle. src/routes/home.rs @l3r8yJ l3r8y@duck.com 43 13 15 DEV 13-97a91bb1 24-27 Handle port argument We should process the port argument and pass it to the server on `start` command. Start command should be added also with clap cli/src/args.rs @h1alexbel aliaksei.bialiauski@hey.com 76 43 30 DEV 43-8af1c1b2 53-57 Enable starts_server integration test. We should enable this integration test that checks whether server starts or not. This test should output success message in info!. For now it does not work. Probably some error with logging configuration. Don't forget to remove this puzzle. cli/tests/integration_test.rs Aliaksei Bialiauski aliaksei.bialiauski@hey.com 52 41 15 DEV 41-6875de44 28-31 Add --report argument. Let's add --report option for generating reports in desired formats: We should support following formats: xml, tex, and txt. User should have ability to generate report in multiple formats as well: --report tex,xml,txt. cli/src/args.rs @h1alexbel aliaksei.bialiauski@hey.com 53 41 60 DEV 41-a34da1fd 26-28 Add function for appending new content into the template. We need to create new function that will append input into the template, thus it will build a detailed report. server/src/report/latex.rs @h1alexbel aliaksei.bialiauski@hey.com 54 41 60 DEV 41-8e9aa4b2 53-56 Add support of @ExtendsWith from JUnit in order to pass expected as test parameter. We should use extensions in order to pass expected as parameters into test. If there is no crate with such functionality - let's develop and release one. server/src/report/latex.rs @h1alexbel aliaksei.bialiauski@hey.com 55 41 45 DEV 41-6165498f 22-24 Create similar to latex.rs functions for XML and TXT formats. Let's create similar to latex.rs functions for generating reports in XML and TXT. Don't forget to remove this puzzle. server/src/report/mod.rs @h1alexbel aliaksei.bialiauski@hey.com 57 35 45 DEV 35-caa80163 123-127 advisories.yml is broken. We can't compile an Open API spec with advisories.yml due to this error: -attribute (get).responses.200.content.'application/json'.schema. is not of type `object` (./paths/advisories.yml). This issue is critical, since it potentially affect all the endpoints containing same structure. Don't forget to remove this puzzle. github-api/github.yml @rultor me@rultor.com 73 17 40 DEV 17-2c1e333d 38-43 Apply XMLed user to the <users/> node in storage. We should apply XMLed user to the <users> XML node in storage. First we need to check that user with provided name does not exist, and only then apply it to the storage. Keep in mind that application function in the storage should be thread-safe (as well as #xml function). Don't forget to create unit tests that prove that. server/src/objects/user.rs @h1alexbel aliaksei.bialiauski@hey.com 74 17 30 DEV 17-e45e524d 44-46 Configure clippy to reject code with #unwrap(). We should prohibit to use #unwrap() function in our code. Let's configure clippy tool in the respective manner and get rid of all #unwrap() calls. server/src/objects/user.rs @h1alexbel aliaksei.bialiauski@hey.com 101 74 30 DEV 74-414ed44d 40-42 Find way to spread clippy config We need to find way to spread clippy/rustfmt configuration through all workspaces to reduce duplications in child workspaces. server/Cargo.toml @h1alexbel aliaksei.bialiauski@hey.com 75 17 35 DEV 17-1a69e44f 59-62 Implement #xml function in Storage. This function should return full XML storage has at the moment. #xml function should be thread-safe, as it intended to be used concurrently. Don't forget to create a unit tests related to #xml function. server/src/xml/storage.rs @h1alexbel aliaksei.bialiauski@hey.com 98 75 60 DEV 75-337ee33d 76-79 Make xml() thread-safe. We should make this function thread-safe in order to get sequential of reads and write to the store. Don't forget to create a unit-test that checks concurrency cases. server/src/xml/storage.rs @rultor me@rultor.com 99 75 35 DEV 75-712e2839 80-82 Prohibit to use `?` (question mark operator). Let's prohibit to use `?` as we did with `unwrap()`. Don't forget to remove this puzzle. server/src/xml/storage.rs rultor me@rultor.com 82 79 25 DEV 79-d0a80208 28-30 Add --v option for verbose output. Let's add --v option for verbose output and debug logs. When this option is passed, we should show debug logs too. cli/src/args.rs @rultor me@rultor.com 105 82 30 DEV 82-95c4782c 73-76 Enable runs_in_verbose_mode test. We should enable this test right after we find out how to shutdown the server in test. This problem is similar to https://github.com/h1alexbel/fakehub/issues/76. cli/tests/integration_test.rs @h1alexbel aliaksei.bialiauski@hey.com 83 79 30 DEV 79-e2ac5f1e 58-60 Log 404 NOT FOUND requests too. Let's create a handler that would log requests failed with 404. Let's use info!() for this one. server/src/lib.rs @rultor me@rultor.com 84 79 45 DEV 79-297c2dd6 30-33 Make mod/fn/struct documentation required. Let's configure cargo in such way, so documentation will be required at all levels. When such rule will be configured, please fix all warnings/errors and integrate changes into master branch. server/src/routes/home.rs rultor me@rultor.com 85 79 25 DEV 79-f3acfe10 26-29 Import assert_that!() macro like in lib.rs instead of assert_that. For some reason we can't use '#[macro_use] extern crate hamcrest;' inside this mod. We should figure out why and replace deprecated import with required macro. server/tests/routes_it.rs rultor me@rultor.com 86 79 35 DEV 79-c1f43fa7 35-37 Enable integration test case for home endpoint. For now this test does not work, because we can't abort the server. Let's implement it first inside lib.rs::Server struct and then enable this case. server/tests/routes_it.rs rultor me@rultor.com 87 79 25 DEV 79-11f081e9 38-40 Check home response from body. We should check that returned home body contains exactly the same response that in resources/home.json (expected). Don't forget this puzzle. server/tests/routes_it.rs rultor me@rultor.com 134 124 35 DEV 124-85a7849c 85-87 Pass fakehub to all required endpoints to be used. We should pass fakehub instance after Fakehub::default() into all places where we need to operate with data somehow. server/src/lib.rs @rultor me@rultor.com 135 124 90 DEV 124-97c33c98 61-65 Think about GitHub Enterprise GitHubs feature. Let's think about how we can simulate multiple GitHub instances like GitHub platform does with GitHub Enterprise feature. Fakehub should have multiple GitHubs inside, and user can pick to which GitHub he wants store the testing data. server/src/objects/fakehub.rs @rultor me@rultor.com 141 137 30 DEV 137-e669be66 75-79 Create NodeId object that will give MD5 hash. Almost in any response, including user, we should display Node ID as GitHub API does. Looks like they use MD5 for it. Let's do the same, but we need only one that hash, because only one instance can be run. Let's hash UTC datetime when server was bootstrapped. server/src/objects/user.rs @rultor me@rultor.com 142 137 35 DEV 137-66b3c00b 80-82 Pass port to the base cursor. Now we hardcode the address localhost:3000, however we need to handle generic ports that users can set. server/src/objects/user.rs @rultor me@rultor.com 150 144 35 DEV 144-bb8cae44 31-34 Test that 404 status code is thrown with "Not Found" response. For now we only check JSON response with: message, documentation_url, status nodes. Let's create unit test that will show that 404 is the status code of response. server/src/handlers/user.rs @rultor me@rultor.com 157 129 35 DEV 129-43a0c45d 66-72 Find a way to run slow tests separately from fast tests. This test `accepts_request_in_detached_mode` runs a way longer than other unit tests. Let's mark such long tests as slow and run them separately from fast test. Locally, developers will run only fast tests, while CI server will run both. Check <a href="https://www.yegor256.com/2023/08/22/fast-vs-deep-testing.html">this link<a> for more information about this idea. cli/tests/integration_test.rs @h1alexbel aliaksei.bialiauski@hey.com 158 129 60 DEV 129-5278c7d1 75-77 Create similar integration test for windows platform. Now we have test for linux and macos. However, we need to maintain similar test case for windows as well. cli/tests/integration_test.rs @h1alexbel aliaksei.bialiauski@hey.com 193 77 45 DEV 77-19cdca9c 99-102 Implement kill_windows_port(id) for windows OS. Currently, we don't support port killing on Windows. Check <a href="https://github.com/h1alexbel/fakehub/pull/159">this</a> pull request for more information. cli/src/main.rs @h1alexbel aliaksei.bialiauski@hey.com 194 77 35 DEV 77-b4ec803f 48-52 Enable current_port_from_lsof test in rultor. This test fails for some reason during Rultor build, because of current_port() panics with: 'failed to convert port to usize: ParseIntError { kind: Empty }'. It can be probably due to build in Docker. cli/src/sys/current_port.rs @h1alexbel aliaksei.bialiauski@hey.com 195 77 60 DEV 77-da342dc5 26-29 Investigate why lsof does not work in tests, while killport tool kills port properly. Due to this problem, we can't create integration test case with fakehub start -d -> fakehub stop. Don't forget to remove this puzzle. cli/src/sys/kill_unix.rs @h1alexbel aliaksei.bialiauski@hey.com 202 45 60 DEV 45-b2cd3d9d 47-49 Transform transpiled state from FSL AST to Fakehub objects. Now we simply logging transpiled AST, let's create Fakehub objects from obtained AST. server/src/init/server_with_init_state.rs Aliaksei Bialiauski aliaksei.bialiauski@hey.com