2 1 30 DEV 1-b3595789 57-59 Refactor this class: move actual logic to separate takes and keep only composition structure in this class. src/main/java/com/g4s8/ghman/bot/BotApp.java @g4s8 g4s8.public@gmail.com 34 2 30 DEV 2-96a53d17 41-42 Implement Unit tests for TkThread class * use JUNIT and cactoos-matchers wrapper. src/main/java/com/g4s8/ghman/bot/TkThread.java rultor me@rultor.com 35 2 30 DEV 2-553fe7c5 43-44 Fix the ClassDataAbstractionCouplingCheck rule exclusion in TkThread class. This class is too complex. src/main/java/com/g4s8/ghman/bot/TkThread.java rultor me@rultor.com 82 35 30 DEV 35-3f32769a 30-31 Implement Unit tests for this class using junit, cactoos-matchers and fake class (no mocks). src/main/java/com/g4s8/ghman/bot/ThreadIssueButtons.java Victor Noël victor.noel@crazydwarves.org 83 35 30 DEV 35-959a3c21 33-34 Implement Unit tests for this class, use junit, cactoos-matchers and fake class (no mocks). src/main/java/com/g4s8/ghman/bot/ThreadIssueText.java Victor Noël victor.noel@crazydwarves.org 84 35 30 DEV 35-c5a279fc 40-42 Fix the ClassDataAbstractionCouplingCheck rule exclusion in this class. It is too complex, some more abstraction should be brought outside of it. src/main/java/com/g4s8/ghman/bot/TkThread.java Victor Noël victor.noel@crazydwarves.org 36 2 30 DEV 2-3058e513 37-38 Fix the ClassDataAbstractionCouplingCheck & PMD rule exclusions in BotApp class src/main/java/com/g4s8/ghman/bot/BotApp.java rultor me@rultor.com 37 2 30 DEV 2-b383a27b 31-32 Implement Unit tests for FbUnauthorized class use JUNIT and cactoos-matchers wrapper. src/main/java/com/g4s8/ghman/bot/FbUnauthorized.java rultor me@rultor.com 38 2 30 DEV 2-1a5a79e9 40-41 Implement Unit tests for TkNotifications class. Refer to takes framework Unit testing guide @ https://github.com/yegor256/takes#unit-testing src/main/java/com/g4s8/ghman/bot/TkNotifications.java Samih Omer samihomer3@hotmail.com 3 1 30 DEV 1-16f6d808 32-33 Move this class to g4s8/teletakes library: submit PR, merge it and update dependency then. src/main/java/com/g4s8/ghman/bot/TkMarkdown.java @g4s8 g4s8.public@gmail.com 4 1 30 DEV 1-ba24450c 54-57 Refactor this class: extract additional classes for takes and pass, move actual logic to these classes, keep only composition structure in TkApp. src/main/java/com/g4s8/ghman/web/TkApp.java @g4s8 g4s8.public@gmail.com 39 4 30 DEV 4-0806f129 30-31 Implement unit tests for PsUserById. Refer to takes framework Unit testing guide @ https://github.com/yegor256/takes#unit-testing src/main/java/com/g4s8/ghman/web/PsUserById.java Samih Omer samihomer3@hotmail.com 40 4 30 DEV 4-ff388267 33-34 Replace the call to static method String.format with the use of cactoos' text.Formatted class in all files. src/main/java/com/g4s8/ghman/web/FkGitHubAuthRedirection.java Samih Omer samihomer3@hotmail.com 41 4 30 DEV 4-05012186 35-36 Implement unit tests for FkGitHubAuthRedirection. Refer to takes framework Unit testing guide @ https://github.com/yegor256/takes#unit-testing src/main/java/com/g4s8/ghman/web/FkGitHubAuthRedirection.java Samih Omer samihomer3@hotmail.com 62 41 30 DEV 41-a6560248 36-38 Extract into a separate object the behaviour of creating the redirect URI and test that exact complete string of the redirect uri is correct. After that unit test for FkGitHubAuthRedirection can be replaced with integration one. src/main/java/com/g4s8/ghman/web/FkGitHubAuthRedirection.java olenagerasimova olena.gerasimova@gmail.com 42 4 30 DEV 4-c1ef585e 36-38 replace those static loggers with something more OO (Related with https://www.yegor256.com/2019/03/19/logging-without-static-logger.html) src/main/java/com/g4s8/ghman/web/TkGitHubAuthorization.java Samih Omer samihomer3@hotmail.com 43 4 30 DEV 4-6f9220be 39-40 Implement unit tests for TkGitHubAuthorization. Refer to takes framework Unit testing guide @ https://github.com/yegor256/takes#unit-testing src/main/java/com/g4s8/ghman/web/TkGitHubAuthorization.java Samih Omer samihomer3@hotmail.com 75 43 30 DEV 43-326a137a 56-59 Introduce a meaningful abstraction for this. The current implementation in the secondary constructor should reside in its own class and there should be a Fake implementation for use in the tests. Do not forget to correct unit test accordingly. src/main/java/com/g4s8/ghman/web/TkGitHubAuthorization.java olenagerasimova olena.gerasimova@gmail.com 5 1 30 DEV 1-41b37148 58-60 Refactor environment usage like APP_HOST, GH_CLIENT, GH_SECRET, etc, in this class and telegram classes, find a way to better configure these variables. src/main/java/com/g4s8/ghman/web/TkApp.java @g4s8 g4s8.public@gmail.com 6 1 30 DEV 1-1f46d7fc 31-33 Create new library with different data sources, move this class and other DataSource implementations and add it as dependency. src/main/java/com/g4s8/ghman/data/FlywayDataSource.java @g4s8 g4s8.public@gmail.com 7 1 30 DEV 1-134b4230 36-37 Extract interfaces and implement unit tests with fake objects and integration tests with embedded postgres. src/main/java/com/g4s8/ghman/user/Users.java @g4s8 g4s8.public@gmail.com 17 7 30 DEV 7-4fac29c9 37-38 Create integration test: check all methods of this class and do not forget about all possible exceptions. src/main/java/com/g4s8/ghman/data/PgUsers.java @rultor me@rultor.com 18 7 30 DEV 7-2fb4e7d6 105-108 Replace this static method with an inner class that implements/extends JsonObject (depending on what is possible to do) and that is responsible of doing what is done here. Do not forget about unit test. src/main/java/com/g4s8/ghman/data/PgUsers.java @rultor me@rultor.com 53 18 30 DEV 18-891197cc 106-112 This class represents details about a user stored in the database. Callers of PgUser.telegram relies on the datastructure defined here and must know how it is structured to exploit the information. Instead, extract interface from it and use it everywhere it is needed instead of exposing this data. One implementation is maybe based on Chat and another would be based on a pg request for example. Add unit tests for both when it's done. src/main/java/com/g4s8/ghman/data/PgUsers.java @rultor me@rultor.com 19 7 30 DEV 7-5d7508dd 28-30 Continue implement this integration test: add cases for all methods of {@link com.g4s8.ghman.data.PgUser} class. Do not forget about all possible exceptions. src/test/java/com/g4s8/ghman/data/PgUserITCase.java @rultor me@rultor.com 20 7 30 DEV 7-0543293b 34-37 Find a way to get rid of static field and method of this class. Note that this class is JUnit 5 Extension and is used to prepare database to integration tests. See https://junit.org/junit5/docs/current/user-guide/#extensions-registration-declarative src/test/java/com/g4s8/ghman/data/DatabaseExtension.java @rultor me@rultor.com 8 1 30 DEV 1-da473f23 168-170 Configure qulice plugin and test coverage. Don't forget to exclude Cactoos compat classes, we need to remove them after Takes fixes. pom.xml @g4s8 g4s8.public@gmail.com 44 8 30 DEV 8-ac152f30 284-288 Increase code coverage by writing unit tests. All coverage ratio minimums are supposed to be greater than 0.60. Classes missed count maximum is 8. When this goal is achieved ask ARC whether these minimums are enough. pom.xml rultor me@rultor.com 29 9 30 DEV 9-ed24d84f 43-48 Continue implement notifications for user when new messages (unread github notification) arrive. To do that we need to monitor unread notifications by constantly checking `threads` table for unread threads. Schedule java thread (or any other synchronization process) to periodically call `PgThreads#unread()` to retrieve unread messages and use `Notification.UnreadThreads()` to send them. src/main/java/com/g4s8/ghman/bot/Notification.java @rultor me@rultor.com 73 29 30 DEV 29-b004b0ba 33-37 Instantiate this class and pass it to `TkSync` (currently in `TkApp`) so that the behaviour of this class is executed every 10 minutes when Heroku ntofify the app. Note that this involves sharing the instance of BotSimple between `TkApp` and `BotApp`. src/main/java/com/g4s8/ghman/bot/UnreadThreadsSync.java @rultor me@rultor.com 30 9 30 DEV 9-bc8289a7 49-52 Now this class send only github subject title as notification. Please aks ARC what exactly we want to send to user and create a class to extract and format this information from `JsonObject` (github subject) accordingly. src/main/java/com/g4s8/ghman/bot/Notification.java @rultor me@rultor.com 31 9 30 DEV 9-965770b0 53-56 Test for `Notification.UnreadThreads` should be implemented after https://github.com/g4s8/teletakes/issues/14 is resolved. Please, while implementing try to avoid using mocked objects, use fake implementations instead. src/main/java/com/g4s8/ghman/bot/Notification.java @rultor me@rultor.com 54 11 30 DEV 11-457109ce 39-44 Patterns in callback queries chains are distributed in multiple classes: for example, pattern for close issue is given here and in TkCloseIssue. Find a way to avoid this by maybe having string pattern representation here and passing Matcher to telegram takes (TkCloseIssue) or by having one class implementing Fork and containing both the current code of TkCloseIssue and the creation of the FkCallbackQuery. src/main/java/com/g4s8/ghman/bot/BotApp.java @rultor me@rultor.com 55 11 30 DEV 11-b8952b84 35-39 1) find a way to avoid using static method Integer.parseInt() 2) there too much method chaining in Issue.Smart() instance creation. It's hard to read and not very good in term of OO practice: we depend here on many objects and we want to promote loose coupling usually. Find a way to avoid it. src/main/java/com/g4s8/ghman/bot/TkCloseIssue.java rultor me@rultor.com 74 26 30 DEV 26-e5ebe138 28-31 In case `Sync.sync` throws an exception, this class should log it instead of failing the whole synchronization process. Some thought must be taken to apply the same principle to instances of `Sync` in case they do multiple tasks. src/main/java/com/g4s8/ghman/web/TkSync.java rultor me@rultor.com