117850DEV85-5b8190cf130-131
- refactor autocomplete view common view class should know nothing about search entities
search/views.pyduker33duker33@gmail.com118850DEV85-cd2a1d5720-21
Create fixtures for tests now we have huge code doubling
tests/search/test_views.pyduker33duker33@gmail.com119850DEV85-01b685cc72-74
- Fix search results order Search results with leading term in result text should go before other results
tests/search/test_views.pyduker33duker33@gmail.com13634330DEV343-7b06e1738-8
Use custom_page_url for every custom page route.
tests/pages/urls.pyArtemiywertins71@gmail.com15114030DEV140-694a3b501-2
Move test case to custom redirects app You can find example at SE's tests_views.Redirects app
tests/refarm_redirects/test_views.pyduker33duker33@gmail.com15214060DEV140-e3f0614265-67
Use `refarm-site's` packages with it's prefix. For example do `INSTALLED_APPS = ['refarm-site.pages', ...]` instead of just `['pages']`.
tests/test_settings.pyduker33duker33@gmail.com15436030DEV360-25169cf614-16
Remove hardcoded fixture data. Replace `url_from` and `url_to` with urls, generated from db. It'll be much more short and clear.
tests/refarm_redirects/test_views.pyduker33duker33@gmail.com15536060DEV360-caeda8fe30-34
Add db constraint for looped redirect. Example of looped redirect: `/news/one-two/ --> /news/one-two/` `60m` because schema and data migrations are needed. And fix test.
tests/refarm_redirects/test_views.pyduker33duker33@gmail.com159131120DEV131-d561a8f913-13
Move seo-templates doc to md file in cvs.
pages/README.mdduker33duker33@gmail.com16416215DEV162-3bc95923293-293
Move serialize_tags to TagQuerySet's method
catalog/models.pyduker33duker33@gmail.com16916415DEV164-e0477b7f126-127
Rm ProductManager.get_active() method Use ProductActiveManager instead
catalog/models.pyduker33duker33@gmail.com16516260DEV162-e3264da6246-247
Create fixtures for refarm tests. Then move TagModel tests from SE to refarm.
tests/catalog/test_models.pyduker33duker33@gmail.com16616260DEV162-13b6823148-50
Create fixtures for tags. Copy from SE all tags fixtures creation logic. Then move `shopelectro.tests.tests_models.TagModel` to this class.
tests/catalog/models.pyduker33duker33@gmail.com17555630DEV556-ee9349541-1
Create unit tests for pagination classes.
tests/refarm_pagination/test_pagination.pyArtemiywertins71@gmail.com17916815DEV168-f08f9547349-350
Move `Tags.parse_url_tags` Tags context. Depends on se#567
catalog/models.pyduker33duker33@gmail.com18155030DEV550-8701571283-83
Split to ProductImagesContext and ProductBrandContext
catalog/context.pyduker33duker33@gmail.com18255060DEV550-f02726e988-89
Move prepare_tile_products func to context Now it's separated function with huge of inconsistent queryset deps.
catalog/context.pyduker33duker33@gmail.com19718230DEV182-0e79567183-84
Move prepare_tile_products to ProductBrandContext. ProductImages is already forked.
catalog/context.pyduker33duker33@gmail.com19818230DEV182-b72b72d4225-226
Customize `prepare_tile_products` for every site Inherit this class at every site.
catalog/context.pyduker33duker33@gmail.com19918260DEV182-e00fc42b87-91
Resolve Model.objects field resolution order `assert(isinstance(Page.objects, PageManager))` is `False` now. See `shopelectro.sitemaps.PagesSitemap` for failed code example. Fix `shopelectro.models.Category.objects_` too. Fix `shopelectro.models.ExcludedModelTPage.objects_` too.
pages/models.pyduker33duker33@gmail.com183550120DEV550-c08f412e117-121
Move context realization to pure to objects composition. Discussed some thoughts with Artemiy via call. Artemiy will do it. For example SortedCategory should consist of separated SortedList and Category classes/objects.
catalog/context.pyduker33duker33@gmail.com207183120DEV183-d6341b3e1-1
Implement Page, PaginatedProducts, ProductBrands, ProductsImages context classes.
catalog/context/__init__.pyArtemiywertins71@gmail.com213207120DEV207-854acb101-1
Implement Page, PaginatedProducts context classes.
catalog/newcontext/__init__.pyArtemiywertins71@gmail.com23921330DEV213-1f0368332-3
Remove mocked Context classes. Wait for fixtures of Tag models to implement this.
tests/catalog/test_context.py@artemiy312wertins71@gmail.com24020760DEV207-f1b71ce71-1
Implement Page context class.
catalog/newcontext/__init__.pyArtemiywertins71@gmail.com26724030DEV240-cb4ad3dc104-108
Improve DB templates (and views) tests. Move them to separated module. Rename theirs `test_display` prefix. Separate them on small pieces. Add test for `display.Page` with passing context.
tests/pages/test_models.py@duker33duker33@gmail.com26824030DEV240-ac87cf5b6-8
Create TextView class. Instead of render_str method. And inherit `pages.db_views.Page` from this class.
pages/utils.pyduker33duker33@gmail.com26924030DEV240-41ca8b7626-26
Create usage doc for page view.
pages/display.pyduker33duker33@gmail.com24120715DEV207-ec3d38b33-3
Annotate methods of Context implementations.
catalog/newcontext/__init__.pyArtemiywertins71@gmail.com20818330DEV183-a9ba47b7101-101
Try to remove `ordering` arg from ProductQuerySet.get_by_category
catalog/models.pyArtemiywertins71@gmail.com18455015DEV550-6e482196223-224
Take `view_type` value from dataclass. Depends on updating to python3.7
catalog/context.pyduker33duker33@gmail.com18555015DEV550-79bb63d1259-260
Move `TaggedCategory.get_tags` to property. As in `products` property case.
catalog/context.pyduker33duker33@gmail.com18655060DEV550-035b850e283-284
Try to rm sorting staff from context.TaggedCategory. Or explain again why it's impossible. Now it's not clear from comment.
catalog/context.pyduker33duker33@gmail.com18918730DEV187-26ce6496440-441
Uncomment the if_404 check for empty products list. To do it fix stb tests to cover this case.
catalog/context.pyduker33duker33@gmail.com224STB374120DEVSTB374-01960267255-259
Move tag's value to separated field. Now we have fields like `tag.name == '10 м'`. But should have smth like this: `tag.value, tag.group.measure, tag.label == 10, 'м', '10 м'`. Right now we should do dirty hacks for tags comparing mech.
catalog/models.pyduker33duker33@gmail.com227STB29660DEVSTB296-d24da08f12-17
Generate image file name with hash. Now generation uses timestamp. It breaks media<->fixtures consistency. See comment for details: https://github.com/fidals/stroyprombeton/issues/296#issuecomment-447770194 And test absolute filename generation.
images/models.pyduker33duker33@gmail.com24222760DEV227-534526f4109-113
Explore additional hash. Now autosaved file has this pattern `<md5>_dTy2ykr.jpg` but should have this one: `<md5>.jpg`. ManifestStaticFilesStorage adds redundant hash after md5. Make the storage to remove this hash.
tests/images/tests.py@duker33duker33@gmail.com228SE61960DEVSE619-2b30c42e134-134
Use fixtures at ecommerce tests
tests/ecommerce/tests_views.pyduker33duker33@gmail.com229SE61930DEVSE619-a95dbe3f156-156
Test if order sends mails
tests/ecommerce/tests_views.pyduker33duker33@gmail.com230SE61915DEVSE619-5f380a0483-84
Move Page's const to it's ancestor And rename it from `_URL_` to `_ROUTE_`
pages/models.pyduker33duker33@gmail.com23523015DEV230-5492e44311-11
Drop `dj_database_url` dependency.
tests/test_settings.pyduker33duker33@gmail.com236230120DEV230-58229d8b75-77
Create base class for `create_fixtures`. And use it for refarm and every site. Sites now call it `test_db` instead `create_fixtures`.
tests/management/commands/create_fixtures.pyduker33duker33@gmail.com237230120DEV230-edd9709f80-80
Use fixtures in every test.
tests/management/commands/create_fixtures.pyduker33duker33@gmail.com26125730DEV257-457f55e0143-146
Document terms Product, Position and Option Seems the best way is to do it with subclassing. Such documentation will clarify types and will be obvious for programmers. But check the docs too. May be some of this terms are mentioned there.
catalog/models.pyduker33duker33@gmail.com31826160DEV261-a4b1299c145-145
Use the new catalog arch at sites.
catalog/models.pyduker33duker33@gmail.com26625530DEV255-b02f6e0d4-8
Improve `PaginationContext` interface. It's not clear now. For example client should know the class context details to fetch objects iterable. See `catalog.newcontext.products.PaginatedProducts#qs`.
refarm_pagination/context.pyduker33duker33@gmail.com28127930DEV279-0ee8f67e26-27
Fix PDD linter from CI pipeline. It missed the wrong formatted task. See the parent task for details.
ecommerce/views.pyArtemiywertins71@gmail.com28227330DEV273-db0487f5230-230
Apply new order_by_alphanumeric for SE/STB.
catalog/models.pyArtemiywertins71@gmail.com29428215DEV282-04c8f0f2252-252
Rename get_group_tags_pairs to group_tags
catalog/models.pyArtemiywertins71@gmail.com28327360DEV273-b2ae754f232-232
Create an index for order_by_alphanumeric query.
catalog/models.pyArtemiywertins71@gmail.com29228330DEV283-e5be1cbf3-3
Group models.py, models_operations.py, models_expressions.py into the module.
catalog/models_operations.py@artemiy312wertins71@gmail.com1292920DEV292-ba927d601-1
Integrate trackers to STB and SE
ecommerce/front/trackers.es6Artemiywertins71@gmail.com287SE74230DEVSE742-b29cbe0a137-138
Fix display issue with shared context. See the test below for details.
tests/pages/test_models.pyduker33duker33@gmail.com291SE74730DEVSE747-53839270256-258
Rm `get_group_tags_pairs`. Use `get_grouped_tags -> Dict[Group, List[Tag]]` instead. Tags pairs already lead us to errors with groups order.
catalog/models.py@duker33duker33@gmail.com30530230DEV302-f7a387f9287-287
Process more special symbols for slugs.
tests/catalog/test_models.py@duker33duker33@gmail.com30630230DEV302-40867787226-227
Resolve slug code doubling. See `TagGroup.slug` and `Tag._get_slug`.
catalog/models.pyduker33duker33@gmail.com30825530DEV255-bee8a1f04-8
Improve `PaginationContext` interface. It's not clear now. For example client should know the class context details to fetch objects iterable. See `catalog.context.products.PaginatedProducts#qs`.
refarm_pagination/context.py@duker33duker33@gmail.com316stb-53730DEVstb-537-a8b2411953-54
Create a class instead this function. See there for details: https://github.com/fidals/refarm-site/pull/315/files#r270500698
search/search.pyArtemiywertins71@gmail.com33733160DEV331-cd71fc194-10
Implement the new arch at the search app. All you need is to implement ContextsStack class and place the other classes to the relevant places. `search.search` module will be fully rewritten. You also can drop away starting_by_term functionality. See "is_name_start_by_term" aggregation parameter inside search.search.search function.
search/arch_draft.py@duker33duker33@gmail.com34534360DEV343-4255fdd020-22
Implement Breadcrumbs class. Use it instead of monolithic logic at the `breadcrumbs_with_siblings`. Create Breadcrumb class or named tuple to specify crumb data structure.
pages/logic/page.pyduker33duker33@gmail.com34734530DEV345-5d25d7b389-89
Test crumbs siblings.
tests/catalog/test_views.py@duker33duker33@gmail.com34834560DEV345-e32a958e14-18
Refold catalog pages in DB. In both fixtures and local DB. Implement this pages structure: - each(category_roots).parent == CustomPage.get('catalog') - CustomPage.get('catalog').parent == CustomPage.get('index')
pages/templatetags/pages_extras.pyduker33duker33@gmail.com