13610930DEV109-3848fb5945-46
Implement a new iterator() for YamlLines to fix different indentations test as indentsValueWithDifferentIndentation() test.
src/test/java/com/amihaiemil/camel/ReadPointedScalarTest.javaMihai Aamihaiemil@gmail.com13710730DEV107-ebfbb57163-64
Add more tests to cover all the nested node possibilities.
src/main/java/com/amihaiemil/camel/AbstractYamlLines.javaMihai Aamihaiemil@gmail.com1383030DEV30-1ab58fb935-37
Add method ``serlialize()`` in YamlNode interface and implement it in the YamlNode implementors (e.g. Scalar) to serlialize it and return the Yaml node as a Yaml tree.
src/main/java/com/amihaiemil/camel/AbstractYamlDump.javaMihai Aamihaiemil@gmail.com13910930DEV109-bb96edbe38-39
Refactor the implementation of value() and indent() methods.
src/main/java/com/amihaiemil/camel/ReadPointedScalar.javaMihai Aamihaiemil@gmail.com16916530DEV165-ab99980e77-79
Add some integration tests to make sure that all types of YAML are printed/indented correctly. It can get a little out of hand with the different implementations of YamlLines.iterator() method.
src/main/java/com/amihaiemil/eoyaml/YamlLines.java@amihaiemilamihaiemil@gmail.com2109030DEV90-5475270c49-53
Check and see how we can use the {@link WellIndented} decorator here, to validate that the lines have correct indentation. Maybe we will need to do some changes inside WellIndented, since in the case of a YAML Stream, the lines after the Start Mark can be more indented or they can have the same indentation as the mark.
src/main/java/com/amihaiemil/eoyaml/ReadYamlStream.java@amihaiemilamihaiemil@gmail.com2119030DEV90-42ab50d061-63
This method has to be enhanced to also cover the case when the first "---" is missing. A YAML Stream of documents can also omit the Start Marker for the first YAML Document.
src/main/java/com/amihaiemil/eoyaml/StartMarkers.java@amihaiemilamihaiemil@gmail.com21821130DEV211-6b8bbc2745-47
Method toYamlNode has a lot of duplicated case, it most likely needs to be refactored. Make sure to add tests for all the performed changes as this method is quite important in the library.
src/main/java/com/amihaiemil/eoyaml/AllYamlLines.java@amihaiemilamihaiemil@gmail.com21921130DEV211-1056c8d2408-411
Fix this unit test. The YAML from the file is not read properly, most likely because of line-numbering Issues. The first actual line of YAML has number 3 because the comments are omitted. YamlLines.line(...) is not aware of these possible numbering diffs.
src/test/java/com/amihaiemil/eoyaml/RtYamlInputTest.java@amihaiemilamihaiemil@gmail.com2129030DEV90-e5a082f960-66
Fix this test case. The problem is that, by the time .toYamlNode(...) is called, the YamlLines iterable is actually empty and iterator.next() throws an exception. A more general solution should be provided, we should actually have an EmptyYamlNode implementation, or something else, to represent the case of a YamlNode with no lines.
src/test/java/com/amihaiemil/eoyaml/ReadYamlStreamTest.java@amihaiemilamihaiemil@gmail.com22722130DEV221-2724374d40-44
Finish the implementation of the methods in this interface. Figure out how to implement literal and built block scalars, also in the the context of indenting/printing a bigger YAML node, as well as printing only that single scalar. Maybe we will need a class called YamlPrinter, that looks for the type of the node to print.
src/main/java/com/amihaiemil/eoyaml/RtYamlScalarBuilder.java@amihaiemilamihaiemil@gmail.com22922730DEV227-592d972336-40
Override the toString() method in each concrete type of Scalar to print it in context. At the moment calling toString() on a Scalar doesn't print a valid YAML. The printed YAML should contain a Start Marker, followed by the proper scalar mark and finally the End Marker.
src/main/java/com/amihaiemil/eoyaml/ComparableScalar.java@amihaiemilamihaiemil@gmail.com23522930DEV229-d421832f219-223
Fix method ReadFoldedBlockScalar.indent(...). At the moment, it folds the scalar when indenting, but this is not correct. Indentation is for printing and when we're printing a Folded Scalar, it should be printed as a block. It is only method value() that should return the folded version.
src/test/java/com/amihaiemil/eoyaml/ReadFoldedBlockScalarTest.javaamihaiemilamihaiemil@gmail.com23022730DEV227-584acdd4112-114
Modify this method in order to properly indent Scalar nodes. They are of multiple types (plain, folded, literal) and their indentation differs. Don't forget to add unit tests.
src/main/java/com/amihaiemil/eoyaml/YamlMapping.java@amihaiemilamihaiemil@gmail.com24122430DEV224-10286916119-123
This method is not correct in the case of folded scalar. When returning the value we should indeed fold the new lines, with the exception that we should preserve the blank lines and new lines of more inner indented lines. See how ReadFoldedBlockScalar.value() is implemented.
src/main/java/com/amihaiemil/eoyaml/RtYamlScalarBuilder.java@amihaiemilamihaiemil@gmail.com24624430DEV244-f87b53f2112-116
This method is not correct. When returning the value we should indeed fold the new lines, with the exception that we should preserve the blank lines and new lines of more inner indented lines. See how ReadFoldedBlockScalar.value() is implemented.
src/main/java/com/amihaiemil/eoyaml/RtYamlScalarBuilder.java@amihaiemilamihaiemil@gmail.com27126130DEV261-3d97786f54-57
Find a way to also "merge" the comments from the mappings' key:value pairs. The comment referring to the YamlMapping itself will either be taken from the original YamlMapping or a new one can be accepted via the constructor.
src/main/java/com/amihaiemil/eoyaml/extensions/MergedYamlMapping.java@amihaiemilamihaiemil@gmail.com27226130DEV261-8e1a0dc7115-117
Continue with the support for comments by implementing the reading of comments in the case of a YamlMapping. Comments for key:value pairs are already implemented in BaseYamlMapping.
src/main/java/com/amihaiemil/eoyaml/ReadYamlMapping.java@amihaiemilamihaiemil@gmail.com27927630DEV276-21bbae9d169-171
Continue implementing support for Comments into the read version of YamlMapping. Comments for the elements of a sequence are already implemented in BaseYamlSequence.
src/main/java/com/amihaiemil/eoyaml/ReadYamlSequence.javaamihaiemilamihaiemil@gmail.com33623830DEV238-cdc69ab745-49
Add more tests to cover all the examples from the Yaml 1.2 Specification. You can have a look at PR 335 to see how other examples have been tested. Don't forget that you do not have to write all the tests in this task -- write 1 or 2 tests, leave a todo (puzzle) and the work will continue in a future ticket.
src/test/java/com/amihaiemil/eoyaml/spec/SpecExamplesITCase.java@ANadrowskiaislan.nadrowski@gmail.com33833630DEV336-cdc69ab745-49
Add more tests to cover all the examples from the Yaml 1.2 Specification. You can have a look at PR 335 to see how other examples have been tested. Don't forget that you do not have to write all the tests in this task -- write 1 or 2 tests, leave a todo (puzzle) and the work will continue in a future ticket.
src/test/java/com/amihaiemil/eoyaml/spec/SpecExamplesITCase.java@ANadrowskiaislan.nadrowski@gmail.com38836860DEV368-ef57578340-43
Implement and unit test class ReadFlowMapping, which will represent a mapping in flow format (between {} brackets). After that is done, use it here when reading the sequence's values. At the moment this flow sequence only reads sequence and scalar values.
src/main/java/com/amihaiemil/eoyaml/ReadFlowSequence.java@amihaiemilamihaiemil@gmail.com38936860DEV368-c52e15ab44-46
Use this class to read flow YamlSequences which are children of other read nodes, and also when reading a flow/json-like YamlSequence directly from the YamlInput.
src/main/java/com/amihaiemil/eoyaml/ReadFlowSequence.java@amihaiemilamihaiemil@gmail.com39036830DEV368-98dbb0f0108-111
Make sure the escaped scalars read from a flow sequence are unescaped when they are returned to the user. The bellow assertions, for [a] and b][ should work without being surrounded by quotes/apostrophes.
src/test/java/com/amihaiemil/eoyaml/ReadFlowSequenceTestCase.java@amihaiemilamihaiemil@gmail.com