36 27 30 DEV 27-b5f30c4d 119-124 Implement metadata update by using tgz package file. In addition to interacting with the NPM client, the artifactory repo also support upload NPM .tgz file manually by upload request. It mean that all the information we can give you is the .tgz filestream. If you Unzip the .tgz file， you could get the project package.json. Then, you could get the metadata information from the package.json src/main/java/com/artipie/npm/Npm.java paulodamaso pauloeduardolobo@gmail.com 54 53 45 DEV 53-d5b414c9 63-63 Rewrite test method to be able to enabled src/test/java/com/artipie/npm/http/UploadSliceTest.java brastak brastak@gmail.com 63 49 90 DEV 49-ba9c0273 50-50 handle https schema in the <code>response</code> method src/main/java/com/artipie/npm/http/DownloadPackageSlice.java brastak brastak@gmail.com 67 64 60 DEV 64-0c89f1b5 82-84 remove the loop with Thread.sleep call: either find the other way to do this or move it to Test NPM Client (see the related task for npmExecute method) src/test/java/com/artipie/npm/NpmCommandsTest.java brastak brastak@gmail.com 68 64 90 DEV 64-5e3ded21 178-181 transform method into NpmClient class - takes the registry address in the constructor - exposes one method to publish a Path - exposes one method to install a package (denoted by a String) to a Path src/test/java/com/artipie/npm/NpmCommandsTest.java brastak brastak@gmail.com 85 16 30 DEV 16-ac6a0eac 36-40 Wrap new instances of HttpNpmRemote with this class in NpmProxy. But first ensure that HttpNpmRemote throws an exception in case the request fails (it should still return Maybe for 404 though). Also see https://vertx.io/docs/vertx-circuit-breaker/java/ for configuring the CircuitBreaker. npm-proxy-adapter/src/main/java/com/artipie/npm/proxy/CircuitBreakerNpmRemote.java @g4s8 g4s8.public@gmail.com 86 16 30 DEV 16-6161ad7f 41-46 Add a test to ensure it works as expected. The most simple is to provide a Fake version of NpmRemote that can be setup to either fail or work as expected by the contract of NpmRemote. Be careful about the fact that the expected behaviour is beasically: empty if the asset/package is not present and an exception if there is an error. See also the todo above or HttpNpmRemote if it had been solved already. npm-proxy-adapter/src/main/java/com/artipie/npm/proxy/CircuitBreakerNpmRemote.java @g4s8 g4s8.public@gmail.com 129 123 60 DEV 123-9c583b0d 114-118 Fix and enable npmPublishWorks test `npmPublishWorks` often fails with the following error in line 128: `NpmCommandsTest.npmPublishWorks:128 » Decode Failed to decode:Illegal character`. It seems that meta JSON is saved with corruption or there is some concurrency issue in this code src/test/java/com/artipie/npm/NpmCommandsTest.java @olegmoz oleg.mozzhechkov@gmail.com 144 141 30 DEV 141-ed29e327 58-62 Fix NPM proxy integration tests. NPM proxy tests became broken by release on newer client ver 0.7.3 It seems that container used in tests needs to be updated or replaced with other image with NPM client. The tests need to be fixed an re-enabled. src/test/java/com/artipie/npm/proxy/NpmProxyITCase.java Oleg Mozzhechkov oleg.mozzhechkov@gmail.com 168 164 30 DEV 164-52856a91 29-32 Improve code coverage by writing unit-tests: each coverage counter (check jacoco plugin in pom.xml) should not be less than 75. Write unit-tests to achieve such coverage. After each iteration do not forget to correct coverage minimums and this todo to continue work. src/main/java/com/artipie/npm/package-info.java @olenagerasimova olena.gerasimova@gmail.com 190 168 30 DEV 168-faf64628 29-32 Improve code coverage for missed instructions ratio. Currently, it is at 70. We need to raise it to 75. Write unit-tests to achieve such coverage. After each iteration do not forget to correct INSTRUCTION counter in jacoco settings in pom.xml. src/main/java/com/artipie/npm/package-info.java @baudoliver7 baudolivier.oura@gmail.com 326 239 30 DEV 239-1cddf630 36-39 Fix download meta for empty prefix. Test for downloading meta hangs for some reason when empty prefix is passed. It is necessary to find out why it happens and add empty prefix to params of method DownloadPackageSliceTest#downloadMetaWorks. src/test/java/com/artipie/npm/proxy/http/DownloadPackageSliceTest.java Aleksei Borodin 45274464+Swizbiz@users.noreply.github.com 343 340 30 DEV 340-99949b75 34-39 Implement `/npm` endpoint properly: for now `/npm` simply returns 200 OK status without any body. We need to figure out what information can (or should) be returned by registry on this request and add it. Here are several links that might be useful https://github.com/npm/cli https://github.com/npm/registry https://docs.npmjs.com/cli/v8 src/main/java/com/artipie/npm/http/NpmSlice.java @olenagerasimova olena.gerasimova@gmail.com 344 339 30 DEV 339-ed8772b7 42-47 Implement token auth for npm client. Npm client since version 7 does not work anonymously, to publish any package you need to add user and get auth token. We need to support `npm login`, `npm adduser`, `npm logout` command and work with bearer auth token instead of basic auth. Related links: https://docs.npmjs.com/cli/v8/commands/npm-adduser https://docs.npmjs.com/cli/v8/commands/npm-logout https://docs.npmjs.com/cli/v8/using-npm/config#_auth src/test/java/com/artipie/npm/Npm8IT.java @olenagerasimova olena.gerasimova@gmail.com