20 569 30 DEV 569-26fa1589 89-90 Consider extending this class by adding password and its format, but pay attention that actually password is not always required. Do not forget about tests. src/main/java/com/artipie/management/Users.java @olegmoz oleg.mozzhechkov@gmail.com 21 231 30 DEV 231-f3499255 36-39 Add tests for Cookies class. `Cookies` class lacks test coverage for primary code flow branches. It is important that to check that proper user is extracted when headers contain session cookie. This might require `Cookie` class refactoring as the class depends on system environment. src/test/java/com/artipie/management/api/CookiesTest.java @olegmoz oleg.mozzhechkov@gmail.com 22 2 30 DEV 2-f08326a0 50-51 This structure is complicated and difficult to work with, let's create inner class to hold with objects and work with them. src/test/java/com/artipie/management/FakeRepoPerms.java @olegmoz oleg.mozzhechkov@gmail.com 31 27 45 DEV 27-5ae5af14 59-65 Enabled test for `ApiRepoUpdateSlice`. Now test for `ApiRepoUpdateSlice` is disabled because yaml string that passes with NameValuePair does not have enough spaces and does not have break lines at all. For example, instead of `repo:\n type:docker\n storage:path` the value `repo: type:docker storage:path` is got therefore NPE is occurred. So, it is necessary to fix this problem and enable test after that. src/main/java/com/artipie/management/api/ApiRepoUpdateSlice.java Aleksandr Krasnov genryxy.alexandr@yandex.ru 50 321 30 DEV 321-1d437500 33-37 Remove code duplication. In this class and in the class with tests for this one a pair of very similar utils methods are used which are also used in classes for update repo. It is necessary to eliminate this code duplication. src/main/java/com/artipie/management/api/ApiRepoDeleteSlice.java Alexander 38591972+genryxy@users.noreply.github.com