14 13 30 DEV 13-c14a4213 38-39 Create an integration test We need an integration test for this class with described logic of upload from client side src/main/java/com/artipie/helm/PushChartSlice.java @Sammers21 titantins@gmail.com 15 13 30 DEV 13-d5c3ea9d 63-65 Implement PushChart endpoint The slice should do the following: accept archived charts, save them into a storage and trigger index.yml reindexing. src/main/java/com/artipie/helm/PushChartSlice.java @Sammers21 titantins@gmail.com 17 12 30 DEV 12-4acc03fc 88-90 Generate TgzArchive from byte flow For now this method is not implemented. Byte flow of archive data should be collected together in order to instantiate a TgzArchive instance. src/main/java/com/artipie/helm/PushChartSlice.java @Sammers21 titantins@gmail.com 18 8 30 DEV 8-2526c766 63-65 Update Index file operation For now this method is not implemented. Index.yml file should be created if not existed before and update should be performed afterwards. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 19 12 30 DEV 12-ae19aa75 32-33 Test for TgzArchive For now this method is not implemented, but we definitely need a test for this class. src/main/java/com/artipie/helm/TgzArchive.java @Sammers21 titantins@gmail.com 29 19 30 DEV 19-c97efbaf 62-64 Replace FileStorage with InMemory one Currently FileStorage is used in this test, but we need to refactor it to use InMemory storage. src/test/java/com/artipie/helm/TarArchiveTest.java @Sammers21 titantins@gmail.com 20 12 30 DEV 12-e4bf7d8b 64-66 TgzArchive name method For now this method is not implemented. We should decompress the archive, find the chart version and name, and, return it, binded together. src/main/java/com/artipie/helm/TgzArchive.java @Sammers21 titantins@gmail.com 21 12 30 DEV 12-328a6b37 76-78 Save the archive into Asto. For now this method is not implemented. The archive should be saved with a key name, obtained from TgzArchive#name(). src/main/java/com/artipie/helm/TgzArchive.java @Sammers21 titantins@gmail.com 26 21 30 DEV 21-a79af815 142-144 Reimplement with slices Instead of copying parts of content into small chunks we can use the big ByteBuffer for referencing to a particular part which would improve memory footprint. src/main/java/com/artipie/helm/TgzArchive.java @Sammers21 titantins@gmail.com 31 89 30 DEV 89-bbfe0d9a 112-114 Implement IndexYaml#empty For now this method is not implemented. This method should return mappings related to an empty index.yaml file and does not include any chart related information src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 32 89 30 DEV 89-cdf59b8a 124-127 Implement IndexYaml#empty This method should update index mappings by scanning a given chart yaml file. Read the official docs https://helm.sh/docs/topics/chart_repository/ for more details src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 40 32 30 DEV 32-3a6b6984 146-148 Digest field One of the fields Index.yaml require is "digest" field. This field should also be generated. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 41 32 30 DEV 32-66701d6b 149-151 Create a unit test for digest field One of the fields Index.yaml require is "digest" field. The test should make verify that field has been generated correctly. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 42 32 30 DEV 32-7ba44240 152-154 Urls field One of the fields Index.yaml require is "urls" field. This field should also be generated. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 43 32 30 DEV 32-3ab761f4 155-157 Create a unit test for urls field One of the fields Index.yaml require is "urls" field. The test should make verify that field has been generated correctly. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 44 1 30 DEV 1-043bc894 46-48 Ensure that generation work In order to check the file generation works fine, we need to create a test, which will install pushed before chart and ensure successful installation. src/main/java/com/artipie/helm/IndexYaml.java @Sammers21 titantins@gmail.com 53 44 30 DEV 44-c6205a1b 114-117 Bind reference repo to a temp dir The generation of the reference index.yaml is performed in the resource folder. It is not a good approach which might case problems with subsequent test. The generation should be performed in a temp folder. src/test/java/com/artipie/helm/SubmitChartITCase.java @Sammers21 titantins@gmail.com 52 1 30 DEV 1-f8ff3e8f 83-85 Ensure that the generated file is good We need to run 'helm repo index .' and check if a generated file is similar to the one generated by this slice. src/test/java/com/artipie/helm/SubmitChartITCase.java @Sammers21 titantins@gmail.com 57 11 30 DEV 11-e613e413 45-47 Add a test to check if auth works For now basic auth is implemented and work with anonymous credentials. We need to check if it work with non anonymous credentials. src/main/java/com/artipie/helm/HelmSlice.java @Sammers21 titantins@gmail.com 86 84 30 DEV 84-6dc281f6 134-136 Remove duplicating code. There is duplicating code in this method and in `IndexYaml#update`. It is necessary to remove this duplication. src/main/java/com/artipie/helm/metadata/IndexYaml.java Aleksandr Krasnov genryxy.alexandr@yandex.ru 94 90 60 DEV 90-d6ead5a4 107-111 Extract logic for creating a new version of chart for `index.yaml`. In this method and in `IndexYaml#update` the same logic for generating additional fields is used. It is necessary to extract this logic or to redesign `IndexYaml` class by removing interaction with storage or something else. src/main/java/com/artipie/helm/metadata/IndexByDirectory.java Aleksandr Krasnov genryxy.alexandr@yandex.ru 108 94 30 DEV 94-41d3f14c 38-39 Residing this class in order to remove synchronized block, preferring keeping it immutable. src/main/java/com/artipie/helm/metadata/IndexYamlMapping.java andreoss andreoss@posteo.net 113 112 90 DEV 112-3bff32f1 47-51 Replace parser with reactive version to avoid copying index file to temp storage. This parser should be replaced with converter from Publisher#ByteBuffer to another Publisher#ByteBuffer which is splitted by breaks (based on implementation of org.reactivestreams.Processor) @checkstyle CyclomaticComplexityCheck (500 lines) src/main/java/com/artipie/helm/metadata/Index.java Alexander 38591972+genryxy@users.noreply.github.com 188 113 30 DEV 113-8cba5db4 52-56 Fix reindex operation. For some cases (about 1-2 of 1000) these tests fail with NPE when it tries to get entries of a new index. It looks like index does not have time to copy from temporary written index file to the source one. It is necessary to address this problem and enable tests. src/test/java/com/artipie/helm/HelmAstoReindexTest.java Alexander 38591972+genryxy@users.noreply.github.com 117 109 30 DEV 109-f9067b99 61-64 Refactor Helm class. Now this class is too big, therefore it should be refactored by extracting some functionality. Probably to extract some classes which would be responsible for writing info about charts to index file. src/main/java/com/artipie/helm/Helm.java Alexander 38591972+genryxy@users.noreply.github.com 134 109 30 DEV 109-89820728 61-65 Extract classes for different operations. Now this class encapsulates logic for several operations. And it is quite large. It would be better to divide this class in separate classes for each operation. Probably some other types of refactoring is possible here for simplification. src/main/java/com/artipie/helm/ChartsWriter.java Alexander 38591972+genryxy@users.noreply.github.com 187 112 90 DEV 112-f1a0e802 43-46 Replace parser with reactive version to avoid copying index file to temp storage. This parser should be replaced with converter from Publisher#ByteBuffer to another Publisher#ByteBuffer which is splitted by breaks (based on implementation of org.reactivestreams.Processor) src/main/java/com/artipie/helm/metadata/Index.java @g4s8 g4s8.public@gmail.com