575330DEV53-9c70e0d743-46
The combination of RxFile and TempDir Junit5 rule doesn't work on Windows. It seems that Junit unable to cleanup temporary directory. Fix RxFile implementation and remove disable annotation.
src/test/java/com/artipie/asto/FileStorageTest.java@g4s8g4s8.public@gmail.com968760DEV87-0ebc33ba83-85
Refactor MultipartUpload class, reduce number of fields. MultipartUpload class is too big right now in terms of fields and could be decomposed. S3Bucket or S3Object classes might be extracted here.
src/main/java/com/artipie/asto/s3/MultipartUpload.java@olegmozoleg.mozzhechkov@gmail.com1088760DEV87-c49a9b4854-59
Do not await abort to complete if save() failed. In case uploading content fails inside {@link S3Storage#save(Key, Content)} method we are doing abort() for multipart upload. Also whole operation does not complete until abort() is complete. It would be better to finish save() operation right away and do abort() in background, but it makes testing the method difficult.
src/main/java/com/artipie/asto/s3/S3Storage.javaOleg Mozzhechkovoleg.mozzhechkov@gmail.com16216030DEV160-2edb9ba439-41
Implement Copy class. This class currently is not implemented. This class should be implemented in a way to storage synchronization would work properly.
src/main/java/com/artipie/asto/Copy.java@Sammers21titantins@gmail.com16816030DEV160-24b7b6f937-39
Implement RxCopy class. This class currently is not implemented. This class should be implemented in a way to storage synchronization would work properly.
src/main/java/com/artipie/asto/rx/RxCopy.java@g4s8g4s8.public@gmail.com18113930DEV139-b53f425f36-39
Implement prefixed transaction support. Transaction extends storage, so it's needed to implement all transactions method with prefixed key too. Also, create unit tests for sub storage to verify that all methods uses prefixed keys.
src/main/java/com/artipie/asto/SubStorage.javaKirillg4s8.public@gmail.com1868760DEV87-de14147230-34
Add tests for LoggingStorage. LoggingStorage class lacks tests coverage. At very base level the tests should check that `LoggingStorage` preserves results provided by `Storage`. In very best case the tests should check that operation results and parameters are properly logged.
src/test/java/com/artipie/asto/LoggingStorageTest.java@olegmozoleg.mozzhechkov@gmail.com34518630DEV186-fbb1def219-22
Test that operations are properly logged in LoggingStorage. We are currently testing that `LoggingStorage` preserves results provided by `Storage`. We now want to introduce tests that should check that operation results and parameters are properly logged.
src/test/java/com/artipie/asto/LoggingStorageTest.java@baudoliver7baudolivier.oura@gmail.com37034530DEV345-188ec55d24-27
Continue to test that operations are properly logged in {@ling LoggingStorage}. We have tested a number of operations of {@ling LoggingStorage}. We want to continue to test that remaining operations results and parameters are properly logged.
src/test/java/com/artipie/asto/LoggingStorageTest.java@baudoliver7baudoliver7@gmail.com19619330DEV193-ee41fbc967-71
Too many methods in `S3Storage` class. `S3Storage` has too many methods. It could be refactored to move some of it's logic to other classes. In particular there three methods related to saving bytes (multipart or not, selecting proper method). This could be moved out of this class.
src/main/java/com/artipie/asto/s3/S3Storage.java@olegmozoleg.mozzhechkov@gmail.com19918360DEV183-8c1925c2277-280
Read no more then limit from Content. Now method does not fulfil it's contract and caches all content bytes to `Flowable`, then reads from them up to the limit. This should be fixed, so no more then `limit` bytes is cached.
src/main/java/com/artipie/asto/s3/S3Storage.java@olegmozoleg.mozzhechkov@gmail.com20620430DEV204-8901f06f35-37
Use one time publisher in Storage. We need to wrap all publishers created in Storage implementations with this one and to wrap all incoming publishers in tests.
src/main/java/com/artipie/asto/OneTimePublisher.java@g4s8g4s8.public@gmail.com30930690DEV306-ccf1092946-48
The test is disabled, the CI can't start ETCD extension which depends on testcontainer with etcd Docker image. Let's fix this issue on CI and enable the test.
src/test/java/com/artipie/asto/etcd/EtcdStorageITCase.java@g4s8g4s8.public@gmail.com38430930DEV309-68384b0c37-44
Run Etcd in windows containers while testing on windows. Currently, when we try to run integration tests based on testcontainers within a platform windows, we notice that Etcd container (presently based on Linux) doesn't work. We have to build and publish an Etcd docker image based on windows to avoid this issue. Please, build an Etcd image for windows (version 3.5.1) and write tests so as to detect before running integration tests, the type of platform (linux or windows) in order to pull the right docker image. After that, enable the test below for windows by removing {@code @DisabledOnOs(OS.WINDOWS)}.
src/test/java/com/artipie/asto/etcd/EtcdStorageITCase.java@baudoliver7baudoliver7@gmail.com31030690DEV306-f94460d849-52
Add etcd storage to StorageExtension to run all common tests on EtcdStorage too. It could be not an easy task, since etcd test depends on etcd clust with at least one node. For this test it starts using testcontainers and `EtcdCluster` junit extension.
src/test/java/com/artipie/asto/etcd/EtcdStorageITCase.java@g4s8g4s8.public@gmail.com35234130DEV341-64dd66a621-23
Add others key operations (exclusion by index, insertion,..). We should exclude a part from a storage key by index. We should also insert a part to a key by specifying the position (Like we do with {@code List.add(Obj, index)}).
src/main/java/com/artipie/asto/Key.java@baudoliver7baudolivier.oura@gmail.com36935230DEV352-ace2d56f20-22
Continue to add more tests for {@link SubStorage}. All the methods of the class should be verified, do not forget to add tests with different prefixes, including {@link Key#ROOT} as prefix.
src/test/java/com/artipie/asto/SubStorageTest.java@baudoliver7baudoliver7@gmail.com35435130DEV351-e3dca53520-22
Add more tests for {@link SubStorage}: all the methods of the class should be verified, do not forget to add tests with different prefixes, including {@link Key#ROOT} as prefix.
src/test/java/com/artipie/asto/SubStorageTest.java@olenagerasimovaolena.gerasimova@gmail.com3835560DEV55-4e3feec021-21
Add test coverage for RxStorage, RxStorageTransaction.
src/main/java/com/artipie/asto/rx/RxStorageWrapper.javaDenis Garusgarus.d.g@gmail.com41441130DEV411-28a7e75950-54
There two disabled tests for S3 storage: S3StorageTest#shouldUploadObjectWhenSaveLargeContent and BucketTest#shouldUploadPartAndCompleteMultipartUpload. These tests fail with S3Exception: null (Service: S3, Status Code: 400, Request ID: null) error. Figure out where is the problem, fix it and enable tests.
src/test/java/com/artipie/asto/s3/S3StorageTest.javaolenagerasimovaolena.gereasimova@gmail.com41541130DEV411-cf1a108e51-55
There is some problem with ETCD storage as sub-storage with ROOT key: tests StorageExclusivelyTest#shouldFailExclusivelyForSameKey and StorageExclusivelyTest#shouldRunExclusivelyForDiffKey get stuck in such storages configuration. Figure out the where the bug is, fix it and uncomment the case here. Note, that after the test got stuck and was terminated, docker client has to be restarted to run the test again.
src/test/java/com/artipie/asto/StorageExtension.javaolenagerasimovaolena.gereasimova@gmail.com